Here are my review comments for the patch v20240703-0002
==
doc/src/sgml/ref/create_publication.sgml
nitpick - consider putting the "FOR ALL SEQUENCES" para last, because
eventually when more sequence syntax is added IMO it will be better to
describe all the TABLES together, and then describe
Hi hackers,
We got trusted extensions since version 13, and some of them are
relocatable:
postgres=> select distinct name from pg_available_extension_versions
where trusted and relocatable;
name
-
tsm_system_time
pgcrypto
dict_int
tablefunc
uuid-ossp
seg
hstore
ltree
On Wed, Jul 3, 2024, at 13:17, Dean Rasheed wrote:
> Anyway, here are both patches for comparison. I'll stop hacking for a
> while and let you see what you make of these.
>
> Regards,
> Dean
>
> Attachments:
> * v5-optimize-numeric-mul_var-small-var1-arbitrary-var2.patch
> * v5-add-mul_var_int.patc
The latest (v20240704) patch 0001 LGTM
==
Kind Regards,
Peter Smith.
Fujitsu Australia
Hello Michael,
04.07.2024 03:51, Michael Paquier wrote:
On Sat, May 18, 2024 at 10:56:43AM +0900, Michael Paquier wrote:
Thanks. I'll look again at that once v18 opens up for business.
Looked at that again, and one in tablecmds.c is not needed anymore,
and there was a conflict in be-secure-op
> On 3 Jul 2024, at 13:29, Ranier Vilela wrote:
> With the function *getPublications* I think it would be good to free up the
> allocated memory?
>
> }
> + pg_free(pubinfo);
> +cleanup:
> PQclear(res);
Since the pubinfo is recorded in the DumpableObject and is responsible for
k
In the ddl.sgml, I’d swap the first two paragraphs.
I find the first one a bit confusing as-is. As far as I can tell, it’s an
implementation detail.
The first paragraph should answer, “I have some data modeled as a graph G=(V,
E). Can Postgres help me?”.
Then, introducing property graphs makes m
On Wed, Jul 3, 2024 at 12:51 AM David E. Wheeler wrote:
>
> Hackers,
>
> In fuzing around trying to work out what’s going on with the formatting of
> timestamptz values cast by the timestamp_tz() jsonpath method[1], I noticed
> that the formatting of the string() method applied to date and time
On 2024-Jul-04, Tom Lane wrote:
> "David G. Johnston" writes:
> > On Wed, Jul 3, 2024 at 8:46 PM Steve Lau wrote:
> >> While reading the source code, I noticed comments like "-cim 9/10/89".
>
> > It's the initials of the person who, back in 1989, wrote the preceding
> > comments
>
> Right.
>
On Thu, Jul 4, 2024 at 11:04 AM Alexander Korotkov wrote:
>
> On Thu, Jul 4, 2024 at 5:15 AM jian he wrote:
> > in remove_self_join_rel, i have
> > ```ChangeVarNodes((Node *) root->parse, toRemove->relid, toKeep->relid,
> > 0);```
> > which will change the joinlist(RangeTblRef) from (1,2) to (
On Thu, 4 Jul 2024 at 06:46, Yugo NAGATA wrote:
> Attached is a small patch to fix a comment on PQcancelErrorMessage.
Oops, copy paste mistake on my part I guess. New comment LGTM
On Jul 4, 2024, at 4:33 PM, Alvaro Herrera wrote:
On 2024-Jul-04, Tom Lane wrote:
"David G. Johnston" writes:
On Wed, Jul 3, 2024 at 8:46 PM Steve Lau wrote:
While reading the source code, I noticed comments like "-cim 9/10/89".
It's the initials of the person who, back in 1989, wrote the p
Hi,
> Good idea. Here's an attempt at that.
>
> I don't have a Mac with beta SDK 15 yet, but I think this should work?
I checked against SDK 15 and 14. I also checked that it doesn't break
something on Linux.
The patch seems to work. I don't have a Windows machine unfortunately.
--
Best regard
On Fri, Jun 28, 2024 at 3:21 PM Richard Guo wrote:
> On Fri, Jun 28, 2024 at 2:54 PM Richard Guo wrote:
> > I've refined this test case further to make it more stable by using an
> > additional filter 'a.tenthous < 5000'. Besides, I noticed a surplus
> > blank line in ExecHashJoinImpl(). I've r
Hi Richard Guo
Thank you for updating the patch.Tested on v8 , It looks good to me
Thanks
Richard Guo 于2024年7月4日周四 17:18写道：
> On Fri, Jun 28, 2024 at 3:21 PM Richard Guo
> wrote:
> > On Fri, Jun 28, 2024 at 2:54 PM Richard Guo
> wrote:
> > > I've refined this test case further to make
On 15/04/2024 04:20, Thomas Munro wrote:
Hi,
I was grepping for iovec users and noticed that the shm_mq stuff
defines its own iovec struct. Is there any reason not to use the
standard one, now that we can? Will add to next commitfest.
I think it's better to keep them separate. They serve a s
Hi,
> Is there a guidebook, any guidelines for writing grammar in Postgres, or any
> suggestions to keep in mind?
> Do we have a set of guidelines to write production rules in gram.y (for the
> Bison Parser Generator) to make the grammar conflict-free and extendible in
> the future?
I'm far fr
On Mon, Jul 1, 2024 at 1:59 PM Richard Guo wrote:
>
> On Mon, Jun 10, 2024 at 5:05 PM Richard Guo wrote:
> > This patchset does not apply any more. Here is a new rebase.
>
> Here is an updated version of this patchset. I've run pgindent for it,
> and also tweaked the commit messages a bit.
>
>
Hi,
> Can anyone recommend a good book on installing Postgres on multiple,
> connected multiuser systems, tuning it, managing users, backups, updated, etc.
>
> A cookbook/checklist approach would be great. I’ve bought several books over
> the years but a more current one is desirable.
>
> Thanks
Hi,
> Thank you for your reply. I am aware about these conflicts, but thank you for
> the explanation.
> My question is specific to Postgres. Do we have a set of guidelines we keep
> in mind while writing grammar rules while introducing new features to
> postgres?
>
> One such suggestion or rul
On 2024/07/03 22:42, Robert Haas wrote:
On Wed, Jul 3, 2024 at 5:34 AM Fujii Masao wrote:
pg_wal_summary_contents() seems to miss the summary information with "limit"
that pg_walsummary reports. This appears to be a bug. The attached patch fixes this.
Oops. It looks like pg_wal_summary_con
While I was trying to install PostgreSQL from the git repository to start
contributing I faced this issue. When I try to type ./configure it gives me
this error
checking for a thread-safe mkdir -p... /usr/bin/mkdir -p
checking for bison... /c/GnuWin32/bin/bison
configure: using bison (GNU Bison) 2
> On 4 Jul 2024, at 12:16, Mohab Yaser wrote:
> *** Flex version 2.5.35 or later is required, but this is
> C:\GnuWin32\bin\flex.exe version 2.5.4.
> $ flex --version
> C:\GnuWin32\bin\flex.exe version 2.5.4
You have all the information you need right there, your Flex is 31 minor
releases too
Hi,
> While I was trying to install PostgreSQL from the git repository to start
> contributing I faced this issue. When I try to type ./configure it gives me
> this error
>
> checking for a thread-safe mkdir -p... /usr/bin/mkdir -p
> checking for bison... /c/GnuWin32/bin/bison
> configure: using
can you send me a link to download this version on windows as I didn't find
anything other than the one I already have downloaded
On Thu, Jul 4, 2024 at 1:21 PM Aleksander Alekseev
wrote:
> Hi,
>
> > While I was trying to install PostgreSQL from the git repository to
> start contributing I faced
Hi,
>> Flex 2.5.4 is ancient. Version 2.5.39 was released in 2020 and I
>> didn't look further to figure out the exact release year of 2.5.4
>>
>> You need something like flex 2.6.4 and bison >= 2.3. That's what I use.
>
> can you send me a link to download this version on windows as I didn't find
On Tue, 25 Jun 2024 at 18:49, Hayato Kuroda (Fujitsu)
wrote:
>
> Dear Shlok,
>
> Thanks for updating patches! Below are my comments, maybe only for 0002.
>
> 01. General
>
> IIUC, we are not discussed why ALTER SUBSCRIPTION ... SET
> include_generated_columns
> is prohibit. Previously, it seems o
> On 4 Jul 2024, at 12:27, Aleksander Alekseev wrote:
>
> Hi,
>
>>> Flex 2.5.4 is ancient. Version 2.5.39 was released in 2020 and I
>>> didn't look further to figure out the exact release year of 2.5.4
>>>
>>> You need something like flex 2.6.4 and bison >= 2.3. That's what I use.
>>
>> can y
Here's a new version of the first patch. In the previous version, I
added the pid cancellation key to pmsignal.c, but on second thoughts, I
think procsignal.c is a better place. The ProcSignal array already
contains the pid, we just need to add the cancellation key there.
This first patch just
On Wed, 26 Jun 2024 at 08:06, Peter Smith wrote:
>
> Hi Shlok. Here are my review comments for patch v10-0003
>
> ==
> General.
>
> 1.
> The patch has lots of conditions like:
> if (att->attgenerated && (att->attgenerated !=
> ATTRIBUTE_GENERATED_STORED || !include_generated_columns))
> conti
Hi,
> > We don't use top posing in this mailing list [1].
> >
> > Sorry, I only have Linux and MacOS. Here are the scripts I use [2].
> > Maybe someone who develops on Windows will answer your questions.
> > However IMO your learning curve will be less steep with a Linux
> > virtual machine.
>
> F
On 04/07/2024 13:32, Heikki Linnakangas wrote:
Here's a new version of the first patch.
Sorry, forgot attachment.
--
Heikki Linnakangas
Neon (https://neon.tech)
From e9fc1f4365077673c71ba138a0ae7fbcebe16a36 Mon Sep 17 00:00:00 2001
From: Heikki Linnakangas
Date: Thu, 4 Jul 2024 01:03:15 +0300
Hi,
>> > Flex/Bison are only required when building from a Git tree, downloading a
>> > source archive and building from there might be easier to get started.
>> >
>> > https://www.postgresql.org/ftp/source/
>>
>> It could work but personally I wouldn't recommend this path for
>> someone w
On Thu, Jul 4, 2024, at 09:38, Joel Jacobson wrote:
> Summary of benchmark results:
>
> cpu | var1ndigits | winner
> --+-+-
..
> v5-optimize-numeric-mul_var-small-
On Thu, 4 Jul 2024 11:06:03 +0200
Jelte Fennema-Nio wrote:
> On Thu, 4 Jul 2024 at 06:46, Yugo NAGATA wrote:
> > Attached is a small patch to fix a comment on PQcancelErrorMessage.
>
> Oops, copy paste mistake on my part I guess. New comment LGTM
Thank you for your comments.
I made a trivial
On Thu, 4 Jul 2024 at 12:35, Heikki Linnakangas wrote:
>
> On 04/07/2024 13:32, Heikki Linnakangas wrote:
> > Here's a new version of the first patch.
>
> Sorry, forgot attachment.
It seems you undid the following earlier change. Was that on purpose?
If not, did you undo any other earlier changes
Greetings,
Thank you for your reply. I am aware about these conflicts, but thank you
for the explanation.
My question is specific to Postgres. Do we have a set of guidelines we keep
in mind while writing grammar rules while introducing new features to
postgres?
One such suggestion or rule for exam
UPD:
With the proposed changes there is no need to set NO_LOCALE to configure
the test build, so the attached patches remove this option from the
recipes.
From: Aleksei Fakeev
Sent: Tuesday, July 2, 2024 2:39 PM
To: pgsql-hack...@postgresql.org
Subject: Test_extensions installcheck fails wit
I'm don't quite understand the problem we're trying to fix:
Currently the launcher's latch is used for the following: a) worker
process attach b) worker process exit and c) subscription creation.
Since this same latch is used for multiple cases, the launcher process
is not able to handle concurr
Hi,
On Wed, Jul 03, 2024 at 06:47:15PM +0900, Michael Paquier wrote:
> While looking at a different patch from Tristan in this area at [1], I
> still got annoyed that this patch set was not able to support the case
> of custom fixed-numbered stats, so as it is possible to plug in
> pgstats things
On Thu, Jul 4, 2024 at 1:34 PM Hayato Kuroda (Fujitsu)
wrote:
>
> > >
> > > It succeeds if force_alter is also expressly set. Prepared transactions
> > > will be
> > > aborted at that time.
> > >
> > > ```
> > > subscriber=# ALTER SUBSCRIPTION sub SET (two_phase = off, force_alter =
> > on);
> >
On 04/07/2024 13:50, Jelte Fennema-Nio wrote:
On Thu, 4 Jul 2024 at 12:35, Heikki Linnakangas wrote:
On 04/07/2024 13:32, Heikki Linnakangas wrote:
Here's a new version of the first patch.
Sorry, forgot attachment.
It seems you undid the following earlier change. Was that on purpose?
If n
Okay, so I've pushed the last version after confirming with Alexander
that it works on the Windows x86 machine. I hope nothing breaks now in
the buildfarm.
--
Álvaro HerreraBreisgau, Deutschland — https://www.EnterpriseDB.com/
On 2024-Jul-04, Yugo NAGATA wrote:
> On Thu, 4 Jul 2024 11:06:03 +0200
> Jelte Fennema-Nio wrote:
>
> > On Thu, 4 Jul 2024 at 06:46, Yugo NAGATA wrote:
> > > Attached is a small patch to fix a comment on PQcancelErrorMessage.
> >
> > Oops, copy paste mistake on my part I guess. New comment LGT
On Wed, Jul 3, 2024 at 5:06 PM Dilip Kumar wrote:
>
> On Wed, Jul 3, 2024 at 4:48 PM Amit Kapila wrote:
> >
> > On Wed, Jul 3, 2024 at 4:04 PM Dilip Kumar wrote:
> > >
> > >
> > > What I am saying is that if we are not applying the whole transaction,
> > > it means we are not receiving it either
Hi Heikki,
> I tried moving it and ran the regression tests. That revealed one place
> where we still don't use dlist_container:
>
> > if (!dlist_is_empty(procgloballist))
> > {
> > MyProc = (PGPROC *) dlist_pop_head_node(procgloballist);
> > ...
>
> I believe that was ju
Alvaro Herrera writes:
> On 2024-Jul-04, Tom Lane wrote:
>
>> "David G. Johnston" writes:
>> > On Wed, Jul 3, 2024 at 8:46 PM Steve Lau wrote:
>> >> While reading the source code, I noticed comments like "-cim 9/10/89".
>>
>> > It's the initials of the person who, back in 1989, wrote the prece
On Thu, 4 Jul 2024 at 12:32, Heikki Linnakangas wrote:
> We currently don't do any locking on the ProcSignal array. For query
> cancellations, that's good because a query cancel packet is processed
> without having a PGPROC entry, so we cannot take LWLocks. We could use
> spinlocks though. In this
Hi Marat,
> V4 path with fixed usage PG_GETARG_BYTEA_PP instead of PG_GETARG_TEXT_PP
Thanks for the patch.
Please add it to the nearest open commitfest [1].
```
+select min(v) from bytea_test_table;
+ min
+--
+ \xaa
+(1 row)
+
+select max(v) from bytea_test_table;
+ max
+--
+ \xff
+(1 r
On 2024-07-02 16:21 +0200, Tom Lane wrote:
> Erik Wienhold writes:
> > On 2024-07-02 10:45 +0200, Peter Eisentraut wrote:
> >> I had to revert the test case from the 0002 patch. It ended up running
> >> some
> >> build farm machines out of memory.
>
> >> +ERROR: out of memory
> >> +DETAIL: Fa
Hi,
I don't have any immediate feedback regarding this patch, but I'm
wondering about one thing related to cancellations - we talk cancelling
a query, but we really target a PID (or a particular backend, no matter
how we identify it).
I occasionally want to only cancel a particular query, but I d
Em qui., 4 de jul. de 2024 às 05:18, Daniel Gustafsson
escreveu:
> > On 3 Jul 2024, at 13:29, Ranier Vilela wrote:
>
> > With the function *getPublications* I think it would be good to free up
> the allocated memory?
> >
> > }
> > + pg_free(pubinfo);
> > +cleanup:
> > PQclear(res)
On Thu, 4 Jul 2024 at 14:43, Tomas Vondra wrote:
> I don't have any immediate feedback regarding this patch, but I'm
> wondering about one thing related to cancellations - we talk cancelling
> a query, but we really target a PID (or a particular backend, no matter
> how we identify it).
>
> I occa
On Wed, 26 Jun 2024 at 22:22, wrote:
> 1) Unify the print format of leader and worker
>
> In show_tidbitmap_info(), the number of exact/loosy blocks of the leader and
> workers
> are printed. I think the printed format should be same. Currently, the leader
> does not
> print the blocks of exact/
> On 4 Jul 2024, at 14:13, Dagfinn Ilmari Mannsåker wrote:
>
> Alvaro Herrera writes:
>
>> On 2024-Jul-04, Tom Lane wrote:
>>
>>> "David G. Johnston" writes:
On Wed, Jul 3, 2024 at 8:46 PM Steve Lau wrote:
> While reading the source code, I noticed comments like "-cim 9/10/89".
>
> On 4 Jul 2024, at 12:34, Aleksander Alekseev wrote:
>>> Sorry, I only have Linux and MacOS. Here are the scripts I use [2].
>>> Maybe someone who develops on Windows will answer your questions.
>>> However IMO your learning curve will be less steep with a Linux
>>> virtual machine.
>>
>> Flex/
On 2024/07/03 23:29, Nathan Bossart wrote:
On Wed, Jul 03, 2024 at 11:08:48PM +0900, Fujii Masao wrote:
+/*
+ * GUC check_hook for summarize_wal
+ */
+bool
+check_summarize_wal(bool *newval, void **extra, GucSource source)
+{
+ if (*newval && wal_level == WAL_LEVEL_MINIMAL)
+ {
+
On Jul 4, 2024, at 04:28, jian he wrote:
> Do you need to reset the datestyle?
Wouldn’t hurt but it’s not necessary, no. It’s set only for the execution of
this file, and there are no more calls that rely on it.
> also the above query is time zone sensitive, maybe the time zone is
> set in ano
On Thu, 04 Jul 2024 at 17:17, Richard Guo wrote:
> On Fri, Jun 28, 2024 at 3:21 PM Richard Guo wrote:
>> On Fri, Jun 28, 2024 at 2:54 PM Richard Guo wrote:
>> > I've refined this test case further to make it more stable by using an
>> > additional filter 'a.tenthous < 5000'. Besides, I noticed
On 2024-Jul-04, Mohab Yaser wrote:
> can you send me a link to download this version on windows as I didn't find
> anything other than the one I already have downloaded
Well,
https://packages.msys2.org/package/flex
has 2.6.4. I don't know what GnuWin32 is, but it looks abandoned.
--
Álvaro He
Hi,
With the current file_fdw, if even one line of data conversion fails,
the contents of the file cannot be referenced at all:
=# \! cat data/test.data
1,a
2,b
a,c
=# create foreign table f_fdw_test_1 (i int, t text) server f_fdw
options (filename 'test.data', format 'csv');
CRE
On 05/06/2024 20:42, Tom Lane wrote:
While working on commit b631d0149, I got a bee in my bonnet about
how unfriendly PL/Tcl's error CONTEXT reports are:
* The context reports expose PL/Tcl's internal names for the Tcl
procedures it creates, which'd be fine if those names were readable.
But actu
Daniel Gustafsson writes:
> Flex/Bison are only required when building from a Git tree, downloading a
> source archive and building from there might be easier to get started.
> https://www.postgresql.org/ftp/source/
That's no longer true I think - as of v17 the source tarballs won't
contain
Hi,
However, as you said, for most use cases, pg_stat_statements and
log_statement may be sufficient.
I would like to withdraw this proposal.
Well, they either require extensions or parameters to be set properly.
One advantage I see to store those kind of information is that it can be
queri
Harjyot Bagga writes:
> One such suggestion or rule for example is the Postgres does not support
> Postfix operators. So whenever a new feature is introduced developers make
> sure that they do not add a postfix operators in their grammar. Just like
> that are there any other further rules or sugg
> On 20 Jun 2024, at 17:22, Andreas Karlsson wrote:
>
> On 10/12/23 11:48 AM, Daniel Gustafsson wrote:
>> Thoughts?
>
> I have looked at the patch and it still applies, builds and passes the test
> cases and I personally think these optimizations are pretty much no-brainers
> that we should do
original CopyOneRowTo:
https://git.postgresql.org/cgit/postgresql.git/tree/src/backend/commands/copyto.c#n922
I change it to:
---
if (!cstate->opts.binary)
{
foreach_int(attnum, cstate->attnumlist)
{
Datum value = slot->tts_values[attnum - 1];
bool isnull = slot->tts_isnull[attn
On 26/06/2024 21:42, Peter Eisentraut wrote:
Here is a patch for using gmtime_r() and localtime_r() instead of
gmtime() and localtime(), for thread-safety.
There are a few affected calls in libpq and ecpg's libpgtypes, which are
probably effectively bugs, because those libraries already claim to
Hi.
We encountered a problem with excessive logging when transaction is
sampled.
When it is getting sampled every statement is logged, event SELECT. This
can
lead to performance degradation and log polluting.
I have added new setting to filter statements when transaction is
sampled - log_tran
Hello hackers,
03.05.2024 17:36, David Rowley wrote:
I pushed the patch after only adjusting the path in the docs which had
"module" rather than "modules".
Please look at another bunch of inconsistencies/orphaned entities I found
in the tree, with the possible substitutions:
errmsg_buf -> erro
čt 4. 7. 2024 v 17:27 odesílatel Heikki Linnakangas
napsal:
> On 05/06/2024 20:42, Tom Lane wrote:
> > While working on commit b631d0149, I got a bee in my bonnet about
> > how unfriendly PL/Tcl's error CONTEXT reports are:
> >
> > * The context reports expose PL/Tcl's internal names for the Tcl
Hi
> Hmm, could we do something with tcl namespaces to allow having two
> procedures with the same name? E.g. create a separate namespace, based
> on the OID, for each procedure. I wonder how the stack trace would look
> like then.
>
I didn't do full test, but I think so tcl uses for error messa
Pavel Stehule writes:
> čt 4. 7. 2024 v 17:27 odesílatel Heikki Linnakangas
> napsal:
>> What happens if you rename a function? I guess the error context will
>> still print the old name, but that's pretty harmless.
> The rename should to generate different tid, so the function will be
> recompi
čt 4. 7. 2024 v 19:36 odesílatel Tom Lane napsal:
> Pavel Stehule writes:
> > čt 4. 7. 2024 v 17:27 odesílatel Heikki Linnakangas
> > napsal:
> >> What happens if you rename a function? I guess the error context will
> >> still print the old name, but that's pretty harmless.
>
> > The rename sh
Hi,
I just built postgresql on macos sonoma (v14) and I had to install the
following packages:
* * icu - https://ports.macports.org/port/icu/
* * pkg - https://ports.macports.org/port/pkgconfig/
I don't see anything related to this on
https://www.postgresql.org/docs/devel/installation-pla
Pavel Stehule writes:
> Getting unique name based on suffix _oid looks not too much nice (using
> _increment can be nicer), but it should to work
Hmm, yeah we could do an increment. It'd make the results in cases
of conflict invocation-order-dependent though, which seems like it
might be worse t
Thomas Munro writes:
> On Mon, Jul 1, 2024 at 2:06 PM Tom Lane wrote:
>> Yeah. I'd do pg_regex_t in a minute except that it'd break existing
>> extensions using our facilities. However, your mention of macrology
>> stirred an idea: could we have our regex/regex.h intentionally
>> #include the s
On Wed, 3 Jul 2024 at 21:45, Joel Jacobson wrote:
>
> > On Wed, Jul 3, 2024, at 20:57, Dean Rasheed wrote:
> >> I wouldn't expect it to ever be off by more than 1
> >
> > OK, so then the cases I found where it was off by 2 for the mul_var_int()
> > patch
> > are unexpected?
>
> Sorry, I meant off
I wrote:
> I think it might be cleaner to put the new #include and macro hacking
> into regcustom.h, to show that it's our own hack and not part of the
> "official" Spencer code.
Oh, scratch that. I was thinking regex.h included regcustom.h,
but it doesn't, so there's no way that can work. Never
./configure —help
It will show that you can build —without-icu ,
you can also specify a path to pkg-config via PKG_CONFIG=/path/to/pkg-config
side note: I’ve had better experience building with brew on macos, rather than
macports.
> On 4 Jul 2024, at 9:02 PM, Said Assemlal wrote:
>
> Hi,
>
I wrote:
> Pavel Stehule writes:
>> PLpgSQL uses more often function signature
>> (2024-07-04 19:49:20) postgres=# select bx(0);
>> ERROR: division by zero
>> CONTEXT: PL/pgSQL function fx(integer) line 1 at RETURN
>> PL/pgSQL function bx(integer) line 1 at RETURN
> Oh that's a good idea! So l
Hi,
+1 for this feature.
Replacing Matviews
--
With patch 0001, a matview can be replaced without having to drop it and
its dependent objects. In our use case it is no longer necessary to
define the actual query in a separate view. Replacing a matview works
analogous to CREA
Hi,
On 2024-07-03 18:47:15 +0900, Michael Paquier wrote:
> While looking at a different patch from Tristan in this area at [1], I
> still got annoyed that this patch set was not able to support the case
> of custom fixed-numbered stats, so as it is possible to plug in
> pgstats things similar to t
Hi,
On 2024-06-13 16:59:50 +0900, Michael Paquier wrote:
> * Making custom stats data persistent is an interesting problem, and
> there are a couple of approaches I've considered:
> ** Allow custom kinds to define callbacks to read and write data from
> a source they'd want, like their own file th
Hi,
On 2024-07-04 01:54:18 +0300, Heikki Linnakangas wrote:
> pgproc.h has this:
>
> > struct PGPROC
> > {
> > /* proc->links MUST BE FIRST IN STRUCT (see ProcSleep,ProcWakeup,etc) */
> > dlist_node links; /* list link if process is in a
> > list */
> > dlist_he
Hi,
On 2024-06-30 16:47:02 +0200, Matthias van de Meent wrote:
> While hooks are generally not installed by default, I would advise
> against marking the hooks as unlikely, as that would unfairly penalize
> the performance of extensions that do utilise this hook (or hooks in
> general when applied
Hi,
On 2024-07-04 14:00:47 -0700, Andres Freund wrote:
> On 2024-06-13 16:59:50 +0900, Michael Paquier wrote:
> > * Making custom stats data persistent is an interesting problem, and
> > there are a couple of approaches I've considered:
> > ** Allow custom kinds to define callbacks to read and wri
On Wed, Jul 03, 2024 at 02:19:07PM -0700, Jeff Davis wrote:
> * Unless I made a mistake, the last three releases of Unicode (14.0,
> 15.0, and 15.1) all have the exact same behavior for UPPER() and
> LOWER() -- even for unassigned code points. It would be silly to
> promise to stay with 15.1 and th
On 2024-07-01 16:29:16 +0800, Richard Guo wrote:
> On Mon, Jun 10, 2024 at 5:05 PM Richard Guo wrote:
> > This patchset does not apply any more. Here is a new rebase.
>
> Here is an updated version of this patchset. I've run pgindent for it,
> and also tweaked the commit messages a bit.
>
> In
On Thu, Jul 04, 2024 at 08:00:00AM +0300, Alexander Lakhin wrote:
> 28.06.2024 08:13, Noah Misch wrote:
> > Pushed. ...
>
> Please look also at another anomaly, I've discovered.
>
> An Assert added with d5f788b41 may be falsified with:
> CREATE TABLE t(a int PRIMARY KEY);
> INSERT INTO t VALUES (
(Moving to -hackers)
On Thu, Jul 04, 2024 at 10:53:49PM +0200, Joel Jacobson wrote:
> On Thu, Jul 4, 2024, at 17:44, Tom Lane wrote:
>> Uh, why is it defined like that rather than allowing a subobject?
>> This definition is unable to fetch column-specific ACLs.
Yes, I was wondering about that as
On Thu, Jul 04, 2024 at 02:00:47PM -0700, Andres Freund wrote:
> On 2024-06-13 16:59:50 +0900, Michael Paquier wrote:
>> * Making custom stats data persistent is an interesting problem, and
>> there are a couple of approaches I've considered:
>> ** Allow custom kinds to define callbacks to read and
On Thu, Jul 04, 2024 at 02:08:25PM -0700, Andres Freund wrote:
> I forgot to say: In general I am highly supportive of this effort and thankful
> to Michael for tackling it. The above was just about that one aspect.
Thanks. Let's discuss how people want this stuff to be shaped, and
how much we wa
On Thu, Jul 04, 2024 at 01:56:52PM -0700, Andres Freund wrote:
> On 2024-07-03 18:47:15 +0900, Michael Paquier wrote:
>> - PgStat_ShmemControl holds an array of void* indexed by
>> PGSTAT_NUM_KINDS, pointing to shared memory areas allocated for each
>> fixed-numbered stats. Each entry is allocated
On Thu, Jul 4, 2024 at 9:12 PM Aleksander Alekseev
wrote:
> I checked against SDK 15 and 14. I also checked that it doesn't break
> something on Linux.
Thanks for testing!
> The patch seems to work. I don't have a Windows machine unfortunately.
Yeah, Windows doesn't have (it has as part of th
Thomas Munro writes:
> I had been thinking that I should try harder to make the pg_ prefix
> compile-time configurable (imagine some kind of string-pasting macros
> constructing the names), so that TCL and PG could have fewer diffs.
> But we're already not doing that for the function names, so unl
On Thu, Jul 04, 2024 at 11:30:17AM +, Bertrand Drouvot wrote:
> On Wed, Jul 03, 2024 at 06:47:15PM +0900, Michael Paquier wrote:
>> among the following lines:
>> - PgStat_ShmemControl holds an array of void* indexed by
>> PGSTAT_NUM_KINDS, pointing to shared memory areas allocated for each
>> f
On Fri, 5 Jul 2024 at 01:59, David Rowley wrote:
> I also made a pass over the patch, and I also changed:
>
> 1. Fixed up a few outdated comments in execnodes.h.
> 2. Added a comment in ExecEndBitmapHeapScan() to explain why we += the
> stats rather than memcpy the BitmapHeapScanInstrumentation.
>
On Thu, Jul 04, 2024 at 11:00:01AM +0300, Alexander Lakhin wrote:
> Could you please share your thoughts regarding other error cases, which is
> not triggered by existing tests, but still can be easily reached by users?
>
> For example:
> SELECT satisfies_hash_partition(1, 1, 0, 0);
>
> ERROR: X
On Thu, Jul 4, 2024 at 11:18 PM Japin Li wrote:
> On Thu, 04 Jul 2024 at 17:17, Richard Guo wrote:
> > Here is a new rebase.
> >
> > Barring objections, I'm planning to push it soon.
Pushed. Thanks for all the reviews.
> Thanks for updating the patch. It looks good to me, except for a minor
1 - 100 of 113 matches
Mail list logo
