Re: Inconsistency between try_mergejoin_path and create_mergejoin_plan

2024-06-18 Thread Tom Lane
Richard Guo writes: > On Mon, Jun 17, 2024 at 10:51 PM Alexander Pyhalov > wrote: >> ERROR: could not find commutator for operator XXX > It seems to me that the new operator is somewhat artificial, since it is > designed to support a mergejoin but lacks a valid commutator. So before > we proce

RE: 001_rep_changes.pl fails due to publisher stuck on shutdown

2024-06-18 Thread Hayato Kuroda (Fujitsu)
Dear Horiguchi-san, Thanks for sharing the patch! I agree this approach (ensure WAL records are flushed) Is more proper than others. I have an unclear point. According to the comment atop GetInsertRecPtr(), it just returns the approximated value - the position of the last full WAL page [1]. If

Re: Document NULL

2024-06-18 Thread Yugo NAGATA
On Tue, 18 Jun 2024 20:56:58 -0700 "David G. Johnston" wrote: > On Tue, Jun 18, 2024 at 8:34 PM Yugo NAGATA wrote: > > > > > It may be a trivial thing but I am not sure we need to mention case > > insensitivity > > here, because all keywords and unquoted identifiers are case-insensitive in > >

Re: Allow logical failover slots to wait on synchronous replication

2024-06-18 Thread Amit Kapila
On Tue, Jun 11, 2024 at 4:21 AM John H wrote: > > Building on bf279ddd1c, this patch introduces a GUC > 'standby_slot_names_from_syncrep' which allows logical failover slots > to wait for changes to have been synchronously replicated before sending > the decoded changes to logical subscribers. > >

Re: Document NULL

2024-06-18 Thread Tom Lane
Yugo NAGATA writes: > On Tue, 18 Jun 2024 20:56:58 -0700 > "David G. Johnston" wrote: >> But it is neither a keyword nor an identifier. The lexer would be quite surprised by your claim that NULL isn't a keyword. Per src/include/parser/kwlist.h, NULL is a keyword, and a fully reserved one at tha

Re: Conflict Detection and Resolution

2024-06-18 Thread Amit Kapila
On Tue, Jun 18, 2024 at 7:44 AM Zhijie Hou (Fujitsu) wrote: > > On Thursday, June 13, 2024 2:11 PM Masahiko Sawada > wrote: > > Hi, > > > On Wed, Jun 5, 2024 at 3:32 PM Zhijie Hou (Fujitsu) > > wrote: > > > > > > This time at PGconf.dev[1], we had some discussions regarding this > > > project.

Re: Document NULL

2024-06-18 Thread David G. Johnston
On Tuesday, June 18, 2024, Tom Lane wrote: > Yugo NAGATA writes: > > On Tue, 18 Jun 2024 20:56:58 -0700 > > "David G. Johnston" wrote: > >> But it is neither a keyword nor an identifier. > > The lexer would be quite surprised by your claim that NULL isn't > a keyword. Per src/include/parser/kw

Re: Conflict Detection and Resolution

2024-06-18 Thread Amit Kapila
On Tue, Jun 11, 2024 at 3:12 PM Ashutosh Bapat wrote: > > On Sat, Jun 8, 2024 at 3:52 PM Amit Kapila wrote: >> >> On Fri, Jun 7, 2024 at 5:39 PM Ashutosh Bapat >> wrote: >> > >> > On Thu, Jun 6, 2024 at 5:16 PM Nisha Moond >> > wrote: >> >> >> >> > >> >> >> >> Here are more use cases of the "e

Re: Separate HEAP WAL replay logic into its own file

2024-06-18 Thread Li, Yong
> On Jun 18, 2024, at 20:42, Melanie Plageman wrote: > > External Email > > On Mon, Jun 17, 2024 at 9:12 PM Li, Yong wrote: >> >> As a newcomer, when I was walking through the code looking for WAL replay >> related code, it was relatively easy for me to find them for the B-Tree >> access m

Re: Incorrect matching of sql/json PASSING variable names

2024-06-18 Thread Amit Langote
On Thu, Jun 13, 2024 at 5:04 PM Amit Langote wrote: > On Thu, Jun 6, 2024 at 6:20 PM Amit Langote wrote: > > > > Hi, > > > > Alvaro reported off-list that the following should really fail, > > because the jsonpath expression refers to a PASSING variable that > > doesn't exist: > > > > select json

Re: ON ERROR in json_query and the like

2024-06-18 Thread Amit Langote
On Mon, Jun 17, 2024 at 10:07 PM Markus Winand wrote: > > On 17.06.2024, at 08:20, Amit Langote wrote: > >>> 2. EMPTY [ARRAY|OBJECT] ON ERROR implies ERROR ON EMPTY > >>> > >>> 17beta1=# SELECT JSON_QUERY('[]', '$[*]' EMPTY ARRAY ON ERROR) a; > >>>a > >>> > >>>[] > >>> (1 row)

<    1   2