Re: apply_scanjoin_target_to_paths and partitionwise join

2024-05-22 Thread Ashutosh Bapat
On Mon, May 6, 2024 at 6:28 PM Ashutosh Bapat wrote: > > > On Mon, May 6, 2024 at 4:26 PM Jakub Wartak > wrote: > >> Hi Ashutosh & hackers, >> >> On Mon, Apr 15, 2024 at 9:00 AM Ashutosh Bapat >> wrote: >> > >> > Here's patch with >> > >> [..] >> > Adding to the next commitfest but better to co

Re: State of pg_createsubscriber

2024-05-22 Thread Shlok Kyal
> Just to summarize, apart from BF failures for which we had some > discussion, I could recall the following open points: > > 1. After promotion, the pre-existing replication objects should be > removed (either optionally or always), otherwise, it can lead to a new > subscriber not being able to re

Re: Avoid orphaned objects dependencies, take 3

2024-05-22 Thread Bertrand Drouvot
Hi, On Tue, May 21, 2024 at 08:53:06AM -0400, Robert Haas wrote: > On Wed, May 15, 2024 at 6:31 AM Bertrand Drouvot > wrote: > > Please find attached v6 (only diff with v5 is moving the tests as suggested > > above). > > I don't immediately know what to think about this patch. Thanks for lookin

Re: zlib detection in Meson on Windows broken?

2024-05-22 Thread Dave Page
On Tue, 21 May 2024 at 18:00, Andres Freund wrote: > Hi, > > On 2024-05-20 11:58:05 +0100, Dave Page wrote: > > I then attempt to build PostgreSQL: > > > > meson setup build > > -Dextra_include_dirs=C:/build64/openssl/include,C:/build64/zlib/include > > -Dextra_lib_dirs=C:/build64/openssl/lib,C:

Re: zlib detection in Meson on Windows broken?

2024-05-22 Thread Dave Page
On Tue, 21 May 2024 at 20:54, Andrew Dunstan wrote: > > On 2024-05-21 Tu 11:04, Andres Freund wrote: > > Hi, > > > > On 2024-05-20 11:58:05 +0100, Dave Page wrote: > >> I have very little experience with Meson, and even less interpreting > it's > >> logs, but it seems to me that it's not includin

Re: in parentesis is not usual on DOCs

2024-05-22 Thread Peter Eisentraut
On 20.05.24 02:00, jian he wrote: removing parentheses means we need to rephrase this sentence? So I come up with the following rephrase: The context_item specifies the input data to query, the path_expression is a JSON path expression defining the query, json_path_name is an optional name for t

Re: speed up a logical replica setup

2024-05-22 Thread Amit Kapila
On Mon, May 20, 2024 at 4:30 PM Shlok Kyal wrote: > > > > I was trying to test this utility when 'sync_replication_slots' is on > > and it gets in an ERROR loop [1] and never finishes. Please find the > > postgresql.auto used on the standby attached. I think if the standby > > has enabled sync_slo

Re: in parentesis is not usual on DOCs

2024-05-22 Thread jian he
On Wed, May 22, 2024 at 7:14 PM Peter Eisentraut wrote: > > On 20.05.24 02:00, jian he wrote: > >> removing parentheses means we need to rephrase this sentence? > >> So I come up with the following rephrase: > >> > >> The context_item specifies the input data to query, the > >> path_expression is

Re: tydedef extraction - back to the future

2024-05-22 Thread Peter Eisentraut
On 20.05.24 23:11, Andrew Dunstan wrote: Attached is an attempt to thread this needle. The core is a new perl module that imports the current buildfarm client logic. The intention is that once we have this, the buildfarm client will switch to using the module (if found) rather than its own buil

Re: Pgoutput not capturing the generated columns

2024-05-22 Thread Peter Eisentraut
On 08.05.24 09:13, Shubham Khanna wrote: The attached patch has the changes to support capturing generated column data using ‘pgoutput’ and’ test_decoding’ plugin. Now if the ‘include_generated_columns’ option is specified, the generated column information and generated column data also will be s

Re: State of pg_createsubscriber

2024-05-22 Thread Amit Kapila
On Wed, May 22, 2024 at 2:45 PM Shlok Kyal wrote: > > > Just to summarize, apart from BF failures for which we had some > > discussion, I could recall the following open points: > > > > 1. After promotion, the pre-existing replication objects should be > > removed (either optionally or always), ot

Re: Testing autovacuum wraparound (including failsafe)

2024-05-22 Thread Alexander Lakhin
Hello, 30.11.2023 10:35, Masahiko Sawada wrote: I've attached new version patches (0002 and 0003 are unchanged except for the commit message). I'll push them, barring any objections. Pushed. I've discovered that the test 001_emergency_vacuum.pl can fail due to a race condition. I can't see

Re: First draft of PG 17 release notes

2024-05-22 Thread torikoshia
On 2024-05-09 13:03, Bruce Momjian wrote: I have committed the first draft of the PG 17 release notes; you can see the results here: https://momjian.us/pgsql_docs/release-17.html It will be improved until the final release. The item count is 188, which is similar to recent releases:

Re: Schema variables - new implementation for Postgres 15

2024-05-22 Thread Peter Eisentraut
On 18.05.24 13:29, Alvaro Herrera wrote: I want to note that when we discussed this patch series at the dev meeting in FOSDEM, a sort-of conclusion was reached that we didn't want schema variables at all because of the fact that creating a variable would potentially change the meaning of queries

Re: Shared detoast Datum proposal

2024-05-22 Thread Nikita Malakhov
Hi, Robert, thank you very much for your response to this thread. I agree with most of things you've mentioned, but this proposal is a PoC, and anyway has a long way to go to be presented (if it ever would) as something to be committed. Andy, glad you've not lost interest in this work, I'm lookin

An implementation of multi-key sort

2024-05-22 Thread Wang Yao
Hi hackers, I'd submit an implementation of multi-key sort for review. Please see the code as attachment. Thanks for your reponse in advance. Overview MKsort (multi-key sort) is an alternative of standard qsort algorithm, which has better performance for particular sort scenarios, i.e.

Re: zlib detection in Meson on Windows broken?

2024-05-22 Thread Nazir Bilal Yavuz
Hi, On Tue, 21 May 2024 at 18:24, Dave Page wrote: > > > > On Tue, 21 May 2024 at 16:04, Andres Freund wrote: >> >> Hi, >> >> On 2024-05-20 11:58:05 +0100, Dave Page wrote: >> > I have very little experience with Meson, and even less interpreting it's >> > logs, but it seems to me that it's not

Re: State of pg_createsubscriber

2024-05-22 Thread Robert Haas
On Wed, May 22, 2024 at 7:42 AM Amit Kapila wrote: > So, what shall we do about such cases? I think by default we can > remove all pre-existing subscriptions and publications on the promoted > standby or instead we can remove them based on some switch. If we want > to go with this idea then we mi

Re: Schema variables - new implementation for Postgres 15

2024-05-22 Thread Dmitry Dolgov
> On Wed, May 22, 2024 at 02:37:49PM +0200, Peter Eisentraut wrote: > On 18.05.24 13:29, Alvaro Herrera wrote: > > I want to note that when we discussed this patch series at the dev > > meeting in FOSDEM, a sort-of conclusion was reached that we didn't want > > schema variables at all because of th

Re: zlib detection in Meson on Windows broken?

2024-05-22 Thread Dave Page
Hi On Wed, 22 May 2024 at 14:11, Nazir Bilal Yavuz wrote: > Hi, > > On Tue, 21 May 2024 at 18:24, Dave Page wrote: > > > > > > > > On Tue, 21 May 2024 at 16:04, Andres Freund wrote: > >> > >> Hi, > >> > >> On 2024-05-20 11:58:05 +0100, Dave Page wrote: > >> > I have very little experience with

RE: Fix src/test/subscription/t/029_on_error.pl test when wal_debug is enabled

2024-05-22 Thread Ilyasov Ian
Dear Michael, Amit, Hayato I corrected my patch according to what I think Michael wanted. I attached the new patch to the letter. -- Kind regards, Ian Ilyasov. Junior Software Developer at Postgres Professional 0002-Fix-subscription-029_on_error.pl-test-when-wal_debug.patch Description: 0002-

Re: State of pg_createsubscriber

2024-05-22 Thread Robert Haas
On Wed, May 22, 2024 at 9:52 AM Robert Haas wrote: > Another option that we should at least consider is "do nothing". In a > case like the one Shlok describes, how are we supposed to know what > the right thing to do is? Is it unreasonable to say that if the user > doesn't want those publications

Re: State of pg_createsubscriber

2024-05-22 Thread Robert Haas
On Mon, May 20, 2024 at 2:42 AM Amit Kapila wrote: > Just to summarize, apart from BF failures for which we had some > discussion, I could recall the following open points: > > 1. After promotion, the pre-existing replication objects should be > removed (either optionally or always), otherwise, it

Avoid possible dereference null pointer (src/backend/catalog/pg_depend.c)

2024-05-22 Thread Ranier Vilela
Hi. Per Coverity. 2. returned_null: SearchSysCacheAttName returns NULL (checked 20 out of 21 times). 3. var_assigned: Assigning: ptup = NULL return value from SearchSysCacheAttName. 964ptup = SearchSysCacheAttName(relid, attname); CID 1545986: (#1 of 1): Dereference null return v

Re: Avoid orphaned objects dependencies, take 3

2024-05-22 Thread Robert Haas
On Wed, May 22, 2024 at 6:21 AM Bertrand Drouvot wrote: > I started initially with [1] but it was focusing on function-schema only. Yeah, that's what I thought we would want to do. And then just extend that to the other cases. > Then I proposed [2] making use of a dirty snapshot when recording t

Re: Shared detoast Datum proposal

2024-05-22 Thread Robert Haas
On Tue, May 21, 2024 at 10:02 PM Andy Fan wrote: > One more things I want to highlight it "syscache" is used for metadata > and *detoast cache* is used for user data. user data is more > likely bigger than metadata, so cache size control (hence eviction logic > run more often) is more necessary in

Re: speed up a logical replica setup

2024-05-22 Thread Euler Taveira
On Wed, May 22, 2024, at 8:19 AM, Amit Kapila wrote: > > > > v2-0001: not changed > > > > Shouldn't we modify it as per the suggestion given in the email [1]? I > am wondering if we can entirely get rid of checking the primary > business and simply rely on recovery_timeout and keep checking > serv

Re: An implementation of multi-key sort

2024-05-22 Thread Heikki Linnakangas
On 22/05/2024 15:48, Wang Yao wrote: Comparing to classic quick sort, it can get significant performance improvement once multiple keys are available. A rough test shows it got ~129% improvement than qsort for ORDER BY on 6 keys, and ~52% for CREATE INDEX on the same data set. (See more details i

Re: Avoid possible dereference null pointer (src/backend/catalog/pg_depend.c)

2024-05-22 Thread Ranier Vilela
Em qua., 22 de mai. de 2024 às 11:44, Ranier Vilela escreveu: > Hi. > > Per Coverity. > > 2. returned_null: SearchSysCacheAttName returns NULL (checked 20 out of > 21 times). > 3. var_assigned: Assigning: ptup = NULL return value from > SearchSysCacheAttName. > 964ptup = SearchSy

Re: AIX support

2024-05-22 Thread Sriram RK
Thanks Alvaro, for the info… Hi Team, We referred to the below links to build this patch … https://wiki.postgresql.org/wiki/Submitting_a_Patch https://peter.eisentraut.org/blog/2023/05/09/how-to-submit-a-patch-by-email-2023-edition Please find the attached patch. Apart from the AIX specific chan

Re: zlib detection in Meson on Windows broken?

2024-05-22 Thread Nazir Bilal Yavuz
Hi, On Wed, 22 May 2024 at 17:21, Dave Page wrote: > > Hi > > On Wed, 22 May 2024 at 14:11, Nazir Bilal Yavuz wrote: >> >> >> I tried to install your latest zlib artifact (nmake one) to the >> Windows CI images (not the official ones) [1]. Then, I used the >> default meson.build file to build bu

Re: zlib detection in Meson on Windows broken?

2024-05-22 Thread Dave Page
On Wed, 22 May 2024 at 17:50, Nazir Bilal Yavuz wrote: > Hi, > > On Wed, 22 May 2024 at 17:21, Dave Page wrote: > > > > Hi > > > > On Wed, 22 May 2024 at 14:11, Nazir Bilal Yavuz > wrote: > >> > >> > >> I tried to install your latest zlib artifact (nmake one) to the > >> Windows CI images (not

Re: Schema variables - new implementation for Postgres 15

2024-05-22 Thread Tom Lane
Peter Eisentraut writes: > On 18.05.24 13:29, Alvaro Herrera wrote: >> I want to note that when we discussed this patch series at the dev >> meeting in FOSDEM, a sort-of conclusion was reached that we didn't want >> schema variables at all because of the fact that creating a variable >> would pote

Re: Virtual generated columns

2024-05-22 Thread Peter Eisentraut
On 29.04.24 20:54, Corey Huinker wrote:  -- generation expression must be immutable -CREATE TABLE gtest_err_4 (a int PRIMARY KEY, b double precision GENERATED ALWAYS AS (random()) STORED); +CREATE TABLE gtest_err_4 (a int PRIMARY KEY, b double precision GENERATED ALWAYS AS (r

Re: Schema variables - new implementation for Postgres 15

2024-05-22 Thread Alvaro Herrera
On 2024-May-22, Dmitry Dolgov wrote: > Yeah, that's a bummer. Interestingly enough, the db2 implementation of > global session variables mechanism is mentioned as similar to what we > have in the patch. But weirdly, the db2 documentation just states > possibility of a resolution conflict for unqua

Re: First draft of PG 17 release notes

2024-05-22 Thread Alvaro Herrera
On 2024-May-21, Andres Freund wrote: > Which reminds me: Eventually I'd like to add links to the most important > commits related to release note entries. We already do much of the work of > building that list of commits for each entry. That'd allow a reader to find > more details if interested.

Re: Schema variables - new implementation for Postgres 15

2024-05-22 Thread walther
Alvaro Herrera: Perhaps the solution to all this is to avoid having the variables be implicitly present in the range table of all queries. Instead, if you need a variable's value, then you need to add the variable to the FROM clause; +1 This should make it easier to work with composite type s

Re: Avoid possible dereference null pointer (src/backend/catalog/pg_depend.c)

2024-05-22 Thread Ranier Vilela
Em qua., 22 de mai. de 2024 às 13:09, Ranier Vilela escreveu: > Em qua., 22 de mai. de 2024 às 11:44, Ranier Vilela > escreveu: > >> Hi. >> >> Per Coverity. >> >> 2. returned_null: SearchSysCacheAttName returns NULL (checked 20 out of >> 21 times). >> 3. var_assigned: Assigning: ptup = NULL retu

Re: Schema variables - new implementation for Postgres 15

2024-05-22 Thread Pavel Stehule
st 22. 5. 2024 v 14:37 odesílatel Peter Eisentraut napsal: > On 18.05.24 13:29, Alvaro Herrera wrote: > > I want to note that when we discussed this patch series at the dev > > meeting in FOSDEM, a sort-of conclusion was reached that we didn't want > > schema variables at all because of the fact

Re: Schema variables - new implementation for Postgres 15

2024-05-22 Thread Pavel Stehule
st 22. 5. 2024 v 19:25 odesílatel Tom Lane napsal: > Peter Eisentraut writes: > > On 18.05.24 13:29, Alvaro Herrera wrote: > >> I want to note that when we discussed this patch series at the dev > >> meeting in FOSDEM, a sort-of conclusion was reached that we didn't want > >> schema variables at

Re: Schema variables - new implementation for Postgres 15

2024-05-22 Thread Pavel Stehule
st 22. 5. 2024 v 20:21 odesílatel napsal: > Alvaro Herrera: > > Perhaps the solution to all this is to avoid having the variables be > > implicitly present in the range table of all queries. Instead, if you > > need a variable's value, then you need to add the variable to the FROM > > clause; >

Re: Sort operation displays more tuples than it contains its subnode

2024-05-22 Thread David Rowley
On Thu, 23 May 2024 at 08:48, a.rybakina wrote: >-> Sort (cost=613.48..632.86 rows=7754 width=8) (actual > time=7.612..21.214 rows=77531 loops=1) > Sort Key: broke_down_course.sno, broke_down_course.cno > Sort Method: quicksort Memory:

Re: Sort operation displays more tuples than it contains its subnode

2024-05-22 Thread Tom Lane
"a.rybakina" writes: > I faced the issue, when the sorting node in the actual information  > shows a larger number of tuples than it actually is. And I can not > understand why? If I'm reading this correctly, the sort node you're worrying about feeds the inner side of a merge join. Merge join

Re: processes stuck in shutdown following OOM/recovery

2024-05-22 Thread Martijn Wallet
The following review has been posted through the commitfest application: make installcheck-world: not tested Implements feature: not tested Spec compliant: not tested Documentation:not tested Hi, I somehow fail to be able to mark all checkboxes on this review page... H

Re: processes stuck in shutdown following OOM/recovery

2024-05-22 Thread Martijn Wallet
The following review has been posted through the commitfest application: make installcheck-world: not tested Implements feature: not tested Spec compliant: not tested Documentation:not tested Hi, I somehow fail to be able to mark all checkboxes on this review page... H

Re: First draft of PG 17 release notes

2024-05-22 Thread Bruce Momjian
On Mon, May 20, 2024 at 02:47:28PM -0400, Melanie Plageman wrote: > On Mon, May 20, 2024 at 9:37 AM Bruce Momjian wrote: > > > > On Mon, May 20, 2024 at 01:23:02PM +0700, John Naylor wrote: > > > Hi Bruce, thanks for doing this again! > > > > > > I'm a bit late to this discussion -- there's been a

Re: First draft of PG 17 release notes

2024-05-22 Thread Bruce Momjian
On Tue, May 21, 2024 at 09:27:20AM -0700, Andres Freund wrote: > On 2024-05-18 10:59:47 -0400, Bruce Momjian wrote: > > I agree the impact of performance improvements are often greater than > > the average release note item. However, if people expect Postgres to be > > faster, is it important for

Re: First draft of PG 17 release notes

2024-05-22 Thread Bruce Momjian
On Tue, May 21, 2024 at 09:51:09AM -0700, Andres Freund wrote: > Hi, > > On 2024-05-21 09:27:20 -0700, Andres Freund wrote: > > Also, the release notes are also not just important to users. I often go > > back > > and look in the release notes to see when some some important change was > > made,

Re: First draft of PG 17 release notes

2024-05-22 Thread Bruce Momjian
On Tue, May 21, 2024 at 01:50:58PM -0400, Robert Haas wrote: > On Tue, May 21, 2024 at 12:27 PM Andres Freund wrote: > > To me that's the "General Performance" section. If somebody reading the > > release notes doesn't care about performance, they can just skip that > > section > > ([1]). I don'

Re: First draft of PG 17 release notes

2024-05-22 Thread Bruce Momjian
On Tue, May 21, 2024 at 02:26:15PM -0400, Melanie Plageman wrote: > In Postgres development, we break larger projects into smaller ones > and then those smaller projects into multiple individual commits. Each > commit needs to stand alone and each subproject needs to have a > defensible benefit. On

Re: processes stuck in shutdown following OOM/recovery

2024-05-22 Thread Thomas Munro
On Thu, May 23, 2024 at 9:58 AM Martijn Wallet wrote: > The following review has been posted through the commitfest application: > make installcheck-world: not tested > Implements feature: not tested > Spec compliant: not tested > Documentation:not tested > > Hi, I som

Re: First draft of PG 17 release notes

2024-05-22 Thread Bruce Momjian
On Tue, May 21, 2024 at 09:40:28AM -0700, Andres Freund wrote: > Hi, > > On 2024-05-18 11:13:54 -0400, Bruce Momjian wrote: > > Please see the email I just posted. There are three goals we have to > > adjust for: > > > > 1. short release notes so they are readable > > 2. giving people credit f

Re: First draft of PG 17 release notes

2024-05-22 Thread Bruce Momjian
On Mon, May 20, 2024 at 11:48:09AM -0700, Jeff Davis wrote: > On Sat, 2024-05-18 at 17:51 -0400, Bruce Momjian wrote: > > Okay, I went with the attached applied patch.  Adjustments? > > I think it should have more emphasis on the actual new feature: a > platform-independent builtin collation provi

Re: First draft of PG 17 release notes

2024-05-22 Thread Bruce Momjian
On Tue, May 21, 2024 at 11:20:02AM +0900, Amit Langote wrote: > Thanks Bruce for working on this as always. > > Failed to notice when I read the notes before: > > > > Add SQL/JSON constructor functions JSON(), JSON_SCALAR(), and > JSON_SERIALIZE() (Amit Langote) > > > > Should be: > > > >

Re: First draft of PG 17 release notes

2024-05-22 Thread Bruce Momjian
On Wed, May 22, 2024 at 11:29:06AM +0900, Masahiko Sawada wrote: > I found a typo: > > s/pg_statstatement/pg_stat_statement/ > > I've attached a patch to fix it. Agreed, applied, thanks. -- Bruce Momjian https://momjian.us EDB https://enterpris

Re: First draft of PG 17 release notes

2024-05-22 Thread Bruce Momjian
On Wed, May 22, 2024 at 09:25:41PM +0900, torikoshia wrote: > Thanks for working on this as always. > > > Allow pg_stat_reset_shared("slru") to clear SLRU statistics (Atsushi > Torikoshi) > > > Considering someone may copy and paste this, 'slru' is better than "slru", > isn't it? > I also found

Re: PostgreSQL 17 Beta 1 release announcement draft

2024-05-22 Thread Jonathan S. Katz
On 5/20/24 5:34 AM, Bertrand Drouvot wrote: Hi, On Sun, May 19, 2024 at 05:10:10PM -0400, Jonathan S. Katz wrote: On 5/16/24 1:15 AM, Bertrand Drouvot wrote: Hi, On Wed, May 15, 2024 at 09:45:35PM -0400, Jonathan S. Katz wrote: Hi, Attached is a copy of the PostgreSQL 17 Beta 1 release anno

Re: PostgreSQL 17 Beta 1 release announcement draft

2024-05-22 Thread Jonathan S. Katz
On 5/19/24 6:15 PM, Erik Rijkers wrote: Op 5/19/24 om 23:34 schreef Jonathan S. Katz: On 5/15/24 9:45 PM, Jonathan S. Katz wrote: Hi, Attached is a copy of the PostgreSQL 17 Beta 1 release announcement 'This release introduces adds an interface'  should be: 'This release adds an interface'

Re: PostgreSQL 17 Beta 1 release announcement draft

2024-05-22 Thread Jonathan S. Katz
On 5/20/24 6:08 AM, Alvaro Herrera wrote: On 2024-May-19, Jonathan S. Katz wrote: ### Query and Operational Performance Improvements In this section I'd add mention the new GUCs to control SLRU memory size, which is going to be a huge performance boon for cases where the current fixed-size bu

Re: PostgreSQL 17 Beta 1 release announcement draft

2024-05-22 Thread Jonathan S. Katz
On 5/21/24 6:40 AM, John Naylor wrote: On Mon, May 20, 2024 at 8:41 PM Masahiko Sawada wrote: On Mon, May 20, 2024 at 8:47 PM Jonathan S. Katz wrote: On 5/20/24 2:58 AM, John Naylor wrote: Hi Jon, Regarding vacuum "has shown up to a 6x improvement in overall time to complete its work" --

Re: processes stuck in shutdown following OOM/recovery

2024-05-22 Thread Martijn Wallet
Great, thanks for the feedback. It was probably the DKIM.

Re: PostgreSQL 17 Beta 1 release announcement draft

2024-05-22 Thread Jonathan S. Katz
On 5/19/24 5:34 PM, Jonathan S. Katz wrote: On 5/15/24 9:45 PM, Jonathan S. Katz wrote: Hi, Attached is a copy of the PostgreSQL 17 Beta 1 release announcement draft. This contains a user-facing summary of some of the features that will be available in the Beta, as well as a call to test. I'v

Re: processes stuck in shutdown following OOM/recovery

2024-05-22 Thread Martijn Wallet
Last test to have a verified mail, added lists.postgresql.org to spf record. Cheers.

Inval reliability, especially for inplace updates

2024-05-22 Thread Noah Misch
https://postgr.es/m/20240512232923.aa.nmi...@google.com wrote: > Separable, nontrivial things not fixed in the attached patch stack: > > - Inplace update uses transactional CacheInvalidateHeapTuple(). ROLLBACK of > CREATE INDEX wrongly discards the inval, leading to the relhasindex=t loss > s

Re: Avoid possible dereference null pointer (src/backend/catalog/pg_depend.c)

2024-05-22 Thread Michael Paquier
On Wed, May 22, 2024 at 03:28:48PM -0300, Ranier Vilela wrote: > 1. Another concern is the function *get_partition_ancestors*, > which may return NIL, which may affect *llast_oid*, which does not handle > NIL entries. Hm? We already know in the code path that the relation we are dealing with when

Speed up JSON escape processing with SIMD plus other optimisations

2024-05-22 Thread David Rowley
Currently the escape_json() function takes a cstring and char-by-char checks each character in the string up to the NUL and adds the escape sequence if the character requires it. Because this function requires a NUL terminated string, we're having to do a little more work in some places. For exam

Re: First draft of PG 17 release notes

2024-05-22 Thread David Rowley
On Thu, 23 May 2024 at 10:04, Bruce Momjian wrote: > You might have seen in this thread, I do record commits that speed up > workloads that are user-visible, or specifically make new workloads > possible. I assume that covers the items above, though I have to > determine this from the commit mess

Re: Shared detoast Datum proposal

2024-05-22 Thread Andy Fan
Robert Haas writes: > On Tue, May 21, 2024 at 10:02 PM Andy Fan wrote: >> One more things I want to highlight it "syscache" is used for metadata >> and *detoast cache* is used for user data. user data is more >> likely bigger than metadata, so cache size control (hence eviction logic >> run mor

Re: Shared detoast Datum proposal

2024-05-22 Thread Andy Fan
Nikita Malakhov writes: > Hi, > Andy, glad you've not lost interest in this work, I'm looking > forward to your improvements! Thanks for your words, I've adjusted to the rhythm of the community and welcome more feedback:) -- Best Regards Andy Fan

Re: First draft of PG 17 release notes

2024-05-22 Thread Bruce Momjian
On Thu, May 23, 2024 at 01:34:10PM +1200, David Rowley wrote: > On Thu, 23 May 2024 at 10:04, Bruce Momjian wrote: > > You might have seen in this thread, I do record commits that speed up > > workloads that are user-visible, or specifically make new workloads > > possible. I assume that covers t

Re: using extended statistics to improve join estimates

2024-05-22 Thread Andy Fan
Andrei Lepikhov writes: > On 20/5/2024 15:52, Andy Fan wrote: >> Hi Andrei, >> >>> On 4/3/24 01:22, Tomas Vondra wrote: Cool! There's obviously no chance to get this into v18, and I have stuff to do in this CF. But I'll take a look after that. >>> I'm looking at your patch now - an e

Re: Speed up JSON escape processing with SIMD plus other optimisations

2024-05-22 Thread David Rowley
On Thu, 23 May 2024 at 13:23, David Rowley wrote: > Master: > $ pgbench -n -f bench.sql -T 10 -M prepared postgres | grep tps > tps = 362.494309 (without initial connection time) > tps = 363.182458 (without initial connection time) > tps = 362.679654 (without initial connection time) > > Master +

Re: First draft of PG 17 release notes

2024-05-22 Thread David Rowley
On Thu, 23 May 2024 at 14:01, Bruce Momjian wrote: > > On Thu, May 23, 2024 at 01:34:10PM +1200, David Rowley wrote: > > What is the best way to communicate this stuff so it's easily > > identifiable when you parse the commit messages? > > This is why I think we need an "Internal Performance" sect

Re: using extended statistics to improve join estimates

2024-05-22 Thread Andrei Lepikhov
On 5/23/24 09:04, Andy Fan wrote: Andrei Lepikhov writes: * c) No extended stats with MCV. If there are multiple join clauses, * we can try using ndistinct coefficients and do what eqjoinsel does. OK, I didn't pay enough attention to this comment before. and yes, I get the same conclusion as

Re: Minor fixes for couple some comments around MERGE RETURNING

2024-05-22 Thread David Rowley
On Sun, 19 May 2024 at 15:20, David Rowley wrote: > > I noticed that PlannedStmt.hasReturning and hasModifyingCTE have an > outdated comment now that MERGE supports RETURNING (per commit > c649fa24a) > > i.e. these two: > > > bool hasReturning; /* is it insert|update|delete RETURNING? */ > > > boo

Re: Pgoutput not capturing the generated columns

2024-05-22 Thread Shubham Khanna
> Dear Shubham, > > Thanks for creating a patch! Here are high-level comments. > 1. > Please document the feature. If it is hard to describe, we should change the > API. I have added the feature in the document. > 4. > Regarding the test_decoding plugin, it has already been able to decode the >

Re: Avoid orphaned objects dependencies, take 3

2024-05-22 Thread Bertrand Drouvot
Hi, On Wed, May 22, 2024 at 10:48:12AM -0400, Robert Haas wrote: > On Wed, May 22, 2024 at 6:21 AM Bertrand Drouvot > wrote: > > I started initially with [1] but it was focusing on function-schema only. > > Yeah, that's what I thought we would want to do. And then just extend > that to the other

Re: PostgreSQL 17 Beta 1 release announcement draft

2024-05-22 Thread Bertrand Drouvot
Hi, On Wed, May 22, 2024 at 07:01:54PM -0400, Jonathan S. Katz wrote: > Thanks. As such I made it: > > "which provides descriptions about wait events and can be combined with > `pg_stat_activity` to give more insight into why an active session is > waiting." > Thanks! Works for me. Regards, -

Re: [PATCH] LockAcquireExtended improvement

2024-05-22 Thread Michael Paquier
On Sat, May 18, 2024 at 05:10:38PM +0800, Jingxian Li wrote: > Nice catch! The patch looks good to me. And fixed that as well. -- Michael signature.asc Description: PGP signature

Re: [PATCH] LockAcquireExtended improvement

2024-05-22 Thread Will Mortensen
Thanks! :-)

Re: Fix src/test/subscription/t/029_on_error.pl test when wal_debug is enabled

2024-05-22 Thread Michael Paquier
On Wed, May 22, 2024 at 02:24:37PM +, Ilyasov Ian wrote: > I corrected my patch according to what I think > Michael wanted. I attached the new patch to the letter. Thanks for compiling this patch. Yes, that's the idea. - qr/processing remote data for replication origin \"pg_\d+\" dur

RE: Pgoutput not capturing the generated columns

2024-05-22 Thread Hayato Kuroda (Fujitsu)
Dear Shubham, Thanks for updating the patch! I checked your patches briefly. Here are my comments. 01. API Since the option for test_decoding is enabled by default, I think it should be renamed. E.g., "skip-generated-columns" or something. 02. ddl.sql ``` +-- check include-generated-columns

Re: Synchronizing slots from primary to standby

2024-05-22 Thread Peter Smith
Here are some review comments for the docs patch v3-0001. == Commit message 1. This patch adds detailed documentation for the slot sync feature including examples to guide users on how to verify that all slots have been successfully synchronized to the standby server and how to confirm whethe

Re: AIX support

2024-05-22 Thread Peter Eisentraut
On 22.05.24 18:15, Sriram RK wrote: Please find the attached patch. Apart from the AIX specific changes, there is a minor change in this file wrt to XLC, below is the error for which we removed inline. Later, the build and tests passed for both XLC(16.1.0.18) and gcc(12) as well. I think w

Re: Schema variables - new implementation for Postgres 15

2024-05-22 Thread Pavel Stehule
st 22. 5. 2024 v 14:37 odesílatel Peter Eisentraut napsal: > On 18.05.24 13:29, Alvaro Herrera wrote: > > I want to note that when we discussed this patch series at the dev > > meeting in FOSDEM, a sort-of conclusion was reached that we didn't want > > schema variables at all because of the fact

Conflict Detection and Resolution

2024-05-22 Thread shveta malik
Hello hackers, Please find the proposal for Conflict Detection and Resolution (CDR) for Logical replication. Introduction In case the node is subscribed to multiple providers, or when local writes happen on a subscriber, conflicts can arise for the incoming changes. CDR is the

Re: State of pg_createsubscriber

2024-05-22 Thread Amit Kapila
On Wed, May 22, 2024 at 8:00 PM Robert Haas wrote: > > On Wed, May 22, 2024 at 9:52 AM Robert Haas wrote: > > Another option that we should at least consider is "do nothing". In a > > case like the one Shlok describes, how are we supposed to know what > > the right thing to do is? Is it unreasona

RE: State of pg_createsubscriber

2024-05-22 Thread Hayato Kuroda (Fujitsu)
Dear Amit, Robert, > So, we have the following options: (a) by default drop the > pre-existing subscriptions, (b) by default disable the pre-existing > subscriptions, and add a Note in the docs that users can take > necessary actions to enable or drop them. Now, we can even think of > providing a