Re: Speed up clean meson builds by ~25%

2024-04-09 Thread Thomas Munro
On Wed, Apr 10, 2024 at 11:44 AM Tom Lane wrote: > ... On my Mac laptop > (Apple clang version 15.0.0), the compile time for preproc.o went from > 6.7sec to 5.5sec. Having seen multi-minute compile times on FreeBSD (where clang is the system compiler) and Debian (where I get packages from apt.llv

Re: Speed up clean meson builds by ~25%

2024-04-09 Thread Tom Lane
Thomas Munro writes: > On Wed, Apr 10, 2024 at 11:44 AM Tom Lane wrote: >> ... On my Mac laptop >> (Apple clang version 15.0.0), the compile time for preproc.o went from >> 6.7sec to 5.5sec. > Having seen multi-minute compile times on FreeBSD (where clang is the > system compiler) and Debian (wh

Re: Incorrect handling of IS [NOT] NULL quals on inheritance parents

2024-04-09 Thread David Rowley
On Tue, 9 Apr 2024 at 21:55, Richard Guo wrote: > > In b262ad440e we introduced an optimization that drops IS NOT NULL quals > on a NOT NULL column, and reduces IS NULL quals on a NOT NULL column to > constant-FALSE. I happened to notice that this is not working correctly > for traditional inheri

Re: Incorrect handling of IS [NOT] NULL quals on inheritance parents

2024-04-09 Thread Tom Lane
David Rowley writes: > I think a better fix is just to not apply the optimisation for > inheritance RTEs in add_base_clause_to_rel(). Is it worth paying attention to whether the constraint is marked connoinherit? If that involves an extra syscache fetch, I'd tend to agree that it's not worth it;

Re: Improve eviction algorithm in ReorderBuffer

2024-04-09 Thread Heikki Linnakangas
On 10/04/2024 07:45, Michael Paquier wrote: On Tue, Apr 09, 2024 at 09:16:53PM -0700, Jeff Davis wrote: On Wed, 2024-04-10 at 12:13 +0900, Michael Paquier wrote: Wouldn't the best way forward be to revert 5bec1d6bc5e3 and revisit the whole in v18? Also consider commits b840508644 and bcb14f4a

Re: Improve eviction algorithm in ReorderBuffer

2024-04-09 Thread Amit Kapila
On Wed, Apr 10, 2024 at 11:00 AM Heikki Linnakangas wrote: > > On 10/04/2024 07:45, Michael Paquier wrote: > > On Tue, Apr 09, 2024 at 09:16:53PM -0700, Jeff Davis wrote: > >> On Wed, 2024-04-10 at 12:13 +0900, Michael Paquier wrote: > >>> Wouldn't the best way forward be to revert > >>> 5bec1d6bc

Re: Incorrect handling of IS [NOT] NULL quals on inheritance parents

2024-04-09 Thread David Rowley
On Wed, 10 Apr 2024 at 17:18, Tom Lane wrote: > > David Rowley writes: > > I think a better fix is just to not apply the optimisation for > > inheritance RTEs in add_base_clause_to_rel(). > > Is it worth paying attention to whether the constraint is marked > connoinherit? If that involves an ext

Re: Can't find not null constraint, but \d+ shows that

2024-04-09 Thread jian he
On Wed, Apr 10, 2024 at 1:29 AM Alvaro Herrera wrote: > > On 2024-Mar-29, Tender Wang wrote: > > > I think aboved case can explain what's meaning about comments in > > dropconstraint_internal. > > But here, in RemoveConstraintById() , we only care about primary key case, > > so NOT NULL is better

Re: Can't find not null constraint, but \d+ shows that

2024-04-09 Thread Tender Wang
jian he 于2024年4月10日周三 14:10写道： > On Wed, Apr 10, 2024 at 1:29 AM Alvaro Herrera > wrote: > > > > On 2024-Mar-29, Tender Wang wrote: > > > > > I think aboved case can explain what's meaning about comments in > > > dropconstraint_internal. > > > But here, in RemoveConstraintById() , we only care a

<    1   2