Re: AIX support

2024-03-28 Thread Thomas Munro
On Fri, Mar 29, 2024 at 3:48 PM Noah Misch wrote: > On Thu, Mar 28, 2024 at 11:09:43AM +, Sriram RK wrote: > > We are setting up the build environment and trying to build the source and > > also trying to analyze the assert from the Aix point of view. > > The thread Alvaro and Tom cited conta

Re: CREATE TABLE creates a composite type corresponding to the table row, which is and is not there

2024-03-28 Thread Erik Wienhold
On 2024-03-29 02:42 +0100, David G. Johnston wrote: > For consideration for the doc portion. The existing wording is too > imprecise for my liking and just tacking on "expects...create type" is > jarring. > > """ > Creates a typed table, which takes it structure from an existing (name > optionall

Re: AIX support

2024-03-28 Thread Tom Lane
Noah Misch writes: > On Thu, Mar 28, 2024 at 11:09:43AM +, Sriram RK wrote: >> Also, would like to know if we can access the buildfarm(power machines) to >> run any of the specific tests to hit this assert. > https://portal.cfarm.net/users/new/ is the form to request access. It lists > the

Re: AIX support

2024-03-28 Thread Thomas Munro
On Fri, Mar 29, 2024 at 4:00 PM Thomas Munro wrote: > On Fri, Mar 29, 2024 at 3:48 PM Noah Misch wrote: > > The thread Alvaro and Tom cited contains an analysis. It's a compiler bug. > > You can get past the compiler bug by upgrading your compiler; both ibm-clang > > 17.1.1.2 and gcc 13.2.0 are

Re: remaining sql/json patches

2024-03-28 Thread jian he
On Thu, Mar 28, 2024 at 1:23 PM Amit Langote wrote: > > On Wed, Mar 27, 2024 at 1:34 PM Amit Langote wrote: > > On Wed, Mar 27, 2024 at 12:42 PM jian he > > wrote: > > > hi. > > > I don't fully understand all the code in json_table patch. > > > maybe we can split it into several patches, > > >

Re: PSQL Should \sv & \ev work with materialized views?

2024-03-28 Thread Isaac Morland
On Thu, 28 Mar 2024 at 20:38, Erik Wienhold wrote: > Of course the problem with using DROP and CREATE is that indexes and > privileges (anything else?) must also be restored. I haven't bothered > with that yet. > Not just those — also anything that depends on the matview, such as views and oth

Re: AIX support

2024-03-28 Thread Tom Lane
Thomas Munro writes: > Oh, sorry, I had missed the part where newer compilers fix the issue > too. Old out-of-support versions of AIX running old compilers, what > fun. Indeed. One of the topics that needs investigation if you want to pursue this is which AIX system and compiler versions still

Re: DOCS: add helpful partitioning links

2024-03-28 Thread Ashutosh Bapat
On Thu, Mar 28, 2024 at 11:22 PM Alvaro Herrera wrote: > On 2024-Mar-28, Ashutosh Bapat wrote: > > > LGTM. > > > > The commitfest entry is marked as RFC already. > > > > Thanks for taking care of the comments. > > Thanks for reviewing. I noticed a typo "seperate", fixed here. Thanks for catchi

Re: Synchronizing slots from primary to standby

2024-03-28 Thread shveta malik
On Fri, Mar 29, 2024 at 6:36 AM Zhijie Hou (Fujitsu) wrote: > > Attach a new version patch which fixed an un-initialized variable issue and > added some comments. Also, temporarily enable DEBUG2 for the 040 tap-test so > that > we can analyze the possible CFbot failures easily. As suggested by A

RE: Synchronizing slots from primary to standby

2024-03-28 Thread Hayato Kuroda (Fujitsu)
Dear Hou, Thanks for updating the patch! Here is a comment for it. ``` +/* + * By advancing the restart_lsn, confirmed_lsn, and xmin using + * fast-forward logical decoding, we can verify whether a consistent + * snapshot can be built. This process also involves sa

Re: Introduce XID age and inactive timeout based replication slot invalidation

2024-03-28 Thread Amit Kapila
On Wed, Mar 27, 2024 at 9:00 PM Bharath Rupireddy wrote: > > > Thanks. I'm attaching v29 patches. 0001 managing inactive_since on the > standby for sync slots. > Commit message states: "why we can't just update inactive_since for synced slots on the standby with the value received from remote slo

Re: PSQL Should \sv & \ev work with materialized views?

2024-03-28 Thread Erik Wienhold
On 2024-03-29 04:27 +0100, Isaac Morland wrote: > On Thu, 28 Mar 2024 at 20:38, Erik Wienhold wrote: > > > > Of course the problem with using DROP and CREATE is that indexes and > > privileges (anything else?) must also be restored. I haven't bothered > > with that yet. > > > > Not just those

Re: type cache cleanup improvements

2024-03-28 Thread Жарков Роман
> Rest of patches, rebased. Hello, I read and tested only the first patch so far. Creation of temp tables and rollback in your script work 3-4 times faster with 0001-type-cache.patch on my windows laptop. In the patch I found a copy of the comment "If it's domain over composite, reset flags...".

Re: Improve eviction algorithm in ReorderBuffer

2024-03-28 Thread vignesh C
On Tue, 26 Mar 2024 at 10:05, Masahiko Sawada wrote: > > On Thu, Mar 14, 2024 at 12:02 PM Masahiko Sawada > wrote: > > > > > > I've attached new version patches. > > Since the previous patch conflicts with the current HEAD, I've > attached the rebased patches. Thanks for the updated patch. One

Re: [PoC] Improve dead tuple storage for lazy vacuum

2024-03-28 Thread Masahiko Sawada
On Thu, Mar 28, 2024 at 6:15 PM John Naylor wrote: > > On Thu, Mar 28, 2024 at 12:55 PM Masahiko Sawada > wrote: > > > > Pushed the refactoring patch. > > > > I've attached the rebased vacuum improvement patch for cfbot. I > > mentioned in the commit message that this patch eliminates the 1GB >

Re: Psql meta-command conninfo+

2024-03-28 Thread Imseih (AWS), Sami
Thank you for the updated patch. First and foremost, thank you very much for the review. > The initial and central idea was always to keep the metacommand > "\conninfo" in its original state, that is, to preserve the string as it is. > The idea of "\conninfo+" is to expand this to include more in

Re: Introduce XID age and inactive timeout based replication slot invalidation

2024-03-28 Thread Bertrand Drouvot
Hi, On Fri, Mar 29, 2024 at 09:39:31AM +0530, Amit Kapila wrote: > On Wed, Mar 27, 2024 at 9:00 PM Bharath Rupireddy > wrote: > > > > > > Thanks. I'm attaching v29 patches. 0001 managing inactive_since on the > > standby for sync slots. > > > > Commit message states: "why we can't just update in

Re: Statistics Import and Export

2024-03-28 Thread Jeff Davis
On Tue, 2024-03-26 at 00:16 +0100, Tomas Vondra wrote: > I did take a closer look at v13 today. I have a bunch of comments and > some minor whitespace fixes in the attached review patches. I also attached a patch implementing a different approach to the pg_dump support. Instead of trying to create

Re: Improve eviction algorithm in ReorderBuffer

2024-03-28 Thread Masahiko Sawada
On Fri, Mar 29, 2024 at 2:09 PM vignesh C wrote: > > On Tue, 26 Mar 2024 at 10:05, Masahiko Sawada wrote: > > > > On Thu, Mar 14, 2024 at 12:02 PM Masahiko Sawada > > wrote: > > > > > > > > > I've attached new version patches. > > > > Since the previous patch conflicts with the current HEAD, I'

Re: To what extent should tests rely on VACUUM ANALYZE?

2024-03-28 Thread Richard Guo
On Fri, Mar 29, 2024 at 1:33 AM Tom Lane wrote: > Tomas Vondra writes: > > Yeah. I think it's good to design the data/queries in such a way that > > the behavior does not flip due to minor noise like in this case. > > +1 Agreed. The query in problem is: -- we can pull up the sublink into the

Re: Synchronizing slots from primary to standby

2024-03-28 Thread Bertrand Drouvot
Hi, On Fri, Mar 29, 2024 at 01:06:15AM +, Zhijie Hou (Fujitsu) wrote: > Attach a new version patch which fixed an un-initialized variable issue and > added some comments. Also, temporarily enable DEBUG2 for the 040 tap-test so > that > we can analyze the possible CFbot failures easily. > Th

Re: Synchronizing slots from primary to standby

2024-03-28 Thread Amit Kapila
On Fri, Mar 29, 2024 at 6:36 AM Zhijie Hou (Fujitsu) wrote: > > > Attach a new version patch which fixed an un-initialized variable issue and > added some comments. > The other approach to fix this issue could be that the slotsync worker get the serialized snapshot using pg_read_binary_file() cor

Re: Can't find not null constraint, but \d+ shows that

2024-03-28 Thread jian he
hi. about v4, i think, i understand the changes you made. RemoveConstraintById(Oid conId) will drop a single constraint record. if the constraint is primary key, then primary key associated attnotnull should set to false. but sometimes it shouldn't. for example: drop table if exists t2; CREATE TA

<    1   2