Re: Add system identifier to backup manifest

2024-03-07 Thread Amul Sul
On Fri, Mar 8, 2024 at 1:22 AM Robert Haas wrote: > On Thu, Mar 7, 2024 at 9:16 AM Robert Haas wrote: > > It could. I just thought this was clearer. I agree that it's a bit > > long, but I don't think this is worth bikeshedding very much. If at a > > later time somebody feels strongly that it ne

Re: Improve readability by using designated initializers when possible

2024-03-07 Thread Michael Paquier
On Wed, Mar 06, 2024 at 08:24:09AM +0800, Japin Li wrote: > On Wed, 06 Mar 2024 at 01:53, Jelte Fennema-Nio wrote: >> I think if you remove the EEO_CASE(EEOP_LAST) block the warning should >> go away. That block is clearly marked as unreachable, so it doesn't >> really serve a purpose. > > Thanks

Re: Remove unnecessary code from psql's watch command

2024-03-07 Thread Yugo NAGATA
On Wed, 06 Mar 2024 13:03:39 -0500 Tom Lane wrote: > Michael Paquier writes: > > On Tue, Mar 05, 2024 at 10:05:52PM +0900, Yugo NAGATA wrote: > >> In the current code of do_watch(), sigsetjmp is called if WIN32 > >> is defined, but siglongjmp is not called in the signal handler > >> in this cond

Fix cancellation check in ExecQueryAndProcessResults

2024-03-07 Thread Yugo NAGATA
Hi, While looking ExecQueryAndProcessResults, I found the following code. /* * If SIGINT is sent while the query is processing, the interrupt will be * consumed. The user's intention, though, is to cancel the entire watch * process, so detect a sent cancellation request and

Re: meson: Specify -Wformat as a common warning flag for extensions

2024-03-07 Thread Tristan Partin
On Sun Jan 21, 2024 at 11:11 PM CST, Sutou Kouhei wrote: Hi, I'm an extension developer. If I use PostgreSQL built with Meson, I get the following warning: cc1: warning: '-Wformat-security' ignored without '-Wformat' [-Wformat-security] Because "pg_config --cflags" includes -Wformat-secur

Re: Improve readability by using designated initializers when possible

2024-03-07 Thread Michael Paquier
On Mon, Mar 04, 2024 at 09:29:03AM +0800, jian he wrote: > On Fri, Mar 1, 2024 at 5:26 PM Peter Eisentraut wrote: >> Oops, there was a second commit in my branch that I neglected to send >> in. Here is my complete patch set. Thanks for the new patch set. The gains are neat, giving nice numbers:

Re: Dump-restore loosing 'attnotnull' bit for DEFERRABLE PRIMARY KEY column(s).

2024-03-07 Thread Amul Sul
On Thu, Mar 7, 2024 at 11:02 PM Alvaro Herrera wrote: > On 2024-Mar-07, Alvaro Herrera wrote: > > > Maybe we can add a flag RelationData->rd_ispkdeferred, so that > > RelationGetPrimaryKeyIndex returned InvalidOid for deferrable PKs; then > > logical replication would continue to not know about t

Re: Statistics Import and Export

2024-03-07 Thread Corey Huinker
> > > > BEGIN; > > LOCK TABLE schema.relation IN SHARE UPDATE EXCLUSIVE MODE; > > LOCK TABLE pg_catalog.pg_statistic IN ROW UPDATE EXCLUSIVE MODE; > > SELECT pg_import_rel_stats('schema.relation', ntuples, npages); > > SELECT pg_import_pg_statistic('schema.relation', 'id', ...); > > SELECT pg_impor

Re: Support a wildcard in backtrace_functions

2024-03-07 Thread Bharath Rupireddy
On Wed, Mar 6, 2024 at 12:41 AM Alvaro Herrera wrote: > > > I think we need to go a bit further and convert backtrace_functions of > > type GUC_LIST_INPUT so that check_backtrace_functions can just use > > SplitIdentifierString to parse the list of identifiers. Then, the > > strspn can just be som

Re: pg_column_toast_chunk_id: a function to get a chunk ID of a TOASTed value

2024-03-07 Thread Yugo NAGATA
On Thu, 7 Mar 2024 16:56:17 -0600 Nathan Bossart wrote: > On Mon, Feb 05, 2024 at 04:28:23PM +0900, Yugo NAGATA wrote: > > On Thu, 1 Feb 2024 17:59:56 +0800 > > jian he wrote: > >> v6 patch looks good. > > > > Thank you for your review and updating the status to RwC! > > I think this one needs

Re: meson: Specify -Wformat as a common warning flag for extensions

2024-03-07 Thread Michael Paquier
On Thu, Mar 07, 2024 at 11:39:39PM -0600, Tristan Partin wrote: > It sounds like a legitimate issue. I have confirmed the issue exists with a > pg_config compiled with Meson. I can also confirm that this issue exists in > the autotools build. First time I'm hearing about that, but I'll admit that

Re: Statistics Import and Export

2024-03-07 Thread Corey Huinker
> > > > Having some discussion around that would be useful. Is it better to > have a situation where there are stats for some columns but no stats for > other columns? There would be a good chance that this would lead to a > set of queries that were properly planned out and a set which end up > w

Re: Proposal to add page headers to SLRU pages

2024-03-07 Thread Li, Yong
> On Mar 7, 2024, at 03:09, Stephen Frost wrote: > > External Email > > From: Stephen Frost > Subject: Re: Proposal to add page headers to SLRU pages > Date: March 7, 2024 at 03:09:59 GMT+8 > To: Alvaro Herrera > Cc: "Li, Yong" , Aleksander Alekseev > , PostgreSQL Hackers > , "Bagga, Rishu"

<    1   2