Hi, Alexander!
On 12.02.2024 05:27, Alexander Korotkov wrote:
But the worst thing is that replacing AND with OR causes breaking session and
server restart:
I haven't managed to reproduce this yet. Could you give more details:
machine, OS, compile options, backtrace?
We already had off-list
Hi!
I can't unnderstand this part of code:
/* Time to generate index paths */
MemSet(&clauseset, 0, sizeof(clauseset));
match_clauses_to_index(root, list_make1(rinfo1), index, &clauseset);
As I understand it, match_clauses_to_index is necessary if you have a
RestrictInfo (rinfo1) variable, so
On 12/2/2024 15:55, Alena Rybakina wrote:
Hi!
I can't unnderstand this part of code:
/* Time to generate index paths */
MemSet(&clauseset, 0, sizeof(clauseset));
match_clauses_to_index(root, list_make1(rinfo1), index, &clauseset);
As I understand it, match_clauses_to_index is necessary if you
On Fri, 9 Feb 2024 at 12:30, Peter Smith wrote:
>
> Here are some review comments for patch v7-0001.
>
> ==
> doc/src/sgml/glossary.sgml
>
> 1.
> +
> + Logical replication cluster
> +
> +
> + A set of publisher and subscriber instance with publisher instance
> + replicating
On 25/01/2024 17:22, Japin Li wrote:
On Thu, 25 Jan 2024 at 21:43, Aleksander Alekseev
wrote:
I find heapam_relation_copy_data() and index_copy_data() have the following
code:
dstrel = smgropen(*newrlocator, rel->rd_backend);
...
RelationCreateStorage(*newrlocato
On Sun, Feb 11, 2024 at 6:53 PM Zhijie Hou (Fujitsu)
wrote:
>
> Agreed. Here is the V84 patch which addressed this.
>
Few comments:
=
1. Isn't the new function (pg_sync_replication_slots()) allowed to
sync the slots from physical standby to another cascading standby?
Won't it be bette
I have done a review of the temporal foreign key patches in this patch
series (0002 and 0003, v24).
The patch set needs a rebase across c85977d8fef. I was able to do it
manually, but it's a bit tricky, so perhaps you can post a new set to
help future reviews.
(Also, the last (0007) patch has so
On 05/12/2023 20:37, Tristan Partin wrote:
The file is only referenced in Meson and MSVC scripts from what I can
tell, and the Meson reference is protected by a Windows check.
There are a bunch of files like win32common.c:
$ ls src/port/win32*.c
src/port/win32common.c
src/port/win32dlopen.c
sr
Hi,
On Sun, Feb 11, 2024 at 01:23:19PM +, Zhijie Hou (Fujitsu) wrote:
> On Saturday, February 10, 2024 9:10 PM Amit Kapila
> wrote:
> >
> > On Sat, Feb 10, 2024 at 5:31 PM Masahiko Sawada
> > wrote:
> > >
> > > On Fri, Feb 9, 2024 at 4:08 PM Zhijie Hou (Fujitsu)
> > > wrote:
> > >
> > > >
On 2024-Feb-11, Peter Eisentraut wrote:
> But I see that table constraints do not work that way. A command like ALTER
> TABLE t1 ADD NOT NULL c1 does nothing if the column already has a NOT NULL
> constraint. I'm not sure this is correct. At least it's not documented.
> We should probably make
Hi all,
I've attached a patch for the master branch to fix up the custom BIOs used
by PostgreSQL, in light of the issues with the OpenSSL update recently.
While c82207a548db47623a2bfa2447babdaa630302b9 (switching from BIO_get_data
to BIO_get_app_data) resolved the immediate conflict, I don't think
Azure Postgres login authentication :
This is how I do it for the Azure PostgreSQL, I will have to test to see if it
will log in the same way, as I need to be able to get the token from Azure and
pass that in as the password for the User/group account in the on-prem database.
Thanks the
On Mon, Feb 12, 2024 at 3:33 PM Bertrand Drouvot
wrote:
>
> A few random comments:
>
>
> 003 ===
>
> + If, after executing the function,
> +
> + hot_standby_feedback is disabled on
> + the standby or the physical slot configured in
> +
> + pr
On 12.02.2024 12:01, Andrei Lepikhov wrote:
On 12/2/2024 15:55, Alena Rybakina wrote:
Hi!
I can't unnderstand this part of code:
/* Time to generate index paths */
MemSet(&clauseset, 0, sizeof(clauseset));
match_clauses_to_index(root, list_make1(rinfo1), index, &clauseset);
As I understand i
Hi,
There are several places where publisher and subscriber terms are used
across the documentation. But the publisher and subscriber were
missing in the documentation. I felt this should be added in the
glossary.
I have created a patch for the same.
Thanks and Regards
Shlok Kyal
v1-0001-Add-pu
Re: Tom Lane
> > I hit this again while porting cplupluscheck to be invoked by meson as
> > well. ISTM that we should just remove the uses of register.
>
> OK by me.
>
> > I tried to use -Wregister to keep us honest going forward, but unfortunately
> > it only works with a C++ compiler...
>
> I
Hello
On 2024-Feb-12, Shlok Kyal wrote:
> There are several places where publisher and subscriber terms are used
> across the documentation. But the publisher and subscriber were
> missing in the documentation. I felt this should be added in the
> glossary.
I agree, but let's wordsmith those def
On 07.02.24 04:06, jian he wrote:
/*
* hashRowType
*
* If two tuple descriptors would be considered equal by equalRowTypes()
* then their hash value will be equal according to this function.
*/
uint32
hashRowType(TupleDesc desc)
{
uint32 s;
int i;
s = hash_combine(0, hash_uint32(desc->
Are there any other
functions that pg_monitor ought to have privileges for?
Not that I'm aware of at the moment. This one was found by chance.
Kind regards,
Pavlo Golub
Hi Sergei,
> I still would like to maintaint the focus on committing the "idle in
transactions" part of pg_stat_session first.
Agreed.
I've done a review of version 0004. This version is applied successful
over ce571434ae7, installcheck passed. The behavior of pg_stat_session
view and correspond
On 06.02.24 16:14, Tom Lane wrote:
Peter Eisentraut writes:
The first want to compare what I call row-type equality, which means
they want to check specifically for equal number of attributes, and the
same attribute names, types, and typmods for each attribute. Most
callers actually want that
On Fri, Feb 9, 2024 at 2:14 AM Bernd Helmle wrote:
>
> Am Mittwoch, dem 10.01.2024 um 22:18 +0800 schrieb jian he:
> >
> > I split the original author's patch into 2.
> > 1. Add GiST sortsupport function for all the btree-gist module data
> > types except anyrange data type (which actually does no
> On 20 Dec 2023, at 12:23, Jelte Fennema-Nio wrote:
> Attached is a trivial patch that starts supporting
> backtrace_functions='*'. By setting that in postgresql.conf for my dev
> environment it starts logging backtraces always.
I happened to implement pretty much the same diff today during a d
On Mon, 12 Feb 2024 at 14:14, Daniel Gustafsson wrote:
> > The main problem it currently has is that it adds backtraces to all
> > LOG level logs too. So probably we want to make backtrace_functions
> > only log backtraces for ERROR and up (or maybe WARNING/NOTICE and up),
> > or add a backtrace_f
Hi All,
alter table t1 add column c serial;
ALTER TABLE
this works, but not
#alter table t1 add column c int;
ALTER TABLE
#alter table t1 alter column c type serial;
ERROR: type "serial" does not exist
Looking at the documentation [1], the grammar for both mentions data_type
ADD [ COLUMN ] [ IF
On Sat, 10 Feb 2024 at 13:28, Andrew Dunstan wrote:
>
> On 2024-02-10 Sa 12:20, Dave Cramer wrote:
>
>
>
> On Sat, 10 Feb 2024 at 11:19, Andrew Dunstan wrote:
>
>>
>> On 2024-02-09 Fr 14:23, Dave Cramer wrote:
>>
>>
>> Dave Cramer
>> www.postgres.rocks
>>
>>
>> On Fri, 9 Feb 2024 at 07:18, Dave
Hi,
On Mon, Feb 12, 2024 at 04:19:33PM +0530, Amit Kapila wrote:
> On Mon, Feb 12, 2024 at 3:33 PM Bertrand Drouvot
> wrote:
> >
> > A few random comments:
> >
> >
> > 003 ===
> >
> > + If, after executing the function,
> > +
> > + hot_standby_feedback is disabled on
>
>I found that \conninfo and \conninfo+ act differently when the connection is
>broken.
>I used pg_terminate_backend function from another session to terminate an open
>psql session.
>After that, \conninfo does not see the connection break (surprisingly!), and
>\conninfo+ returns an error:
>
>po
On 2024-02-12 Mo 08:51, Dave Cramer wrote:
On Sat, 10 Feb 2024 at 13:28, Andrew Dunstan wrote:
On 2024-02-10 Sa 12:20, Dave Cramer wrote:
On Sat, 10 Feb 2024 at 11:19, Andrew Dunstan
wrote:
On 2024-02-09 Fr 14:23, Dave Cramer wrote:
Dave Cramer
ww
> On 11 Feb 2024, at 19:19, David Benjamin wrote:
>
> Hi all,
>
> I've attached a patch for the master branch to fix up the custom BIOs used by
> PostgreSQL, in light of the issues with the OpenSSL update recently. While
> c82207a548db47623a2bfa2447babdaa630302b9 (switching from BIO_get_data t
On 08.02.24 08:20, Ashutosh Bapat wrote:
On Wed, Feb 7, 2024 at 12:47 PM Ashutosh Bapat
wrote:
0001 fixes compression inheritance
0002 fixes storage inheritance
The first patch does not update compression_1.out which makes CI
unhappy. Here's patchset fixing that.
The changed behavior look
On 12.02.24 14:27, Jelte Fennema-Nio wrote:
And honestly wanting
to get backtraces for non-ERROR log entries seems quite niche to me,
which to me makes it a weird default.
I think one reason for this is that non-ERRORs are fairly unique in
their wording, so you don't have to isolate them by fu
On Mon, Feb 12, 2024 at 12:27:54PM +, Pavlo Golub wrote:
>> Are there any other
>> functions that pg_monitor ought to have privileges for?
>>
> Not that I'm aware of at the moment. This one was found by chance.
Okay. I'll plan on committing this in the next few days.
--
Nathan Bossart
Ama
On Sun, Feb 11, 2024 at 03:44:42PM +0100, Mats Kindahl wrote:
> On Sat, Feb 10, 2024 at 9:53 PM Nathan Bossart
> wrote:
>> and I think we should expand on some of the commentary in int.h.
>> For example, the comment at the top of int.h seems very tailored to the
>> existing functions and should pr
Peter Eisentraut writes:
> On 06.02.24 16:14, Tom Lane wrote:
>> +1 for the general idea, but it seems like "row type equality"
>> might still be a slightly fuzzy concept.
> I did another pass across the callers to check what pg_attribute fields
> might be relevant.
> Collation definitely needs
On 10.02.24 21:13, Nathan Bossart wrote:
(Interestingly, IWYU has been mentioned in src/tools/pginclude/README since
2012. Has anyone else played with it? Was it not mature enough back then?)
I haven't played with it at all, but the topic reminds me of this thread:
https://postgr.es/
Christoph Berg writes:
> Should the removal of "register" be backported to support that better?
Perhaps. It's early days yet, but nobody has complained that that
broke anything in v16, so I'm guessing it'd be fine.
regards, tom lane
On Sat, 10 Feb 2024 10:19:15 +0900
Michael Paquier wrote:
> On Fri, Feb 09, 2024 at 04:37:23PM +0800, Julien Rouhaud wrote:
> > On Fri, Feb 09, 2024 at 03:38:23PM +0900, Yugo NAGATA wrote:
> >> Also, I think the name is a bit confusing for the same reason, that is,
> >> query_id_enabled may be fa
On Mon, Feb 12, 2024 at 05:08:40PM +0100, Peter Eisentraut wrote:
> On 10.02.24 21:13, Nathan Bossart wrote:
>> I haven't played with it at all, but the topic reminds me of this thread:
>>
>>
>> https://postgr.es/m/flat/CALDaNm1B9naPDTm3ox1m_yZvOm3KA5S4kZQSWWAeLHAQ%3D3gV1Q%40mail.gmail.com
>
On Feb 10, 2024, at 20:52, Erik Wienhold wrote:
>
> Let me comment on some issues since I wrote the very first version of
> parse_type() on which David's patch is based.
Thanks Erik.
>> On 2024-02-01 01:00 +0100, jian he wrote:
>> if you are wondering around other code deal with NULL, ErrorSav
Dave Cramer
www.postgres.rocks
On Mon, 12 Feb 2024 at 09:19, Andrew Dunstan wrote:
>
> On 2024-02-12 Mo 08:51, Dave Cramer wrote:
>
>
>
> On Sat, 10 Feb 2024 at 13:28, Andrew Dunstan wrote:
>
>>
>> On 2024-02-10 Sa 12:20, Dave Cramer wrote:
>>
>>
>>
>> On Sat, 10 Feb 2024 at 11:19, Andrew Duns
>
>
> - About the style: there is usually an empty line between an ending
> and the next starting . It does not matter for correctness, but I
> think it makes the source easier to read.
>
Done. I've seen them with spaces and without, and have no preference.
>
> - I would rather have only "
On Mon, 2024-02-12 at 11:45 -0500, Corey Huinker wrote:
>
> > - I am not sure if it is necessary to have the at all.
> > I'd say that it is just a trivial variation of the UPDATE example.
> > On the other hand, a beginner might find the example useful.
> > Not sure.
>
> I think a beginner
On Wed Jan 24, 2024 at 8:09 AM CST, Alvaro Herrera wrote:
From 3d24b89855888a6650ec1aafb3579d810bfec5ac Mon Sep 17 00:00:00 2001
From: Alvaro Herrera
Date: Tue, 23 Jan 2024 10:36:14 +0100
Subject: [PATCH] Remove IndividualLWLockNames
We can just merge the lwlock names into the BuiltinTrancheNam
On Mon, Feb 12, 2024 at 4:57 PM Nathan Bossart
wrote:
> On Sun, Feb 11, 2024 at 03:44:42PM +0100, Mats Kindahl wrote:
> > On Sat, Feb 10, 2024 at 9:53 PM Nathan Bossart >
> > wrote:
> >> and I think we should expand on some of the commentary in int.h.
> >> For example, the comment at the top of
On Sat Feb 10, 2024 at 1:40 AM CST, Peter Eisentraut wrote:
I played with include-what-you-use (IWYU), "a tool for use with clang to
analyze #includes in C and C++ source files".[0] I came across this via
clangd (the language server), because clangd (via the editor) kept
suggesting a bunch of
>
> Do you plan to add it to the commitfest? If yes, I'd set it "ready for
> committer".
>
> Commitfest entry reanimated.
On Sun Feb 11, 2024 at 5:09 PM CST, Peter Eisentraut wrote:
Small update: I noticed that on Windows (at least the one that is
running the CI job), I need to use git -c core.autocrlf=false, otherwise
git archive does line-ending conversion for the files it puts into the
archive. With this fix,
"David E. Wheeler" writes:
> [ v4-0001-Add-parse_type-SQL-function.patch ]
It strikes me that this is basically to_regtype() with the additional
option to return the typmod. That leads to some questions:
* Should we choose a name related to to_regtype? I don't have any
immediate suggestions, b
On Wed, 31 Jan 2024 at 18:47, Robert Haas wrote:
>
> On Wed, Jan 31, 2024 at 11:17 AM Matthias van de Meent
> wrote:
> > I was also thinking about smaller per-attribute expression storage, for
> > index attribute expressions, table default expressions, and functions.
> > Other than that, less m
I wrote:
> It strikes me that this is basically to_regtype() with the additional
> option to return the typmod. That leads to some questions:
BTW, another way that this problem could be approached is to use
to_regtype() as-is, with a separate function to obtain the typmod:
select format_type(to_
po 12. 2. 2024 v 19:20 odesílatel Tom Lane napsal:
> I wrote:
> > It strikes me that this is basically to_regtype() with the additional
> > option to return the typmod. That leads to some questions:
>
> BTW, another way that this problem could be approached is to use
> to_regtype() as-is, with a
On 2024-02-12 Mo 11:44, Dave Cramer wrote:
Dave Cramer
www.postgres.rocks
On Mon, 12 Feb 2024 at 09:19, Andrew Dunstan wrote:
On 2024-02-12 Mo 08:51, Dave Cramer wrote:
On Sat, 10 Feb 2024 at 13:28, Andrew Dunstan
wrote:
On 2024-02-10 Sa 12:20, Dave Cramer wrote:
Jakub Wartak wrote:
> when I run with default pager (more or less):
> \set FETCH_COUNT 1000
> WITH data AS (SELECT generate_series(1, 2000) as Total) select
> repeat('a',100) || data.Total || repeat('b', 800) as total_pat from
> data;
> -- it enters pager, a skip couple of pages and t
On Mon, 12 Feb 2024 at 19:03, Matthias van de Meent
wrote:
> Attached is patchset v2, which contains the improvements from these patches:
Attached v3, which fixes an out-of-bounds read in pg_strtoken_next,
detected by asan, that was a likely cause of the problems in CFBot's
FreeBSD regression tes
On Wed, 2024-01-31 at 14:30 +0530, Bharath Rupireddy wrote:
> Please see the attached v22 patch set.
Committed 0001.
For 0002 & 0003, I'd like more clarity on how they will actually be
used by an extension.
For 0004, we need to resolve why callers are using XLOG_BLCKSZ and we
can fix that indepe
Hi,
On 2024-02-10 08:40:43 +0100, Peter Eisentraut wrote:
> So as a test, I ran IWYU over the backend *.c files and removed all the
> #includes it suggested. (Note that IWYU also suggests to *add* a bunch of
> #includes, in fact that is its main purpose; I didn't do this here.) In some
> cases, a
On 2024-Feb-10, Peter Eisentraut wrote:
> So as a test, I ran IWYU over the backend *.c files and removed all the
> #includes it suggested. (Note that IWYU also suggests to *add* a bunch of
> #includes, in fact that is its main purpose; I didn't do this here.) In some
> cases, a more specific #in
My responses with questions,
> > +# XXX: The configure.ac check for __cpuidex() is broken, we don't
> > +copy that # here. To prevent problems due to two detection methods
> > +working, stop # checking after one.
>
> This seems like a bogus copy-paste.
My bad. Will remove the offending comment.
Hi,
I noticed that in the following code in BitmapPrefetch(), we use the
current block's TBMIterateResult->recheck when deciding whether or not
to prefetch the block returned by tbm_iterate() (which is very likely
a different block). Why not use TBMIterateResult->recheck for the
block we are consi
Hi,
On 2024-02-12 11:33:24 -0800, Jeff Davis wrote:
> On Wed, 2024-01-31 at 14:30 +0530, Bharath Rupireddy wrote:
> > Please see the attached v22 patch set.
>
> Committed 0001.
Yay, I think this is very cool. There are plenty other improvements than can
be based on this...
One thing I'm a bit c
On Sun, 2024-02-11 at 22:04 +0530, Robert Haas wrote:
> 1. Here's what we think your OS package manager is probably going to
> do.
> 2. That's going to interact with PostgreSQL in this way that I will
> now describe.
> 3. See, that sucks, because of the stuff I said above about needing
> stable col
Hi,
I happened to notice a typo in pg_rotate_logfile in ipc/signalfuncs.c
- the hint message wrongly mentions that pg_logfile_rotate is part of
the core; which is actually not. pg_logfile_rotate is an adminpack's
1.0 SQL function dropped in 2.0. The core defines pg_rotate_logfile
SQL function inst
Hi,
On 2024-02-12 20:14:06 +, Amonson, Paul D wrote:
> > > +# Check for header immintrin.h
> > ...
> > Do these all actually have to link? Invoking the linker is slow.
> > I think you might be able to just use cc.has_header_symbol().
>
> I took this to mean the last of the 3 new blocks.
Yep.
> On 12 Feb 2024, at 21:32, Bharath Rupireddy
> wrote:
> I happened to notice a typo in pg_rotate_logfile in ipc/signalfuncs.c
> - the hint message wrongly mentions that pg_logfile_rotate is part of
> the core; which is actually not. pg_logfile_rotate is an adminpack's
> 1.0 SQL function dropped
Hi,
Postgres has a good amount of code for dealing with backtraces - two
GUCs backtrace_functions and backtrace_on_internal_error,
errbacktrace; all of which use core function set_backtrace from
elog.c. I've not seen this code being tested at all, see code coverage
report -
https://coverage.postg
On Mon, 2024-02-12 at 12:18 -0800, Andres Freund wrote:
> + upto = Min(startptr + count, LogwrtResult.Write);
> + nbytes = upto - startptr;
>
> Shouldn't it pretty much be a bug to ever encounter this?
In the current code it's impossible, though Bharath hinted at an
extension which could re
On Mon, Feb 12, 2024 at 09:39:06PM +0100, Daniel Gustafsson wrote:
>> On 12 Feb 2024, at 21:32, Bharath Rupireddy
>> wrote:
>> I happened to notice a typo in pg_rotate_logfile in ipc/signalfuncs.c
>> - the hint message wrongly mentions that pg_logfile_rotate is part of
>> the core; which is actua
Hi,
On 2024-02-12 13:28:40 -0500, Andrew Dunstan wrote:
> On 2024-02-12 Mo 11:44, Dave Cramer wrote:
> > OK, so I have managed to get a debugger attached to postgres.exe when it
> > faults and the fault occurs at
> > https://github.com/postgres/postgres/blob/09eb633e1baa3b7cd7929f3cc77f9c46f63c20b
On Mon, Feb 12, 2024 at 06:09:06PM +0100, Mats Kindahl wrote:
> Here are the two fixed patches.
These patches look pretty good to me. Barring additional feedback, I'll
plan on committing them in the next few days.
--
Nathan Bossart
Amazon Web Services: https://aws.amazon.com
Hi,
On 2024-02-09 15:32:10 -0500, Dave Cramer wrote:
> On Fri, 9 Feb 2024 at 14:36, Andres Freund wrote:
> > That's something like a segfault.
> >
> > One suspicion I have is that src/port/pg_crc32c_armv8_choose.c possibly
> > doesn't properly support msvc. It seems to assume that SIGILL can be
On Sat, Feb 10, 2024 at 03:52:38PM -0800, Noah Misch wrote:
> On Fri, Feb 09, 2024 at 08:33:23PM -0800, Andres Freund wrote:
>> My understanding is that the ifunc mechanism just avoid the need for repeated
>> indirect calls/jumps to implement a single function call, not the use of
>> indirect funct
On Feb 12, 2024, at 12:53 PM, Tom Lane wrote:
> "David E. Wheeler" writes:
>> [ v4-0001-Add-parse_type-SQL-function.patch ]
>
> It strikes me that this is basically to_regtype() with the additional
> option to return the typmod. That leads to some questions:
Huh. I saw it more on a par with f
> On 12 Feb 2024, at 21:46, Nathan Bossart wrote:
>
> On Mon, Feb 12, 2024 at 09:39:06PM +0100, Daniel Gustafsson wrote:
>>> On 12 Feb 2024, at 21:32, Bharath Rupireddy
>>> wrote:
>>> I happened to notice a typo in pg_rotate_logfile in ipc/signalfuncs.c
>>> - the hint message wrongly mentions t
On Mon, 12 Feb 2024 at 15:50, Andres Freund wrote:
> Hi,
>
> On 2024-02-12 13:28:40 -0500, Andrew Dunstan wrote:
> > On 2024-02-12 Mo 11:44, Dave Cramer wrote:
> > > OK, so I have managed to get a debugger attached to postgres.exe when
> it
> > > faults and the fault occurs at
> > >
> https://git
Hi,
On 2024-02-12 12:50:12 -0800, Andres Freund wrote:
> On 2024-02-12 13:28:40 -0500, Andrew Dunstan wrote:
> I wonder if this indicates that we are either missing memory barriers
> somewhere or that the memory barriers we end up with on msvc + arm aren't
> correct? Either could explain why the
Hi! Sorry my delayed reply too.
On 17.01.2024 12:33, Yuya Watari wrote:
Hello Alena,
Thank you for your quick response, and I'm sorry for my delayed reply.
On Sun, Dec 17, 2023 at 12:41 AM Alena Rybakina
wrote:
I thought about this earlier and was worried that the index links of the
equival
On Mon, Feb 12, 2024 at 5:51 PM Nathan Bossart
wrote:
>
> On Mon, Feb 12, 2024 at 06:09:06PM +0100, Mats Kindahl wrote:
> > Here are the two fixed patches.
>
> These patches look pretty good to me. Barring additional feedback, I'll
> plan on committing them in the next few days.
>
Also did some
On 28.01.2024 22:51, Pavel Luzanov wrote:
I'll think about it and try to implement in the next patch version
within a few days.
Sorry for delay.
Please look at v4.
I tried to implement all of David's suggestions.
The only addition - "Login" column. I still thinks this is important
information
Hi,
On 2024-02-12 14:51:38 -0600, Nathan Bossart wrote:
> On Mon, Feb 12, 2024 at 06:09:06PM +0100, Mats Kindahl wrote:
> > Here are the two fixed patches.
>
> These patches look pretty good to me. Barring additional feedback, I'll
> plan on committing them in the next few days.
One thing that'
On Tue, Feb 13, 2024 at 2:29 AM Daniel Gustafsson wrote:
>
> On that note though, we might want to consider just dropping it altogether in
> v17 (while fixing the incorrect hint in backbranches)? I can't imagine
> adminpack 1.0 being in heavy use today, and skimming pgAdmin code it seems
> it's
Peter Eisentraut writes:
> Approaches like that as well as the in-tree pgrminclude work by "I
> removed the #include and it still compiled fine", which can be
> unreliable. IWYU on the other hand has the compiler tracking where a
> symbol actually came from, and so if it says that an #include
Hi,
On 12.02.2024 17:16, Maiquel Grassi wrote:
The "if (db == NULL)" has been removed, as well as the message inside
it. To always maintain the same error messages, I changed the
validation of "\conninfo" to match the validation used for
"\conninfo+". Therefore, now "\conninfo" and "\conninf
Hello
I would like to share a patch that adds a feature to libpq to automatically
select the best client certificate to send to the server (if it requests one).
This feature is inspired by this email discussion years ago:
https://www.postgresql.org/message-id/200905081539.n48Fdl2Y003286%40no
Hi,
On 2024-02-12 16:46:55 -0500, Tom Lane wrote:
> Peter Eisentraut writes:
> > Approaches like that as well as the in-tree pgrminclude work by "I
> > removed the #include and it still compiled fine", which can be
> > unreliable. IWYU on the other hand has the compiler tracking where a
> > symb
Robert Haas writes:
> On Tue, Jan 16, 2024 at 11:46 AM Tom Lane wrote:
>> Also, we already
>> treat the multirange as dependent for some things:
> But this seems like an entirely valid point.
Yeah, it's a bit of a muddle. But there is no syntax for making
a standalone multirange type, so it se
On Mon, Feb 12, 2024 at 01:31:30PM -0800, Andres Freund wrote:
> One thing that's worth checking is if this ends up with *worse* code when the
> comparators are inlined. I think none of the changed comparators will end up
> getting used with an inlined sort, but ...
Yeah, AFAICT the only inlined s
On Mon, 12 Feb 2024 at 20:32, Matthias van de Meent
wrote:
>
> On Mon, 12 Feb 2024 at 19:03, Matthias van de Meent
> wrote:
> > Attached is patchset v2, which contains the improvements from these patches:
>
> Attached v3, which fixes an out-of-bounds read in pg_strtoken_next,
> detected by asan,
Hi,
On 2024-02-12 12:46:00 -0800, Jeff Davis wrote:
> On Mon, 2024-02-12 at 12:18 -0800, Andres Freund wrote:
> > + upto = Min(startptr + count, LogwrtResult.Write);
> > + nbytes = upto - startptr;
> >
> > Shouldn't it pretty much be a bug to ever encounter this?
>
> In the current code it's
Hi,
On 2024-02-12 17:04:23 -0600, Nathan Bossart wrote:
> On Mon, Feb 12, 2024 at 01:31:30PM -0800, Andres Freund wrote:
> > One thing that's worth checking is if this ends up with *worse* code when
> > the
> > comparators are inlined. I think none of the changed comparators will end up
> > getti
On Mon, 2024-02-12 at 11:33 -0800, Jeff Davis wrote:
> For 0002 & 0003, I'd like more clarity on how they will actually be
> used by an extension.
In patch 0002, I'm concerned about calling
WaitXLogInsertionsToFinish(). It loops through all the locks, but
doesn't have any early return path or adva
ate "C";`
then the rightop is not Const, it will be CollateExpr, it will not be
used in transformation.
-
Maybe the previous thread mentioned it, but this thread is very long.
after apply
v16-0001-Transform-OR-clause-to-ANY-expressions.patch
and 0002-Teach-generate_bitmap_or_path
Hi,
On 2024-02-12 15:56:19 -0800, Jeff Davis wrote:
> On Mon, 2024-02-12 at 11:33 -0800, Jeff Davis wrote:
> > For 0002 & 0003, I'd like more clarity on how they will actually be
> > used by an extension.
>
> In patch 0002, I'm concerned about calling
> WaitXLogInsertionsToFinish(). It loops throu
On 2024-02-07 19:14, torikoshia wrote:
On 2024-02-07 13:58, Ashutosh Bapat wrote:
The prologue refers to a very populated
lock hash table. I think that will happen if thousands of tables are
queried in a single query OR a query runs on a partitioned table with
thousands of partitions. May be w
On Monday, February 12, 2024 6:03 PM Bertrand Drouvot
wrote:
>
> Hi,
>
> On Sun, Feb 11, 2024 at 01:23:19PM +, Zhijie Hou (Fujitsu) wrote:
> > On Saturday, February 10, 2024 9:10 PM Amit Kapila
> wrote:
> > >
> > > On Sat, Feb 10, 2024 at 5:31 PM Masahiko Sawada
> > >
> > > wrote:
> > > >
On Monday, February 12, 2024 5:40 PM Amit Kapila
wrote:
>
> On Sun, Feb 11, 2024 at 6:53 PM Zhijie Hou (Fujitsu)
> wrote:
> >
> > Agreed. Here is the V84 patch which addressed this.
> >
>
> Few comments:
> =
> 1. Isn't the new function (pg_sync_replication_slots()) allowed to sync
On Mon, 2024-02-12 at 15:36 -0800, Andres Freund wrote:
>
> It doesn't really seem like a necessary, or even particularly useful,
> part. You couldn't just call WALRead() for that, since the caller
> would need
> to know the range up to which WAL is valid but not yet flushed as
> well. Thus
> the
Update: another patch with 1) suggested changes, 2) delete old html before
generating new, and 3) added flex names for the more complex regular
expressions.
Exercising the “ninja doxygen” command, brought up some issues.
1. The generated html directory contained old as well as new pages.
Th
On Fri, 2022-09-23 at 10:49 +0200, Alvaro Herrera wrote:
> On 2022-Jul-28, Alvaro Herrera wrote:
>
> > v10 is just a trivial rebase. No changes. Moved to next
> > commitfest.
>
> I realized that because of commit e369f3708636 this change is no
> longer
> as critical as it used to be, so I'm wit
On Wed, 2024-02-07 at 10:53 +0100, Peter Eisentraut wrote:
> Various comments are updated to include the term "character class".
> I
> don't recognize that as an official Unicode term. There are
> categories
> and properties. Let's check this.
It's based on
https://www.unicode.org/reports/tr1
1 - 100 of 114 matches
Mail list logo
