Re: index prefetching

2024-01-21 Thread Konstantin Knizhnik
On 22/01/2024 1:39 am, Tomas Vondra wrote: Why we can prefer covering index  to compound index? I see only two good reasons: 1. Extra columns type do not  have comparison function need for AM. 2. The extra columns are never used in query predicate. Or maybe you don't want to include the column

Re: Add system identifier to backup manifest

2024-01-21 Thread Amul Sul
On Mon, Jan 22, 2024 at 10:08 AM Amul Sul wrote: > > > On Fri, Jan 19, 2024 at 10:36 PM Amul Sul wrote: > >> On Wed, Jan 17, 2024 at 8:40 PM Robert Haas >> wrote: >> >>> >>> >> Updated version is attached. >> > > Another updated version attached -- fix missing manifest version check in > pg_ver

Re: the s_lock_stuck on perform_spin_delay

2024-01-21 Thread Andy Fan
Andy Fan writes: > I found a speical case about checking it in errstart. So commit 3 in v7 > is added. > > commit 757c67c1d4895ce6a523bcf5217af8eb2351e2a1 (HEAD -> s_stuck_v3) > Author: yizhi.fzh > Date: Mon Jan 22 07:14:29 2024 +0800 > > Bypass SpinLock checking in SIGQUIT signal hander

Re: [PoC] Improve dead tuple storage for lazy vacuum

2024-01-21 Thread Masahiko Sawada
On Mon, Jan 22, 2024 at 2:36 PM John Naylor wrote: > > On Mon, Jan 22, 2024 at 10:28 AM Masahiko Sawada > wrote: > > > > On further thought, as you pointed out before, "num_tids" should not > > be in tidstore in terms of integration with tidbitmap.c, because > > tidbitmap.c has "lossy pages". Wi

make dist using git archive

2024-01-21 Thread Peter Eisentraut
One of the goals is to make the creation of the distribution tarball more directly traceable to the git repository. That is why we removed the "make distprep" step. Here I want to take another step in that direction, by changing "make dist" to directly use "git archive", rather than the custo

Re: Use of backup_label not noted in log

2024-01-21 Thread Michael Paquier
On Fri, Jan 19, 2024 at 09:32:26AM -0400, David Steele wrote: > Any status on this patch? If we do back patch it would be nice to see this > in the upcoming minor releases. I'm in favor of a back patch, as I think > this is minimally invasive and would be very useful for debugging recovery > issues

Re: Synchronizing slots from primary to standby

2024-01-21 Thread Bertrand Drouvot
Hi, On Fri, Jan 19, 2024 at 05:23:53PM +0530, Amit Kapila wrote: > On Wed, Jan 17, 2024 at 4:00 PM shveta malik wrote: > > > > Now, the concerns related to this could be that users would probably > need to change existing mechanisms/tools to update priamry_conninfo Yeah, for the ones that want

Re: introduce dynamic shared memory registry

2024-01-21 Thread Michael Paquier
On Sun, Jan 21, 2024 at 04:13:20PM -0600, Nathan Bossart wrote: > Oops. I've attached an attempt at fixing this. I took the opportunity to > clean up the surrounding code a bit. Thanks for the patch. Your proposed attempt looks correct to me with an ERROR when no segments are found.. -- Michael

<    1   2