On Fri, Oct 27, 2023 at 04:40:43AM +, Hayato Kuroda (Fujitsu) wrote:
> Yeah, Bharath has already reported, I agreed that the reason was [1].
>
> ```
> In the Windows API (with some exceptions discussed in the following
> paragraphs),
> the maximum length for a path is MAX_PATH, which is defi
Hello.
I found the following message recently introduced in pg_upgrade:
> pg_log(PG_VERBOSE, "slot_name: \"%s\", plugin: \"%s\",
> two_phase: %s",
> slot_info->slotname,
> slot_info->plugin,
> slot_info->two
On Fri, Oct 27, 2023 at 9:52 AM Amit Kapila wrote:
>
> > errmsg("\"max_slot_wal_keep_size\" must be set to -1 during the upgrade"),
> > errhint("Do not override \"max_slot_wal_keep_size\" using command line
> > options."));
> >
>
> But OTOH, we don't have a value of user-passed options to ensure t
On Fri, Oct 27, 2023 at 10:32 AM Michael Paquier wrote:
>
> On Fri, Oct 27, 2023 at 10:23:34AM +0530, Bharath Rupireddy wrote:
> > A possible way is to move existing pgstat_count_slru_flush in
> > SimpleLruWriteAll closer to pg_fsync and WAIT_EVENT_SLRU_SYNC in
> > SlruPhysicalWritePage, remove WA
At Fri, 27 Oct 2023 09:51:43 +0530, Amit Kapila wrote
in
> On Fri, Oct 27, 2023 at 9:37 AM Peter Smith wrote:
> > IIUC the only possible way to reach this error (according to the
> > comment preceding it) is by the user overriding the GUC value (which
> > was defaulted -1) on the command line.
On Fri, Oct 27, 2023 at 10:43 AM Michael Paquier wrote:
>
> On Fri, Oct 27, 2023 at 04:40:43AM +, Hayato Kuroda (Fujitsu) wrote:
> > Yeah, Bharath has already reported, I agreed that the reason was [1].
> >
> > ```
> > In the Windows API (with some exceptions discussed in the following
> > pa
Dear Michael,
> Or you could do something even shorter, with "invalid_slots.txt".
I think current one seems better, because we only support logical replication
slots for now. We can extend as you said when we support physical slot as well.
Also, proposed length is sufficient for fairywren [1].
[
On Fri, Oct 27, 2023 at 11:09 AM Amit Kapila wrote:
>
> On Fri, Oct 27, 2023 at 10:43 AM Michael Paquier wrote:
> >
> > -"invalid_logical_replication_slots.txt");
> > +"invalid_logical_slots.txt");
> >
> > Or you could do something even shorter, wit
On Fri, Oct 27, 2023 at 10:10 AM Hayato Kuroda (Fujitsu)
wrote:
>
> Here is a patch for fixing to 003_logical_slots. Also, I got a comment off
> list so that it was included.
>
> ```
> -# Setup a pg_upgrade command. This will be used anywhere.
> +# Setup a common pg_upgrade command to be used by
On Friday, October 27, 2023 1:21 PM Kyotaro Horiguchi
wrote:
>
> Hello.
>
> I found the following message recently introduced in pg_upgrade:
>
> > pg_log(PG_VERBOSE, "slot_name: \"%s\", plugin: \"%s\",
> two_phase: %s",
> >slot_info->slotname,
> >
On Fri, Oct 27, 2023 at 11:24 AM Bharath Rupireddy
wrote:
>
> On Fri, Oct 27, 2023 at 10:10 AM Hayato Kuroda (Fujitsu)
> wrote:
> >
> > Here is a patch for fixing to 003_logical_slots. Also, I got a comment off
> > list so that it was included.
> >
> > ```
> > -# Setup a pg_upgrade command. This
On Thu, Oct 26, 2023 at 10:04:25AM +0200, Drouvot, Bertrand wrote:
> By "used in an unexpected way in the future", what do you mean exactly? Do
> you mean
> the caller forgetting it is working on a copy and then could work with
> "stale" counters?
(Be careful about the code indentation.)
The par
At Fri, 27 Oct 2023 05:56:31 +, "Zhijie Hou (Fujitsu)"
wrote in
> On Friday, October 27, 2023 1:21 PM Kyotaro Horiguchi
> wrote:
> >
> > Hello.
> >
> > I found the following message recently introduced in pg_upgrade:
> >
> > > pg_log(PG_VERBOSE, "slot_name: \"%s\", plugin: \"%
Hi Alexander,
>> Thank you for catching it. Please, post this.
Just for a more complete picture of the final state here.
I have posted the described fix (for avoiding race condition in the tests)
separately:
https://commitfest.postgresql.org/45/4616/
--
best regards,
Mikhail A. Gribkov
e-
On Thu, 21 Sept 2023 at 11:27, Michael Paquier wrote:
>
> On Fri, Sep 15, 2023 at 03:08:21PM +0530, vignesh C wrote:
> > On Tue, 12 Sept 2023 at 14:25, Hayato Kuroda (Fujitsu)
> > wrote:
> >> Is there a possibility that apply worker on old cluster connects to the
> >> publisher during the upgrade
On Fri, 2023-10-13 at 15:33 -0400, Daniel Fredouille wrote:
> sorry it took me some time to reply. Yes, the patch is perfect if this is
> indeed the behavior.
I'm sending a reply to the hackers list so that I can add the patch to the
commitfest.
Tiny as the patch is, I don't want it to fall bet
On Tue, May 23, 2023 at 01:47:52PM +0300, Aleksander Alekseev wrote:
> That's me still talking to myself :)
Let's be two then.
> Evidently this works differently from what I initially thought on
> Windows due to lack of fork() on this system.
This comes down to the fact that processes executed w
On Mon, 2023-01-09 at 16:40 +0100, Laurenz Albe wrote:
> > "Using ONLY to add or drop a constraint on only the partitioned table is
> > supported as long as there are no partitions. Once partitions exist, using
> > ONLY will result in an error. Instead, constraints on the partitions
> > themselves
101 - 118 of 118 matches
Mail list logo
