> On 23 Oct 2023, at 08:22, Peter Eisentraut wrote:
>
> On 23.10.23 02:26, Michael Paquier wrote:
>> 5e4dacb9878c has reminded me that we don't show the version of OpenSSL
>> in the output of ./configure. This would be useful to know when
>> looking at issues within the buildfarm, and I've wante
On Mon, Oct 23, 2023 at 11:10 AM Hayato Kuroda (Fujitsu)
wrote:
>
> Thank you for reviewing! PSA new version.
> > 6. A nit: how about is_decodable_txn or is_decodable_change or some
> > other instead of just a plain name processing_required?
> > +/* Do we need to process any change in 'fast_f
Dear Horiguchi-san, Shlok,
>
> At Fri, 6 Oct 2023 12:28:32 +0530, Shlok Kyal wrote
> i> D:\project\pg_dev\bin>pg_ctl -D ../data -l data2.log start
> > pg_ctl: another server might be running; trying to start server anyway
> > waiting for server to startpg_ctl: launcher shell died
> >
> > The
On Sat, 2023-10-21 at 04:29 +0200, Erik Wienhold wrote:
> The attached v3 of my initial patch
> does that. It also includes Laurenz' fix to no longer ignore \pset null
> (minus the doc changes that suggest using \pset null to distinguish
> between default and empty privileges because that's no lon
On Mon, Oct 23, 2023 at 6:43 AM Andrei Lepikhov
wrote:
> On 22/10/2023 05:01, Alexander Korotkov wrote:
> > On Thu, Oct 19, 2023 at 6:16 AM Andrei Lepikhov
> > wrote:
> >> On 19/10/2023 01:50, Alexander Korotkov wrote:
> >>> This query took 3778.432 ms with self-join removal disabled, and
> >>> 3
On Mon, Oct 23, 2023 at 2:37 PM Peter Eisentraut wrote:
>
> Since C99, there can be a trailing comma after the last value in an enum
C99 allows us to do this doesn't mean we must do this, this is not
inconsistent IMHO, and this will pollute the git log messages, people
may *git blame* the file an
Please, consider this small fix for the query example in the docs[1]:
SELECT a.pid, a.wait_event, w.description
FROM pg_stat_activity a JOIN
pg_wait_events w ON (a.wait_event_type = w.type AND
a.wait_event = w.name)
WHERE wait_event is NOT NULL and a.state =
Hi Alexander,
23.10.2023 12:47, Alexander Korotkov wrote:
I think this patch makes substantial improvement to query planning.
It has received plenty of reviews. The code is currently in quite
good shape. I didn't manage to find the cases when this optimization
causes significant overhead to pl
On Mon, Oct 23, 2023 at 2:00 PM Alexander Lakhin wrote:
> 23.10.2023 12:47, Alexander Korotkov wrote:
> > I think this patch makes substantial improvement to query planning.
> > It has received plenty of reviews. The code is currently in quite
> > good shape. I didn't manage to find the cases wh
Hi,
Thanks for reviewing.
Attached the updated patch v3.
Andres Freund , 12 Eki 2023 Per, 19:23 tarihinde şunu
yazdı:
> > Here how pg_backend_memory_contexts would look like with this patch:
> >
> > postgres=# SELECT name, id, parent, parent_id, path
> > FROM pg_backend_memory_contexts
> > ORDER
Hi,
On 10/20/23 5:27 AM, shveta malik wrote:
On Wed, Oct 18, 2023 at 4:24 PM Amit Kapila wrote:
PFA v25 patch set. The changes are:
1) 'enable_failover' is changed to 'failover'
2) Alter subscription changes to support 'failover'
3) Fixes a bug in patch001 wherein any change in standby_slot_n
On Mon, Oct 23, 2023 at 5:52 PM Drouvot, Bertrand
wrote:
>
> Hi,
>
> On 10/20/23 5:27 AM, shveta malik wrote:
> > On Wed, Oct 18, 2023 at 4:24 PM Amit Kapila wrote:
> >
> > PFA v25 patch set. The changes are:
> >
> > 1) 'enable_failover' is changed to 'failover'
> > 2) Alter subscription changes
On Mon, Oct 16, 2023 at 11:21:20PM -0700, Donghang Lin wrote:
> > I've also caught btree posting lists where one TID refers to a '1d' heap
> > tuple, while another TID refers to a '24h' heap tuple. amcheck complains.
> Index-only scans can return the '1d' bits where the actual tuple had the
> '24h
On Monday, October 23, 2023, Laurenz Albe wrote:
>
> --- a/src/bin/psql/describe.c
> +++ b/src/bin/psql/describe.c
> @@ -6718,7 +6680,13 @@ static void
>printACLColumn(PQExpBuffer buf, const char *colname)
>{
> appendPQExpBuffer(buf,
> - "pg_catalog.array
On Mon, 2023-10-23 at 07:03 -0700, David G. Johnston wrote:
> On Monday, October 23, 2023, Laurenz Albe wrote:
> >
> > --- a/src/bin/psql/describe.c
> > +++ b/src/bin/psql/describe.c
> > @@ -6718,7 +6680,13 @@ static void
> > printACLColumn(PQExpBuffer buf, const char *colname)
> > {
On Thu, Oct 19, 2023 at 6:09 PM Andres Freund wrote:
> Hm. Did you not run into simmilar issues with make check-world? I found the
> concurrency of that to be even more variable over a run.
I did not, but I didn't generally run that in parallel, either, mostly
for fear of being unable to see fail
On Fri, Oct 20, 2023 at 1:08 PM Tristan Partin wrote:
> You will see this in the 1.3.0 release which will be happening soon™️.
Cool, thanks!
--
Robert Haas
EDB: http://www.enterprisedb.com
On Fri, Oct 20, 2023 at 12:28 PM Jeff Davis wrote:
> I still have a question though: if a buffer is exclusive-locked,
> unmodified and clean, and then the caller registers it and later does
> PageSetLSN (just as if it were dirty), is that a definite bug?
>
> There are a couple callsites where the
On 2023-10-16 Mo 20:19, Tom Lane wrote:
Currently we have this odd behavior (for a superuser):
regression=# ALTER SYSTEM SET foo.bar TO 'baz';
ERROR: unrecognized configuration parameter "foo.bar"
regression=# SET foo.bar TO 'baz';
SET
regression=# ALTER SYSTEM SET foo.bar TO 'baz';
ALTER SYS
Daniel Gustafsson writes:
> On 23 Oct 2023, at 08:22, Peter Eisentraut wrote:
>> The problem is that the binary might not match the library, so this could be
>> very misleading. Also, meson gets the version via pkg-config, so the result
>> would also be inconsistent with meson. I am afraid th
On Monday, October 23, 2023, Laurenz Albe wrote:
> On Mon, 2023-10-23 at 07:03 -0700, David G. Johnston wrote:
> > On Monday, October 23, 2023, Laurenz Albe
> wrote:
> > >
> > > --- a/src/bin/psql/describe.c
> > > +++ b/src/bin/psql/describe.c
> > > @@ -6718,7 +6680,13 @@ static void
> > >
On 2023-10-22 Su 20:59, Andres Freund wrote:
Hi,
On 2023-09-01 11:31:07 -0500, Tristan Partin wrote:
Muon development has slowed quite a bit this year. Postgres is probably the
largest project which tries its best to support Muon. It seems like if we
want to keep supporting Muon, we should ge
"David G. Johnston" writes:
> We document default privileges print as an empty string - I do not think we
> should change the definition to "default privileges print null which can be
> controlled via \pset null", and regardless of preference doing so is not a
> bug.
Well, "if it's documented it'
On Mon, Oct 23, 2023 at 01:15:04PM +1300, Thomas Munro wrote:
> On Sun, Oct 22, 2023 at 2:44 PM Thomas Munro wrote:
> > On Sat, Oct 21, 2023 at 2:45 PM Tom Lane wrote:
> > > Thomas Munro writes:
> > > > (It'd be nice if the
> > > > build farm logged "$LLVM_CONFIG --version" somewhere.)
> > >
> >
On Mon, Oct 23, 2023 at 7:57 AM Tom Lane wrote:
>
> IOW, the current definition is "NULL privileges print as an empty
> string no matter what", and I don't think that serves to reduce
> confusion about whether an ACL is NULL or not. We ought to be doing
> what we can to make clear that such an A
On Fri, Oct 20, 2023 at 11:30 AM David Steele wrote:
> Then I'm fine with it as is.
OK, thanks.
> In my view this feature puts the cart way before the horse. I'd think
> higher priority features might be parallelism, a backup repository,
> expiration management, archiving, or maybe even a restor
On 23.10.23 16:26, Tom Lane wrote:
Also, since "PGAC_PATH_PROGS(OPENSSL, openssl)" prints the full path to
what it found, you can at least tell after the fact that you are being
misled, because you can cross-check that path against the -L switches
being used for libraries.
Yeah, that seems ok
I wrote:
> Given the exception the spec makes for CAST, I wonder if we shouldn't
> just say "NULL is a valid value of every domain type, as well as every
> base type. If you don't like it, too bad; write a separate NOT NULL
> constraint for your table column."
After ruminating on this for awhile,
On Wed, Oct 18, 2023 at 05:22:34AM +,
fujii.y...@df.mitsubishielectric.co.jp wrote:
> Hi hackers.
>
> Because there is a degrade in pg_dump.c, I fixed it.
Fujii-san, to get this patch closer to finished, can I modify this
version of the patch to improve some wording and post an updated versi
On Mon, 2023-10-23 at 08:35 -0700, David G. Johnston wrote:
> I tend to prefer the argument that these views are for human consumption and
> should
> be designed with that in mind.
True, although given the shape of ACLs, it takes a somewhat trained human to
consume the string representation. But
> On 23 Oct 2023, at 18:06, Peter Eisentraut wrote:
>
> On 23.10.23 16:26, Tom Lane wrote:
>> Also, since "PGAC_PATH_PROGS(OPENSSL, openssl)" prints the full path to what
>> it found, you can at least tell after the fact that you are being misled,
>> because you can cross-check that path agains
On Wed, Oct 18, 2023 at 1:25 PM Tom Lane wrote:
> Stephen Frost writes:
> > This change would mean that policies added by a user after the extension
> > is created would just be lost by a pg_dump/reload, doesn't it?
>
> Yes. But I'd say that's unsupported, just like making other ad-hoc
> changes
On Mon, 23 Oct 2023 at 13:40, Tom Lane wrote:
> I wrote:
> > Given the exception the spec makes for CAST, I wonder if we shouldn't
> > just say "NULL is a valid value of every domain type, as well as every
> > base type. If you don't like it, too bad; write a separate NOT NULL
> > constraint for
On Monday, October 23, 2023, Laurenz Albe wrote:
> On Mon, 2023-10-23 at 08:35 -0700, David G. Johnston wrote:
>
> > along with not translating (none) and (default) and thus making the data
> contents
> > of these views environment independent. But minimizing the variance of
> these command's
>
Jacob Champion writes:
> Is this approach backportable?
The code fix would surely work in the back branches. Whether the
behavioral change is too big to be acceptable in minor releases
is something I don't have a strong opinion on.
regards, tom lane
po 23. 10. 2023 v 19:34 odesílatel Tom Lane napsal:
> I wrote:
> > Given the exception the spec makes for CAST, I wonder if we shouldn't
> > just say "NULL is a valid value of every domain type, as well as every
> > base type. If you don't like it, too bad; write a separate NOT NULL
> > constrai
rebased
--
Nathan Bossart
Amazon Web Services: https://aws.amazon.com
>From 0934f23773a612051c36070ed1f3b8ab100c4c65 Mon Sep 17 00:00:00 2001
From: Nathan Bossart
Date: Wed, 15 Feb 2023 14:28:53 -0800
Subject: [PATCH v16 1/5] introduce routine for checking mutually exclusive
string GUCs
---
s
Hi!
I looked through your patch and noticed that it was not applied to the
current version of the master. I rebased it and attached a version. I
didn't see any problems and, honestly, no big changes were needed, all
regression tests were passed.
I think it's better to add a test, but to be h
rebased
--
Nathan Bossart
Amazon Web Services: https://aws.amazon.com
>From 9618c243cbd3056006acda0136036b432af37830 Mon Sep 17 00:00:00 2001
From: Nathan Bossart
Date: Wed, 28 Jun 2023 15:12:18 -0700
Subject: [PATCH v2 1/3] vacuumdb: allow specifying tables or schemas to
process in all databas
On Mon, Oct 23, 2023 at 05:55:32PM +0800, Junwang Zhao wrote:
> On Mon, Oct 23, 2023 at 2:37 PM Peter Eisentraut wrote:
>> Since C99, there can be a trailing comma after the last value in an enum
>
> C99 allows us to do this doesn't mean we must do this, this is not
> inconsistent IMHO, and this
On Sun, Oct 22, 2023 at 12:07:59PM -0700, Andres Freund wrote:
> Medium term, I think we need an approximate xid->"time of assignment" mapping
> that's continually maintained on the primary. One of the things that'd show
> us to do is introduce a GUC to control the maximum effect of hs_feedback
On 10/23/23 20:36, Isaac Morland wrote:
Also, where it says "Expressions evaluating to TRUE or UNKNOWN succeed":
Do we really mean "Expressions evaluating to TRUE or NULL succeed"?
No, UNKNOWN is the correct nomenclature for booleans.
--
Vik Fearing
Nathan Bossart writes:
> From a long-term perspective, I
> think standardizing on the trailing comma style will actually improve
> git-blame because patches won't need to add a comma to the previous line
> when adding a value.
Yeah, that's a good point. I had been leaning towards "this is
unnece
On 10/23/23 18:53, Tom Lane wrote:
1. Domains are data types, with the proviso that NULL is always a valid
value no matter what the domain constraints might say.
Implementation-wise, this'd just require that CoerceToDomain immediately
return any null input without checking the constraints. This
On Tue, Oct 24, 2023 at 4:27 AM Mark Wong wrote:
> I haven't gotten around to disabling llvm on any of my animals with llvm
> < 7 yet. Do you still want to hold on that?
Yes, please disable --with-llvm on s390x and POWER animals with LLVM <
7 (see below). Also, you have a bunch of machines with
Vik Fearing writes:
> On 10/23/23 18:53, Tom Lane wrote:
>> (1A) It satisfies the plain language of the SQL spec about
>> how CAST to a domain type behaves.
> I agree with all of your proposal, except for this part. I think the
> shortcut in the General Rules of is an oversight
> and I plan
I ran into a situation that echoed this original one by Kato in the
start of this thread:
https://www.postgresql.org/message-id/OSAPR01MB374809E8DE169C8BF2B82CBD9F6B0%40OSAPR01MB3748.jpnprd01.prod.outlook.com
More below.
Tom Lane writes:
>
> I tried running the original test case under HEAD. I
Isaac Morland writes:
> Then domain CHECK constraints are checked anytime a non-NULL value is
> turned into a domain value, and NOT NULL ones are checked only when storing
> to a table. CHECK constraints would be like STRICT functions; if the input
> is NULL, the implementation is not run and the
I wrote:
> Isaac Morland writes:
>> If we decide we do want "CHECK (VALUE NOT NULL)" to work, then I wonder if
>> we could pass NULL to the constraint at CREATE DOMAIN time, and if it
>> returns FALSE, do exactly what we would have done (set pg_type.typnotnull)
>> if an actual NOT NULL clause had
On Mon, Oct 16, 2023 at 11:21 PM Donghang Lin wrote:
> It seems to me that as long as a data type has a deterministic sort but not
> necessarily be equalimage,
> it should be able to support deduplication. e.g for interval type, we add a
> byte wise tie breaker
> after '24h' and '1day' are comp
On Oct 22, 2023, at 20:36, Erik Wienhold wrote:
> That's an AppleSingle file according to [1][2]. It only contains the
> resource fork and file name but no data fork.
Ah, I had “Send large attachments with Mail Drop” enabled. To me 20K is not big
but whatever. Let’s see if turning it off fixes
On Fri, 20 Oct 2023 at 22:30, Ashutosh Bapat
wrote:
> I ran my experiments again. It seems on my machine the execution times
> do vary a bit. I ran EXPLAIN ANALYZE on the query 5 times and took
> average of execution times. I did this three times. For each run the
> standard deviation was within 2
On Tue, Oct 24, 2023 at 10:17:22AM +1300, Thomas Munro wrote:
> On Tue, Oct 24, 2023 at 4:27 AM Mark Wong wrote:
> > I haven't gotten around to disabling llvm on any of my animals with llvm
> > < 7 yet. Do you still want to hold on that?
>
> Yes, please disable --with-llvm on s390x and POWER ani
Hi,
I investigated a crashing postgres instance. Turns out the original issue was
operator error. But in the process I found a few postgres issues. The scenario
is basically that redo LSN and checkpoint LSN are in seperate segments, and
that for whatever reason, the file containing the redo LSN is
On Mon, 23 Oct 2023, 19:34 Tom Lane, wrote:
>
> I wrote:
> > Given the exception the spec makes for CAST, I wonder if we shouldn't
> > just say "NULL is a valid value of every domain type, as well as every
> > base type. If you don't like it, too bad; write a separate NOT NULL
> > constraint for
On Mon, Oct 23, 2023 at 06:06:02PM +0200, Peter Eisentraut wrote:
> On 23.10.23 16:26, Tom Lane wrote:
>> Also, since "PGAC_PATH_PROGS(OPENSSL, openssl)" prints the full path to
>> what it found, you can at least tell after the fact that you are being
>> misled, because you can cross-check that pat
On Mon, Oct 23, 2023 at 01:17:42PM +0300, Pavel Luzanov wrote:
> I propose to add a table alias for the wait_event column in the
> WHERE clause for consistency.
Okay by me that it looks like an improvement to understand where this
attribute is from, so applied on HEAD.
--
Michael
signature.asc
D
On Fri, Oct 20, 2023 at 8:55 PM Noah Misch wrote:
> > > I lean toward fixing this by
> > > having amcheck scan left; if left links reach only half-dead or deleted
> > > pages,
> > > that's as good as the present child block being P_LEFTMOST.
> >
> > Also my preference.
>
> Done mostly that way, e
On 10/23/23 11:44, Robert Haas wrote:
On Fri, Oct 20, 2023 at 11:30 AM David Steele wrote:
I don't plan to stand in your way on this feature. I'm reviewing what
patches I can out of courtesy and to be sure that nothing adjacent to
your work is being affected. My apologies if my reviews are not
On 10/23/23 17:04, Tom Lane wrote:
Nathan Bossart writes:
From a long-term perspective, I
think standardizing on the trailing comma style will actually improve
git-blame because patches won't need to add a comma to the previous line
when adding a value.
Yeah, that's a good point. I had been
Hi Mr.Momjian.
> Fujii-san, to get this patch closer to finished, can I modify this version of
> the patch to improve some wording and post an
> updated version you can use for future changes?
Yes, I greatly appreciate your offer.
I would very much appreciate your modifications.
Sincerely yours,
On 2023-10-24 00:58 +0200, David E. Wheeler wrote:
> On Oct 22, 2023, at 20:36, Erik Wienhold wrote:
>
> > That's an AppleSingle file according to [1][2]. It only contains the
> > resource fork and file name but no data fork.
>
> Ah, I had “Send large attachments with Mail Drop” enabled. To me
Hi,
On 2023-10-23 16:21:45 -0700, Andres Freund wrote:
> 1) For some reason I haven't yet debugged, the ReadRecord(PANIC) in
>PerformWalRecovery() doesn't PANIC, but instead just returns NULL
>
>We *do* output a DEBUG message, but well, that's insufficient.
The debug is from this backtrac
Michael Paquier writes:
> Please find attached a patch to move the version call close to the
> existing PGAC_PATH_PROGS. And of course, I'd like to do a backpatch.
> Is that OK?
OK by me.
regards, tom lane
On Mon, 2023-10-23 at 10:14 -0400, Robert Haas wrote:
> I think that would be a bug. I think it would be OK to just change
> the
> page LSN and nothing else, but that requires calling
> MarkBufferDirty()
> at some point. If you only call PageSetLSN() and never
> MarkBufferDirty(), that sounds messe
On Wed, 2023-10-18 at 22:34 +1300, David Rowley wrote:
> It would be good to learn how many of the committers out of the ones
> you listed that --enable-indent-checks would have saved from breaking
> koel.
I'd find that a useful option.
Regards,
Jeff Davis
Matthias van de Meent writes:
> On Mon, 23 Oct 2023, 19:34 Tom Lane, wrote:
>> After ruminating on this for awhile, here's a straw-man proposal:
>> ...
> How does this work w.r.t. concurrently created tables that contain the
> domain?
It wouldn't change that at all I think. I had noticed that
On Tue, Oct 24, 2023 at 9:51 Jeff Davis wrote:
> On Wed, 2023-10-18 at 22:34 +1300, David Rowley wrote:
> > It would be good to learn how many of the committers out of the ones
> > you listed that --enable-indent-checks would have saved from breaking
> > koel.
>
> I'd find that a useful option.
On Mon, Oct 23, 2023 at 04:46:23PM -0700, Peter Geoghegan wrote:
> On Fri, Oct 20, 2023 at 8:55 PM Noah Misch wrote:
> > > > I lean toward fixing this by
> > > > having amcheck scan left; if left links reach only half-dead or deleted
> > > > pages,
> > > > that's as good as the present child bloc
On Mon, 2023-10-23 at 11:37 -0700, David G. Johnston wrote:
> > I didn't understand this completely. You want default privileges displayed
> > as
> > "(default)", but are you for or against "\pset null" to have its normal
> > effect on
> > the output of backslash commands in all other cases?
>
On 20/10/2023 19:39, Stephen Frost wrote:
Greetings,
* Andrei Lepikhov (a.lepik...@postgrespro.ru) wrote:
The only issue I worry about is the uncertainty and clutter that can be
created by this feature. In the worst case, when we have a complex error
stack (including the extension's CATCH sectio
Hi,
On 2023-10-24 10:17:22 +1300, Thomas Munro wrote:
> This POWER animal fails, unexpectedly to me:
>
> > bonito: 7.0.1 Fedora 29
>
> We could try to chase that down, or we could rejoice that at least it
> works on current release. It must begin working somewhere between 7
> and 11, but when I
Hi,
On 2023-10-24 09:39:42 +0700, Andrei Lepikhov wrote:
> On 20/10/2023 19:39, Stephen Frost wrote:
> Greetings,
> > * Andrei Lepikhov (a.lepik...@postgrespro.ru) wrote:
> > > The only issue I worry about is the uncertainty and clutter that can be
> > > created by this feature. In the worst case,
Laurenz Albe writes:
> On Mon, 2023-10-23 at 11:37 -0700, David G. Johnston wrote:
>> I do believe that we should be against exposing, like in this case, any
>> internal
>> implementation detail that encodes something (e.g., default privileges) as
>> NULL
>> in the catalogs, to the user of the p
Andres Freund writes:
> FC 29 is well out of support, so I don't think it makes sense to invest any
> further time in this. Personally, I don't think it's useful to have years old
> fedora in the buildfarm...
+1. It's good to test old LTS distros, but Fedora releases have a
short shelf life by d
On Monday, October 23, 2023, Laurenz Albe wrote:
> On Mon, 2023-10-23 at 11:37 -0700, David G. Johnston wrote:
> > > I didn't understand this completely. You want default privileges
> displayed as
> > > "(default)", but are you for or against "\pset null" to have its
> normal effect on
> > > the
On Monday, October 23, 2023, Tom Lane wrote:
> Laurenz Albe writes:
> > On Mon, 2023-10-23 at 11:37 -0700, David G. Johnston wrote:
> >> I do believe that we should be against exposing, like in this case, any
> internal
> >> implementation detail that encodes something (e.g., default privileges)
On Mon, Oct 23, 2023 at 3:29 PM Jeevan Chalke
wrote:
>
> Attached are all three patches fixing the above comments.
>
minor issue:
/src/backend/utils/adt/jsonpath_exec.c
2531: Timestamp result;
2532: ErrorSaveContext escontext = {T_ErrorSaveContext};
2533:
2534: /* Get a warning when precision is
On Mon, Oct 23, 2023 at 2:00 PM Bharath Rupireddy
wrote:
>
> On Mon, Oct 23, 2023 at 11:10 AM Hayato Kuroda (Fujitsu)
> wrote:
> >
> > Thank you for reviewing! PSA new version.
>
> > > 6. A nit: how about is_decodable_txn or is_decodable_change or some
> > > other instead of just a plain name pro
On Sat, Oct 21, 2023 at 5:41 AM Bharath Rupireddy
wrote:
>
> On Fri, Oct 20, 2023 at 8:51 PM Zhijie Hou (Fujitsu)
> wrote:
>
> 9. IMO, binary_upgrade_logical_replication_slot_has_caught_up seems
> better, meaningful and consistent despite a bit long than just
> binary_upgrade_slot_has_caught_up.
On Tue, Oct 24, 2023 at 10:16:55AM +0900, Amit Langote wrote:
> +1. While I’ve made it part of routine to keep my local work pgindented
> since breaking Joel once, an option like this would still be useful.
I'd be OK with an option like that. It is one of these things to type
once in a script, t
On Tue, Oct 03, 2023 at 04:20:45PM +0900, Michael Paquier wrote:
> If there's no interest in this patch set after the next CF, I'm OK to
> drop it. The state of HEAD is at least correct in the OOM cases now.
I have been thinking about this patch for the last few days, and in
light of 6b18b3fe2c2f
The commit message in the attached patch provides the reasoning, as follows:
The user does not benefit from knowing that libpq allocates some/all memory
using malloc(). Mentioning malloc() here has a few downsides, and almost no
benefits.
All the relevant mentions of malloc() are followed by an e
Hi
út 24. 10. 2023 v 7:10 odesílatel Kirk Wolak napsal:
> On Wed, Jul 26, 2023 at 5:39 PM Nathan Bossart
> wrote:
>
>> On Wed, Jul 26, 2023 at 08:06:37AM +0200, Pavel Stehule wrote:
>> > st 26. 7. 2023 v 6:22 odesílatel Nathan Bossart <
>> nathandboss...@gmail.com>
>> > napsal:
>> >> Barring ad
On Friday, October 20, 2023 11:27 AM shveta malik
wrote:
>
> The changes are mostly in patch001 and a very few in patch002.
>
> Thank You Ajin for working on alter-subscription changes and adding more
> TAP-tests for 'failover'
Thanks for updating the patch. Here are few things I noticed when
On Mon, Oct 23, 2023 at 11:22 PM Drouvot, Bertrand
wrote:
>
> Hi,
>
> On 10/20/23 5:27 AM, shveta malik wrote:
> > On Wed, Oct 18, 2023 at 4:24 PM Amit Kapila wrote:
> >
> > PFA v25 patch set. The changes are:
> >
> > 1) 'enable_failover' is changed to 'failover'
> > 2) Alter subscription changes
At Mon, 23 Oct 2023 08:57:19 +, "Hayato Kuroda (Fujitsu)"
wrote in
> > I agree with your suggestion. Ultimately, if there's a possibility
> > for this to be committed, the message will be consolidated to "could
> > not start server".
>
> Based on the suggestion, I tried to update the patch
Dear Bharath, Amit,
Thanks for reviewing! PSA new version.
I addressed comments which have not been claimed.
> On Mon, Oct 23, 2023 at 2:00 PM Bharath Rupireddy
> wrote:
> >
> > On Mon, Oct 23, 2023 at 11:10 AM Hayato Kuroda (Fujitsu)
> > wrote:
> > >
> > > Thank you for reviewing! PSA new vers
On Tue, Oct 24, 2023 at 4:34 AM Nathan Bossart wrote:
>
> On Mon, Oct 23, 2023 at 05:55:32PM +0800, Junwang Zhao wrote:
> > On Mon, Oct 23, 2023 at 2:37 PM Peter Eisentraut
> > wrote:
> >> Since C99, there can be a trailing comma after the last value in an enum
> >
> > C99 allows us to do this d
Hi,
On 10/23/23 2:56 PM, shveta malik wrote:
On Mon, Oct 23, 2023 at 5:52 PM Drouvot, Bertrand
wrote:
We are waiting for DEFAULT_NAPTIME_PER_CYCLE (3 minutes) before checking if
there
is new synced slot(s) to be created on the standby. Do we want to keep this
behavior
for V1?
I think fo
On Mon, 2023-10-23 at 22:43 -0400, Tom Lane wrote:
> Laurenz Albe writes:
> > On Mon, 2023-10-23 at 11:37 -0700, David G. Johnston wrote:
> > > I do believe that we should be against exposing, like in this case, any
> > > internal
> > > implementation detail that encodes something (e.g., default
91 matches
Mail list logo
