Re: BRIN minmax multi - incorrect distance for infinite timestamp/date

On Thu, 19 Oct 2023, 05:32 Ashutosh Bapat, wrote: > On Wed, Oct 18, 2023 at 8:23 PM Tomas Vondra > wrote: > > > > > I did use that many values to actually force "compaction" and merging of > > points into ranges. We only keep 32 values per page range, so with 2 > > values we'll not build a range

Re: pgsql: Generate automatically code and documentation related to wait ev

Re: Michael Paquier > Will fix as per the attached. Thanks for the report. Thanks for the lightning-fast fix :) Christoph

Re: [PoC] pg_upgrade: allow to upgrade publisher node

I tested a test scenario: I started a new publisher with 'max_replication_slots' parameter set to '1' and created a streaming replication with the new publisher as primary node. Then I did a pg_upgrade from old publisher to new publisher. The upgrade failed with following error: Restoring logical

Re: list of acknowledgments for PG16

On 16.10.23 15:46, Alvaro Herrera wrote: On 2023-Aug-27, Peter Eisentraut wrote: On 22.08.23 15:48, Vik Fearing wrote: I think these might be the same person:     Zhihong Yu     Zihong Yu I did not spot any others. Fixed. Hm, I noticed we also list Ted Yu, but that's the same perso

Re: pgsql: Generate automatically code and documentation related to wait ev

On Thu, Oct 19, 2023 at 09:38:30AM +0200, Christoph Berg wrote: > Thanks for the lightning-fast fix :) No pb. Not the first one, not the last one. ;) -- Michael signature.asc Description: PGP signature

Re: BRIN minmax multi - incorrect distance for infinite timestamp/date

On 10/19/23 06:32, Ashutosh Bapat wrote: > On Wed, Oct 18, 2023 at 8:23 PM Tomas Vondra > wrote: > >> >> I did use that many values to actually force "compaction" and merging of >> points into ranges. We only keep 32 values per page range, so with 2 >> values we'll not build a range. You're ri

Re: BRIN minmax multi - incorrect distance for infinite timestamp/date

On 10/19/23 09:04, Dean Rasheed wrote: > On Thu, 19 Oct 2023, 05:32 Ashutosh Bapat, > wrote: > > On Wed, Oct 18, 2023 at 8:23 PM Tomas Vondra > > wrote: > > > > > I did use that many values to actu

Re: BRIN minmax multi - incorrect distance for infinite timestamp/date

On Thu, Oct 19, 2023 at 2:31 PM Tomas Vondra wrote: > > Does that explain the algorithm? I'm not against clarifying the comment, > of course. Thanks a lot for this explanation. It's clear now. > I tried to do that, but I ran into troubles with the "date" tests. I > needed to build values that c

RE: [PoC] pg_upgrade: allow to upgrade publisher node

Dear Shlok, Thanks for testing the feature! > > I tested a test scenario: > I started a new publisher with 'max_replication_slots' parameter set > to '1' and created a streaming replication with the new publisher as > primary node. Just to confirm what you did - you set up a physical replicatio

Re: Use virtual tuple slot for Unique node

On Thu, 12 Oct 2023 at 23:06, Ashutosh Bapat wrote: > Q7 select distinct a,b from (select string_agg(left(a, 100), ', ') > over (order by a rows 2 preceding) a, b from t_text) q > HEAD: 16070.62 ms > patched: 16182.16 ms Did you time the SELECT or EXPLAIN ANALYZE? With SELECT, I'm unable to recr

[patch] pg_basebackup: mention that spread checkpoints are the default in --help

Hi, I believed that spread (not fast) checkpoints are the default in pg_basebackup, but noticed that --help does not specify which is which - contrary to the reference documentation. So I propose the small attached patch to clarify that. Michael >From 2fc49eae5ccc82e144c3f683689757e014e331bd Mo

Re: Initial Schema Sync for Logical Replication

On Thu, 31 Aug 2023 at 17:18, Kumar, Sachin wrote: > > Hi Everyone, based on internal discussion with Masahiko > I have implemented concurrent DDL support for initial schema sync. > > Concurrent Patch workflow > > 1. When TableSync worker creates a replicaton slot, It will > save the slot lsn into

Re: Initial Schema Sync for Logical Replication

On Fri, 7 Jul 2023 at 12:41, Masahiko Sawada wrote: > > On Wed, Jul 5, 2023 at 11:14 AM Masahiko Sawada wrote: > > > > On Mon, Jun 19, 2023 at 5:29 PM Peter Smith wrote: > > > > > > Hi, > > > > > > Below are my review comments for the PoC patch 0001. > > > > > > In addition, the patch needed re

Re: Special-case executor expression steps for common combinations

> On 12 Oct 2023, at 19:52, Andres Freund wrote: > On 2023-10-12 13:24:27 +0300, Heikki Linnakangas wrote: >> On 12/10/2023 12:48, Daniel Gustafsson wrote: >>> The attached patch adds special-case expression steps for common sets of >>> steps >>> in the executor to shave a few cycles off during

RE: [PoC] pg_upgrade: allow to upgrade publisher node

Dear Peter, Thanks for reviewing! PSA new version. > == > src/bin/pg_upgrade/t/003_upgrade_logical_replication_slots.pl > > 1. > + # 2. max_replication_slots is set to smaller than the number of slots (2) > + # present on the old cluster > > SUGGESTION > 2. Set 'max_replication_slots' to be

RE: [PoC] pg_upgrade: allow to upgrade publisher node

Dear Vignesh, Thanks for reviewing! New patch can be available in [1]. > > Few comments: > 1) We will be able to override the value of max_slot_wal_keep_size by > using --new-options like '--new-options "-c > max_slot_wal_keep_size=val"': > + /* > +* Use max_slot_wal_keep_size as

RE: [PoC] pg_upgrade: allow to upgrade publisher node

Dear Hou, Thanks for reviewing! New patch can be available in [1]. > Thanks for updating the patch, here are few comments for the test. > > 1. > > > > # The TAP Cluster.pm assigns default 'max_wal_senders' and 'max_connections' > to > # the same value (10) but PG12 and prior considered max_wals

RE: [PoC] pg_upgrade: allow to upgrade publisher node

Dear Shlok, > > I have tested the above scenario. We are able to override the > max_slot_wal_keep_size by using '--new-options "-c > max_slot_wal_keep_size=val"'. And also with some insert statements > during pg_upgrade, old WAL file were deleted and logical replication > slots were invalidated

RE: [PoC] pg_upgrade: allow to upgrade publisher node

Dear Vignesh, Thanks for revieing! New patch can be available in [1]. > Few comments: > 1) Even if we comment 3rd point "Emit a non-transactional message", > test_slot2 still appears in the invalid_logical_replication_slots.txt > file. There is something wrong here. > + # 2. Advance the slo

Re: Use virtual tuple slot for Unique node

On Thu, 19 Oct 2023 at 22:29, David Rowley wrote: > It's hard to imagine why there would be a slowdown as this query uses > a TTSOpsMinimalTuple slot type in the patch and the unpatched version. I shrunk down your table sizes to 10k rows instead of 1 million rows to reduce the CPU cache pressure

Re: [HACKERS] Allow INSTEAD OF DELETE triggers to modify the tuple for RETURNING

Hi, Thank you for the feedback. Apparently it took me six years, but I've attached the latest version of the patch which I believe addresses all issues. I'll add it to the open commitfest. .m instead_of_delete_returning_v3.patch Description: Binary data

Re: BRIN minmax multi - incorrect distance for infinite timestamp/date

On 10/19/23 11:22, Ashutosh Bapat wrote: > On Thu, Oct 19, 2023 at 2:31 PM Tomas Vondra > wrote: > >> >> Does that explain the algorithm? I'm not against clarifying the comment, >> of course. > > Thanks a lot for this explanation. It's clear now. > >> I tried to do that, but I ran into troubles

Re: [PATCH] Tracking statements entry timestamp in pg_stat_statements

Hi hackers, New version 23 attached. It contains rebase to the current master. Noted that v1.11 adds new fields to the pg_stat_sstatements view, but leaves the PGSS_FILE_HEADER constant unchanged. It this correct? -- Andrei Zubkov Postgres Professional: http://www.postgrespro.com The Russian Pos

Re: BRIN minmax multi - incorrect distance for infinite timestamp/date

On Thu, Oct 19, 2023 at 4:51 PM Tomas Vondra wrote: > > On 10/19/23 11:22, Ashutosh Bapat wrote: > > On Thu, Oct 19, 2023 at 2:31 PM Tomas Vondra > > wrote: > > > >> > >> Does that explain the algorithm? I'm not against clarifying the comment, > >> of course. > > > > Thanks a lot for this explana

RE: [PoC] pg_upgrade: allow to upgrade publisher node

Dear hackers, > Thanks for reviewing! PSA new version. Hmm. The cfbot got angry, whereas it can pass on my machine. It seems that the ordering in invalid_logical_replication_slots.txt is not fixed. A change for checking the content was reverted. It could pass on my CI. Best Regards, Hayato Kur

Re: [patch] pg_basebackup: mention that spread checkpoints are the default in --help

Hi, > I believed that spread (not fast) checkpoints are the default in > pg_basebackup, but noticed that --help does not specify which is which - > contrary to the reference documentation. > > So I propose the small attached patch to clarify that. You are right and I believe this is a good change

Re: Patch: Improve Boolean Predicate JSON Path Docs

On Oct 19, 2023, at 01:22, jian he wrote: > "Do not use with non-predicate", double negative is not easy to > comprehend. Maybe we can simplify it. > > 16933: value. Use only SQL-standard JSON path expressions, not not > there are two "not". > > 15842: SQL-standard JSON path exp

Re: Allow ALTER SYSTEM SET on unrecognized custom GUCs

I do like the idea that we should keep the set and the altar system with the same behavior. But one thing I am worried about is the typo detected here because I usually make that type of mistake myself. I believe we should have an extra log to explicitly tell the user this is a `custom variable` gu

Re: Avoid race condition for event_triggers regress test

Hi, > The current problem is that a race condition may occur on some systems, when > oidjoins test starts a moment later than normally and affects logins count > for on-login trigger test. The problem is quite a rare one and I only faced > it once. But rare or not - the problem is a problem and

Re: The danger of deleting backup_label

On Wed, Oct 18, 2023 at 7:15 PM David Steele wrote: > > (b) be stored someplace > > else, > > I don't think the additional fields *need* to be stored anywhere at all, > at least not by us. We can provide them as output from pg_backup_stop() > and the caller can do as they please. None of those fie

Re: Add support for AT LOCAL

On Wed, Oct 18, 2023 at 7:33 PM Noah Misch wrote: > I feel the gravity and longevity of xlc bugs has been out of proportion with > the compiler's contribution to PostgreSQL. I would find it reasonable to > revoke xlc support in v17+, leaving AIX gcc support in place. +1 for this proposal. I just

Re: The danger of deleting backup_label

On 10/19/23 10:24, Robert Haas wrote: On Wed, Oct 18, 2023 at 7:15 PM David Steele wrote: (b) be stored someplace else, I don't think the additional fields *need* to be stored anywhere at all, at least not by us. We can provide them as output from pg_backup_stop() and the caller can do as the

Re: Add support for AT LOCAL

Robert Haas writes: > On Wed, Oct 18, 2023 at 7:33 PM Noah Misch wrote: >> I feel the gravity and longevity of xlc bugs has been out of proportion with >> the compiler's contribution to PostgreSQL. I would find it reasonable to >> revoke xlc support in v17+, leaving AIX gcc support in place. >

Re: The danger of deleting backup_label

On Thu, Oct 19, 2023 at 10:43 AM David Steele wrote: > What I meant here (but said badly) is that in the case of snapshot > backups, the backup_label and tablespace_map will likely need to be > stored somewhere off the server since they can't be part of the > snapshot, perhaps in a key store. In t

Remove last traces of HPPA support

We removed support for the HP-UX OS in v16, but left in support for the PA-RISC architecture, mainly because I thought that its spinlock mechanism is weird enough to be a good stress test for our spinlock infrastructure. It still is that, but my one remaining HPPA machine has gone to the great rec

Re: The danger of deleting backup_label

On Thursday, October 19, 2023, David Steele wrote: > On 10/19/23 10:24, Robert Haas wrote: > >> On Wed, Oct 18, 2023 at 7:15 PM David Steele wrote: >> >>> pg_llbackup -d $CONNTR --backup-label=PATH --tablespace-map=PATH --copy-data-directory=SHELLCOMMAND I think in most cases

Re: boolin comment not moved when code was refactored

Peter Smith writes: > PSA v2. Pushed. regards, tom lane

Re: Allow ALTER SYSTEM SET on unrecognized custom GUCs

shihao zhong writes: > I do like the idea that we should keep the set and the altar system with > the same behavior. But one thing I am worried about is the typo detected > here because I usually make that type of mistake myself. I believe we > should have an extra log to explicitly tell the user

Re: [PATCH] Add support function for containment operators

On Fri, 2023-10-13 at 14:26 +0800, jian he wrote: > Collation problem seems solved. I didn't review your patch in detail, there is still a problem with my example: CREATE TYPE textrange AS RANGE ( SUBTYPE = text, SUBTYPE_OPCLASS = text_pattern_ops ); CREATE TABLE tx (t text COLLA

Re: The danger of deleting backup_label

On 10/19/23 10:56, Robert Haas wrote: On Thu, Oct 19, 2023 at 10:43 AM David Steele wrote: What I meant here (but said badly) is that in the case of snapshot backups, the backup_label and tablespace_map will likely need to be stored somewhere off the server since they can't be part of the snaps

Re: Allow ALTER SYSTEM SET on unrecognized custom GUCs

Thanks for the answer. The code looks good to me. Thanks, Shihao On Thu, Oct 19, 2023 at 12:00 PM Tom Lane wrote: > shihao zhong writes: > > I do like the idea that we should keep the set and the altar system with > > the same behavior. But one thing I am worried about is the typo detected > >

Re: Allow ALTER SYSTEM SET on unrecognized custom GUCs

> On 17 Oct 2023, at 05:19, Tom Lane wrote: > > In the original discussion about this [1], I initially leaned towards > "they should both fail", but I reconsidered: there doesn't seem to be > any harm in allowing ALTER SYSTEM SET to succeed for any custom GUC > name, as long as you're superuser

controlling meson's parallelism (and some whining)

Hi, Twice now, I've had 'meson test' fail because it tried to start too many copies of the server at the same time. In the server log, I get the complaint about needing to raise SHMMNI. This is a macos machine, with kern.sysv.shmmni=32. The obvious fix to this is to just tell 'meson test' how many

prevent non-superuser terminate bgworker running as superuser

Hi All, Currently, BackgroundWorker connected to a database by calling BackgroundWorkerInitializeConnection with username as NULL can be terminated by non-superuser with pg_signal_backend privilege. When the username is NULL the bgworker process runs as superuser (which is expected as per the docu

Re: New WAL record to detect the checkpoint redo location

On Thu, Oct 19, 2023 at 1:53 AM Michael Paquier wrote: > Seems fine to me. Thanks for considering the idea. I think it was a good idea! I've committed the patch. -- Robert Haas EDB: http://www.enterprisedb.com

Re: Oversight in reparameterize_path_by_child leading to executor crash

Hi! Thank you for your work on the subject. During review your patch I didn't understand why are you checking that the variable is path and not new_path of type T_SamplePath (I highlighted it)? Path * reparameterize_path_by_child(PlannerInfo *root, Path *path,  RelOptInfo *child_rel) ... s

Re: trying again to get incremental backup

On 10/19/23 12:05, Robert Haas wrote: On Wed, Oct 4, 2023 at 4:08 PM Robert Haas wrote: Clearly there's a good amount of stuff to sort out here, but we've still got quite a bit of time left before feature freeze so I'd like to have a go at it. Please let me know your thoughts, if you have any.

Re: trying again to get incremental backup

On Thu, Oct 19, 2023 at 3:18 PM David Steele wrote: > 0001 looks pretty good to me. The only thing I find a little troublesome > is the repeated construction of file names with/without segment numbers > in ResetUnloggedRelationsInDbspaceDir(), .e.g.: > > + if (segno == 0) > +

Re: Is this a problem in GenericXLogFinish()?

On Tue, Oct 17, 2023 at 12:38 PM Jeff Davis wrote: > I meant: are those cleanup operations frequent enough that dirtying > those buffers in that case would matter? Honestly, I'm not sure. Probably not? I mean, hashbucketcleanup() seems to only be called during vacuum or a bucket split, and I don'

Re: [patch] pg_basebackup: mention that spread checkpoints are the default in --help

Hi, On Thu, Oct 19, 2023 at 04:21:19PM +0300, Aleksander Alekseev wrote: > > I believed that spread (not fast) checkpoints are the default in > > pg_basebackup, but noticed that --help does not specify which is which - > > contrary to the reference documentation. > > > > So I propose the small att

Re: prevent non-superuser terminate bgworker running as superuser

This seems like it should even be considered a security honestly. On Thu, 19 Oct 2023, 19:49 Hemanth Sandrana, wrote: > Hi All, > > Currently, BackgroundWorker connected to a database by calling > BackgroundWorkerInitializeConnection with username as NULL can be > terminated by non-superuser wit

Re: Parent/child context relation in pg_get_backend_memory_contexts()

Greetings, * Andres Freund (and...@anarazel.de) wrote: > On 2023-10-18 15:53:30 -0400, Stephen Frost wrote: > > > Here how pg_backend_memory_contexts would look like with this patch: > > > > > > postgres=# SELECT name, id, parent, parent_id, path > > > FROM pg_backend_memory_contexts > > > ORDER

Re: Add the ability to limit the amount of memory that can be allocated to backends.

Greetings, * Andrei Lepikhov (a.lepik...@postgrespro.ru) wrote: > On 19/10/2023 02:00, Stephen Frost wrote: > > * Andrei Lepikhov (a.lepik...@postgrespro.ru) wrote: > > > On 29/9/2023 09:52, Andrei Lepikhov wrote: > > > > On 22/5/2023 22:59, reid.thomp...@crunchydata.com wrote: > > > > > Attach pa

Re: boolin comment not moved when code was refactored

On Fri, Oct 20, 2023 at 2:31 AM Tom Lane wrote: > > Peter Smith writes: > > PSA v2. > > Pushed. > Thanks for pushing. == Kind Regards, Peter Smith. Fujitsu Australia

Re: controlling meson's parallelism (and some whining)

Hi, On 2023-10-19 13:44:20 -0400, Robert Haas wrote: > Twice now, I've had 'meson test' fail because it tried to start too > many copies of the server at the same time. In the server log, I get > the complaint about needing to raise SHMMNI. This is a macos machine, > with kern.sysv.shmmni=32. Hm.

Re: Add the ability to limit the amount of memory that can be allocated to backends.

Hi, On 2023-10-19 18:06:10 -0400, Stephen Frost wrote: > Ignoring such would defeat much of the point of this effort- which is to > get to a position where we can say with some confidence that we're not > going to go over some limit that the user has set and therefore not > allow ourselves to end

Re: Add the ability to limit the amount of memory that can be allocated to backends.

Greetings, * Andres Freund (and...@anarazel.de) wrote: > On 2023-10-19 18:06:10 -0400, Stephen Frost wrote: > > Ignoring such would defeat much of the point of this effort- which is to > > get to a position where we can say with some confidence that we're not > > going to go over some limit that t

Re: [patch] pg_basebackup: mention that spread checkpoints are the default in --help

On Thu, Oct 19, 2023 at 10:30:04PM +0200, Michael Banck wrote: > Hrm right, but those have multiple options and they do not enumerate > them in the help string as do -F and -c - not sure what general project > policy here is for mentioning defaults in --help, I will check some of > the other comman

Re: Remove last traces of HPPA support

On Thu, Oct 19, 2023 at 11:16:28AM -0400, Tom Lane wrote: > We removed support for the HP-UX OS in v16, but left in support > for the PA-RISC architecture, mainly because I thought that its > spinlock mechanism is weird enough to be a good stress test > for our spinlock infrastructure. It still is

Re: Remove last traces of HPPA support

Michael Paquier writes: > On Thu, Oct 19, 2023 at 11:16:28AM -0400, Tom Lane wrote: >> Hence, the attached removes the remaining support for HPPA. >> Any objections? > Would a refresh of config/config.guess and config/config.sub be > suited? This stuff still has references to HPPA. AFAIK we jus

Re: list of acknowledgments for PG16

Hi, > On Aug 22, 2023, at 17:33, Peter Eisentraut wrote: > > The list of acknowledgments for the PG16 release notes has been committed. > It should show up here sometime: > . > As usual, please check for problem

Re: Remove last traces of HPPA support

On Thu, Oct 19, 2023 at 11:16:28AM -0400, Tom Lane wrote: > We removed support for the HP-UX OS in v16, but left in support > for the PA-RISC architecture, mainly because I thought that its > spinlock mechanism is weird enough to be a good stress test > for our spinlock infrastructure. It still is

Re: Remove wal_level settings for subscribers in tap tests

On Wed, Oct 18, 2023 at 03:39:16PM +0900, Michael Paquier wrote: > Hmm, okay. On top of your argument, this may be a good idea for a > different reason: it makes the tests a bit cheaper as "logical" > generates a bit more WAL. Still the gain is marginal. And applied this one. -- Michael signa

Re: Remove last traces of HPPA support

Noah Misch writes: > On Thu, Oct 19, 2023 at 11:16:28AM -0400, Tom Lane wrote: >> Hence, the attached removes the remaining support for HPPA. > I wouldn't do this. NetBSD/hppa still claims to exist, as does the OpenBSD > equivalent. I presume its pkgsrc compiles this code. The code is basicall

Re: [PoC] pg_upgrade: allow to upgrade publisher node

Here are some review comments for v54-0001 == src/backend/replication/slot.c 1. + if (*invalidated && SlotIsLogical(s) && IsBinaryUpgrade) + { + ereport(ERROR, + errcode(ERRCODE_INVALID_PARAMETER_VALUE), + errmsg("replication slots must not be invalidated during the upgrade"), + errhint("\"ma

Re: Faster "SET search_path"

On Fri, 2023-09-15 at 11:31 -0700, Jeff Davis wrote: > On Tue, 2023-09-12 at 13:55 -0700, Jeff Davis wrote: > > On Mon, 2023-08-07 at 15:39 -0700, Nathan Bossart wrote: > > > 0003 is looking pretty good, too, but I think we > > > should get some more eyes on it, given the complexity. > > > > Attac

Re: Fix output of zero privileges in psql

On 2023-10-17 04:05 +0200, David G. Johnston wrote: > Erik seems to favors (none) Yes, with a slight favor for "(none)" because it's the least disruptive to users who change \pset null to a non-blank string. The output of \dp etc. would still look the same for default privileges. But I'm also ok

Re: [PoC/RFC] Multiple passwords, interval expirations

On Wed, 2023-10-18 at 14:48 -0400, Stephen Frost wrote: > Right, we need more observability, agreed, but that's not strictly > necessary of this patch and could certainly be added independently.  > Is > there really a need to make this observability a requirement of this > particular change? I won

Re: Add the ability to limit the amount of memory that can be allocated to backends.

On 20/10/2023 05:06, Stephen Frost wrote: Greetings, * Andrei Lepikhov (a.lepik...@postgrespro.ru) wrote: On 19/10/2023 02:00, Stephen Frost wrote: * Andrei Lepikhov (a.lepik...@postgrespro.ru) wrote: On 29/9/2023 09:52, Andrei Lepikhov wrote: On 22/5/2023 22:59, reid.thomp...@crunchydata.co

Re: Guiding principle for dropping LLVM versions?

We could go further. With LLVM 14 as the minimum we can just use opaque pointers everywhere, and delete more conditional code in master. Tested on 14-18. I explored using the new pass manager everywhere too. It almost worked, but I couldn't see how to override the inlining threshold before LLVM

Re: Remove last traces of HPPA support

On Fri, Oct 20, 2023 at 4:21 AM Tom Lane wrote: > We removed support for the HP-UX OS in v16, but left in support > for the PA-RISC architecture, mainly because I thought that its > spinlock mechanism is weird enough to be a good stress test > for our spinlock infrastructure. It still is that, bu

Re: Patch: Improve Boolean Predicate JSON Path Docs

On 2023-10-19 15:39 +0200, David E. Wheeler wrote: > On Oct 19, 2023, at 01:22, jian he wrote: > > Updated patch attached and also on GitHub. > > > https://github.com/postgres/postgres/compare/master...theory:postgres:jsonpath-pred-docs Just wanted to take a look at v5. But it's an applefil

Re: [PoC] pg_upgrade: allow to upgrade publisher node

On Thu, 19 Oct 2023 at 16:14, Hayato Kuroda (Fujitsu) wrote: > > Dear Vignesh, > > Thanks for reviewing! New patch can be available in [1]. > > > > > Few comments: > > 1) We will be able to override the value of max_slot_wal_keep_size by > > using --new-options like '--new-options "-c > > max_slo

Re: Patch: Improve Boolean Predicate JSON Path Docs

On Oct 19, 2023, at 10:49 PM, Erik Wienhold wrote: > Just wanted to take a look at v5. But it's an applefile again :P I don’t get it. It was the other times too! Are you able to save it with a .patch suffix? D

Re: [PoC] pg_upgrade: allow to upgrade publisher node

On Thu, 19 Oct 2023 at 16:16, Hayato Kuroda (Fujitsu) wrote: > > Dear Vignesh, > > Thanks for revieing! New patch can be available in [1]. > > > Few comments: > > 1) Even if we comment 3rd point "Emit a non-transactional message", > > test_slot2 still appears in the invalid_logical_replication_slo

Re: Synchronizing slots from primary to standby

On Wed, Oct 18, 2023 at 4:24 PM Amit Kapila wrote: > > On Tue, Oct 17, 2023 at 2:01 PM shveta malik wrote: > > > > On Tue, Oct 17, 2023 at 12:44 PM Peter Smith wrote: > > > > > > FYI - the latest patch failed to apply. > > > > > > [postgres@CentOS7-x64 oss_postgres_misc]$ git apply > > > ../patc

Re: Synchronizing slots from primary to standby

On Tue, Oct 17, 2023 at 9:06 PM Drouvot, Bertrand wrote: > > Hi, > > On 10/13/23 10:35 AM, shveta malik wrote: > > On Thu, Oct 12, 2023 at 9:18 AM shveta malik wrote: > >> > > > > PFA v24 patch set which has below changes: > > > > 1) 'enable_failover' displayed in pg_replication_slots. > > 2) Sup

Re: Patch: Improve Boolean Predicate JSON Path Docs

On 2023-10-20 05:20 +0200, David E. Wheeler wrote: > On Oct 19, 2023, at 10:49 PM, Erik Wienhold wrote: > > > Just wanted to take a look at v5. But it's an applefile again :P > > I don’t get it. It was the other times too! Are you able to save it > with a .patch suffix? Saving it is not the pr

Re: SLRU optimization - configurable buffer pool and partitioning the SLRU lock

On Sat, Oct 14, 2023 at 9:43 AM Amit Kapila wrote: > > This and other results shared by you look promising. Will there be any > improvement in workloads related to clog buffer usage? I did not understand this question can you explain this a bit? In short, if it is regarding the performance then

Re: Fix output of zero privileges in psql

On Fri, 2023-10-20 at 04:13 +0200, Erik Wienhold wrote: > On 2023-10-17 04:05 +0200, David G. Johnston wrote: > > Erik seems to favors (none) > > Yes, with a slight favor for "(none)" because it's the least disruptive > to users who change \pset null to a non-blank string.  The output of \dp > etc