Re: Some performance degradation in REL_16 vs REL_15

=?utf-8?B?6YKx5a6H6Iiq?= writes: > I wrote a script and test on branch REL_[10-16]_STABLE, and do see > performance drop in REL_13_STABLE, which is about 1~2%. I'm really skeptical that we should pay much attention to these numbers. You've made several of the mistakes that we typically tell peop

Re: run pgindent on a regular basis / scripted manner

On Wed, 18 Oct 2023 at 01:47, Robert Haas wrote: > On Sat, Aug 12, 2023 at 5:53 PM Peter Geoghegan wrote: > > This policy isn't working. > > +1. I think this is more annoying than the status quo ante. Maybe there are two camps of committers here; ones who care about committing correctly indented

Re: Synchronizing slots from primary to standby

On Tue, Oct 17, 2023 at 9:06 PM Drouvot, Bertrand wrote: > > Hi, > > On 10/13/23 10:35 AM, shveta malik wrote: > > On Thu, Oct 12, 2023 at 9:18 AM shveta malik wrote: > >> > > > > PFA v24 patch set which has below changes: > > > > 1) 'enable_failover' displayed in pg_replication_slots. > > 2) Sup

Re: Synchronizing slots from primary to standby

On Tue, Oct 17, 2023 at 9:06 PM Drouvot, Bertrand wrote: > > On 10/13/23 10:35 AM, shveta malik wrote: > > On Thu, Oct 12, 2023 at 9:18 AM shveta malik wrote: > >> > > Code: > > + True if this logical slot is enabled to be synced to the physical > standbys > + so that logical replica

Re: Allow ALTER SYSTEM SET on unrecognized custom GUCs

On 17/10/2023 07:19, Tom Lane wrote: Currently we have this odd behavior (for a superuser): regression=# ALTER SYSTEM SET foo.bar TO 'baz'; ERROR: unrecognized configuration parameter "foo.bar" regression=# SET foo.bar TO 'baz'; SET regression=# ALTER SYSTEM SET foo.bar TO 'baz'; ALTER SYSTEM

Re: Allow ALTER SYSTEM SET on unrecognized custom GUCs

Andrei Lepikhov writes: > "SET foo.bar TO 'smth'" can immediately alter the placeholder's value. > But what is the reason that "ALTER SYSTEM SET foo.bar TO 'smth'" doesn't > do the same? Because it's not supposed to take effect until you issue a reload command (and maybe not even then, dependin

Re: Asymmetric partition-wise JOIN

On 17/10/2023 17:09, Ashutosh Bapat wrote: On Tue, Oct 17, 2023 at 2:05 PM Andrei Lepikhov wrote: On 16/10/2023 23:21, Ashutosh Bapat wrote: On Mon, Oct 16, 2023 at 10:24 AM Andrei Lepikhov Whenever I visited this idea, I hit one issue prominently - how would we differentiate different scans

Re: Allow ALTER SYSTEM SET on unrecognized custom GUCs

On 18/10/2023 12:15, Tom Lane wrote: Andrei Lepikhov writes: "SET foo.bar TO 'smth'" can immediately alter the placeholder's value. But what is the reason that "ALTER SYSTEM SET foo.bar TO 'smth'" doesn't do the same? Because it's not supposed to take effect until you issue a reload command (

Re: pgBufferUsage.blk_{read|write}_time are zero although there are pgBufferUsage.local_blks_{read|written}

On Tue, Oct 17, 2023 at 04:44:25PM +0300, Nazir Bilal Yavuz wrote: > I updated patches based on your comments. v4 is attached. Thanks for the new versions. I have applied 0001 and backpatched it for now. 0002 and 0003 look in much cleaner shape than previously. -- Michael signature.asc Descrip

Re: [PoC] pg_upgrade: allow to upgrade publisher node

Here are some comments for the patch v51-0002 == src/bin/pg_upgrade/t/003_upgrade_logical_replication_slots.pl 1. +# Set max_wal_senders to a lower value if the old cluster is prior to PG12. +# Such clusters regard max_wal_senders as part of max_connections, but the +# current TAP tester sets

Re: RFC: Logging plan of the running query

On 2023-10-16 18:46, Ashutosh Bapat wrote: On Thu, Oct 12, 2023 at 6:51 PM torikoshia wrote: On 2023-10-11 16:22, Ashutosh Bapat wrote: > > Considering the similarity with auto_explain I wondered whether this > function should be part of auto_explain contrib module itself? If we > do that user

Re: Clean up some pg_dump tests

On 10.10.23 10:03, Peter Eisentraut wrote: On 09.10.23 11:20, Alvaro Herrera wrote: I tried this out.  I agree it's a good change.  BTW, this made me realize that "unlike" is not a good name: maybe it should be called "except". right I would add quotes to the words "like" and "unlike" there.

Re: Test 026_overwrite_contrecord fails on very slow machines (under Valgrind)

On Thu, Oct 12, 2023 at 04:46:02PM -0700, Andres Freund wrote: > The machine skink is hosted on runs numerous buildfarm animals (24 I think > right now, about to be 28). While it has plenty resources (16 cores/32 > threads, 128GB RAM), test runtime is still pretty variable depending on what > other

Re: Remove wal_level settings for subscribers in tap tests

On Wed, Oct 18, 2023 at 02:59:52AM +, Hayato Kuroda (Fujitsu) wrote: > While discussing [1], I found that in tap tests, wal_level was set to logical > for > subscribers too. The setting is not needed for subscriber side, and it may > cause > misunderstanding for newcomers. Therefore, I wanted

Re: Oversight in reparameterize_path_by_child leading to executor crash

On Fri, Oct 13, 2023 at 6:18 PM Andrei Lepikhov wrote: > On 23/8/2023 12:37, Richard Guo wrote: > > To fix it we may need to modify RelOptInfos for Path, BitmapHeapPath, > > ForeignPath and CustomPath, and modify IndexOptInfos for IndexPath. It > > seems that that is not easily done without post

Re: pg_rewind WAL segments deletion pitfall

Thanks for the patch. I tested the v6 patch using the test script attached on [1], old primary has succeeded to become new standby. I have very minor questions on the regression tests mainly regarding the consistency with other tests for pg_rewind: +setup_cluster; +create_standby; Would

<    1   2