On Mon, Aug 28, 2023 at 01:47:18PM +0530, Dilip Kumar wrote:
> I removed this mainly because now in other comments[1] where we are
> introducing this new CHECKPOINT_REDO record we are explaining the
> problem
> that the redo location and the actual checkpoint records are not at
> the same place and
On Wed, Aug 16, 2023 at 6:45 PM Etsuro Fujita wrote:
> On Wed, Aug 16, 2023 at 9:41 AM Richard Guo wrote:
> > On Tue, Aug 15, 2023 at 7:50 PM Etsuro Fujita
> > wrote:
> >> So we should have modified the second one as well? Attached is a
> >> small patch for that.
>
> > Agreed, nice catch! +1
> On 28 Aug 2023, at 14:32, Daniel Gustafsson wrote:
> Attached is a patch with a quick PoC for using PQPing instead of using psql
> for
> connection checks in pg_regress.
The attached v2 fixes a silly mistake which led to a compiler warning.
--
Daniel Gustafsson
v2-0001-Speed-up-pg_regress
> On 30 Aug 2023, at 00:55, Peter Geoghegan wrote:
>
> On Tue, Aug 29, 2023 at 3:37 PM Daniel Gustafsson wrote:
>>> It's handy when using pg_regress with a custom test suite, where I
>>> don't want to be nagged about disconnecting from the database every
>>> time.
>>
>> I'm curious about your w
Hi Richard,
On Wed, Aug 30, 2023 at 11:05 AM Richard Guo wrote:
> On Tue, Aug 29, 2023 at 5:08 PM Etsuro Fujita wrote:
>> Another thing I would like to propose is minor adjustments to the docs
>> related to parallel query:
>>
>> A custom scan provider will typically add paths for a base rela
Hi,
> > On Mon, Aug 28, 2023 at 09:46:07PM +0800, Junwang Zhao wrote:
> > > Yeah, it makes sense to me, or maybe just `PQputCopyEnd(...) == -1`,
> > > let's wait for some other opinions.
> >
> > One can argue that PQputCopyEnd() returning 0 could be possible in an
> > older version of libpq these
Em ter., 29 de ago. de 2023 às 20:06, Michael Paquier
escreveu:
> On Thu, Aug 24, 2023 at 07:02:40PM -0700, Peter Geoghegan wrote:
> > FWIW I'm pretty sure that it's impossible to run into problems here in
> > practice -- the minheap is allocated by palloc(), and the high
> > watermark number of
Dear hackers,
While testing pg_upgrade for [1], I found a bug related with logical replication
slots.
# Found bug
Status of logical replication slots are still "reserved", but they are not
usable.
```
tmp=# SELECT slot_name, slot_type, restart_lsn, confirmed_flush_lsn, wal_status
FROM pg_rep
On Wed, Aug 30, 2023 at 1:03 PM Michael Paquier wrote:
>
> On Mon, Aug 28, 2023 at 01:47:18PM +0530, Dilip Kumar wrote:
> > I removed this mainly because now in other comments[1] where we are
> > introducing this new CHECKPOINT_REDO record we are explaining the
> > problem
> > that the redo locati
I am seeing a new gcc 12.2.0 compiler warning from
src/backend/commands/sequence.c:
sequence.c: In function ‘DefineSequence’:
sequence.c:196:35: warning: ‘coldef’ may be used uninitialized
[-Wmaybe-uninitialized]
196 | stmt->tableElts = lappend(stmt->tabl
Hi,
> I am seeing a new gcc 12.2.0 compiler warning from
> src/backend/commands/sequence.c:
Yep, the compiler is just not smart enough to derive that this
actually is not going to happen.
Here is a proposed fix.
--
Best regards,
Aleksander Alekseev
v1-0001-Silence-GCC-12-warning.patch
Descri
On Wed, 30 Aug 2023 at 01:01, Jim Jones wrote:
> However, pgbouncer closes with a segmentation fault, so I couldn't test the
> result of pg_basebackup itself - but I guess it isn't the issue here.
Oops it indeed seemed like I made an unintended change when handling
database names that did not ex
Hi,
I have another case of this on dikkop (on 11 again). Is there anything
else we'd want to try? Or maybe someone would want access to the machine
and do some investigation directly?
regards
--
Tomas Vondra
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
Hi everyone,
I just release a logfmt log collector for PostgreSQL :
https://pgxn.org/dist/logfmt/1.0.0/ . This works quite well but I have
a few issues I would like to share with hackers.
First, what do you think of having logfmt output along json and CSV ?
PostgreSQL internal syslogger has built
Greetings
On 27.07.23 06:43, Garrett Thornburg wrote:
I added a v2 patch for adding REINDEX to event triggers. The following
has changed:
1. I fixed the docs to note that ddl_command_start is supported for
REINDEX. Thanks, Michael!
2. I added Jian He's excellent partition table test and updat
I noticed that pg_resetwal has poor test coverage. There are some TAP
tests, but they all run with -n, so they don't actually test the full
functionality. (There is a non-dry-run call of pg_resetwal in the
recovery test suite, but that is incidental.)
So I added a bunch of more tests to test
On 28.08.23 15:46, Peter Eisentraut wrote:
I would like to be the commitfest manager for CF 2023-09.
I think my community account needs to have some privilege change to be
able to act as CF manager in the web interface. Could someone make that
happen?
On Wed, Aug 30, 2023 at 2:50 PM Peter Eisentraut wrote:
>
> On 28.08.23 15:46, Peter Eisentraut wrote:
> > I would like to be the commitfest manager for CF 2023-09.
>
> I think my community account needs to have some privilege change to be
> able to act as CF manager in the web interface. Could s
On Mon, 28 Aug 2023 at 17:57, Robert Haas wrote:
>
> On Mon, Aug 28, 2023 at 11:50 AM Matthias van de Meent
> wrote:
> > Agreed on all points. But isn't that true for most most tools on bloat
> > prevention and/or detection? E.g. fillfactor, autovacuum_*, ...
>
> Not nearly to the same extent, IM
On Tue, Aug 29, 2023 at 5:40 PM Ashutosh Bapat
wrote:
>
> I am looking at it. If you can wait till the end of the week, that
> will be great.
/*
* Successfully wrote, unset dirty bit, unless somebody dirtied again
- * already.
+ * already and remember the confirmed_flush LSN va
On Wed, Aug 30, 2023 at 9:01 AM Matthias van de Meent
wrote:
> I've reworked the patch a bit to remove the "excessive bloat with low
> fillfactors when local space is available" issue that this parameter
> could cause - local updates are now done if the selected page we would
> be inserting into i
On Wed, Aug 30, 2023 at 9:31 AM Robert Haas wrote:
> That seems like a good chance, but
*change
--
Robert Haas
EDB: http://www.enterprisedb.com
Hi Jeff,
On Wed, Aug 30, 2023 at 2:12 PM Jeff Davis wrote:
>
> The server "myserver" must have been created with the new syntax:
>
>CREATE SERVER myserver FOR CONNECTION ONLY
>
> instead of specifying FOREIGN DATA WRAPPER. In other words, a server
> FOR CONNECTION ONLY doesn't have a real FDW
On 2023-08-30 00:47, Andy Fan wrote:
see what it is. Suppose the original query is:
numeric(jsonb_object_field(v_jsonb, text)) -> numeric.
...
However the declared type of jsonb_object_field_type is:
jsonb_object_field_type(internal, jsonb, text) -> internal.
So the situation is: b). We retu
Jeff Davis writes:
> The server "myserver" must have been created with the new syntax:
>CREATE SERVER myserver FOR CONNECTION ONLY
> instead of specifying FOREIGN DATA WRAPPER. In other words, a server
> FOR CONNECTION ONLY doesn't have a real FDW, it's a special server just
> used for the pos
On Wed, Aug 30, 2023 at 12:13 AM Michael Paquier wrote:
> Yep, that looks more consistent, at quick glance.
Sorry, I'm only just noticing this thread. Thanks, Nathan, Ian, and
others, for your work on this. Apart from hoping that the 0002 patch
will get a more detailed commit message spelling out
On 8/30/23 08:10, Aleksander Alekseev wrote:
I am seeing a new gcc 12.2.0 compiler warning from
src/backend/commands/sequence.c:
Yep, the compiler is just not smart enough to derive that this
actually is not going to happen.
Here is a proposed fix.
Here's an alternate way to deal with this
On 29.08.23 19:45, Nathan Bossart wrote:
On Tue, Aug 29, 2023 at 10:43:39AM +0200, Peter Eisentraut wrote:
I have committed a few more patches from this series that were already
agreed upon. The remaining ones are rebased and reordered a bit, attached.
My compiler is complaining about 1fa9241
On Wed, Aug 30, 2023 at 09:50:41AM -0400, Robert Haas wrote:
> Sorry, I'm only just noticing this thread. Thanks, Nathan, Ian, and
> others, for your work on this. Apart from hoping that the 0002 patch
> will get a more detailed commit message spelling out the problem very
> explicitly, I don't hav
On 2023-Aug-29, Nathan Bossart wrote:
> On Tue, Aug 29, 2023 at 08:44:02PM +0200, Alvaro Herrera wrote:
> > Makes sense. However, maybe we should replace those ugly defines and
> > their hardcoded values in DefineSequence with a proper array with their
> > names and datatypes.
>
> That might be
On Wed, Aug 30, 2023 at 10:27 AM Nathan Bossart
wrote:
> On Wed, Aug 30, 2023 at 09:50:41AM -0400, Robert Haas wrote:
> > Sorry, I'm only just noticing this thread. Thanks, Nathan, Ian, and
> > others, for your work on this. Apart from hoping that the 0002 patch
> > will get a more detailed commit
Hi,
Just a follow-up: having spoken to the relevant people, sadly, right now,
we do not have the capacity to be pulling machines out of our day-to-day CI
tasks to dedicate to specific projects.
I can, however, offer a few alternatives:
1. If you have capacity on your linux x64 machines, it is po
On Tue, Aug 29, 2023 at 11:30:06PM -0400, Tom Lane wrote:
> Bruce Momjian writes:
> > On Tue, Aug 29, 2023 at 10:18:36AM -0400, Tom Lane wrote:
> >> That seems like a pretty clear compiler bug, particularly since it just
> >> appears in this one version. Rather than contorting our code, I'd
> >>
Hi,
On 2023-08-29 03:05, Jeevan Chalke wrote:
This commit implements jsonpath .bigint(), .integer(), and .number()
---
This commit implements jsonpath .date(), .time(), .time_tz(),
.timestamp(), .timestamp_tz() methods.
---
This commit implements jsonpath .boolean() and .string() methods.
Writ
On 2023-08-30 11:18, Chapman Flack wrote:
If I look in [1], am I looking in the right place for the most
current jsonpath draft?
My bad, I see that it is not. Um if I look in [1'], am I then looking
at the same spec you are?
[1'] https://www.ietf.org/archive/id/draft-ietf-jsonpath-base-20.html
On Wed, 2023-08-30 at 19:11 +0530, Ashutosh Bapat wrote:
> Are you suggesting that SERVERs created with FDW can not be used as
> publishers?
Correct. Without that, how would the subscription know that the FDW
contains valid postgres connection information? I suppose it could
create a connection st
On Wed, Aug 30, 2023 at 11:16:48AM -0400, Bruce Momjian wrote:
> On Tue, Aug 29, 2023 at 11:30:06PM -0400, Tom Lane wrote:
> > Bruce Momjian writes:
> > > On Tue, Aug 29, 2023 at 10:18:36AM -0400, Tom Lane wrote:
> > >> That seems like a pretty clear compiler bug, particularly since it just
> > >>
Peter Eisentraut has applied a patch to fix this.
---
On Wed, Aug 30, 2023 at 10:07:24AM -0400, David Steele wrote:
> On 8/30/23 08:10, Aleksander Alekseev wrote:
> >
> > > I am seeing a new gcc 12.2.0 compiler warning fro
On Wed, 2023-08-30 at 09:49 -0400, Tom Lane wrote:
> This seems like it requires a whole lot of new mechanism (parser
> and catalog infrastructure) that could be done far more easily
> in other ways. In particular, how about inventing a built-in
> dummy FDW to serve the purpose?
That was my initi
On Wed, 30 Aug 2023 at 15:31, Robert Haas wrote:
>
> On Wed, Aug 30, 2023 at 9:01 AM Matthias van de Meent
> wrote:
> > I've reworked the patch a bit to remove the "excessive bloat with low
> > fillfactors when local space is available" issue that this parameter
> > could cause - local updates ar
On 2023-Aug-30, Chapman Flack wrote:
> Hi,
>
> On 2023-08-29 03:05, Jeevan Chalke wrote:
> > This commit implements jsonpath .bigint(), .integer(), and .number()
> > ---
> > This commit implements jsonpath .date(), .time(), .time_tz(),
> > .timestamp(), .timestamp_tz() methods.
> > ---
> > This c
Hi,
I have inspected the performance of the GROUP BY and DISTINCT queries for the
sorted data streams and found out, that Group node (produced by GROUP BY) works
faster then the Unique node (produced by DISTINCT). The flame graph should out
the reason - Unique palloc`s tuples for the result sl
Peter Eisentraut wrote:
> Committed with some editing. I moved the existing rules example from
> the CREATE COLLATION page into the new section you created, so we have a
> simple example followed by the complex example.
OK, thanks for pushing this!
Best regards,
--
Daniel Vérité
htt
On 2023-08-30 12:28, Alvaro Herrera wrote:
Yeah, I think the experience of the SQL committee with XML was pretty
bad, as you carefully documented. I hope they don't make such a mess
with JSON.
I guess the SQL committee was taken by surprise after basing something
on Infoset and XPath 1.0 for 2
Hi,
cstring_to_text has a small overhead, because call strlen for
pointer to char parameter.
Is it worth the effort to avoid this, where do we know the size of the
parameter?
best regards,
Ranier Vilela
0003-Avoid-unecessary-calls-to-strlen-function.patch
Description: Binary data
> On 21 Aug 2023, at 13:42, Andrey M. Borodin wrote:
>
>
FPA attached next version.
Changes:
- implemented protection from time leap backwards when series is generated on
the same backend
- counter overflow is now translated into ms step forward
Best regards, Andrey Borodin.
v6-0001-Impl
On 30.08.23 14:11, Jelte Fennema wrote:
Oops it indeed seemed like I made an unintended change when handling
database names that did not exist in pgbouncer.conf when you used
auth_type=hba. I pushed a fix for that now to the replication-support
branch. Feel free to try again. But as you said it's
On 7/19/23 16:44, Jacob Champion wrote:
> This patch pushes down any
> forced-null and not-null Vars as ScanKeys. It doesn't remove the
> redundant quals after turning them into ScanKeys, so it's needlessly
> inefficient, but there's still a decent speedup for some of the basic
> benchmarks in 0003
On Tue, 29 Aug 2023 at 22:35, Heikki Linnakangas wrote:
> Looking the new heapgettup_advance_block() function and the code that it
> replaced, it's now skipping this ss_report_location() on the last call,
> when it has reached the end of the scan:
>
> >
> > /*
> >* Report our new sca
On Wed, Aug 30, 2023 at 10:56:22AM -0400, Robert Haas wrote:
> On Wed, Aug 30, 2023 at 10:27 AM Nathan Bossart
> wrote:
>> I'm about to spend way too much time writing the commit message for 0002,
>> but I plan to commit both patches sometime today.
>
> Thanks! I'm glad your committing the patche
On Thu, 31 Aug 2023 at 05:37, Денис Смирнов wrote:
> I have inspected the performance of the GROUP BY and DISTINCT queries for the
> sorted data streams and found out, that Group node (produced by GROUP BY)
> works faster then the Unique node (produced by DISTINCT). The flame graph
> should ou
Hi,
On 2023-08-28 17:29:56 +1200, Thomas Munro wrote:
> Every time we run a SQL query, we fork a new psql process and a new
> cold backend process. It's not free on Unix, and quite a lot worse on
> Windows, at around 70ms per query. Take amcheck/001_verify_heapam for
> example. It runs 272 subt
On 2023-08-28 Mo 09:23, Andrew Dunstan wrote:
On 2023-08-28 Mo 01:29, Thomas Munro wrote:
Hi,
Every time we run a SQL query, we fork a new psql process and a new
cold backend process. It's not free on Unix, and quite a lot worse on
Windows, at around 70ms per query. Take amcheck/001_verify
v11 is a quick rebase over the recent Cirrus changes, and I've dropped
0006 now that psycopg2 can build against BSD/Meson setups (thanks Daniele!).
--Jacob1: 0278c7ba90 = 1: 36409a76ce common/jsonapi: support FRONTEND clients
2: bb3ce4b6a9 = 2: 1356b729db libpq: add OAUTHBEARER SASL mechanism
On Wed, Aug 30, 2023 at 5:15 PM David Rowley wrote:
>
> On Tue, 29 Aug 2023 at 22:35, Heikki Linnakangas wrote:
> > Looking the new heapgettup_advance_block() function and the code that it
> > replaced, it's now skipping this ss_report_location() on the last call,
> > when it has reached the end
On Wed, Aug 30, 2023 at 09:50:17AM +0800, Richard Guo wrote:
> Yeah, IIRC the source tree currently is able to be built without any
> shadow-related warnings with -Wshadow=compatible-local. But with
> -Wshadow or -Wshadow=local, you can still see a lot of warnings.
Yep. I've addressed on HEAD th
On Thu, Aug 31, 2023 at 9:39 AM Michael Paquier wrote:
>
> On Wed, Aug 30, 2023 at 09:50:17AM +0800, Richard Guo wrote:
> > Yeah, IIRC the source tree currently is able to be built without any
> > shadow-related warnings with -Wshadow=compatible-local. But with
> > -Wshadow or -Wshadow=local, you
> On Tue, Aug 29, 2023 at 5:07 AM David Geier wrote:
> > Could you measure any performance difference?
> >
> > If so could you provide your test case?
>
> I created a large table and then updated a tuple on every page in the
> relation and vacuumed it. I saw a consistent slight improvement in
> va
On Thu, Aug 31, 2023 at 10:32 AM Andrew Dunstan wrote:
> #!/usr/bin/perl
>
> use strict; use warnings;
>
> use FFI::Platypus;
>
> my $ffi = FFI::Platypus->new(api=>1);
> $ffi->lib("inst/lib/libpq.so");
>
>
> $ffi->type('opaque' => 'PGconn');
> $ffi->attach(PQconnectdb => [ 'string' ] => 'PGconn');
On Thu, Aug 31, 2023 at 12:16 AM Tomas Vondra
wrote:
> I have another case of this on dikkop (on 11 again). Is there anything
> else we'd want to try? Or maybe someone would want access to the machine
> and do some investigation directly?
Sounds interesting -- I'll ping you off-list.
On Wed, Aug 30, 2023 at 03:00:13PM -0300, Ranier Vilela wrote:
> cstring_to_text has a small overhead, because call strlen for
> pointer to char parameter.
>
> Is it worth the effort to avoid this, where do we know the size of the
> parameter?
Are there workloads where this matters?
--
Michael
It looks like my patch was not analyzed by the hackers mailing list due to
incorrect mime type, so I duplicate it here.
commit 2852a3f2fab8e723f208d81c1ad1eb6a6a377b09
Author: Denis Smirnov
Date: Thu Aug 31 08:51:14 2023 +0700
Change tuple table slot for Unique node to "virtual"
T
On Wed, Aug 30, 2023 at 04:51:19PM +0530, Dilip Kumar wrote:
> Your suggestions LGTM so modified accordingly
I have been putting my HEAD on this patch for a few hours, reviewing
the surroundings, and somewhat missed that this computation is done
while we do not hold the WAL insert locks:
+ c
On Wed, Aug 30, 2023 at 04:12:16PM +0100, Anthony Roberts wrote:
> Just a follow-up: having spoken to the relevant people, sadly, right now,
> we do not have the capacity to be pulling machines out of our day-to-day CI
> tasks to dedicate to specific projects.
Okay, thanks for letting us know.
>
On Wed, Aug 30, 2023 at 02:56:48PM -0700, Nathan Bossart wrote:
> Committed.
Cool, thanks!
--
Michael
signature.asc
Description: PGP signature
On Thu, Aug 31, 2023 at 9:36 AM Michael Paquier wrote:
>
> On Wed, Aug 30, 2023 at 04:51:19PM +0530, Dilip Kumar wrote:
> > Your suggestions LGTM so modified accordingly
>
> I have been putting my HEAD on this patch for a few hours, reviewing
> the surroundings, and somewhat missed that this compu
On Thu, Aug 31, 2023 at 09:55:45AM +0530, Dilip Kumar wrote:
> Yeah, good catch. With this, it seems like we can not move this new
> WAL Insert out of the Exclusive WAL insertion lock right? Because if
> we want to set the LSN of this record as the checkpoint.redo then
> there should not be any c
Michael Paquier writes:
> On Wed, Aug 30, 2023 at 04:12:16PM +0100, Anthony Roberts wrote:
>> Just a follow-up: having spoken to the relevant people, sadly, right now,
>> we do not have the capacity to be pulling machines out of our day-to-day CI
>> tasks to dedicate to specific projects.
> Okay,
On Thu, Aug 31, 2023 at 4:22 PM Michael Paquier wrote:
> Honestly, I am not sure how to proceed here. Having something in the
> buildfarm is necessary IMO, because this is the central place that
> community members look at when it comes to monitoring the stability of
> a patch committed.
It's tr
Thomas Munro writes:
> But, supposing Azure credits were suddenly available (just between
> you, me and the mailing list, I heard that this should be imminent as
> some kind of grant to PG US, as a result of the Cirrus thing), do we
> have a Windows-savvy volunteer to feed and water an animal? I
On Wed, Aug 30, 2023 at 9:00 PM Jeff Davis wrote:
>
> On Wed, 2023-08-30 at 19:11 +0530, Ashutosh Bapat wrote:
> > Are you suggesting that SERVERs created with FDW can not be used as
> > publishers?
>
> Correct. Without that, how would the subscription know that the FDW
> contains valid postgres c
On Tue, Aug 29, 2023 at 06:14:08PM -0700, Nathan Bossart wrote:
> That seems fair enough. I did this in v7. I restructured fsync_pgdata()
> and fsync_dir_recurse() so that any new sync methods should cause compiler
> warnings until they are implemented.
That's pretty cool and easier to maintain
On Thu, Aug 31, 2023 at 01:06:53AM -0400, Tom Lane wrote:
> That's a good point. The hardware resources to support a buildfarm
> animal are really pretty trivial these days. What is important is
> an animal owner who is willing to help chase down problems when they
> arise.
Unfortunately I don't
On Wed, Aug 30, 2023 at 6:33 PM Ashutosh Bapat
wrote:
>
> On Tue, Aug 29, 2023 at 5:40 PM Ashutosh Bapat
> wrote:
> >
> > I am looking at it. If you can wait till the end of the week, that
> > will be great.
>
> /*
> * Successfully wrote, unset dirty bit, unless somebody dirtied again
pg_stats_export is a view that aggregates pg_statistic data by relation
oid and stores all of the column statistical data in a system-indepdent
(i.e.
no oids, collation information removed, all MCV values rendered as text)
jsonb format, along with the relation's relname, reltuples, and relpages
fro
On Thu, Aug 31, 2023 at 12:10 PM Amit Kapila wrote:
>
> > +
> > +/*
> > + * We won't ensure that the slot is persisted after the confirmed_flush
> > + * LSN is updated as that could lead to frequent writes. However, we
> > need
> > + * to ensure that we do persist the slots at th
76 matches
Mail list logo
