Re: POC PATCH: copy from ... exceptions to: (was Re: VLDB Features)

I'm sorry I was unable to respond right away. On 09.05.2023 17:23, torikoshia wrote: You may already understand it, but these variable names are given in imitation of FREEZE and BINARY cases:   --- a/src/include/commands/copy.h   +++ b/src/include/commands/copy.h   @@ -42,6 +42,7 @@ typedef st

Re: "38.10.10. Shared Memory and LWLocks" may require a clarification

Hi, > However it's not clear when a race-condition may happen. The rest of > the text gives an overall impression that the shmem_startup_hook will > be called by postmaster once (unless an extension places several hooks > in series). Thus there is no real need to ackquire AddinShmemInitLock > and

Re: PG 16 draft release notes ready

2023年5月19日(金) 5:49 Bruce Momjian : > > I have completed the first draft of the PG 16 release notes. You can > see the output here: > > https://momjian.us/pgsql_docs/release-16.html > > I will adjust it to the feedback I receive; that URL will quickly show > all updates. Hi Below are a f

Re: RFI: Extending the TOAST Pointer

Hi, > We'd need to stop using the va_tag as length indicator, but I don't > think it's currently assumed to be a length indicator anyway (see > VARSIZE_EXTERNAL(ptr)). By not using the varatt_external struct > currently in use, we could be able to get down to <18B toast pointers > as well, though

Re: createuser --memeber and PG 16

On Sun, May 21, 2023 at 08:00:15AM +0200, Peter Eisentraut wrote: > Maybe > > createuser --with-members > > and > > createuser --member-of > > would be clearer. Those seem like reasonable choices to me. I suspect we'll want to keep --role around for backward compatibility. -- Nathan Bossart

Re: Naming of gss_accept_deleg

Abhijit Menon-Sen writes: > At 2023-05-20 23:21:57 -0400, t...@sss.pgh.pa.us wrote: >> I thought the plan was to also rename the libpq "gssdeleg" connection >> parameter and so on? I can look into that tomorrow, if nobody beats >> me to it. > I was trying the change to see if it would be better

Re: createuser --memeber and PG 16

On Sun, May 21, 2023 at 07:44:49AM -0700, Nathan Bossart wrote: > On Sun, May 21, 2023 at 08:00:15AM +0200, Peter Eisentraut wrote: >> Maybe >> >> createuser --with-members >> >> and >> >> createuser --member-of >> >> would be clearer. > > Those seem like reasonable choices to me. I suspect w

Re: createuser --memeber and PG 16

On Sun, May 21, 2023 at 08:22:05AM -0700, Nathan Bossart wrote: > On Sun, May 21, 2023 at 07:44:49AM -0700, Nathan Bossart wrote: > > On Sun, May 21, 2023 at 08:00:15AM +0200, Peter Eisentraut wrote: > >> Maybe > >> > >> createuser --with-members > >> > >> and > >> > >> createuser --member-of >

Re: createuser --memeber and PG 16

Bruce Momjian writes: > On Sun, May 21, 2023 at 08:22:05AM -0700, Nathan Bossart wrote: >> I've attached a draft patch for this. I also changed --admin to >> --with-admin. > If we want to go forward with this, the big question is whether we want > to get this in before beta1. FYI, the release n

Re: PG 16 draft release notes ready

On Sun, May 21, 2023 at 09:30:01PM +0900, Ian Lawrence Barwick wrote: > 2023年5月19日(金) 5:49 Bruce Momjian : > > > > I have completed the first draft of the PG 16 release notes. You can > > see the output here: > > > > https://momjian.us/pgsql_docs/release-16.html > > > > I will adjust it to

Re: Naming of gss_accept_deleg

Greetings, * Tom Lane (t...@sss.pgh.pa.us) wrote: > Abhijit Menon-Sen writes: > > At 2023-05-20 23:21:57 -0400, t...@sss.pgh.pa.us wrote: > >> I thought the plan was to also rename the libpq "gssdeleg" connection > >> parameter and so on? I can look into that tomorrow, if nobody beats > >> me to

Re: walsender performance regression due to logical decoding on standby changes

Hi, On 2023-05-19 12:07:56 +0900, Kyotaro Horiguchi wrote: > At Thu, 18 May 2023 20:11:11 +0530, Bharath Rupireddy > wrote in > > > > + ConditionVariableInit(&WalSndCtl->physicalWALSndCV); > > > > + ConditionVariableInit(&WalSndCtl->logicalWALSndCV); > > > > > > It's not

Re: walsender performance regression due to logical decoding on standby changes

Hi, On 2023-05-18 20:11:11 +0530, Bharath Rupireddy wrote: > Please find the attached v4 patch addressing the review comment (not > the fastpath one). I pushed a mildly edited version of this. I didn't like the name of the CVs much, so I renamed them to wal_flush_cv/wal_replay_cv. I also did some

Re: PostgreSQL 16 Beta 1 release announcement draft

On 5/19/23 1:42 AM, Erik Rijkers wrote: Op 5/19/23 om 06:17 schreef Jonathan S. Katz: Hi, Attached is a draft of the release announcement for PostgreSQL 16 Beta Hi, The usual small fry: 'continues to to'  should be 'continues to' 'continues to give users to the ability'  should be 'cont

Re: PostgreSQL 16 Beta 1 release announcement draft

On 5/19/23 10:57 AM, Nathan Bossart wrote: On Fri, May 19, 2023 at 12:17:50AM -0400, Jonathan S. Katz wrote: PostgreSQL 16 continues to give users to the ability grant privileged access to features without requiring superuser with new [predefined roles](https://www.postgresql.org/docs/devel/pr

Re: PostgreSQL 16 Beta 1 release announcement draft

On 5/19/23 12:17 AM, Jonathan S. Katz wrote: Hi, Attached is a draft of the release announcement for PostgreSQL 16 Beta 1. The goal of this announcement is to get people excited about testing the beta and highlight many of the new features. Please review for inaccuracies, omissions, and othe

Re: createuser --memeber and PG 16

On Sun, May 21, 2023 at 11:45:24AM -0400, Tom Lane wrote: > A few comments on the patch: Thanks for taking a look. >>> Indicates an existing role that will be automatically added as a >>> member of the new > > "Specifies" would be clearer than "indicates" (not your fault, but > let's a

Re: PG 16 draft release notes ready

Bruce Momjian writes: > On Sun, May 21, 2023 at 09:30:01PM +0900, Ian Lawrence Barwick wrote: >> 2ceea5adb Accept "+infinity" in date and timestamp[tz] input. > I have this but didn't add that commit, added. That's really not related to the commit you added it to... I don't have time today to r

Re: PostgreSQL 16 Beta 1 release announcement draft

On Sun, May 21, 2023 at 12:51:05PM -0400, Jonathan S. Katz wrote: > On 5/19/23 10:57 AM, Nathan Bossart wrote: >> [pg_use_]reserved_connections might also deserve a mention here. AFAICT >> it's the only new predefined role that isn't mentioned in the announcement. >> I'm okay with leaving it out i

Re: PG 16 draft release notes ready

Hi, Thanks for the release notes! > > > > > Allow more efficient addition of multiple heap and index pages (Andres Freund) > > While the case of extending by multiple pages improved the most, even extending by a single page at a time got a good bit more scalable. Maybe just "Improve effici

Re: Add PQsendSyncMessage() to libpq

Hello, On 05/05/2023 16:02, Anton Kirilov wrote: On Thu, 4 May 2023, 11:36 Alvaro Herrera, > wrote: On 2023-May-04, Anton Kirilov wrote: If you want to make sure it's fully flushed, your only option is to have the call block. Surely PQflush() return

Re: createuser --memeber and PG 16

Nathan Bossart writes: > Fixed. v2 looks good to me, except the documentation wording for --with-role is needlessly inconsistent with --with-admin. The --with-admin wording looks better, so I suggest -Indicates the specified existing role should be automatically +Specifies an ex

Re: PG 16 draft release notes ready

On 5/21/23 1:13 PM, Andres Freund wrote: Looking through the release notes, I didn't see an entry for commit c6e0fe1f2a08505544c410f613839664eea9eb21 Author: David Rowley Date: 2022-08-29 17:15:00 +1200 Improve performance of and reduce overheads of memory management even though I

Re: PG 16 draft release notes ready

On 5/18/23 4:49 PM, Bruce Momjian wrote: I have completed the first draft of the PG 16 release notes. One thing that we could attempt for this beta is to include a prospective list of "major features + enhancements." Of course it can change before the GA, but it'll give readers some idea of t

Re: createuser --memeber and PG 16

On Sun, May 21, 2023 at 01:20:01PM -0400, Tom Lane wrote: > Nathan Bossart writes: >> Fixed. > > v2 looks good to me, except the documentation wording for --with-role > is needlessly inconsistent with --with-admin. The --with-admin > wording looks better, so I suggest > > -Indicates the

Re: PG 16 draft release notes ready

Hi, On May 21, 2023 11:46:56 AM PDT, "Jonathan S. Katz" wrote: >On 5/21/23 1:13 PM, Andres Freund wrote: > >> >> Looking through the release notes, I didn't see an entry for >> >> commit c6e0fe1f2a08505544c410f613839664eea9eb21 >> Author: David Rowley >> Date: 2022-08-29 17:15:00 +1200 >>

Re: Assert failure of the cross-check for nullingrels

I wrote: > If they have the same clause_relids, then clearly in its current > form clause_is_computable_at() cannot distinguish them. So what > I now think we should do is have clause_is_computable_at() examine > their required_relids instead. Those will be different, by > construction in deconst

Re: PG 16 draft release notes ready

On Sun, May 21, 2023 at 01:11:05PM -0400, Tom Lane wrote: > Bruce Momjian writes: > > On Sun, May 21, 2023 at 09:30:01PM +0900, Ian Lawrence Barwick wrote: > >> 2ceea5adb Accept "+infinity" in date and timestamp[tz] input. > > > I have this but didn't add that commit, added. > > That's really no

Re: pg_stat_io for the startup process

Hi, I don't really feel confident we're going to get the timeout approach solid enough for something going into the tree around beta 1. How about this, imo a lot simpler, approach: We flush stats whenever replaying a XLOG_RUNNING_XACTS record. Unless the primary is idle, it will log those at a re

Re: PG 16 draft release notes ready

On 5/21/23 3:24 PM, Andres Freund wrote: Hi, On May 21, 2023 11:46:56 AM PDT, "Jonathan S. Katz" wrote: On 5/21/23 1:13 PM, Andres Freund wrote: Looking through the release notes, I didn't see an entry for commit c6e0fe1f2a08505544c410f613839664eea9eb21 Author: David Rowley Date: 2022-

Re: PG 16 draft release notes ready

On 5/21/23 3:04 PM, Jonathan S. Katz wrote: On 5/18/23 4:49 PM, Bruce Momjian wrote: I have completed the first draft of the PG 16 release notes. One thing that we could attempt for this beta is to include a prospective list of "major features + enhancements." Of course it can change before

Re: createuser --memeber and PG 16

On Sun, May 21, 2023 at 12:16:58PM -0700, Nathan Bossart wrote: > On Sun, May 21, 2023 at 01:20:01PM -0400, Tom Lane wrote: > > Nathan Bossart writes: >>> How do folks feel about keeping --role undocumented? Should we give it a >>> mention in the docs for --member-of? >> >> I'm okay with leaving

Re: Add PQsendSyncMessage() to libpq

Hello, On 02/05/2023 00:55, Michael Paquier wrote: > Well, these are nice numbers. At ~1% I am ready to buy the noise > argument, but what would the range of the usual noise when it comes to > multiple runs under the same conditions> I managed to get my patch tested in the TechEmpower Framework

Re: ERROR: wrong varnullingrels (b 5 7) (expected (b)) for Var 3/3

On Fri, May 19, 2023 at 03:46:26PM +0800, Richard Guo wrote: > Thanks for testing. I looked into it and figured out that it is the > same issue discussed at the end of this thread: > https://www.postgresql.org/message-id/CAMbWs4-EU9uBGSP7G-iTwLBhRQ%3DrnZKvFDhD%2Bn%2BxhajokyPCKg%40mail.gmail.com O

Re: WAL Insertion Lock Improvements

On Fri, May 19, 2023 at 08:34:16PM +0530, Bharath Rupireddy wrote: > I get it. How about the following similar to what > ProcessProcSignalBarrier() has? > > + * Note that pg_atomic_exchange_u64 is a full barrier, so we're > guaranteed > + * that the variable is updated before waking up wa

Re: PG 16 draft release notes ready

In E.1.2. Migration to Version 16, probably need mention, some privilege command cannot restore. if new cluster bootstrap superuser name is not the same as old one. "GRANT x TO y GRANTED BY no_bootstrap_superuser; " will have error. ---pg15 dump content. CREATE ROLE jian; ALTER ROLE jian WITH SUPE

Re: Initial Schema Sync for Logical Replication

On Fri, Apr 28, 2023 at 4:16 PM Masahiko Sawada wrote: > Yes, in this approach, we need to dump/restore objects while > specifying with fine granularity. Ideally, the table sync worker dumps > and restores the table schema, does copy the initial data, and then > creates indexes, and triggers and t

Re: PG 16 draft release notes ready

On Sun, May 21, 2023 at 10:13:41AM -0700, Andres Freund wrote: > Hi, > > Thanks for the release notes! > > > > > > > > > > > Allow more efficient addition of multiple heap and index pages (Andres > > Freund) > > > > > > While the case of extending by multiple pages improved the most, even

Re: PG 16 draft release notes ready

On Mon, May 22, 2023 at 09:03:11AM +0800, jian he wrote: > In E.1.2. Migration to Version 16, probably need mention, some > privilege command cannot restore. > if new cluster bootstrap superuser name is not the same as old one. "GRANT x > TO > y GRANTED BY no_bootstrap_superuser; " will have error

Re: PG 16 draft release notes ready

On Sun, May 21, 2023 at 10:13:41AM -0700, Andres Freund wrote: > Hi, > > Thanks for the release notes! > > > > > > > > > > > Allow more efficient addition of multiple heap and index pages (Andres > > Freund) > > > > > > While the case of extending by multiple pages improved the most, even

Re: createuser --memeber and PG 16

On Mon, May 22, 2023 at 09:11:18AM +0900, Michael Paquier wrote: > On Sun, May 21, 2023 at 12:16:58PM -0700, Nathan Bossart wrote: >> Alright. Barring any additional feedback, I'll commit this tonight. > > v2 passes the eye test, and I am not spotting any references to the > past option names. T

RE: [PoC] pg_upgrade: allow to upgrade publisher node

On Tues, May 16, 2023 at 14:15 PM Kuroda, Hayato/黒田 隼人 wrote: > Dear Peter, > > Thanks for reviewing! PSA new version patchset. Thanks for updating the patch set. Here are some comments: === For patches 0001 1. The latest patch set fails to apply because the new commit (0245f8d) in HEAD. ~~~

Re: LLVM 16 (opaque pointers)

Oh, one important thing I forgot to mention: that patch is for LLVM 16 only, and I developed it with a local build of their "release/16.x" branch on a FreeBSD box, and also tested with a released package for 16 on a Debian box. Further changes are already needed for their "main" branch (LLVM 17-to

Re: pg_stat_io for the startup process

At Sun, 21 May 2023 15:14:23 -0700, Andres Freund wrote in > Hi, > > I don't really feel confident we're going to get the timeout approach solid > enough for something going into the tree around beta 1. > > How about this, imo a lot simpler, approach: We flush stats whenever replaying > a XLOG_

Re: Adding SHOW CREATE TABLE

On Fri, May 19, 2023 at 1:08 PM Andrew Dunstan wrote: > I think the ONLY place we should have this is in server side functions. > More than ten years ago I did some work in this area (see below), but it's > one of those things that have been on my ever growing personal TODO list > > See

Re: createuser --memeber and PG 16

On 21.05.23 19:07, Nathan Bossart wrote: How do folks feel about keeping --role undocumented? Should we give it a mention in the docs for --member-of? We made a point in this release to document deprecated options consistently. See commit 2f80c95740.

Re: Avoiding another needless ERROR during nbtree page deletion

On 20/05/2023 05:17, Peter Geoghegan wrote: It has come to my attention that there is a remaining issue of the same general nature in nbtree VACUUM's page deletion code. Though this remaining issue seems significantly less likely to come up in practice, there is no reason to take any chances here