Re: Add two missing tests in 035_standby_logical_decoding.pl

2023-05-06 Thread Drouvot, Bertrand
Hi, On 5/6/23 4:10 AM, Amit Kapila wrote: On Fri, May 5, 2023 at 7:53 PM Drouvot, Bertrand wrote: On 5/5/23 2:28 PM, Amit Kapila wrote: On Fri, May 5, 2023 at 5:36 PM Drouvot, Bertrand So, even on a successful test, we can see that the WAL file we expect to be removed on the standby has n

Re: Add RESPECT/IGNORE NULLS and FROM FIRST/LAST options

2023-05-06 Thread Oliver Ford
On Sat, 6 May 2023, 04:57 Tatsuo Ishii, wrote: > Attached is the patch to implement this (on top of your patch). > > test=# SELECT row_number() RESPECT NULLS OVER () FROM (SELECT 1) AS s; > ERROR: window function row_number cannot have RESPECT NULLS or IGNORE > NULLS > The last time this was di

Questionable coding in nth_value

2023-05-06 Thread Tatsuo Ishii
Currently Window function nth_value is coded as following: nth = DatumGetInt32(WinGetFuncArgCurrent(winobj, 1, &isnull)); if (isnull) PG_RETURN_NULL(); const_offset = get_fn_expr_arg_stable(fcinfo->flinfo, 1); if (nth <= 0) ereport(E

Re: Questionable coding in nth_value

2023-05-06 Thread Richard Guo
On Sat, May 6, 2023 at 4:44 PM Tatsuo Ishii wrote: > Currently Window function nth_value is coded as following: > > nth = DatumGetInt32(WinGetFuncArgCurrent(winobj, 1, &isnull)); > if (isnull) > PG_RETURN_NULL(); > const_offset = get_fn_expr_arg_stable(fcin

Re: Add RESPECT/IGNORE NULLS and FROM FIRST/LAST options

2023-05-06 Thread Tatsuo Ishii
> The last time this was discussed ( > https://www.postgresql.org/message-id/1037735.1610402426%40sss.pgh.pa.us) > it was suggested to make the feature generalizable, beyond what the > standard says it should be limited to. I have read the mail. In my understanding nobody said that standard window

Re: Questionable coding in nth_value

2023-05-06 Thread Tatsuo Ishii
> On Sat, May 6, 2023 at 4:44 PM Tatsuo Ishii wrote: > >> Currently Window function nth_value is coded as following: >> >> nth = DatumGetInt32(WinGetFuncArgCurrent(winobj, 1, &isnull)); >> if (isnull) >> PG_RETURN_NULL(); >> const_offset = get_fn_expr_arg_s

Re: Bancolombia Open Source Program Office - Proposal of contribution on lock inactive users

2023-05-06 Thread Joe Conway
On 5/5/23 15:54, Francisco Luis Arbelaez Lopez wrote: If it matches your needs and objectives, I would like to receive more information related to the next steps of this contribution. If you want to contribute a patch for consideration, you would start by sending it here (to this list) with di

Re: Add two missing tests in 035_standby_logical_decoding.pl

2023-05-06 Thread Amit Kapila
On Sat, May 6, 2023 at 1:52 PM Drouvot, Bertrand wrote: > > There is 2 runs with this extra info in place: > > A successful one: https://cirrus-ci.com/task/6528745436086272 > A failed one: https://cirrus-ci.com/task/4558139312308224 > Thanks, I think I got some clue as to why this test is failing

Remove duplicates of membership from results of \du

2023-05-06 Thread Shinya Kato
Hi, hackers When executing \du, you can see duplicates of the same role in 'member of'. This happens when admin | inherit | set options are granted by another role. --- postgres=# create role role_a login createrole; CREATE ROLE postgres=# \du    List of roles  Ro

Re: Add two missing tests in 035_standby_logical_decoding.pl

2023-05-06 Thread Drouvot, Bertrand
Hi, On 5/6/23 3:28 PM, Amit Kapila wrote: On Sat, May 6, 2023 at 1:52 PM Drouvot, Bertrand wrote: There is 2 runs with this extra info in place: A successful one: https://cirrus-ci.com/task/6528745436086272 A failed one: https://cirrus-ci.com/task/4558139312308224 Thanks, I think I got so

Re: pg_stat_io not tracking smgrwriteback() is confusing

2023-05-06 Thread Melanie Plageman
v5 attached. On Thu, May 4, 2023 at 12:44 PM Andres Freund wrote: > On 2023-04-27 11:36:49 -0400, Melanie Plageman wrote: > > > > /* and finally tell the kernel to write the data to > > > > storage */ > > > > reln = smgropen(currlocator, InvalidBackendId); > > > >

Re: Remove duplicates of membership from results of \du

2023-05-06 Thread David G. Johnston
On Sat, May 6, 2023 at 6:37 AM Shinya Kato wrote: > Hi, hackers > > When executing \du, you can see duplicates of the same role in 'member of'. > This happens when admin | inherit | set options are granted by another > role. > There is already an ongoing patch discussing the needed changes to ps

Re: POC PATCH: copy from ... exceptions to: (was Re: VLDB Features)

2023-05-06 Thread Alena Rybakina
Hi! Thank you, Damir, for your patch. It is very interesting to review it! It seemed to me that the names of variables are not the same everywhere. I noticed that you used /ignore_datatype_errors_specified/ variable in /copy.c/ , but guc has a short name /ignore_datatype_errors/. Also you use

Re: Missing update of all_hasnulls in BRIN opclasses

2023-05-06 Thread Tomas Vondra
On 4/24/23 23:20, Tomas Vondra wrote: > On 4/24/23 17:36, Alvaro Herrera wrote: >> On 2023-Apr-23, Tomas Vondra wrote: >> >>> here's an updated version of the patch, including a backport version. I >>> ended up making the code yet a bit closer to master by introducing >>> add_values_to_range().

Re: [PATCH] Add native windows on arm64 support

2023-05-06 Thread Michael Paquier
On Sat, May 06, 2023 at 12:35:40AM -0400, Tom Lane wrote: > Indeed, there's not much in this patch ... but it's impossible to see > how "run on an entirely new platform" isn't a new feature. Moreover, > it's a platform that very few of us will have any ability to support > or debug for. I can't s

2023-05-11 release announcement draft

2023-05-06 Thread Jonathan S. Katz
Hi, Attached is a draft of the release announcement for the upcoming update release on May 11, 2023. Please provide any suggestions, corrections, or notable omissions no later than 2023-05-11 0:00 AoE. Thanks, Jonathan The PostgreSQL Global Development Group has released an update to all s

Re: MERGE lacks ruleutils.c decompiling support!?

2023-05-06 Thread Tom Lane
I wrote: > I think we could probably commit this, though I've not tried it > in v15 yet. Ping? The hours grow short, if we're to get this into 15.3. regards, tom lane

Re: Missing update of all_hasnulls in BRIN opclasses

2023-05-06 Thread Julien Rouhaud
Hi, On Sun, May 07, 2023 at 12:13:07AM +0200, Tomas Vondra wrote: > > c) ignore the issue - AFAICS this would be an issue only for (external) > code accessing BrinMemTuple structs, but I don't think we're aware of > any out-of-core BRIN opclasses or anything like that ... FTR there's at least pos

Re: 2023-05-11 release announcement draft

2023-05-06 Thread Erik Rijkers
Op 5/7/23 om 05:37 schreef Jonathan S. Katz: Attached is a draft of the release announcement for the upcoming update release on May 11, 2023. Please provide any suggestions, corrections, or notable omissions no later than 2023-05-11 0:00 AoE. 'leak in within a' should be 'leak within a' Er

Proposal for Prototype Implementation to Enhance C/C++ Interoperability in PostgreSQL

2023-05-06 Thread 盏一
Hi I am writing to propose a prototype implementation that can greatly enhance the C/C++ interoperability in PostgreSQL. The implementation involves converting PG longjmp to [force unwind](https://itanium-cxx-abi.github.io/cxx-abi/abi-eh.html#base-throw), which triggers the destruction of l