Re: [PoC] Let libpq reject unexpected authentication requests

On Tue, Mar 14, 2023 at 12:14:40PM -0700, Jacob Champion wrote: > On Mon, Mar 13, 2023 at 10:39 PM Michael Paquier wrote: >> 0002 looks pretty simple as well, I think that's worth a look for this >> CF. > > Cool. v17 just rebases the set over HEAD, then, for cfbot. I have looked at 0002, and I a

Re: add log messages when replication slots become active and inactive (was Re: Is it worth adding ReplicationSlot active_pid to ReplicationSlotPersistentData?)

On Thu, Sep 15, 2022 at 10:39 AM Bharath Rupireddy wrote: > > On Mon, Jul 25, 2022 at 6:31 PM Bharath Rupireddy > wrote: > > > > Here's the v6 patch, a much simpler one - no changes to any of the > > existing function APIs. Please see the sample logs at [1]. There's a > > bit of duplicate code in

Re: Add pg_walinspect function with block info columns

On Mon, Mar 20, 2023 at 05:00:25PM -0700, Peter Geoghegan wrote: > I think that we should also make the description output column display > NULLs for those records that don't output any description string. This > at least includes the "FPI" record type from the "XLOG" rmgr. > Alternatively, we coul

Re: Commitfest 2023-03 starting tomorrow!

Thomas Munro writes: > On Tue, Mar 21, 2023 at 10:59 PM Alvaro Herrera > wrote: >> This led me to suggesting that perhaps we need to be more lenient when >> it comes to new contributors. As I said, for seasoned contributors, >> it's not a problem to keep up with our requirements, however silly

RE: Data is copied twice when specifying both child and parent table in publication

Dear Wang, Thank you for updating patch! Following are comments form v19-0001. 01. logical-replication.sgml I found a following statement in logical-replication.sgml. I think this may cause mis-reading because it's OK when publishers list partitions and publish_via_root is true. ``` A s

Re: Add pg_walinspect function with block info columns

On Mon, Mar 20, 2023 at 04:51:19PM -0700, Peter Geoghegan wrote: > On Mon, Mar 20, 2023 at 4:34 PM Peter Geoghegan wrote: >> I agree. A little redundancy is better when the alternative is fragile >> code, and I'm pretty sure that that applies here -- there won't be >> very many duplicated lines, a

Re: Reconcile stats in find_tabstat_entry() and get rid of PgStat_BackendFunctionEntry

Hi, On 3/22/23 5:45 AM, Michael Paquier wrote: On Wed, Mar 22, 2023 at 11:37:03AM +0900, Kyotaro Horiguchi wrote: In the original description, "buffer fetches" appears to be a plural form of a compound noun and correct, similar to "buffer hits" mentioned later. If we reword it, I think it shoul

Re: Set arbitrary GUC options during initdb

On 27.01.23 21:02, Tom Lane wrote: I wrote: Anyway, it seems like I gotta work harder. I'll produce a new patch. The string-hacking was fully as tedious as I expected. However, the output looks pretty nice, and this does have the advantage that the pre-programmed substitutions become a lot m

Re: User functions for building SCRAM secrets

On Tue, Feb 14, 2023 at 06:16:18PM -0500, Jonathan S. Katz wrote: > I opted for the approach in [2]. v5 contains the branching logic for the > UTF8 only tests, and the corresponding output files. I tested locally on > macOS against both UTF8 + C locales. I was reading this thread again, and ponde

Re: Dropped and generated columns might cause wrong data on subs when REPLICA IDENTITY FULL

Hi Shi Yu, > > Is there any reasons why we drop column here? Dropped column case has been > tested on table dropped_cols. The generated column problem can be detected > without dropping columns on my machine. > We don't really need to, if you check the first patch, we don't have DROP for generat

<    1   2