Re: Improve logging when using Huge Pages

2023-03-13 Thread Kyotaro Horiguchi
At Mon, 13 Mar 2023 21:33:31 +0100, Stephen Frost wrote in > > On Thu, Mar 09, 2023 at 03:02:29PM -0500, Stephen Frost wrote: > > > * Justin Pryzby (pry...@telsasoft.com) wrote: > > > Is there an agreement to use a function, instead ? > > > > Alvaro was -1 on using a function > > > I don’t enti

Re: Combine pg_walinspect till_end_of_wal functions with others

2023-03-13 Thread Bharath Rupireddy
On Tue, Mar 14, 2023 at 5:02 AM Michael Paquier wrote: > > So let's be clean and drop these slots to keep the tests > self-contained. pg_walinspect in REL_15_STABLE gets that right, IMV, > and that's no different from the role cleanup, as one example. Hm, added replication slot drop back. > > A

Re: [PoC] Let libpq reject unexpected authentication requests

2023-03-13 Thread Michael Paquier
On Mon, Mar 13, 2023 at 12:38:10PM -0700, Jacob Champion wrote: > Here's a v16: > - updated 0001 patch message > - all test names should have commas rather than colons now > - new test for an empty require_auth > - new SSPI suite (note that it doesn't run by default on Cirrus, due > to the use of P

RE: [PATCH] Use indexes on the subscriber when REPLICA IDENTITY is full on the publisher

2023-03-13 Thread shiy.f...@fujitsu.com
On Mon, Mar 13, 2023 10:16 PM Önder Kalacı wrote: > > Attaching v47. > Thanks for updating the patch. Here are some comments. 1. in RemoteRelContainsLeftMostColumnOnIdx(): + if (indexInfo->ii_NumIndexAttrs < 1) + return false; Did you see any cases that the condition is t

Re: Testing autovacuum wraparound (including failsafe)

2023-03-13 Thread Masahiko Sawada
On Wed, Mar 8, 2023 at 1:52 PM Masahiko Sawada wrote: > > On Fri, Mar 3, 2023 at 8:34 PM Heikki Linnakangas wrote: > > > > On 16/11/2022 06:38, Ian Lawrence Barwick wrote: > > > Thanks for the patch. While reviewing the patch backlog, we have > > > determined that > > > the latest version of thi

Re: [PATCH] Use indexes on the subscriber when REPLICA IDENTITY is full on the publisher

2023-03-13 Thread Amit Kapila
On Mon, Mar 13, 2023 at 7:46 PM Önder Kalacı wrote: > > Attaching v47. > I have made the following changes in the attached patch (a) removed the function IsIdxSafeToSkipDuplicates() and used the check directly in the caller; (b) changed a few comments in the patch; (c) the test file was inconsist

<    1   2