Re: odd buildfarm failure - "pg_ctl: control file appears to be corrupt"

2023-02-13 Thread Anton A. Melnikov
Hi, Thomas! Thanks for your rapid answer and sorry for my delay with reply. On 01.02.2023 09:45, Thomas Munro wrote: Might add a custom error message for EDEADLK since it absent in errcode_for_file_access()? Ah, good thought. I think it shouldn't happen™, so it's OK that errcode_for_file_acc

Re: Improve logging when using Huge Pages

2023-02-13 Thread Nathan Bossart
On Mon, Feb 13, 2023 at 05:22:45PM -0600, Justin Pryzby wrote: > +Reports whether huge pages are in use by the current process. > +See for more information. nitpick: Should this say "server" instead of "current process"? > +static char *huge_pages_active = "unknown"; /* dynamical

Re: Todo: Teach planner to evaluate multiple windows in the optimal order

2023-02-13 Thread John Naylor
SortTupleComparator comparetup; + /* +* Fall back to the full tuple for comparison, but only compare the first +* sortkey if it was abbreviated. Otherwise, only compare second and later +* sortkeys. +*/ + SortTupleComparator comparetup_fallback; + /* * Alter datum1 representation in the SortTuple's array back from the * abbreviated key to the first column value. -- 2.39.1 window-sort-bench-jcn-20230213.ods Description: application/vnd.oasis.opendocument.spreadsheet

Re: ExecRTCheckPerms() and many prunable partitions (sqlsmith)

2023-02-13 Thread Amit Langote
On Mon, Feb 13, 2023 at 22:31 Tom Lane wrote: > Amit Langote writes: > > On Mon, Feb 13, 2023 at 5:07 Justin Pryzby wrote: > >> That seems to add various elog()s which are hit frequently by sqlsmith: > > > Thanks for the report. I’ll take a look once I’m back at a computer in a > > few days. >

Re: Perform streaming logical transactions by background workers and parallel apply

2023-02-13 Thread Amit Kapila
On Fri, Feb 10, 2023 at 8:56 AM Peter Smith wrote: > > On Fri, Feb 10, 2023 at 1:32 PM houzj.f...@fujitsu.com > wrote: > > > > On Tuesday, February 7, 2023 11:17 AM Amit Kapila > > wrote: > > > > > > On Mon, Feb 6, 2023 at 3:43 PM houzj.f...@fujitsu.com > > > wrote: > > > > > > > > while readi

Re: Reconcile stats in find_tabstat_entry() and get rid of PgStat_BackendFunctionEntry

2023-02-13 Thread Kyotaro Horiguchi
Thanks for the new version. At Mon, 13 Feb 2023 09:58:52 +0100, "Drouvot, Bertrand" wrote in > Hi, > > On 2/13/23 8:40 AM, Kyotaro Horiguchi wrote: > > At Mon, 13 Feb 2023 08:09:50 +0100, "Drouvot, Bertrand" > > wrote in > >>> I think this is useful beyond being able to generate those functio

RE: Time delayed LR (WAS Re: logical replication restrictions)

2023-02-13 Thread Takamichi Osumi (Fujitsu)
Hi, Andres-san On Tuesday, February 14, 2023 1:47 AM Andres Freund wrote: > On 2023-02-11 05:44:47 +, Takamichi Osumi (Fujitsu) wrote: > > On Saturday, February 11, 2023 11:10 AM Andres Freund > wrote: > > > Has there been any discussion about whether this is actually best > > > implemented

Re: Perform streaming logical transactions by background workers and parallel apply

2023-02-13 Thread Peter Smith
On Tue, Feb 14, 2023 at 5:04 PM Amit Kapila wrote: > > On Fri, Feb 10, 2023 at 8:56 AM Peter Smith wrote: > > > > On Fri, Feb 10, 2023 at 1:32 PM houzj.f...@fujitsu.com > > wrote: > > > > > > On Tuesday, February 7, 2023 11:17 AM Amit Kapila > > > wrote: > > > > > > > > On Mon, Feb 6, 2023 at

Re: Force testing of query jumbling code in TAP tests

2023-02-13 Thread Michael Paquier
On Mon, Feb 13, 2023 at 09:45:12AM -0800, Andres Freund wrote: > Shouldn't there at least be some basic verification of pg_stat_statements > output being sane after running the test? Even if that's perhaps just actually > printing the statements. There is a total of 20k entries in pg_stat_statemen

Re: Use pg_pwritev_with_retry() instead of write() in dir_open_for_write() to avoid partial writes?

2023-02-13 Thread Michael Paquier
On Mon, Feb 13, 2023 at 05:10:56PM -0800, Andres Freund wrote: > I just tried to use pg_pwrite_zeros - and couldn't because it doesn't have an > offset parameter. Huh, what lead to the function being so constrained? Its current set of uses cases, where we only use it now to initialize with zeros

<    1   2