Re: Time delayed LR (WAS Re: logical replication restrictions)

At Tue, 7 Feb 2023 09:10:01 +0530, Amit Kapila wrote in > On Tue, Feb 7, 2023 at 6:03 AM Peter Smith wrote: > > 5b. > > Since there are no translator considerations here why not write the > > second error like: > > > > errmsg("%d ms is outside the valid range for parameter > > \"min_apply_delay

Re: heapgettup refactoring

On Fri, 3 Feb 2023 at 15:26, David Rowley wrote: > I've pushed all but the final 2 patches now. I just pushed the final patch in the series. I held back on moving the setting of rs_inited back into the heapgettup_initial_block() helper function as I wondered if we should even keep that field. I

Re: Time delayed LR (WAS Re: logical replication restrictions)

Thanks! At Mon, 6 Feb 2023 13:10:01 +, "Takamichi Osumi (Fujitsu)" wrote in > The attached patch v29 has included your changes. catalogs.sgml + + The minimum delay (ms) for applying changes. + I think we don't use unit symbols that way. Namely I think we would write it

Re: run pgindent on a regular basis / scripted manner

On Mon, Feb 06, 2023 at 06:17:02PM +0100, Peter Eisentraut wrote: > Also, pgindent takes tens of seconds to run, so hooking that into the git > push process would slow this down quite a bit. The pre-receive hook would do a full pgindent when you change typedefs.list. Otherwise, it would reindent o

Re: tests against running server occasionally fail, postgres_fdw & tenk1

Hi, On 2023-02-06 19:29:46 -0800, Andres Freund wrote: > There's something off. Isolationtester's control connection emits *loads* of > invalidation messages: > 2023-02-06 19:29:06.430 PST [2125297][client > backend][6/0:121864][isolation/receipt-report/control connection] LOG: > previously emi

Re: In-placre persistance change of a relation

Thank you for the comment! At Fri, 3 Feb 2023 08:42:52 +0100, Heikki Linnakangas wrote in > I want to call out this part of this patch: > > > Also this allows for the cleanup of files left behind in the crash of > > the transaction that created it. > > This is interesting to a lot wider audie

Re: Exit walsender before confirming remote flush in logical replication

Hi, On 2023-02-07 09:00:13 +0530, Amit Kapila wrote: > On Tue, Feb 7, 2023 at 2:04 AM Andres Freund wrote: > > How about we make it an option in START_REPLICATION? Delayed logical rep can > > toggle that on by default. > Works for me. So, when this option is set in START_REPLICATION > message, w

Re: Where is the logig to create a table file?

At Fri, 3 Feb 2023 13:44:46 +0400, Pavel Borisov wrote in > Hi, Jack > > On Fri, 3 Feb 2023 at 13:19, jack...@gmail.com wrote: > > > > When I use 'create table t(a int);'; suppose that this table t's oid is > > 1200, > > then postgres will create a file named 1200 in the $PGDATA/base, So wher

Re: Time delayed LR (WAS Re: logical replication restrictions)

On Tue, Feb 7, 2023 at 10:07 AM Kyotaro Horiguchi wrote: > > At Tue, 7 Feb 2023 09:10:01 +0530, Amit Kapila > wrote in > > On Tue, Feb 7, 2023 at 6:03 AM Peter Smith wrote: > > > 5b. > > > Since there are no translator considerations here why not write the > > > second error like: > > > > > > e

Re: Time delayed LR (WAS Re: logical replication restrictions)

On Tue, Feb 7, 2023 at 4:02 PM Amit Kapila wrote: > > On Tue, Feb 7, 2023 at 10:07 AM Kyotaro Horiguchi > wrote: > > > > At Tue, 7 Feb 2023 09:10:01 +0530, Amit Kapila > > wrote in > > > On Tue, Feb 7, 2023 at 6:03 AM Peter Smith wrote: > > > > 5b. > > > > Since there are no translator conside

Re: Time delayed LR (WAS Re: logical replication restrictions)

On Tue, Feb 7, 2023 at 10:13 AM Kyotaro Horiguchi wrote: > > At Mon, 6 Feb 2023 13:10:01 +, "Takamichi Osumi (Fujitsu)" > wrote in > > The attached patch v29 has included your changes. > > catalogs.sgml > > + > + The minimum delay (ms) for applying changes. > + > > I think

Re: Time delayed LR (WAS Re: logical replication restrictions)

On Tue, Feb 7, 2023 at 10:42 AM Peter Smith wrote: > > On Tue, Feb 7, 2023 at 4:02 PM Amit Kapila wrote: > > > > On Tue, Feb 7, 2023 at 10:07 AM Kyotaro Horiguchi > > wrote: > > > > > > At Tue, 7 Feb 2023 09:10:01 +0530, Amit Kapila > > > wrote in > > > > On Tue, Feb 7, 2023 at 6:03 AM Peter S

Re: [PATCH] Compression dictionaries for JSONB

Hi, On updating dictionary - >You cannot "just" refresh a dictionary used once to compress an >object, because you need it to decompress the object too. and when you have many - updating an existing dictionary requires going through all objects compressed with it in the whole database. It's a ve

Re: A problem in deconstruct_distribute_oj_quals

Richard Guo writes: > In deconstruct_distribute_oj_quals, when we've identified a commutable > left join which provides join clause with flexible semantics, we try to > generate multiple versions of the join clause. Here we have the logic > that puts back any ojrelids that were removed from its m

Re: Make mesage at end-of-recovery less scary.

Thanks! At Fri, 3 Feb 2023 15:16:02 +0100, Alvaro Herrera wrote in > So this patch is now failing because it applies new tests to > 011_crash_recovery.pl, which was removed recently. Can you please move > them elsewhere? I don't find an appropriate file to move to. In the end I created a new

Re: Remove some useless casts to (void *)

On 03.02.23 00:59, Corey Huinker wrote: On Thu, Feb 2, 2023 at 5:22 PM Peter Eisentraut > wrote: I have found that in some corners of the code some calls to standard C functions are decorated with casts to (void *) for no reason, and this co

A bug in make_outerjoininfo

In cases where we have any clauses between two outer joins, these clauses should be treated as degenerate clauses in the upper OJ, and they may prevent us from re-ordering the two outer joins. Previously we have the flag 'delay_upper_joins' to help avoid the re-ordering in such cases. In b448f1c8

Re: Perform streaming logical transactions by background workers and parallel apply

On Fri, Feb 3, 2023 at 6:44 PM Amit Kapila wrote: > > On Fri, Feb 3, 2023 at 1:28 PM Masahiko Sawada wrote: > > > > On Fri, Feb 3, 2023 at 12:29 PM houzj.f...@fujitsu.com > > wrote: > > > > > > On Friday, February 3, 2023 11:04 AM Amit Kapila > > > wrote: > > > > > > > > On Thu, Feb 2, 2023 at

Re: OpenSSL 3.0.0 vs old branches

On 06.02.23 16:56, Andrew Dunstan wrote: I recently moved crake to a new machine running Fedora 36, which has OpenSSL 3.0.0. This causes the SSL tests to fail on branches earlier than release 13, so I propose to backpatch commit f0d2c65f17 to the release 11 and 12 branches. This is not the on

RE: [PATCH] Reuse Workers and Replication Slots during Logical Replication

On Wed, Feb 1, 2023 20:07 PM Melih Mutlu wrote: > Thanks for pointing out this review. I somehow skipped that, sorry. > > Please see attached patches. Thanks for updating the patch set. Here are some comments. 1. In the function ApplyWorkerMain. + /* This is main apply wor

Re: Perform streaming logical transactions by background workers and parallel apply

On Tue, Feb 7, 2023 at 12:41 PM Masahiko Sawada wrote: > > On Fri, Feb 3, 2023 at 6:44 PM Amit Kapila wrote: > > > We need to think of a predictable > > way to test this path which may not be difficult. But I guess it would > > be better to wait for some feedback from the field about this feature

RE: Deadlock between logrep apply worker and tablesync worker

On Tuesday, February 7, 2023 12:12 PM Peter Smith wrote: > On Fri, Feb 3, 2023 at 6:58 PM houzj.f...@fujitsu.com > wrote: > > > ... > > > Right, I think that case could be addressed by Tom's patch to some > > > extent but I am thinking we should also try to analyze if we can > > > completely avoi

Re: make_ctags: use -I option to ignore pg_node_attr macro

> On 2022/10/19 13:25, Tatsuo Ishii wrote: >> Thanks. the v6 patch pushed to master branch. > > Since this commit, make_etags has started failing to generate > tags files with the following error messages, on my MacOS. > > $ src/tools/make_etags > /Applications/Xcode.app/Contents/Developer/Toolch

<    1   2