Re: In-placre persistance change of a relation

2023-02-02 Thread Heikki Linnakangas
I want to call out this part of this patch: Also this allows for the cleanup of files left behind in the crash of the transaction that created it. This is interesting to a lot wider audience than ALTER TABLE SET LOGGED/UNLOGGED. It also adds most of the complexity, with the new marker files.

Re: Weird failure with latches in curculio on v15

2023-02-02 Thread Andres Freund
Hi, On 2023-02-03 02:24:03 -0500, Tom Lane wrote: > Andres Freund writes: > > Ugh, I think I might understand what's happening: > > > The signal arrives just after the fork() (within system()). Because we > > have all our processes configure themselves as process group leaders, > > and we signal

Re: Weird failure with latches in curculio on v15

2023-02-02 Thread Tom Lane
Thomas Munro writes: > On Fri, Feb 3, 2023 at 8:35 PM Andres Freund wrote: >> we don't have a hard dependency on setsid() > FTR There are no Unixes without setsid()... Yeah. What I just got done reading in SUSv2 (1997) is "Derived from the POSIX.1-1988 standard". We need not concern ourselves

Re: Weird failure with latches in curculio on v15

2023-02-02 Thread Tom Lane
Andres Freund writes: > On 2023-02-03 02:24:03 -0500, Tom Lane wrote: >> setsid(2) is required since SUSv2, so I'm not sure which systems >> are of concern here ... other than Redmond's of course. > I was thinking of windows, yes. But given the lack of fork(2), Windows requires a completely diff

RE: Deadlock between logrep apply worker and tablesync worker

2023-02-02 Thread houzj.f...@fujitsu.com
On Thursday, February 2, 2023 7:21 PM Amit Kapila wrote: > > On Thu, Feb 2, 2023 at 12:05 PM houzj.f...@fujitsu.com > wrote: > > > > On Tuesday, January 31, 2023 1:07 AM vignesh C > wrote: > > > On Mon, 30 Jan 2023 at 17:30, vignesh C wrote: > > > > > > > I also tried to test the time of "src

Re: Weird failure with latches in curculio on v15

2023-02-02 Thread Andres Freund
Hi, On 2023-02-03 20:34:36 +1300, Thomas Munro wrote: > What if we block signals, fork, then in the child, install the default > SIGTERM handler, then unblock, and then exec the shell? Yep. I was momentarily wondering why we'd even need to unblock signals, but while exec (et al) reset the signal

Re: Perform streaming logical transactions by background workers and parallel apply

2023-02-02 Thread Masahiko Sawada
On Fri, Feb 3, 2023 at 12:29 PM houzj.f...@fujitsu.com wrote: > > On Friday, February 3, 2023 11:04 AM Amit Kapila > wrote: > > > > On Thu, Feb 2, 2023 at 4:52 AM Peter Smith > > wrote: > > > > > > Some minor review comments for v91-0001 > > > > > > > Pushed this yesterday after addressing your

<    1   2