On Tuesday, January 31, 2023 8:23 AM Peter Smith wrote:
>
> On Mon, Jan 30, 2023 at 5:23 PM houzj.f...@fujitsu.com
> wrote:
> >
> > On Monday, January 30, 2023 12:13 PM Peter Smith
> wrote:
> > >
> > > Here are my review comments for v88-0002.
> >
> > Thanks for your comments.
> >
> > >
> > > =
On Mon, Jan 30, 2023 at 02:57:13PM +0900, Michael Paquier wrote:
> 1) means more test cycles, and perhaps we could enforce compression of
> WAL while on it? At the end, my vote would just go for 3) and drop
> the whole scenario, though there may be an argument in 1).
And actually I was under the
On Tue, Jan 24, 2023 at 07:37:29PM -0600, Justin Pryzby wrote:
> BTW, I didn't realize it when I made the suggestion, nor when I wrote
> the patch, but a GUC was implemented in the v2 patch.
> https://www.postgresql.org/message-id/TU4PR8401MB1152CB4FEB99658BC6B35543EECF9%40TU4PR8401MB1152.NAMPRD84
Thank you Justin. I started a new thread because the context is a little
bit different. I am no longer interested in statistics anymore. I want to
find exact individual pages of a table which are cached and are/aren't
dirty. pg_buffercache implements the loop, but it goes over all the
buffers. Howe
At Mon, 30 Jan 2023 14:24:31 +0530, Amit Kapila wrote
in
> On Mon, Jan 30, 2023 at 12:38 PM Kyotaro Horiguchi
> wrote:
> >
> > At Mon, 30 Jan 2023 11:56:33 +0530, Amit Kapila
> > wrote in
> > > #define TimestampTzPlusMilliseconds(tz,ms) ((tz) + ((ms) * (int64) 1000))
> >
> > Which can lead to
On Mon, Jan 30, 2023 at 11:46:06AM +0100, Peter Eisentraut wrote:
> Either that or src/backend/nodes/README.
The README holds nothing about the node attributes currently, so
nodes.h feels most adapted here at the end..
Thanks,
--
Michael
signature.asc
Description: PGP signature
On Tue, Jan 31, 2023 at 2:10 PM Anton A. Melnikov wrote:
> Also checked for a few hours that the patch 0002 fixes this error,
> but there are some questions to its logical structure.
Hi Anton,
Thanks for looking!
> The equality between the previous and newly calculated crc is checked only
> if
Thanks for the updates to address all of my previous review comments.
Patch v90-0001 LGTM.
--
Kind Reagrds,
Peter Smith.
Fujitsu Australia
On Mon, Jan 30, 2023 at 9:41 PM Masahiko Sawada wrote:
>
> On Mon, Jan 30, 2023 at 8:30 PM Amit Kapila wrote:
> >
> > On Fri, Jan 27, 2023 at 4:31 PM Hayato Kuroda (Fujitsu)
> > wrote:
> > >
> > > Thank you for making the patch! I'm still considering whether this
> > > approach is
> > > correct
On Tue, Jan 31, 2023 at 4:25 AM Tom Lane wrote:
>
> Peter Smith writes:
> > I'd forgotten about the 'streaming' option -- AFAIK this was
> > previously a boolean parameter and so its [= value] part can also be
> > omitted. However, in PG16 streaming became an enum type
> > (on/off/parallel), and
Per:
```
select ts_debug('english', 'you''re a star');
ts_debug
---
(asciiword,"Word, all ASCII",you,{english_stem},english_stem,{})
(blank,"Space symbols",',{},,)
(asciiword,"Word, all ASCII",re,
On Mon, Jan 30, 2023 at 11:48:45AM +0100, Peter Eisentraut wrote:
> I'm going to set this thread as "Ready for Committer". Either wait a bit
> for more feedback on this topic, or just go ahead with either solution. We
> can leave it as a semi-open item for reconsideration later.
All the measurem
On 2023/01/29 19:31, Etsuro Fujita wrote:
I agree that if the name of an existing function was bad, we should
rename it, but I do not think the name pgfdw_get_cleanup_result is
bad; I think it is good in the sense that it well represents what the
function waits for.
The patch you proposed cha
On Tue, Jan 31, 2023 at 11:12 AM Masahiko Sawada wrote:
>
> On Mon, Jan 30, 2023 at 9:41 PM Masahiko Sawada wrote:
>
> I've attached patches for HEAD and backbranches. Please review them.
>
Shall we add a comment like the one below in
ReplicationSlotsComputeRequiredXmin()?
diff --git a/src/backe
On Tue, Jan 31, 2023 at 3:56 PM Amit Kapila wrote:
>
> On Tue, Jan 31, 2023 at 11:12 AM Masahiko Sawada
> wrote:
> >
> > On Mon, Jan 30, 2023 at 9:41 PM Masahiko Sawada
> > wrote:
> >
> > I've attached patches for HEAD and backbranches. Please review them.
> >
>
> Shall we add a comment like t
Dear Horiguchi-san,
> I'm not sure. I think that int is generally thought that it is tied
> with an integer type of any size. min_apply_delay is tightly bond
> with a catalog column of int32 thus I thought that (PG_)INT32_MAX is
> the right limit. So, as I expressed before, if we assume sizeof(i
On 30.01.23 20:04, Aleksander Alekseev wrote:
I would appreciate it if you could help figuring out how to do this
for MacPorts, since I'm not a MacPorts user. I'll figure out how to do
this for Homebrew.
I'm on macOS Monterey and Homebrew. I'm sure I have gone through many
variations of this
On Mon, Jan 30, 2023 at 4:07 PM Tom Lane wrote:
> Gurjeet Singh writes:
> > [ generate_series_with_timezone.v6.patch ]
>
> The cfbot isn't terribly happy with this. It looks like UBSan
> is detecting some undefined behavior. Possibly an uninitialized
> variable?
It was the classical case of ou
On Mon, Jan 30, 2023 at 11:50 PM Gurjeet Singh wrote:
> It was the classical case of out-of-bounds access.
> This mistake would've been caught early if there were assertions
> preventing access beyond the number of arguments passed to the
> function. I'll send the assert_enough_args.patch, that a
101 - 119 of 119 matches
Mail list logo
