Re: Add 64-bit XIDs into PostgreSQL 15

Hi; Trying to discuss where we are talking past eachother. On Fri, Nov 25, 2022 at 9:38 AM Aleksander Alekseev < aleksan...@timescale.com> wrote: > Hi hackers, > > > I'm wondering whether the safest way to handle this is by creating a > > new TAM called "heap64", so that all storage changes

Re: [PATCH] Allow specification of custom slot for custom nodes

2022年11月22日(火) 5:50 Alexander Korotkov : > > On Mon, Nov 21, 2022 at 4:34 PM Pavel Borisov wrote: > > The following review has been posted through the commitfest application: > > make installcheck-world: tested, passed > > Implements feature: tested, passed > > Spec compliant: not

Re: Avoid streaming the transaction which are skipped (in corner cases)

On Sat, Nov 26, 2022 at 10:59 AM Dilip Kumar wrote: > > On Fri, Nov 25, 2022 at 4:04 PM Ashutosh Bapat > wrote: > > > > Excellent catch. We were looking at this code last week and wondered > > the purpose of this abort. Probably we should have some macro or > > function to decided whether to skip

Re: postgres_fdw: batch inserts vs. before row triggers

On Sat, Nov 26, 2022 at 1:57 AM Tom Lane wrote: > I don't think the committed patch is acceptable at all, at least > not in the back branches, because it creates a severe ABI break. > Specifically, by adding a field to ResultRelInfo you have changed > the array stride of es_result_relations, and t

Re: Avoid distributing new catalog snapshot again for the transaction being decoded.

On Fri, Nov 25, 2022 at 5:30 PM Ashutosh Bapat wrote: > > Hi Hou, > Thanks for the patch. With a simple condition, we can eliminate the > need to queueing snapshot change in the current transaction and then > applying it. Saves some memory and computation. This looks useful. > > When the queue sna

Re: Small miscellaneous fixes

Em sex., 25 de nov. de 2022 às 22:21, Michael Paquier escreveu: > On Fri, Nov 25, 2022 at 01:15:40PM +0100, Peter Eisentraut wrote: > > Is this something you want to follow up on, since you were involved in > that > > patch? Is the redundant assignment simply to be deleted, or do you want > to >

Re: MSVC vs Perl

On 2022-11-25 Fr 18:52, Andrew Dunstan wrote: > On 2022-11-25 Fr 18:48, Andrew Dunstan wrote: >> For various reasons (see below) it's preferable to build on Windows with >> Strawberry Perl. This works OK if you're building with Msys2, I upgraded >> the instance on the machine that runs fairywren

Re: postgres_fdw: batch inserts vs. before row triggers

Etsuro Fujita writes: > On Sat, Nov 26, 2022 at 1:57 AM Tom Lane wrote: >> Couldn't we add the field to ModifyTableState, instead? > We could probably do so, but I thought having a global list would be > more efficient to handle pending buffered inserts than that. OK, as long as there's a reaso

Re: CI and test improvements

[ resending to -hackers because of list issues ] On 2022-05-28 Sa 11:37, Justin Pryzby wrote: > I'm "joining" a bunch of unresolved threads hoping to present them better > since > they're related and I'm maintaining them together anyway. > > https://www.postgresql.org/message-id/flat/202202192341

Re: Decoupling antiwraparound autovacuum from special rules around auto cancellation

On Fri, 2022-11-25 at 14:47 -0800, Peter Geoghegan wrote: > Attached WIP patch invents the idea of a regular autovacuum that is > tasked with advancing relfrozenxid -- which is really just another > trigger criteria, reported on in the server log in its autovacuum > reports. Of course we retain the

Re: Decoupling antiwraparound autovacuum from special rules around auto cancellation

On Sat, Nov 26, 2022 at 9:58 AM Laurenz Albe wrote: > The target is a table that receives no DML at all, right? Sort of, but not really. The target is a table that doesn't get vacuumed for any other reason -- I don't make any claims beyond that one. It seems a little too optimistic to suppose th

Re: TAP output format in pg_regress

В письме от пятница, 25 ноября 2022 г. 00:20:01 MSK пользователь Daniel Gustafsson написал: + /* + * The width of the testname field when printing to ensure vertical alignment + * of test runtimes. Thius number i

Re: User functions for building SCRAM secrets

On 11/16/22 10:09 PM, Michael Paquier wrote: On Thu, Nov 10, 2022 at 11:14:34PM -0500, Jonathan S. Katz wrote: On 10/31/22 8:56 PM, Michael Paquier wrote: Well, one could pass a salt based on something generated by random() to emulate what we currently do in the default case, as well. The salt

pg_regress: Treat child process failure as test failure

In the thread about TAP format out in pg_regress, Andres pointed out [0] that we allow a test to pass even if the test child process failed. While its probably pretty rare to have a test pass if the process failed, this brings a risk for false positives (and it seems questionable that any regress

Re: TAP output format in pg_regress

> On 26 Nov 2022, at 20:37, Nikolay Shaplov wrote: > В письме от пятница, 25 ноября 2022 г. 00:20:01 MSK пользователь Daniel > Gustafsson написал: > "Thius" seems to be a typo :-) Correct, fixed in the attached. > + #define bail_noatexit(...) bail_out(true, __VA_ARGS__) > > BTW what does "noa

Re: pg_regress: Treat child process failure as test failure

Hi, On 2022-11-26 21:11:39 +0100, Daniel Gustafsson wrote: > In the thread about TAP format out in pg_regress, Andres pointed out [0] that > we allow a test to pass even if the test child process failed. While its > probably pretty rare to have a test pass if the process failed, this brings a > r

Re: MSVC vs Perl

Hi, On 2022-11-26 09:43:19 -0500, Andrew Dunstan wrote: > OK, so this cures the problem for drongo: > > > diff --git a/src/tools/msvc/Mkvcbuild.pm b/src/tools/msvc/Mkvcbuild.pm > index 83a3e40425..dc6b94b74f 100644 > --- a/src/tools/msvc/Mkvcbuild.pm > +++ b/src/tools/msvc/Mkvcbuild.pm > @@ -707

Re: Decouple last important WAL record LSN from WAL insert locks

Hi, On 2022-11-23 19:12:07 +0530, Bharath Rupireddy wrote: > While working on something else, I noticed that each WAL insert lock > tracks its own last important WAL record's LSN (lastImportantAt) and > both the bgwriter and checkpointer later computes the max > value/server-wide last important WA

Re: Allow processes to reset procArrayGroupNext themselves instead of leader resetting for all the followers

Hi, On 2022-11-24 10:43:46 +0530, Bharath Rupireddy wrote: > While working on something else, I noticed that the proc array group > XID clearing leader resets procArrayGroupNext of all the followers > atomically along with procArrayGroupMember. ISTM that it's enough for > the followers to exit the

Re: MSVC vs Perl

On 2022-11-26 Sa 16:05, Andres Freund wrote: > Hi, > > On 2022-11-26 09:43:19 -0500, Andrew Dunstan wrote: >> OK, so this cures the problem for drongo: >> >> >> diff --git a/src/tools/msvc/Mkvcbuild.pm b/src/tools/msvc/Mkvcbuild.pm >> index 83a3e40425..dc6b94b74f 100644 >> --- a/src/tools/msvc/Mk

Re: pg_regress: Treat child process failure as test failure

> On 26 Nov 2022, at 21:55, Andres Freund wrote: > On 2022-11-26 21:11:39 +0100, Daniel Gustafsson wrote: >> The attached makes child failures an error condition for the test as a belts >> and suspenders type check. Thoughts? > > I wonder if it's the right thing to treat a failed psql that's the

CF 2022-11: entries "Waiting for Committer" but no recent activity

Hi Apologies for the intermission in activity, among other "fun" things had a family visitation of the influenza virus, which is becoming fashionable in these parts again. In an attempt to salvage something from the situation I am having a crack at the older entries marked "Ready for Committer",

Re: CF 2022-11: entries "Waiting for Committer" but no recent activity

On 11/27/22 01:43, Ian Lawrence Barwick wrote: > ... > Faster pglz compression (2021-11-17) > > > - https://commitfest.postgresql.org/40/2897/ > - > https://www.postgresql.org/message-id/flat/fef3dc5e-4bc4-44e1-8deb-dadc67046...@yandex-team.ru > > This one,

Removing another gen_node_support.pl special case

I got confused about how we were managing EquivalenceClass pointers in the copy/equal infrastructure, and it took me awhile to remember that the reason it works is that gen_node_support.pl has hard-wired knowledge about that. I think that's something we'd be best off dropping in favor of explicit

Re: Add tracking of backend memory allocated to pg_stat_activity

Code rebased to current master. Updated to incorporate additional recommendations from the the list - add units to variables in view - remove 'backend_' prefix from variables/functions - update documentation - add functional test for allocated_bytes - refactor allocation reporting to

Re: Add tracking of backend memory allocated to pg_stat_activity

On Wed, 2022-11-09 at 09:23 -0500, Reid Thompson wrote: > Hi Melanie, > Thank you for looking at this and for the feedback. Responses inline > below. > > On Mon, 2022-11-07 at 16:17 -0500, Melanie Plageman wrote: > > > > It doesn't seem like you need the backend_ prefix in the view since > > that

Re: Add tracking of backend memory allocated to pg_stat_activity

On Wed, 2022-11-09 at 08:54 -0500, Reid Thompson wrote: > Hi Andres, > Thanks for looking at this and for the feedback. Responses inline > below. > >> On Fri, 2022-11-04 at 19:41 -0700, Andres Freund wrote: > > Hi, > > > On 2022-11-04 08:56:13 -0400, Reid Thompson wrote: > > > > I'm not convince

Re: Add the ability to limit the amount of memory that can be allocated to backends.

On Thu, 2022-11-03 at 11:48 -0400, Reid Thompson wrote: > On Tue, 2022-10-25 at 11:49 -0400, Reid Thompson wrote: > > Rebased to current. Add a couple changes per conversation with D > Christensen (include units in field name, group field with > backend_xid > and backend_xmin fields in pg_stat_acti

RE: Perform streaming logical transactions by background workers and parallel apply

On Friday, November 25, 2022 10:54 AM Peter Smith wrote: > > Here are some review comments for v51-0001. Thanks for the comments! > == > > .../replication/logical/applyparallelworker.c > > 1. General - Error messages, get_worker_name() > > I previously wrote a comment to ask if the get_wo

RE: Perform streaming logical transactions by background workers and parallel apply

On Tuesday, November 22, 2022 9:53 PM Kuroda, Hayato wroteL > > Thanks for updating the patch! > I tested the case whether the deadlock caused by foreign key constraint could > be detected, and it worked well. > > Followings are my review comments. They are basically related with 0001, but > so

CF 2022-11: entries "Ready for Committer" with recent activity

Hi This is an overview of the current patches marked "Ready for Committer" which have been actively worked on during the current CF. They largely fall into two categories: - active participation from likely committers - have been reviewed and marked as "RfC", but need committer interest Dates in

Re: Small miscellaneous fixes

On Sat, Nov 26, 2022 at 11:30:07AM -0300, Ranier Vilela wrote: > Thank you Michael, for taking care of it. (As of 1e31484, after finishing the tests I wanted.) -- Michael signature.asc Description: PGP signature

Re: Reducing power consumption on idle servers

2022年11月22日(火) 5:50 Laurenz Albe : > > On Mon, 2022-11-21 at 12:11 -0500, Tom Lane wrote: > > Robert Haas writes: > > > The reason that I pushed back -- not as successfully as I would have > > > liked -- on the changes to pg_stop_backup / pg_start_backup is that I > > > know there are people using

Re: User functions for building SCRAM secrets

On 11/26/22 2:53 PM, Jonathan S. Katz wrote: On 11/16/22 10:09 PM, Michael Paquier wrote: git diff --check reports some whitespaces. Ack. Will fix on the next pass. (I've been transitioning editors, which could have resulted in that), Fixed (and have run that check subsequently). scram_

Re: Add tracking of backend memory allocated to pg_stat_activity

On Sat, 2022-11-26 at 22:10 -0500, Reid Thompson wrote: > Code rebased to current master. > Updated to incorporate additional recommendations from the the list >    - add units to variables in view >    - remove 'backend_' prefix from variables/functions >    - update documentation >    - add funct

Re: Avoid streaming the transaction which are skipped (in corner cases)

On Sat, Nov 26, 2022 at 12:15 PM Amit Kapila wrote: > > On Fri, Nov 25, 2022 at 5:38 PM Amit Kapila wrote: > > > > On Fri, Nov 25, 2022 at 1:35 PM Dilip Kumar wrote: > > > > > > During DecodeCommit() for skipping a transaction we use ReadRecPtr to > > > check whether to skip this transaction or

Re: Allow file inclusion in pg_hba and pg_ident files

2022年11月25日(金) 11:25 Julien Rouhaud : > > On Fri, Nov 25, 2022 at 07:41:59AM +0900, Michael Paquier wrote: > > On Thu, Nov 24, 2022 at 05:07:24PM +0800, Julien Rouhaud wrote: > > > So I went with CONF_FILE_START_DEPTH and CONF_FILE_MAX_DEPTH. Attached > > > v22 > > > that fixes it in all the plac

Re: Allow file inclusion in pg_hba and pg_ident files

Le dim. 27 nov. 2022 à 15:31, Ian Lawrence Barwick > > I'm trying to reconcile open CommitFest entries with their actual > status; the entry for this: > > https://commitfest.postgresql.org/40/3558/ > > shows as "Waiting on Author", but looks like it's all been committed; > is there anything > le