Re: Non-decimal integer literals

2022-11-22 Thread John Naylor
On Tue, Nov 22, 2022 at 8:36 PM Peter Eisentraut < peter.eisentr...@enterprisedb.com> wrote: > > On 15.11.22 11:31, Peter Eisentraut wrote: > > On 14.11.22 08:25, John Naylor wrote: > >> Regarding the patch, it looks good overall. My only suggestion would > >> be to add a regression test for just b

Re: Collation version tracking for macOS

2022-11-22 Thread Thomas Munro
On Tue, Nov 22, 2022 at 7:34 PM Jeff Davis wrote: > On Sat, 2022-10-22 at 14:22 +1300, Thomas Munro wrote: > > Problem 2: If ICU 67 ever decides to report a different version for > > a > > given collation (would it ever do that? I don't expect so, but ...), > > we'd be unable to open the collati

Re: pg_stat_bgwriter.buffers_backend is pretty meaningless (and more?)

2022-11-22 Thread Justin Pryzby
Note that 001 fails to compile without 002: ../src/backend/storage/buffer/bufmgr.c:1257:43: error: ‘from_ring’ undeclared (first use in this function) 1257 | StrategyRejectBuffer(strategy, buf, from_ring)) My "warnings" script informed me about these gripes from MSVC: [03:42:30.607] c:\c

Re: Allow file inclusion in pg_hba and pg_ident files

2022-11-22 Thread Michael Paquier
On Tue, Nov 22, 2022 at 05:20:01PM +0900, Michael Paquier wrote: > + /* XXX: this should stick to elevel for some cases? */ > + ereport(LOG, > + (errmsg("skipping missing authentication file \"%s\"", > + inc_fullname))); > Should we always issue a LOG here?

Re: Introduce a new view for checkpointer related stats

2022-11-22 Thread Bharath Rupireddy
On Wed, Nov 23, 2022 at 2:23 AM Andres Freund wrote: > > On 2022-11-22 18:08:28 +0530, Bharath Rupireddy wrote: > > > > CREATE VIEW pg_stat_bgwriter AS > > SELECT > > -pg_stat_get_bgwriter_timed_checkpoints() AS checkpoints_timed, > > -pg_stat_get_bgwriter_requested_checkpoin

Re: odd buildfarm failure - "pg_ctl: control file appears to be corrupt"

2022-11-22 Thread Michael Paquier
On Tue, Nov 22, 2022 at 05:42:24PM -0800, Andres Freund wrote: > The failure has to be happening in wait_for_postmaster_promote(), because the > standby2 is actually successfully promoted. That's the one under -fsanitize=address. It really smells to me like a bug with a race condition all over it

Help running 010_tab_completion.pl on windows

2022-11-22 Thread Kirk Wolak
I have psql working with readline (roughly) in windows 10! in my attempt to test it... >> 1..0 # SKIP IO::Pty is needed to run this test I would like to run these tests to see how far off I am... (Randomly typing sql and squealing like a child has its limits) I have built this using VS 2022 Com

Re: Documentation for building with meson

2022-11-22 Thread Justin Pryzby
On Mon, Nov 14, 2022 at 10:41:21AM -0800, samay sharma wrote: > You need LZ4, if you want to support compression of data with that > method; see default_toast_compression and wal_compression. => The first comma is odd. Maybe it should say "LZ4 is needed to support .." > You need Zstandard, if

Re: Prefetch the next tuple's memory during seqscans

2022-11-22 Thread sirisha chamarthi
On Tue, Nov 22, 2022 at 1:58 PM David Rowley wrote: > On Thu, 3 Nov 2022 at 06:25, Andres Freund wrote: > > Attached is an experimental patch/hack for that. It ended up being more > > beneficial to make the access ordering more optimal than prefetching the > tuple > > contents, but I'm not at al

Re: Prefetch the next tuple's memory during seqscans

2022-11-22 Thread David Rowley
On Wed, 23 Nov 2022 at 20:29, sirisha chamarthi wrote: > I ran your test1 exactly like your setup except the row count is 300 > (with 13275 blocks). Shared_buffers is 128MB and the hardware configuration > details at the bottom of the mail. It appears Master + 0001 + 0005 regressed > compar

drop postmaster symlink

2022-11-22 Thread Peter Eisentraut
A little while ago we discussed briefly over in the meson thread whether we could remove the postmaster symlink [0]. The meson build system currently does not install a postmaster symlink. (AFAICT, the MSVC build system does not either.) So if we want to elevate the meson build system, we ei

Re: Allow file inclusion in pg_hba and pg_ident files

2022-11-22 Thread Julien Rouhaud
Hi, Sorry for the very late answer, I had quite a lot of other things going on recently. And thanks for taking care of the patchset! On Wed, Nov 23, 2022 at 03:05:18PM +0900, Michael Paquier wrote: > On Tue, Nov 22, 2022 at 05:20:01PM +0900, Michael Paquier wrote: > > + /* XXX: this should s

Re: New docs chapter on Transaction Management and related changes

2022-11-22 Thread Laurenz Albe
On Tue, 2022-11-22 at 13:50 -0500, Bruce Momjian wrote: > Agreed, updated patch attached. I cannot find any more problems, and I shouldn't mention the extra empty line at the end of the patch. I'd change the commitfest status to "ready for committer" now if it were not already in that status. Yo

<    1   2