Re: CI and test improvements

Hi, On 2022-11-16 21:58:39 -0600, Justin Pryzby wrote: > On Wed, Nov 16, 2022 at 07:48:14PM -0800, Andres Freund wrote: > > I've used this a bunch on personal branches, and I think it's the way to > > go. It doesn't take long, saves a lot of cycles when one pushes something > > broken. Starts to r

Re: CI and test improvements

On Wed, Nov 16, 2022 at 08:08:32PM -0800, Andres Freund wrote: > I also don't like my "cores_script". Not quite sure yet how to do that > more cleanly. I don't know which is cleaner: ls /core* && mv /tmp/core* /tmp/cores find / -maxdepth 1 -type f -name 'core*' -print0 | xargs -r0 mv -vt

Re: pglz compression performance, take two

2021年11月5日(金) 14:51 Andrey Borodin : > > Thanks for the review Mark! Sorry it took too long to reply on my side. > > > 28 июня 2021 г., в 21:05, Mark Dilger > > написал(а): > > > >> #define PGLZ_HISTORY_SIZE 0x0fff - 1 /* to avoid compare in > >> iteration */ > > ... > >> static PGLZ_Hist

Re: Parallel Full Hash Join

2022年4月8日(金) 20:30 Thomas Munro : > > On Wed, Jan 12, 2022 at 10:30 AM Melanie Plageman > wrote: > > On Fri, Nov 26, 2021 at 3:11 PM Thomas Munro wrote: > > > #3 0x009cf57e in ExceptionalCondition (conditionName=0x29cae8 > > > "BarrierParticipants(&accessor->shared->batch_barrier) == 1",

Re: ps command does not show walsender's connected db

2022年10月11日(火) 20:06 Bharath Rupireddy : > > On Tue, Oct 11, 2022 at 2:11 PM bt22nakamorit > wrote: > > > > 2022-10-10 16:12 Bharath Rupireddy wrote: > > > Thanks. LGTM. > > Thank you for your review! > > I have this issue posted on Commitfest 2022-11 with title "show > > walsender's connected db

Re: predefined role(s) for VACUUM and ANALYZE

On Wed, Nov 16, 2022 at 03:09:47PM -0500, Andrew Dunstan wrote: > OK, reading the history I think everyone is on board with expanding > AclMode from uint32 to uint64. Is that right? I skimmed through this thread again, and AFAICT folks are okay with this approach. I'm not aware of any remaining c

Re: Assertion failure in SnapBuildInitialSnapshot()

On Wed, Nov 16, 2022 at 11:56 PM Andres Freund wrote: > > On 2022-11-16 14:22:01 +0530, Amit Kapila wrote: > > On Wed, Nov 16, 2022 at 7:30 AM Andres Freund wrote: > > > > > > On 2022-11-15 16:20:00 +0530, Amit Kapila wrote: > > > > On Tue, Nov 15, 2022 at 8:08 AM Andres Freund > > > > wrote: >

RE: Fix the README file for MERGE command

Hi Richard, Thank you for your time. Best Regards, Myo Wai Thant From: Richard Guo Sent: Thursday, November 17, 2022 10:31 AM To: Myo, Waithant/Ｍｙｏ Ｗ． Cc: pgsql-hackers@lists.postgresql.org Subject: Re: Fix the README file for MERGE command On Wed, Nov 16, 2022 at 4:37 PM Waithant Myo (Fujits

Re: Data is copied twice when specifying both child and parent table in publication

On Wed, 16 Nov 2022 at 14:28, wangw.f...@fujitsu.com wrote: > > On Mon, Nov 14, 2022 at 0:56 AM vignesh C wrote: > > > > > > Attach new patches. > > > > Thanks for your comments. > > > Here we are having tables list to store the relids and table_infos > > list which stores pubid along with relid.

Re: Supporting TAP tests with MSVC and Windows

On Mon, Aug 22, 2022 at 09:44:42AM -0400, Andrew Dunstan wrote: > On 2022-08-21 Su 20:40, Noah Misch wrote: > > This (commit 13d856e of 2015-07-29) added the following: > > > > --- a/src/test/perl/TestLib.pm > > +++ b/src/test/perl/TestLib.pm > > @@ -242,7 +288,17 @@ sub command_exit_is > > pri

Re: Add LSN along with offset to error messages reported for WAL file read/write/validate header failures

On Wed, Nov 16, 2022 at 6:55 PM Maxim Orlov wrote: > >> These functions are marked as 'STRICT', meaning a null is returned, >> without even calling the function, if any of the input parameters is >> null. I think we can keep the behaviour the same as its friends. > > Thanks for the explanations. I

Re: Assertion failure in SnapBuildInitialSnapshot()

On Wed, Nov 16, 2022 at 11:56 PM Andres Freund wrote: > > On 2022-11-16 14:22:01 +0530, Amit Kapila wrote: > > On Wed, Nov 16, 2022 at 7:30 AM Andres Freund wrote: > > > > > > On 2022-11-15 16:20:00 +0530, Amit Kapila wrote: > > > > On Tue, Nov 15, 2022 at 8:08 AM Andres Freund > > > > wrote: >

Re: Fix order of checking ICU options in initdb and create database

On 29.10.22 15:09, Marina Polyakova wrote: On 2022-10-29 14:33, Marina Polyakova wrote: Hello! This is the last proposed patch on this subject [1] moved to a separate thread for Commitfest.. Also added a patch to export with_icu when running src/bin/scripts tests [1]. I have committed the

Re: Fix order of checking ICU options in initdb and create database

On 29.10.22 13:33, Marina Polyakova wrote: 2. initdb/create database report problems with the ICU locale/encoding although they may already report that ICU is not supported in this build: 2.1. $ initdb --locale-provider icu hoge ... initdb: error: ICU locale must be specified $ initdb --local

Re: Assertion failure with barriers in parallel hash join

Hi Thomas, Can we make progress with this patch in the current commit fest, or discuss what is still missing to bring this in? Thanks! -- David Geier (ServiceNow) On 6/6/22 17:01, David Geier wrote: Hi Thomas, Correct. We're running with disabled parallel leader participation and we have

Typo for xl_running_xacts

Hi, hackers I find some typo about xl_running_xacts in comments. Attached a patch to fix those. -- Regrads, Japin Li. ChengDu WenWu Information Technology Co.,Ltd. diff --git a/src/backend/replication/logical/snapbuild.c b/src/backend/replication/logical/snapbuild.c index 5006a5c464..44d94bf65

Re: Parallel Full Hash Join

On Thu, Nov 17, 2022 at 5:22 PM Ian Lawrence Barwick wrote: > This patch is marked as "Waiting for Committer" in the current commitfest [1] > with yourself as committer; do you have any plans to move ahead with this? Yeah, sorry for lack of progress. Aiming to get this in shortly.

Re: when the startup process doesn't (logging startup delays)

On Thu, Nov 17, 2022 at 12:21 AM Robert Haas wrote: > > On Wed, Nov 16, 2022 at 1:47 AM Bharath Rupireddy > wrote: > > That can be done, only if we can disable the timeout in another place > > when the StandbyMode is set to true in ReadRecord(), that is, after > > the standby server finishes cras

Odd behavior with pg_stat_statements and queries called from SQL functions

I noticed an odd behavior today in pg_stat_statements query normalization for queries called from SQL-language functions. If I have three functions that call an essentially identical query (the functions are only marked SECURITY DEFINER to prevent inlining): maciek=# create or replace function f1(

Re: ubsan fails on 32bit builds

Hi, On 2022-11-16 17:42:30 -0800, Andres Freund wrote: > Afaict the problem is that > proc = (PGPROC *) &(waitQueue->links); > > is a gross gross hack - this isn't actually a PGPROC, it's pointing to an > SHM_QUEUE, but *not* one embedded in PGPROC. It kinda works because ->links >

Re: Assertion failure with barriers in parallel hash join

On Thu, Nov 17, 2022 at 8:01 PM David Geier wrote: > Can we make progress with this patch in the current commit fest, or discuss > what is still missing to bring this in? Hi David, Sorry for the delay. I'll aim to get this done in the next few days.

Re: Reducing power consumption on idle servers

On Wed, Nov 16, 2022 at 8:35 PM Simon Riggs wrote: > > On Wed, 16 Nov 2022 at 12:47, Bharath Rupireddy > wrote: > > > > On Wed, Nov 16, 2022 at 2:34 PM Simon Riggs > > wrote: > > > > > > Reposting v6 now so that patch tester doesn't think this has failed > > > when the patch on other thread gets

RE: Data is copied twice when specifying both child and parent table in publication

On Thurs, Nov 17, 2022 at 13:58 PM vignesh C wrote: > On Wed, 16 Nov 2022 at 14:28, wangw.f...@fujitsu.com > wrote: > > > > On Mon, Nov 14, 2022 at 0:56 AM vignesh C wrote: > > > > > > > > Attach new patches. > > > > > > > Thanks for your comments. > > > > > Here we are having tables list to sto

Re: Reducing power consumption on idle servers

On Thu, 17 Nov 2022 at 07:36, Bharath Rupireddy wrote: > > promote_trigger_file is not tested and there are better ways, so > > deprecating it in this release is fine. > > Hm, but.. > > > Anyone that relies on it can update their mechanisms to a supported > > one with a one-line change. Realistic

<    1   2