On Thu, Sep 01, 2022 at 08:42:15AM -0300, Ranier Vilela wrote:
> Let's wait for the patch to be accepted and committed, so we can try to
> change it.
FWIW, I think that this switch is a good idea for cases where we
potentially update a bunch of tuples, especially based on what
CatalogTupleInsert()
On Thu, Nov 10, 2022 at 04:01:02PM +0900, Michael Paquier wrote:
> I have looked at what you have here..
The comment at the top of SimpleLruInit() for sync_handler has been
fixed as of 5ca3645, and backpatched. Nice catch.
--
Michael
signature.asc
Description: PGP signature
On Thu, Nov 10, 2022 at 1:31 AM David Christensen
wrote:
>
Thanks for providing the v7 patch, please see my comments and responses below.
> > 2. I'm unable to understand the use-case for --fixup-fpi option.
> > pg_waldump is supposed to be just WAL reader, and must not return any
> > modified in
Hello all,
Meson doesn't see the redefinition of locale_t done
in src/include/port/win32_port.h, so is not defining
HAVE_LOCALE_T, HAVE_WCSTOMBS_L nor HAVE_MBSTOWCS_L as the
current src/tools/msvc/build.pl script does.
Please find attached a patch for so.
Regards,
Juan José Santamaría Flecha
On Wed, Nov 9, 2022 at 12:02 AM Juan José Santamaría Flecha <
juanjo.santama...@gmail.com> wrote:
> On Mon, Nov 7, 2022 at 4:08 PM Peter Eisentraut <
> peter.eisentr...@enterprisedb.com> wrote:
>
>>
>> This looks pretty good to me. The refactoring of the non-Windows parts
>> makes sense. The Win
On Thu, Aug 25, 2022 at 6:27 PM Richard Guo wrote:
> I'm not sure if I understand it correctly. If we are given the first
> order from the parser, the SpecialJoinInfo for the B/C join would have
> min_lefthand as containing both B and the A/B join. And this
> SpecialJoinInfo would make the B/C jo
On Mon, Apr 18, 2022 at 9:10 AM vignesh C wrote:
>
> The attached v21 patch has the changes for the same.
Thanks for the patch. Here are some comments:
1. I think there's a fundamental problem with this patch, that is, it
prints the backtrace when the interrupt is processed but not when
interrup
Hi,
Thomas has reported this failure in an email [1] and shared the
following links offlist with me:
https://cirrus-ci.com/task/5311549010083840
https://api.cirrus-ci.com/v1/artifact/task/5311549010083840/testrun/build/testrun/subscription/100_bugs/log/100_bugs_twoways.log
https://api.cirrus-ci.co
On Wed, Nov 9, 2022 at 2:37 AM Amit Kapila wrote:
> On Fri, Nov 4, 2022 at 1:40 PM sirisha chamarthi
> wrote:
> >
> Is the intent of setting restart_lsn to InvalidXLogRecPtr was to
> disallow reviving the slot?
> >
>
> I think the intent is to compute the correct value for
> replicationSlotMinL
On Wed, Nov 9, 2022 at 12:32 AM Kyotaro Horiguchi
wrote:
> I don't think walsenders fetching segment from archive is totally
> stupid. With that feature, we can use fast and expensive but small
> storage for pg_wal, while avoiding replciation from dying even in
> emergency.
>
Thanks! If there is
Hi! Do this patch still need reviewer, or reviewer field in commit-fest have
been left empty by mistake?
I am fan of TAP-tests, so I am quite happy that pg_regress output changed to
TAP tests...
I've checked new output, if is conform TAP specification. Checked that prove
consumes new pg_regres
On 2022-Nov-10, Laurenz Albe wrote:
> On Wed, 2022-11-09 at 09:16 -0500, Robert Treat wrote:
> > > > - If AND CHAIN is specified, a new transaction
> > > > is
> > > > + If AND CHAIN is specified, a new unaborted
> > > > transaction is
> > > > immediately started with the same t
On Mon, 7 Nov 2022 at 22:04, Laurenz Albe wrote:
>
> On Sat, 2022-11-05 at 10:08 +, Simon Riggs wrote:
> > Agreed; new compilation patch attached, including mine and then
> > Robert's suggested rewordings.
>
> Thanks. There is clearly a lot of usefule information in this.
>
> Some comments:
>
Em qui., 10 de nov. de 2022 às 05:16, Michael Paquier
escreveu:
> On Thu, Sep 01, 2022 at 08:42:15AM -0300, Ranier Vilela wrote:
> > Let's wait for the patch to be accepted and committed, so we can try to
> > change it.
>
> FWIW, I think that this switch is a good idea for cases where we
> potent
Hello
I've been trying to understand what 0001 does. One thing that strikes
me is that it seems like it'd be easy to have bugs because of modifying
the perminfo list inadequately. I couldn't find any cross-check that
some perminfo element that we obtain for a rte does actually match the
relation
On Wed, 12 Oct 2022 at 10:51, Michael Paquier wrote:
> On Mon, Sep 12, 2022 at 03:18:59PM -0400, Tom Lane wrote:
> > I spun up a 32-bit VM, since that had been on my to-do list anyway,
> > and it looks like I was right:
>
> This feedback has not been addressed and the thread is idle four
> weeks,
On 2022-Oct-06, Amit Langote wrote:
> Actually, List of Bitmapsets turned out to be something that doesn't
> just-work with our Node infrastructure, which I found out thanks to
> -DWRITE_READ_PARSE_PLAN_TREES. So, I had to go ahead and add
> first-class support for copy/equal/write/read support f
On Fri, Nov 4, 2022 at 11:14 AM Masahiko Sawada wrote:
>
> On Thu, Nov 3, 2022 at 7:53 PM Amit Kapila wrote:
> >
> > The comments atop seem to indicate that we always accumulate
> > invalidation messages in top-level transactions which is neither
> > required nor match with the code. This is intr
On 11/9/22 00:13, Justin Pryzby wrote:
> On Mon, Oct 03, 2022 at 10:29:38PM +0200, Tomas Vondra wrote:
>> I'll get this fixed in a couple days. Considering the benign nature of
>> this issue (unnecessary assert) I'm not going to rush.
>
> Is this still an outstanding issue ?
>
Yes. I'll get it f
Hi,
I did some tests on windows. I used 'ninja' as a backend.
On 11/8/2022 9:23 PM, samay sharma wrote:
Hi,
On Sat, Nov 5, 2022 at 2:39 PM Andres Freund wrote:
Hi,
On 2022-10-30 20:51:59 -0700, samay sharma wrote:
> +# setup and enter build directory (done only first time)
>
Hi, hackers
I found that we set the SO_TYPE_ANALYZE option in table_beginscan_analyze()
static inline TableScanDesc
table_beginscan_analyze(Relation rel)
{
uint32 flags = SO_TYPE_ANALYZE;
return rel->rd_tableam->scan_begin(rel, NULL, 0, NULL, NULL, flags);
}
But I didn’t find a
Hello everyone.
Recently when I was running regression tests, I got 'Database
"contrib_regression" does not exist' error. After I reproduce the
problem, I found it is an auto-vacuum worker process who complains about
this error.
Then I tried to analyze the code. When this auto-vacuum worker
On Monday, November 7, 2022 7:43 PM Kuroda, Hayato/黒田 隼人
wrote:
>
> Dear Hou,
>
> The followings are my comments. I want to consider the patch more, but I sent
> it once.
Thanks for the comments.
>
> ===
> worker.c
>
> 01. typedef enum TransApplyAction
>
> ```
> /*
> * What action to take
On Monday, November 7, 2022 4:17 PM Peter Smith
>
> Here are my review comments for v42-0001
Thanks for the comments.
> ==
>
> 28. handle_streamed_transaction
>
> static bool
> handle_streamed_transaction(LogicalRepMsgType action, StringInfo s) {
> - TransactionId xid;
> + TransactionId
Apologies. I made a mistake on my downgrade test.
So 3 should be
3) It is possible to downgrade with the wildcard. For example I had
paths
wildtest--%--2.1.sql
and confirmed it used the downgrade path when going from 2.2 to 2.1
Jingtang Zhang writes:
> Recently when I was running regression tests, I got 'Database
> "contrib_regression" does not exist' error. After I reproduce the
> problem, I found it is an auto-vacuum worker process who complains about
> this error.
That's perfectly normal. I don't see anything to
Hi Michael,
Thanks for the review and also for committing 5ca3645.
> This patch redesigns SimpleLruInit() [...]
> I am not really convinced that this is something that a
> patch aimed at extending testing coverage should redesign, especially
> with a routine as old as that.
> [...] you'd better p
On Thu, Nov 10, 2022 at 2:33 AM Bharath Rupireddy
wrote:
>
> On Thu, Nov 10, 2022 at 1:31 AM David Christensen
> wrote:
> >
>
> Thanks for providing the v7 patch, please see my comments and responses below.
Hi Bharath, Thanks for the feedback.
> > > 2. I'm unable to understand the use-case for
"Regina Obe" writes:
>> I have a distinct sense of deja vu here. I think this idea, or something
>> isomorphic to it, was previously discussed with some other syntax details.
> I found the old discussion I recalled having and Stephen had suggested using
> @extschema{'postgis'}@
> On this thread
>
>
> +if you are reading this prepatorily, please redesign your
> query to use temporary tables or arrays
>
I agree with the documentation of this parameter.
I agree with dissuading anyone from attempting to change it
The wording is bordering on snark (however well deserved) and I think the
v
On 2022-Nov-01, Michael Paquier wrote:
> On Mon, Oct 31, 2022 at 03:14:54PM +0800, Japin Li wrote:
> > For example, since SetCommitTsLimit() is only used in BootStrapXLog() and
> > StartupXLOG(), we can safely remove the code of acquiring/releasing lock?
>
> Logically yes, I guess that you could
On Thu, Nov 10, 2022 at 10:58 AM Corey Huinker
wrote:
>
>> +if you are reading this prepatorily, please redesign your
>> query to use temporary tables or arrays
>>
>
> I agree with the documentation of this parameter.
> I agree with dissuading anyone from attempting to change it
> The wording
>It makes sense to prefer consistency here, I suppose. The reason why
>we're not consistent is because it was easier not to be, which isn't
>exactly the best reason (nor the worst).
Consistency is the key point here. It is odd that a serial
vacuum may skip the remainder of the indexes
> "Regina Obe" writes:
> >> I have a distinct sense of deja vu here. I think this idea, or
> >> something isomorphic to it, was previously discussed with some other
> syntax details.
>
> > I found the old discussion I recalled having and Stephen had suggested
> > using @extschema{'postgis'}@ On
Yugo NAGATA writes:
> Tom Lane wrote:
>> Hmm. Maybe the right way to think about this is "if we have completed an
>> EXECUTE, and not yet received a following SYNC, then report that we are in
>> a transaction block"? But I'm not sure if that breaks any other cases.
> Or, in that case, regardin
Greetings! Long time no see, I know. How are you, Hackers?
I notice from the docs in the Postgres JSONPath type, brackets are described as:
> • Square brackets ([]) are used for array access.
https://www.postgresql.org/docs/current/datatype-json.html#DATATYPE-JSONPATH
Notably they are not us
On Tue, Nov 8, 2022 at 9:28 PM Michael Paquier wrote:
> On Tue, Nov 08, 2022 at 04:57:09PM -0800, Jacob Champion wrote:
> > But I guess that wouldn't really help with ALTER ROLE ... PASSWORD,
> > because you can't parameterize it. Hm...
>
> Yeah, and I'd like to think that this is never something
On Thu, Nov 10, 2022 at 10:20 AM Imseih (AWS), Sami wrote:
> Consistency is the key point here. It is odd that a serial
> vacuum may skip the remainder of the indexes if failsafe
> kicks-in, but in the parallel case it will go through the entire index
> cycle.
Yeah, it's a little inconsistent.
>
I wrote:
> I've not read the patch in any detail, but I don't see a problem
> with the design.
Hearing no push-back on that position, I reviewed and pushed the
patch. You'd missed that it also affects CREATE TABLE, but
otherwise it was in pretty good shape.
regards, tom l
On Tue, Sep 20, 2022 at 3:12 PM Peter Geoghegan wrote:
> Attached is v2, which I'm just posting to keep CFTester happy. No real
> changes here.
Attached is v3. I'd like to move forward with commit soon. I'll do so
in the next few days, barring objections.
v3 has vacuumlazy.c pass NewRelfrozenXid
On Thu, 2022-10-13 at 12:49 -0700, Jeff Davis wrote:
> It may violate our torn page protections for checksums, as well...
I could not reproduce a problem here, but I believe one exists when
checksums are enabled, because it bypasses the protections of
UpdateMinRecoveryPoint(). By not updating the
On Tuesday, November 8, 2022 7:50 PM Amit Kapila
wrote:
> On Mon, Nov 7, 2022 at 6:49 PM houzj.f...@fujitsu.com
> wrote:
> >
> > On Friday, November 4, 2022 7:45 PM Amit Kapila
> wrote:
> > > 3.
> > > apply_handle_stream_start(StringInfo s) { ...
> > > + if (!first_segment)
> > > + {
> > > + /*
On Monday, November 7, 2022 6:18 PM Masahiko Sawada
wrote:
>
> On Thu, Nov 3, 2022 at 10:06 PM houzj.f...@fujitsu.com
> wrote:
> >
> > On Wednesday, November 2, 2022 10:50 AM Masahiko Sawada
> wrote:
> > >
> > > On Mon, Oct 24, 2022 at 8:42 PM Masahiko Sawada
> > > wrote:
> > > >
> > > > On W
At Thu, 10 Nov 2022 15:56:35 +0530, Bharath Rupireddy
wrote in
> On Mon, Apr 18, 2022 at 9:10 AM vignesh C wrote:
> >
> > The attached v21 patch has the changes for the same.
>
> Thanks for the patch. Here are some comments:
>
> 1. I think there's a fundamental problem with this patch, that i
On Thu, Nov 10, 2022 at 04:48:17PM -0800, Peter Geoghegan wrote:
> On Tue, Sep 20, 2022 at 3:12 PM Peter Geoghegan wrote:
> > Attached is v2, which I'm just posting to keep CFTester happy. No real
> > changes here.
>
> Attached is v3. I'd like to move forward with commit soon. I'll do so
> in the
Hi, hackers
Recently, when I read the XidInMVCCSnapshot(), and find there are some
typos in the comments.
diff --git a/src/backend/storage/ipc/procarray.c
b/src/backend/storage/ipc/procarray.c
index 207c4b27fd..9e8b6756fe 100644
--- a/src/backend/storage/ipc/procarray.c
+++ b/src/backend/stora
Note that this fails under -fsanitize=align
Subject: [PATCH v5 2/6] Teach VACUUM to use visibility map snapshot.
performing post-bootstrap initialization ...
../src/backend/access/heap/visibilitymap.c:482:38: runtime error: load of
misaligned address 0x5559e1352424 for type 'uint64', which requi
On 10/31/22 8:56 PM, Michael Paquier wrote:
On Mon, Oct 31, 2022 at 04:27:08PM -0400, Jonathan S. Katz wrote:
1. password only -- this defers to the PG defaults for SCRAM
2. password + salt -- this is useful for the password history / dictionary
case to allow for a predictable way to check a pas
Here are more review comments for the v32-0001 file ddl_deparse.c
This completes my first review pass over this overly large file.
This review has taken a long time, so for any of my review comments
(in this and previous posts) that get rejected, please reply citing
the rejected reference numbers
On Thu, Nov 10, 2022 at 08:56:25AM -0300, Ranier Vilela wrote:
> For CopyStatistics() have performance checks.
You are not giving all the details of your tests, though, so I had a
look with some of my stuff using the attached set of SQL functions
(create_function.sql) to create a bunch of indexes
On Fri, Nov 11, 2022 at 8:56 AM Japin Li wrote:
>
> Recently, when I read the XidInMVCCSnapshot(), and find there are some
> typos in the comments.
>
> diff --git a/src/backend/storage/ipc/procarray.c
> b/src/backend/storage/ipc/procarray.c
> index 207c4b27fd..9e8b6756fe 100644
> --- a/src/backen
On Fri, Nov 11, 2022 at 3:47 PM Peter Smith wrote:
>
> Here are more review comments for the v32-0001 file ddl_deparse.c
>
> *** NOTE - my review post became too big, so I split it into smaller parts.
THIS IS PART 2 OF 4.
===
src/backend/commands/ddl_deparse.c
1. deparse_AlterExtensionStmt
On Thu, Nov 10, 2022 at 06:40:44PM +0300, Aleksander Alekseev wrote:
> Fair enough. PFA the corrected patch v5.
Is there a reason why you need a TAP test here? It is by design more
expensive than pg_regress and it does not require --enable-tap-tests.
See for example what we do for snapshot_too_ol
On Fri, Nov 11, 2022 at 4:09 PM Peter Smith wrote:
>
> On Fri, Nov 11, 2022 at 3:47 PM Peter Smith wrote:
> >
> > Here are more review comments for the v32-0001 file ddl_deparse.c
> >
> > *** NOTE - my review post became too big, so I split it into smaller parts.
>
THIS IS PART 3 OF 4.
===
On Fri, Nov 11, 2022 at 10:39:06AM +0530, Amit Kapila wrote:
> On Fri, Nov 11, 2022 at 8:56 AM Japin Li wrote:
> >
> > Recently, when I read the XidInMVCCSnapshot(), and find there are some
> > typos in the comments.
> >
> > diff --git a/src/backend/storage/ipc/procarray.c
> > b/src/backend/stora
On Fri, Nov 11, 2022 at 4:17 PM Peter Smith wrote:
>
> On Fri, Nov 11, 2022 at 4:09 PM Peter Smith wrote:
> >
> > On Fri, Nov 11, 2022 at 3:47 PM Peter Smith wrote:
> > >
> > > Here are more review comments for the v32-0001 file ddl_deparse.c
> > >
> > > *** NOTE - my review post became too big,
On Thu, Nov 10, 2022 at 4:07 PM sirisha chamarthi
wrote:
>
> On Wed, Nov 9, 2022 at 2:37 AM Amit Kapila wrote:
>>
>> On Fri, Nov 4, 2022 at 1:40 PM sirisha chamarthi
>> wrote:
>> >
>> Is the intent of setting restart_lsn to InvalidXLogRecPtr was to
>> disallow reviving the slot?
>> >
>>
>> I th
On Fri, Oct 21, 2022 at 17:02 PM Peter Smith wrote:
>
Thanks for your comments. Sorry for not replying in time.
> On Mon, Oct 17, 2022 at 4:49 PM wangw.f...@fujitsu.com
> wrote:
> >
> > On Wed, Oct 5, 2022 at 11:08 AM Peter Smith
> wrote:
> > > Hi Wang-san. Here are my review comments for HEAD
On Tue, Nov 8, 2022 at 11:08 AM Michael Paquier wrote:
>
> So, I have looked at that, and at the end concluded that Andres'
> suggestion to use PGAlignedBlock in pg_write_zeros() will serve better
> in the long run. Thomas has mentioned upthread that some of the
> comments don't need to be that l
On Fri, Oct 21, 2022 at 17:02 PM Peter Smith wrote:
> Here are my review comments for HEAD patches v13*
Thanks for your comments.
> Patch HEAD_v13-0002
>
> 1. Commit message
>
> The following usage scenarios are not described in detail in the manual:
> If one subscription subscribes multiple
On Tues, Nov 8, 2022 at 12:12 PM Osumi, Takamichi/大墨 昂道
wrote:
> On Monday, October 17, 2022 2:49 PM Wang, Wei/王 威
> wrote:
> > Attach the new patch set.
> Hi, thank you for posting the new patches.
>
>
> Here are minor comments on the HEAD_v13-0002.
Thanks for your comments.
> (1) Suggestio
On Fri, Nov 11, 2022 at 11:14 AM John Naylor
wrote:
>
> On Tue, Nov 8, 2022 at 11:08 AM Michael Paquier wrote:
> >
> > So, I have looked at that, and at the end concluded that Andres'
> > suggestion to use PGAlignedBlock in pg_write_zeros() will serve better
> > in the long run. Thomas has menti
On Thu, Nov 10, 2022 at 4:12 PM sirisha chamarthi
wrote:
>
> On Wed, Nov 9, 2022 at 12:32 AM Kyotaro Horiguchi
> wrote:
>>
>> I don't think walsenders fetching segment from archive is totally
>> stupid. With that feature, we can use fast and expensive but small
>> storage for pg_wal, while avoid
On Fri, Nov 11, 2022 at 11:26 AM Japin Li wrote:
> Recently, when I read the XidInMVCCSnapshot(), and find there are some
> typos in the comments.
Hmm, it seems to me 'the subxact array' is just another saying to refer
to snapshot->subxip. I'm not sure about this being typo. But I have no
obj
On Fri, Nov 11, 2022 at 11:53:08AM +0530, Bharath Rupireddy wrote:
> On Fri, Nov 11, 2022 at 11:14 AM John Naylor
> wrote:
>> Was there supposed to be an attachment here?
>
> Nope. The patches have already been committed -
> 3bdbdf5d06f2179d4c17926d77ff734ea9e7d525 and
> 28cc2976a9cf0ed661dbc55f
On Fri, Nov 11, 2022 at 7:57 AM houzj.f...@fujitsu.com
wrote:
>
> On Monday, November 7, 2022 6:18 PM Masahiko Sawada
> wrote:
> >
> > Here are comments on v42-0001:
> >
> > We have the following three similar name functions regarding to
> > starting a new parallel apply worker:
> > ---
> >
On Fri, Nov 11, 2022 at 12:16 PM Richard Guo wrote:
>
> On Fri, Nov 11, 2022 at 11:26 AM Japin Li wrote:
>>
>> Recently, when I read the XidInMVCCSnapshot(), and find there are some
>> typos in the comments.
>
>
> Hmm, it seems to me 'the subxact array' is just another saying to refer
> to snapsh
67 matches
Mail list logo
