Hi All:
On Tue, Sep 10, 2019 at 9:49 PM Tom Lane wrote:
> Richard Guo writes:
> > Currently we do not try to pull up sub-select of type ANY_SUBLINK if it
> > refers to any Vars of the parent query, as indicated in the code snippet
> > below:
> > if (contain_vars_of_level((Node *) subselect,
Respected Sir/Madam
I am Joseph Raj Vishal, a Computer Science undergrad. I have just entered
third year at Dayananda Sagar College of Engineering in Bengaluru. I am new
to open source contributions but I am well aware of Python, Java, Django,
PHP, SQL, Javascript,Kotlin and Android. I would love
HI Joseph:
Maybe the following links are helpful.
https://www.postgresql.org/message-id/pine.bsf.4.21.9912052011040.823-100...@thelab.hub.org
https://wiki.postgresql.org/wiki/So,_you_want_to_be_a_developer%3F
On Sun, Oct 30, 2022 at 3:42 PM 1DS20CS093 Joseph Raj Vishal <
josephrvis...@gmail.com
On Sat, Oct 29, 2022 at 1:01 AM wrote:
>
> Right now it is possible to add a partitioned table with foreign tables
> as its children as a target of a subscription. It can lead to an assert
> (or a segfault, if compiled without asserts) on a logical replication
> worker when the worker attempts to
Dilip Kumar writes:
> Yes, this looks like a bug and your fix seems correct to me. It would
> be nice to add a test case for this scenario.
A test case doesn't seem that exciting to me. If we were trying to
make it actually work, then yeah, but throwing an error isn't that
useful to test. The
On 2022-Oct-27, Michael Paquier wrote:
> On Thu, Sep 29, 2022 at 08:09:56PM -0700, Nathan Bossart wrote:
> > Looks reasonable to me.
>
> 0001, to move pg_pwritev_with_retry() to a new home, seems fine, so
> applied.
Maybe something a bit useless, but while perusing the commits I noticed
a forwar
Thanks, I'll check them out.
On Sun, 30 Oct, 2022, 2:47 pm Andy Fan, wrote:
> HI Joseph:
>
> Maybe the following links are helpful.
>
>
> https://www.postgresql.org/message-id/pine.bsf.4.21.9912052011040.823-100...@thelab.hub.org
>
> https://wiki.postgresql.org/wiki/So,_you_want_to_be_a_develope
On 2022-Oct-28, ilya.v.gladys...@gmail.com wrote:
> This will cause a segfault or raise an assert, because inserting into
> foreign tables via logical replication is not possible. The solution I
> propose is to add recursive checks of relkind for children of a target,
> if the target is a partitio
postgres=# \set QUIET
CREATE TABLE stxdinp (i int, j int) PARTITION BY RANGE(i);
CREATE TABLE stxdinp1 PARTITION OF stxdinp FOR VALUES FROM (1)TO(10);
INSERT INTO stxdinp SELECT generate_series(1,9)a;
CREATE STATISTICS stxdp ON i,j FROM stxdinp;
ANALYZE stxdinp;
explain SELECT i, j, COUNT(1) FROM
On Fri, 28 Oct 2022 at 10:33, Simon Riggs wrote:
> Thanks for the feedback, I will make all of those corrections in the
> next version.
New version attached. I've rolled 002-004 into one patch, but can
split again as needed.
--
Simon Riggshttp://www.EnterpriseDB.com/
001_psql
> On Thu, Oct 13, 2022 at 07:41:32AM +0200, Pavel Stehule wrote:
> rebased with simplified code related to usage of pfree function
Thanks for the patch, great work!
I've got a couple of questions, although I haven't fully finished reviewing yet
(so more to come):
* I'm curious about ALTER VARIA
Hi
ne 30. 10. 2022 v 19:05 odesÃlatel Dmitry Dolgov <9erthali...@gmail.com>
napsal:
> > On Thu, Oct 13, 2022 at 07:41:32AM +0200, Pavel Stehule wrote:
> > rebased with simplified code related to usage of pfree function
>
> Thanks for the patch, great work!
>
> I've got a couple of questions, alt
On Sat, Oct 29, 2022 at 10:40 AM Justin Pryzby wrote:
>
> On Fri, Sep 02, 2022 at 05:24:58PM -0500, Justin Pryzby wrote:
> > It caused no issue when I changed:
> >
> > /* Check that it's acceptable for the indicated
> > parameter */
> > if (!parse_a
On Sun, Oct 30, 2022 at 03:44:32PM +0100, Alvaro Herrera wrote:
> So I'm kinda proposing that we only do the forward struct initialization
> dance when it really saves on things -- in particular, when it helps
> avoid or reduce massive indirect header inclusion.
Sure.
> extern ssize_t pg_pwritev
On Fri, Oct 28, 2022 at 09:36:23AM +0200, Peter Eisentraut wrote:
> Would there be a use for that? It's currently only used in the atomics
> code.
Yep, but they would not trigger when using atomics in the frontend
code. We don't have any use for that in core on HEAD, still that
could be useful f
On Fri, Oct 28, 2022 at 6:05 PM Michael Paquier wrote:
>
> On Fri, Oct 28, 2022 at 11:48:13AM +0900, Michael Paquier wrote:
> > Thanks. I have not looked at the checkup logic yet, but the central
> > declarations seem rather sane, and I have a few comments about the
> > latter.
>
> So, I've had t
On Wed, Oct 26, 2022 at 10:55 AM Melanie Plageman
wrote:
+ The pg_statio_ and
+ pg_stat_io views are primarily useful to determine
+ the effectiveness of the buffer cache. When the number of actual disk reads
Totally nitpicking, but this reads a little funny to me. Previously
the trailing unders
At Sat, 29 Oct 2022 13:00:25 -0700, Andres Freund wrote in
> One way to reduce the size increase would be to use the space for initialarr
> to store variables we don't need while initialarr is used. E.g. itemsarr,
> maxitems, lastarr are candidates. But I suspect that the code complication
> isn
Hi, hackers
The VariableCacheData says nextOid and oidCount are protected by
OidGenLock. However, we update them without holding the lock on
OidGenLock in BootStrapXLOG(). Same as nextXid, for other fields
that are protected by XidGenLock, it holds the lock, see
SetTransactionIdLimit().
void
Thank you for having another look at this
On Sat, 29 Oct 2022 at 18:32, Bharath Rupireddy
wrote:
> 1. I guess we need to cast the 'node' parameter too, something like
> below? I'm reading the comment there talking about compilers
> complaning about the unused function arguments.
> dlist_member_ch
On Sun, Oct 30, 2022 9:39 PM Tom Lane wrote:
>
> What I'm wondering about is whether we can refactor this code
> to avoid so many usually-useless catalog lookups. Pulling the
> namespace name, in particular, is expensive and we generally
> are not going to need the result. In the child-rel case
Hi,
On Thu, Oct 27, 2022 at 1:04 AM John Naylor
wrote:
> +# Run the main pg_regress and isolation tests
> +meson test --suite main
>
> This does not work for me in a fresh install until running
>
> meson test --suite setup
>
> In fact, we see in
>
> https://wiki.postgresql.org/wiki/Meson
>
> mes
As part of the AIO work [1], Andres mentioned to me that he found that
prefetching tuple memory during hot pruning showed significant wins.
I'm not proposing anything to improve HOT pruning here, but as a segue
to get the prefetching infrastructure in so that there are fewer AIO
patches, I'm propos
On Mon, Oct 31, 2022 at 1:05 AM Justin Pryzby wrote:
> I think this is what's needed.
>
> diff --git a/src/backend/utils/adt/selfuncs.c
> b/src/backend/utils/adt/selfuncs.c
> index 14e0885f19f..4450f0d682f 100644
> --- a/src/backend/utils/adt/selfuncs.c
> +++ b/src/backend/utils/adt/selfuncs.c
>
On Mon, Oct 31, 2022 at 12:01:33PM +1100, Peter Smith wrote:
> SUGGESTION
> /* Only applicable when prefetching is available */
Thanks for the suggestion. Done this way, then.
> +/* Disabled on Windows as the performance overhead can be significant */
> +#ifdef WIN32
> +#define DEFAULT_UPDATE_PR
On Mon, Oct 31, 2022 at 12:26 PM Richard Guo wrote:
> On Mon, Oct 31, 2022 at 1:05 AM Justin Pryzby
> wrote:
>
>> I think this is what's needed.
>>
>> diff --git a/src/backend/utils/adt/selfuncs.c
>> b/src/backend/utils/adt/selfuncs.c
>> index 14e0885f19f..4450f0d682f 100644
>> --- a/src/backend
At Thu, 27 Oct 2022 09:59:14 -0700, Andres Freund wrote in
> But I think we can solve that fairly reasonably nonetheless. We can change
> PGPROC->lwWaiting to not just be a boolean, but have three states:
> 0: not waiting
> 1: waiting in waitlist
> 2: waiting to be woken up
>
> which we then can
On Mon, Oct 31, 2022 at 01:12:09PM +0800, Richard Guo wrote:
> BTW, I noticed a micro-optimization opportunity in examine_variable that
> we can fetch the RangeTblEntry for 'onerel' outside the foreach loop
> when iterating the extended stats so that we can do it only once rather
> than for each st
Hi all,
I am trying to determine optimal standby for automatic failover based on
pg_last_wal_recieve_lsn() value of all slaves.
But what if max_wal_size is reached, is LSN value reset to zero.
Please share some documentation that mentions clarification.
Also suggest if there is any better appro
Hi all,
As per the world clock, the next commit fest will begin in 30 hours
(11/1 0:00 AoE time). I may have missed something, but it looks like
we have no CFM for this one yet.
Opinions, thoughts or volunteers?
--
Michael
signature.asc
Description: PGP signature
Just to reiterate the main impetus for this patch is to save PostGIS from
shipping 100s of duplicate extension files for each release.
> And now with the actual patch attached ... (sorry)
>
> --strk;
>
Sandro, can you submit an updated version of this patch.
I was testing it out and looked goo
On Mon, Oct 31, 2022 at 8:26 AM David Rowley wrote:
>
> I looked at dlist_check() and I didn't quite manage to figure out why
> the cast is needed. As far as I can see, there are no calls where we
> only pass dlist_head solely for the dlist_check(). For
> dlist_member_check(), dlist_delete_from()
HI,
On Oct 31, 2022, 10:48 +0800, Japin Li , wrote:
>
> Hi, hackers
>
> The VariableCacheData says nextOid and oidCount are protected by
> OidGenLock. However, we update them without holding the lock on
> OidGenLock in BootStrapXLOG(). Same as nextXid, for other fields
> that are protected by XidG
On Mon, Oct 31, 2022 at 5:01 AM Michael Paquier wrote:
>
> On Sun, Oct 30, 2022 at 03:44:32PM +0100, Alvaro Herrera wrote:
> > So I'm kinda proposing that we only do the forward struct initialization
> > dance when it really saves on things -- in particular, when it helps
> > avoid or reduce massi
On Mon, Oct 31, 2022 at 4:02 PM Michael Paquier wrote:
>
> On Mon, Oct 31, 2022 at 12:01:33PM +1100, Peter Smith wrote:
> > SUGGESTION
> > /* Only applicable when prefetching is available */
>
> Thanks for the suggestion. Done this way, then.
>
> > +/* Disabled on Windows as the performance overh
35 matches
Mail list logo
