Re: minimum perl version

On Wed, Sep 14, 2022 at 10:46 AM Tom Lane wrote: > > John Naylor writes: > > On Wed, Sep 14, 2022 at 6:47 AM Tom Lane wrote: > >> I've just switched longfin to use built-from-source perl 5.14.0. > > > In that case, here is a quick update with commit message. Not yet any > > change for MSVC, but

A question about StartSubTransaction

Hi hackers, I found the StartSubTransaction has the following code: static void StartSubTransaction(void) { [...] s->state = TRANS_START; /* * Initialize subsystems for new subtransaction * * must initialize resource-management st

Re: A question about StartSubTransaction

Japin Li writes: > IIRC, AtSubStart_Memory, AtSubStart_ResourceOwner and > AfterTriggerBeginSubXact don't > use s->state. No, they don't. > Why should we set s->state to TRANS_START and then TRANS_INPROGRESS? I believe it's so that if an error gets thrown somewhere in that area, we'll recover

Re: A question about StartSubTransaction

On Wed, 14 Sep 2022 at 13:52, Tom Lane wrote: > Japin Li writes: >> Why should we set s->state to TRANS_START and then TRANS_INPROGRESS? > > I believe it's so that if an error gets thrown somewhere in that > area, we'll recover properly. I'd be the first to say that this > stuff isn't terribly

Re: A question about wording in messages

On Wed, Sep 14, 2022 at 7:45 AM Kyotaro Horiguchi wrote: > > I saw the following message recently modified. > > > This controls the maximum distance we can read ahead in the WAL to prefetch > > referenced data blocks. > > Maybe the "we" means "PostgreSQL program and you" but I see it > somewhat o

Re: tweak to a few index tests to hits ambuildempty() routine.

I still wonder, if assert doesn't catch why that place is marked as covered here? https://coverage.postgresql.org/src/backend/access/gin/ginvacuum.c.gcov.html a.kozhemya...@postgrespro.ru писал 2022-09-12 15:47: Hi, The commit 4fb5c794e5 eliminates the ginbulkdelete() test coverage provided by

<    1   2