On Thu, Sep 08, 2022 at 04:40:32PM +0900, Shinya Kato wrote:
> Thanks! I marked it as ready for committer.
I thought that there was a gotcha in this area for composite types,
but on second look it looks that I was wrong. Hence, applied.
--
Michael
signature.asc
Description: PGP signature
Hi Melih,
> I'm not sure about what undefined behaviour could harm this badly.
You are right that in practice nothing wrong will (probably) happen on
x86/x64 architecture with (most?) modern C compilers. This is not true in
the general case though. It's up to the compiler to decide how reading th
Hello,
please find my first patch for PostgreSQL is attached.
Kind regards,
Andrey Arapov
0001-initdb-do-not-exit-after-warn_on_mount_point.patch
Description: Binary data
Hello,
Are there any plans or thoughts about adding support for other languages
than C into Postgres, namely Rust? I would love to hack on some features
but I worry somewhat that the C compiler won't give me enough hints that
I'm doing something wrong, and the Rust compiler has been excellent at
p
hi,
this morning i met an issue, that after vacuum full tablename, the associated
toast table shows not exist.
here is the operation steps:
drop table if exists reymont;
create table reymont ( id bigint primary key, data bytea not null);
alter table reymont alter column data set compression p
Created a CF entry.
https://commitfest.postgresql.org/40/3883/
Attached a patch with a fix correction to regress output.
I think this needs to be backpatched until version 12.
regards,
Ranier Vilela
v1-0001-fix-typo-isnan-test-geo_ops.patch
Description: Binary data
Hello Aleksander,
> I'm not sure about what undefined behaviour could harm this badly.
>
> You are right that in practice nothing wrong will (probably) happen on
> x86/x64 architecture with (most?) modern C compilers. This is not true in
> the general case though. It's up to the compiler to decide
On Fri, Sep 9, 2022 at 1:52 PM Tom Lane wrote:
>
> I wrote:
> > On testing that in HEAD, I read
>
> > Both the system-wide startup file and the user's personal startup file
> > can be made psql-version-specific by appending a dash and the
> > PostgreSQL major or minor release number to
"=?ISO-8859-1?B?d2Fsa2Vy?=" writes:
> this morning i met an issue, that after vacuum full tablename, the associated
> toast table shows not exist.
Your example doesn't show what you actually did, but I think what is
fooling you is that VACUUM FULL changes the relfilenode of the table
but not the
On Fri, Sep 09, 2022 at 10:23:57PM +0300, Heikki Linnakangas wrote:
> On 11/01/2022 00:03, Tom Lane wrote:
> > Peter Eisentraut writes:
> > > I don't think preserving timestamps should be the default behavior, but
> > > I would support organizing things so that additional options can be
> > > pass
andrey.ara...@nixaid.com writes:
> please find my first patch for PostgreSQL is attached.
You haven't explained why you think this would be a good
change, or even a safe one.
regards, tom lane
Hi!
> On 10 Sep 2022, at 07:38, Lev Kokotov wrote:
>
> Are there any plans or thoughts about adding support for other languages than
> C into Postgres, namely Rust? I would love to hack on some features but I
> worry somewhat that the C compiler won't give me enough hints that I'm doing
> som
On Fri, Sep 09, 2022 at 07:38:14PM -0700, Lev Kokotov wrote:
> Are there any plans or thoughts about adding support for other languages
> than C into Postgres, namely Rust? I would love to hack on some features
> but I worry somewhat that the C compiler won't give me enough hints that
> I'm doing s
Here's a WIP stab at the project Andres mentioned [1] of splitting up
guc.c into smaller files. As things stand here, we have:
1. guc.c: the core GUC machinery.
2. guc_tables.c: the data arrays, and some previously-exposed constant
tables. guc_tables.h can now be considered the associated header
Hi,
On 2022-09-10 15:04:59 -0400, Tom Lane wrote:
> Here's a WIP stab at the project Andres mentioned [1] of splitting up
> guc.c into smaller files.
Cool!
> As things stand here, we have:
>
> 1. guc.c: the core GUC machinery.
> 2. guc_tables.c: the data arrays, and some previously-exposed con
Andres Freund writes:
> On 2022-09-10 15:04:59 -0400, Tom Lane wrote:
>> $ size guc*o
>> text data bss dec hex filename
>> 13653 4 112 1376935c9 guc-file.o
>> 54953 0 564 55517d8dd guc.o
>> 69510 11270631b97 guc_hooks.o
>> 43570
Hi,
On 2022-09-10 12:15:33 -0700, Andres Freund wrote:
> On 2022-09-10 15:04:59 -0400, Tom Lane wrote:
> > As things stand here, we have:
> >
> > 1. guc.c: the core GUC machinery.
> > 2. guc_tables.c: the data arrays, and some previously-exposed constant
> > tables. guc_tables.h can now be consid
I wrote:
> Andres Freund writes:
>> On 2022-09-10 15:04:59 -0400, Tom Lane wrote:
>>> $ size guc*o
>>> text data bss dec hex filename
>>> 13653 4 112 1376935c9 guc-file.o
>>> 54953 0 564 55517d8dd guc.o
>>> 6951 0 11270631b97 guc_h
On Sun, Aug 28, 2022 at 02:28:02PM -0700, Andres Freund wrote:
> On 2022-08-28 12:10:29 -0500, Justin Pryzby wrote:
> > On Sun, Aug 28, 2022 at 09:07:52AM -0700, Andres Freund wrote:
> > > > --- /dev/null
> > > > +++ b/src/tools/ci/windows-compiler-warnings
> > >
> > > Wouldn't that be doable as so
On Mon, Sep 05, 2022 at 04:52:17PM -0700, Andres Freund wrote:
> I don't think you should need to use --host, that indicates cross compiling,
This made me consider the idea of cross-compiling for windows under a
new linux task, and then running tests under Windows with a dependent
task. I suppose
Nathan Bossart writes:
> Of course. I've marked it as ready-for-committer.
Pushed with a bit of additional wordsmithing.
regards, tom lane
On Sat, Sep 10, 2022 at 04:44:16PM -0400, Tom Lane wrote:
> Nathan Bossart writes:
>> Of course. I've marked it as ready-for-committer.
>
> Pushed with a bit of additional wordsmithing.
Thanks!
--
Nathan Bossart
Amazon Web Services: https://aws.amazon.com
On a two-column btree index, we can constrain the first column with
equality and read the rows in order by the 2nd column. But we can't
constrain the first column by IS NULL and still read the rows in order by
the 2nd column. But why not? Surely the structure of the btree index
would allow for t
Hi,
the patch no longer applies cleanly, please rebase (it's trivial).
I don't like the provided commit message very much, I think the
discussion about pgJDBC having had load balancing for a while belongs
elsewhere.
On Wed, Jun 22, 2022 at 07:54:19AM +, Jelte Fennema wrote:
> I tried to stay
On Sat, Sep 10, 2022 at 2:28 PM Jeff Janes wrote:
> explain analyze select * from j where b is null order by c limit 10;
> explain analyze select * from j where b =8 order by c limit 10;
>
> The first uses a sort despite it being disabled.
The first/is null query seems to give the result and plan
On Fri, Sep 9, 2022 at 2:17 PM Mark Dilger wrote:
> > On Sep 9, 2022, at 8:18 AM, Robert Haas wrote:
> > Things might be clearer if we'd made the syntax "ALTER PUBLICATION p1
> > { ADD | DROP } { TABLE | SCHEMA } name". I don't understand why we
> > used this ALL TABLES IN SCHEMA language.
>
> Th
On Fri, Sep 09, 2022 at 08:11:09PM +0900, Michael Paquier wrote:
> Based on what I can see, the Windows animals seem to have digested
> 47bd0b3 (cygwin, MinGW and MSVC), so I think that we are good.
The last part that's worth adjusting is ldap_start_tls_sA(), which
would lead to the attached simpl
On Sat, Sep 10, 2022 at 03:04:59PM -0400, Tom Lane wrote:
> Before proceeding further, I wanted to ask for comments on a design
> choice that might be controversial. Even though I don't want to
> invent guc_hooks.c, I think we *should* invent guc_hooks.h, and
> consolidate all the GUC hook functio
On Sat, 10 Sept 2022 at 19:18, Robert Haas wrote:
If I encountered this syntax in a vacuum, that's not what I would
> think. I would think that ADD ALL TABLES IN SCHEMA meant add all the
> tables in the schema to the publication one by one as individual
> objects, i.e. add the tables that are cur
Michael Paquier writes:
> One part that I have found a bit strange lately about guc.c is that we
> have mix the core machinery with the SQL-callable parts. What do you
> think about the addition of a gucfuncs.c in src/backend/utils/adt/ to
> split things a bit more?
I might be wrong, but I think
Jeff Janes writes:
> On a two-column btree index, we can constrain the first column with
> equality and read the rows in order by the 2nd column. But we can't
> constrain the first column by IS NULL and still read the rows in order by
> the 2nd column. But why not?
"x IS NULL" doesn't give rise
On Sun, Sep 11, 2022 at 09:28:54AM +0900, Michael Paquier wrote:
> On Fri, Sep 09, 2022 at 08:11:09PM +0900, Michael Paquier wrote:
> > Based on what I can see, the Windows animals seem to have digested
> > 47bd0b3 (cygwin, MinGW and MSVC), so I think that we are good.
>
> The last part that's wor
On Sat, Sep 10, 2022 at 10:39:19PM -0500, Justin Pryzby wrote:
> There's a CF entry to add it, and I launched it with your patch.
> (This is in a branch which already has that, and also does a few other
> things differently).
No need for a CF entry if you want to play with the tree. I have
Cirrus
33 matches
Mail list logo
