Re: [PATCH] Expose port->authn_id to extensions and triggers

On Fri, Aug 12, 2022 at 03:34:04PM +0200, Drouvot, Bertrand wrote: > 3) > > +SerializeClientConnectionInfo(Size maxsize, char *start_address) > +{ > +   /* > +    * First byte is an indication of whether or not authn_id has been > set to > +    * non-NULL, to differentiate that case fr

Re: Tab completion for "ALTER TYPE typename SET" and rearranged "Alter TYPE typename RENAME"

On Sun, Aug 14, 2022 at 08:25:01AM +0530, vignesh C wrote: > Attached patch has the changes for the same. Thoughts? > > a) Add tab completion for "ALTER TYPE typename SET" was missing. Why not. I can also note that CREATE TYPE lists all the properties that can be set to a new type. We could both

Re: fix stale help message

On Wed, Aug 10, 2022 at 11:32:18PM +0800, Junwang Zhao wrote: > when parsing command-line options, the -f option support disabling > 8 scan and join methods, o, b and t disable index-only scans, > bitmap index scans, and TID scans respectively, add them to the > help message. > > @@ -351,7 +351,7 @

latest patches not updated in repos

Hi, I am not sure whom I need to contact but the patches were not pushed to the repos as per release notes. https://www.postgresql.org/docs/release/ PostgreSQL: Release Notes 11th August 2022: PostgreSQL 14.5, 13.8, 12.12, 11.17, 10.22, and 15 Beta 3 Rel

Re: fix stale help message

Hi Michael, Thanks for your reply :) I think the goal of `help message` is to tell users(like DBA) how to use postgres, so it's better to provide a complete view. I'm not sure by saying `set_plan_disabling_options` do you mean the postgres source code? If that's the case, I think most of the ins

Re: latest patches not updated in repos

"Graaff, Selwyn" writes: > I am not sure whom I need to contact but the patches were not pushed to the > repos as per release notes. > https://www.postgresql.org/docs/release/ > PostgreSQL: Release Notes > 11th August 2022: PostgreSQL 14.5, 13.8, 12.12, 1

Re: latest patches not updated in repos

Hi, On Sun, 2022-08-14 at 10:10 -0400, Tom Lane wrote: > "Graaff, Selwyn" writes: > > I am not sure whom I need to contact but the patches were not > > pushed to the repos as per release notes. > > https://www.postgresql.org/docs/release/ > > PostgreSQL: Release Notes

Re: Tab completion for "ALTER TYPE typename SET" and rearranged "Alter TYPE typename RENAME"

On Sun, Aug 14, 2022 at 3:41 PM Michael Paquier wrote: > > On Sun, Aug 14, 2022 at 08:25:01AM +0530, vignesh C wrote: > > Attached patch has the changes for the same. Thoughts? > > > > a) Add tab completion for "ALTER TYPE typename SET" was missing. > > Why not. I can also note that CREATE TYPE l

bogus assert in logicalmsg_desc

Hi, while experimenting with logical messages, I ran into this assert in logicalmsg_desc: Assert(prefix[xlrec->prefix_size] != '\0'); This seems to be incorrect, because LogLogicalMessage does this: xlrec.prefix_size = strlen(prefix) + 1; So prefix_size includes the null byte, so the a

Re: Include the dependent extension information in describe command.

On Sun, Aug 14, 2022 at 11:07 AM Tom Lane wrote: > > vignesh C writes: > > Currently we do not include the dependent extension information for > > index and materialized view in the describe command. I felt it would > > be useful to include this information as part of the describe command > > lik

Re: bogus assert in logicalmsg_desc

On Mon, Aug 15, 2022 at 1:17 AM Tomas Vondra wrote: > > Hi, > > while experimenting with logical messages, I ran into this assert in > logicalmsg_desc: > > Assert(prefix[xlrec->prefix_size] != '\0'); > > This seems to be incorrect, because LogLogicalMessage does this: > > xlrec.prefix_size

Re: bogus assert in logicalmsg_desc

On Mon, Aug 15, 2022 at 12:17 AM Tomas Vondra wrote: > So prefix_size includes the null byte, so the assert points out at the > first payload byte. And of course, the check should be "==" because we > expect the byte to be \0, not the other way around. Yes, indeed. There is even a comment empha

Re: Cleaning up historical portability baggage

On Sun, Aug 14, 2022 at 10:36 AM Andres Freund wrote: > On 2022-08-14 10:03:19 +1200, Thomas Munro wrote: > > I hadn't paid attention to our existing abstract Unix socket support > > before and now I'm curious: do we have a confirmed sighting of that > > working on Windows? > > I vaguely remember

Re: Improve description of XLOG_RUNNING_XACTS

Sorry for the late reply. On Thu, Jul 28, 2022 at 4:29 PM Kyotaro Horiguchi wrote: > > At Thu, 28 Jul 2022 15:53:33 +0900, Masahiko Sawada > wrote in > > > > > Do you mean that both could be true at the same time? If I read > > GetRunningTransactionData() correctly, that doesn't happen. > > So,

Re: fix stale help message

On Sun, Aug 14, 2022 at 09:03:15PM +0800, Junwang Zhao wrote: > I'm not sure by saying `set_plan_disabling_options` do you mean > the postgres source code? If that's the case, I think most of the > installations don't have source code but just binaries, people will > reference the help message by r

Re: Tab completion for "ALTER TYPE typename SET" and rearranged "Alter TYPE typename RENAME"

On Sun, Aug 14, 2022 at 07:56:00PM +0530, vignesh C wrote: > Modified the patch to list all the properties in case of "ALTER TYPE > typename SET (". I have included the properties in alphabetical order > as I notice that the ordering is in alphabetical order in few cases > ex: "ALTER SUBSCRIPTION

Re: Fast COPY FROM based on batch insert

On 8/9/22 16:44, Etsuro Fujita wrote: -1 foo 1 bar \. ERROR: new row for relation "t1" violates check constraint "t1_f1positive" DETAIL: Failing row contains (-1, foo). CONTEXT: remote SQL command: INSERT INTO public.t1(f1, f2) VALUES ($1, $2), ($3, $4) COPY ft1, line 3 In single-insert mode

Header checker scripts should fail on failure

Hi, I thought commit 81b9f23c9c8 had my back, but nope, we still need to make CI turn red if "headerscheck" and "cpluspluscheck" don't like our patches (crake in the build farm should be a secondary defence...). See attached. diff --git a/src/tools/pginclude/cpluspluscheck b/src/tools/pginclude/cp

Re: [PoC] Improve dead tuple storage for lazy vacuum

On Fri, Jul 22, 2022 at 10:43 AM Masahiko Sawada wrote: > > On Tue, Jul 19, 2022 at 1:30 PM John Naylor > wrote: > > > > > > > > On Tue, Jul 19, 2022 at 9:11 AM Masahiko Sawada > > wrote: > > > > > I’d like to keep the first version simple. We can improve it and add > > > more optimizations lat

Re: Cleaning up historical portability baggage

On Sun, Aug 14, 2022 at 10:03 AM Thomas Munro wrote: > All green on CI... Next stop, build farm. All good so far (except for an admonishment from crake, for which my penance was to fix headerscheck, see separate thread...). I did figure out one thing that I mentioned I was confused by before: t

Re: Assertion failure in WaitForWALToBecomeAvailable state machine

On Thu, Aug 11, 2022 at 10:06 PM Bharath Rupireddy wrote: > > Today I encountered the assertion failure [2] twice while working on > another patch [1]. The pattern seems to be that the walreceiver got > killed or crashed and set it's state to WALRCV_STOPPING or > WALRCV_STOPPED by the team the WAL

Re: Use SetInstallXLogFileSegmentActive() for setting XLogCtl->InstallXLogFileSegmentActive

On Fri, Aug 12, 2022 at 4:17 AM Nathan Bossart wrote: > > On Thu, Aug 11, 2022 at 09:42:18PM +0530, Bharath Rupireddy wrote: > > Here's a small patch replacing the explicit setting of > > XLogCtl->InstallXLogFileSegmentActive with the existing function > > SetInstallXLogFileSegmentActive(), remove

Re: latest patches not updated in repos - [External Email]

Thank you. regards, Selwyn From: Devrim Gündüz Sent: Sunday, 14 August 2022 16:25 To: Tom Lane ; Graaff, Selwyn Cc: pgsql-hackers@lists.postgresql.org Subject: Re: latest patches not updated in repos - [External Email] Hi, On Sun, 2022-08-14 at 10:10 -0400, To