On Thu, Jul 28, 2022 at 11:56 AM Fujii Masao
wrote:
>
>
>
> On 2022/07/27 10:36, Kyotaro Horiguchi wrote:
> > At Tue, 26 Jul 2022 18:33:04 +0900, Fujii Masao
> > wrote in
> >>> I'm not sure the two are similar with each other. The new function
> >>> pgfdw_exec_pre_commit() looks like a merger o
On Thu, Aug 4, 2022 at 3:38 PM Justin Pryzby wrote:
> [train wreck]
Oh my, so I'm getting the impression we might actually be totally
unstable on Cygwin. Which surprises me because ... wait a minute ...
lorikeet isn't even running most of the tests. So... we don't really
know the degree to whic
On Thu, Aug 4, 2022 at 4:09 PM Tom Lane wrote:
> Andres Freund writes:
> >> XXX This can only be committed once prairedog is decommissioned, because
> >> macOS 10.4 didn't have clock_gettime().
>
> > Maybe put it later in the queue?
>
> clock_gettime is required by SUSv2 (1997), so I have to admi
Hi,
On 2022-08-04 16:16:06 +1200, Thomas Munro wrote:
> Ok, that's slightly reassuring, so maybe we *can* fix this, but I'm
> one step closer to what Tom said, re wasting developer time...
It might be worth checking whether the cygwin installer, which at some point
at least allowed installing pos
On Wed, Aug 3, 2022 at 12:11 AM Robert Haas wrote:
>
> On Tue, Aug 2, 2022 at 3:25 AM Bharath Rupireddy
> wrote:
> > ereport_startup_progress infrastructure added by commit 9ce346e [1]
> > will be super-useful for reporting progress of any long-running server
> > operations, not just the startup
On Thu, Aug 4, 2022 at 3:43 PM Andres Freund wrote:
> > We retain a HAVE_SHM_OPEN macro, because it's clearer to readers than
> > something like !defined(WIN32).
>
> I don't like these. I don't find them clearer - if we really just assume this
> to be the case on windows, it's easier to understand
On Thu, Aug 4, 2022 at 4:16 PM Thomas Munro wrote:
> On Thu, Aug 4, 2022 at 3:38 PM Justin Pryzby wrote:
> > [train wreck]
>
> Oh my, so I'm getting the impression we might actually be totally
> unstable on Cygwin. Which surprises me because ... wait a minute ...
> lorikeet isn't even running mo
Thomas Munro writes:
> It may be madness to try to work around this, but I wonder if we could
> use a static local variable that we update with atomic compare
> exhange, inside PG_SIGNAL_HANDLER_ENTRY(), and
> PG_SIGNAL_HANDLER_EXIT() macros that do nothing on every other system.
> On entry, if yo
Hi,
On Wed, Aug 3, 2022 at 2:01 PM John Naylor wrote:
>
>
> On Tue, Aug 2, 2022 at 11:53 PM Nathan Bossart
> wrote:
> > I did a bit of cross-checking, and AFAICT this is a reasonable starting
> > point. emmintrin.h appears to be sufficient for one of my patches that
> > makes use of SSE2 instr
On Mon, Jul 18, 2022 at 10:39 AM Andrew Dunstan wrote:
> On 2022-07-18 Mo 10:33, Justin Pryzby wrote:
> > It's easy to use CREATE TABLE..LIKE + ALTER..ATTACH PARTITION to avoid
> > acquiring a strong lock when creating a new partition.
> > But it's also easy to forget.
> >
> > commit 76c0d1198cf29
Patch update without merge conflicts.
MartinFrom 0ecffcf3ed2eb59d045941b69bb86a34b93f3391 Mon Sep 17 00:00:00 2001
From: Martin Kalcher
Date: Sun, 17 Jul 2022 18:06:04 +0200
Subject: [PATCH v3] Introduce array_shuffle() and array_sample()
* array_shuffle() shuffles the elements of an array.
* a
At Wed, 3 Aug 2022 18:16:33 +0530, Ashutosh Sharma
wrote in
> Following comment in RemoveNonParentXlogFiles() says that we are trying to
> remove any WAL file whose segment number is >= the segment number of the
> first WAL file on the new timeline. However, looking at the code, I can say
> that
At Thu, 04 Aug 2022 15:00:06 +0900 (JST), Kyotaro Horiguchi
wrote in
> At Wed, 3 Aug 2022 18:16:33 +0530, Ashutosh Sharma
> wrote in
> > Following comment in RemoveNonParentXlogFiles() says that we are trying to
> > remove any WAL file whose segment number is >= the segment number of the
> >
On Thu, Aug 4, 2022 at 5:23 PM Tom Lane wrote:
> Thomas Munro writes:
> > It may be madness to try to work around this, but I wonder if we could
> > use a static local variable that we update with atomic compare
> > exhange, inside PG_SIGNAL_HANDLER_ENTRY(), and
> > PG_SIGNAL_HANDLER_EXIT() macro
On Tue, Aug 02, 2022 at 07:37:27AM -0700, Noah Misch wrote:
> On Tue, Aug 02, 2022 at 10:14:22AM -0400, David Steele wrote:
> > On 7/31/22 02:17, Noah Misch wrote:
> > >On Tue, Jul 26, 2022 at 07:21:29AM -0400, David Steele wrote:
> > >>On 6/19/21 16:39, Noah Misch wrote:
> > >>>On Tue, Feb 02, 202
On Sun, Jul 31, 2022 at 8:36 PM mahendrakar s
wrote:
>
>> On Mon, 25 Jul 2022 at 16:42, Bharath Rupireddy
>> wrote:
>> Here's the v3 patch after rebasing.
>>
>> I just would like to reiterate the issue the patch is trying to solve:
>> At times (when no space is left on the device or when the pr
On Thurs, Jul 28, 2022 at 13:20 PM Kuroda, Hayato/黒田 隼人
wrote:
>
> Dear Wang-san,
>
> Hi, I'm also interested in the patch and I started to review this.
> Followings are comments about 0001.
Thanks for your kindly review and comments.
To avoid making this thread too long, I will reply to all of
On Wed, Jul 27, 2022 at 16:03 PM Peter Smith wrote:
> Here are some review comments for the patch v19-0004:
Thanks for your kindly review and comments.
To avoid making this thread too long, I will reply to all of your comments
(0001-patch ~ 0004-patch) in this email.
In addition, in order not to
On Mon, Jul 25, 2022 at 21:50 PM Amit Kapila wrote:
> Few comments on 0001:
> ==
Thanks for your comments.
> 1.
> - substream bool
> + substream char
>
>
> - If true, the subscription will allow streaming of in-progress
> - transactions
On Thu, Aug 4, 2022 at 12:38 PM Masahiko Sawada
wrote:
>
> I also think it's a good start. There is a typo in the commit message:
>
> s/hepler/helper/
>
> The rest looks good to me.
Fixed, and pushed, thanks to you both! I'll polish a small patch I have
that actually uses this.
--
John Naylor
ED
101 - 120 of 120 matches
Mail list logo
