Re: Allow file inclusion in pg_hba and pg_ident files

On Tue, Jul 26, 2022 at 01:04:02PM +0800, Julien Rouhaud wrote: > It doesn't have much impact most of the time. The filename is reported if > there's an IO error while reading the already opened correct file. The real > problem is if the hba_file and ident_file are stored in different directory,

Re: Cygwin cleanup

On Tue, Jul 26, 2022 at 4:34 PM Tom Lane wrote: > Thomas Munro writes: > > 3. You can't really run PostgreSQL on Cygwin for real, because its > > implementation of signals does not have reliable signal masking, so > > unsubtle and probably also subtle breakage occurs. That was reported > > upst

Re: [BUG] Logical replication failure "ERROR: could not map filenode "base/13237/442428" to relation OID" with catalog modifying txns

On Tue, Jul 26, 2022 at 7:00 AM Masahiko Sawada wrote: > > On Mon, Jul 25, 2022 at 7:57 PM shiy.f...@fujitsu.com > wrote: > > > > Hi, > > > > I did some performance test for the master branch patch (based on v6 patch) > > to > > see if the bsearch() added by this patch will cause any overhead. >

Re: making relfilenodes 56 bits

On Mon, Jul 25, 2022 at 9:51 PM Ashutosh Sharma wrote: > > Hi, > > As oid and relfilenumber are linked with each other, I still see that if the > oid value reaches the threshold limit, we are unable to create a table with > storage. For example I set FirstNormalObjectId to 4294967294 (one value

Re: making relfilenodes 56 bits

On Thu, Jul 21, 2022 at 9:53 AM Thomas Munro wrote: > > On Wed, Jul 20, 2022 at 11:27 PM Dilip Kumar wrote: > > [v10 patch set] > > Hi Dilip, I'm experimenting with these patches and will hopefully have > more to say soon, but I just wanted to point out that this builds with > warnings and failed

Re: making relfilenodes 56 bits

On Fri, Jul 22, 2022 at 4:21 PM vignesh C wrote: > > On Wed, Jul 20, 2022 at 4:57 PM Dilip Kumar wrote: > > > Thanks for the patch, my comments from the initial review: > 1) Since we have changed the macros to inline functions, should we > change the function names similar to the other inline fu

Re: making relfilenodes 56 bits

On Tue, Jul 26, 2022 at 10:05 AM Amul Sul wrote: > > Few more typos in 0004 patch as well: > > the a value > interger > previosly > currenly > Thanks for the review, I will fix it in the next version. -- Regards, Dilip Kumar EnterpriseDB: http://www.enterprisedb.com

Re: explain analyze rows=%.0f

The following review has been posted through the commitfest application: make installcheck-world: tested, passed Implements feature: tested, passed Spec compliant: not tested Documentation:not tested The previous review was incorrectly posted. Updating the pat.ch revie

<    1   2