On Mon, May 09, 2022 at 11:21:26AM +0100, Dagfinn Ilmari Mannsåker wrote:
> David Fetter writes:
>
> > diff --git src/backend/utils/error/elog.c src/backend/utils/error/elog.c
> > index 55ee5423af..4698e32ab7 100644
> > --- src/backend/utils/error/elog.c
> > +++ src/backend/utils/error/elog.c
> >
Op 13-06-2022 om 07:51 schreef David Fetter:
Folks,
Please find attached a patch to do $Subject. As dates in a fair number
of fields of endeavor are expressed this way, it seems reasonable to
ensure tha we can parse them on input. Making it possible to use them
in output is a more invasive patch
On Monday, June 13, 2022 1:53 PM Amit Kapila wrote:
>
> On Sat, Jun 11, 2022 at 2:36 PM houzj.f...@fujitsu.com
> wrote:
> >
> > On Saturday, June 11, 2022 9:36 AM Amit Kapila
> wrote:
> > >
> > > On Fri, Jun 10, 2022 at 2:26 PM Amit Langote
> > >
> > > wrote:
> > > >
> > > > +logicalrep_partma
On 13.06.22 04:32, Julien Rouhaud wrote:
I think it makes more sense to have a sanity check to prevent HEADER
MATCH with COPY TO.
I'm fine with it. I added such a check and mentioned it in the documentation.
I think it would still be problematic if the target table has dropped columns.
Fort
On Mon, Jun 13, 2022 at 10:32:13AM +0800, Julien Rouhaud wrote:
> On Sun, Jun 12, 2022 at 09:36:13AM -0400, Andrew Dunstan wrote:
> I'm fine with it. I added such a check and mentioned it in the documentation.
An error looks like the right call at this stage of the game. I am
not sure what the c
On Sun, Jun 12, 2022 at 05:58:54PM -0400, Andrew Dunstan wrote:
> On 2022-06-12 Su 10:14, Andrew Dunstan wrote:
>> I tried in fb16d2c658 to avoid littering the mainline code with
>> version-specific tests, and put that in the methods in the subclasses
>> that override the mainline functions.
Excep
Hello, hackers.
While working on (1) in commit
2871b4618af1acc85665eec0912c48f8341504c4 (2) from 2010 I noticed Simon
Riggs was thinking about usage of memory barrier for KnownAssignedXids
access instead of spinlocks.
> We could dispense with the spinlock if we were to
> create suitable memory ac
On Sat, Jun 11, 2022 at 10:36 AM Amit Kapila wrote:
> On Fri, Jun 10, 2022 at 2:26 PM Amit Langote wrote:
> >
> > +logicalrep_partmap_invalidate
> >
> > I wonder why not call this logicalrep_partmap_update() to go with
> > logicalrep_relmap_update()? It seems confusing to have
> > logicalrep_par
On Mon, Jun 13, 2022 at 2:20 PM Amit Langote wrote:
>
> On Sat, Jun 11, 2022 at 10:36 AM Amit Kapila wrote:
> > On Fri, Jun 10, 2022 at 2:26 PM Amit Langote
> > wrote:
> > >
> > > +logicalrep_partmap_invalidate
> > >
> > > I wonder why not call this logicalrep_partmap_update() to go with
> > >
On Sunday, June 12, 2022 2:46 PM Zheng Li wrote:
>
> > > > > > I've not looked at these patches in-depth yet but with this
> > > > > > approach, what do you think we can handle the DDL syntax
> > > > > > differences between major versions? DDL syntax or behavior
> > > > > > could be changed by fu
Hi,
In addition to the use cases mentioned above, some users want to use n-way
replication of partial database.
The following is the typical use case.
* There are several data centers.
(ex. Japan and India)
* The database in each data center has its unique data.
(ex. the database in Japan h
On Fri, Jun 10, 2022, at 8:25 AM, Kyotaro Horiguchi wrote:
>
> The current implement of PQsendQueryInternal looks like the result of
> a misunderstanding of the doc. In the regression tests, that path is
> excercised only for an error case, where no CloseComplete comes.
>
> The attached adds a t
On Mon, Jun 13, 2022 at 6:53 PM Peter Eisentraut
wrote:
> frame #1: 0x7ff803a28751 libsystem_c.dylib`hash_search + 215
> frame #2: 0x000110357700
> pltcl.so`compile_pltcl_function(fn_oid=16418, tgreloid=0,
Hmm, I can’t reproduce that…. although that symbol is present in my
libS
I thought about the strategy below in the past few days, and think it
is better because it uses less cycles to get the same answer. IIUC, the
related structs should be created during / after deconstruct_jointree rather
than join_search_xx stage.
> The schemes I've been toying with tend to look
On Mon, Jun 13, 2022 at 1:03 PM houzj.f...@fujitsu.com
wrote:
>
> On Monday, June 13, 2022 1:53 PM Amit Kapila wrote:
>
> I have separated out the bug-fix for the subscriber-side.
> And fix the typo and function name.
> Attach the new version patch set.
>
The first patch looks good to me. I have
Hi hackers,
> > Can't we add some extra fork that stores this extra per-page
> > information, and contains this extra metadata
> >
> +1 for this approach. I had observed some painful corruption cases where
> block storage simply returned stale version of a rage of blocks. This is only
> possible
> Have you measured the performance effects of this? On fast storage with large
> shared_buffers I've seen these loops in profiles. It's probably fine, but it'd
> be good to verify that.
To understand the performance effects of the above, I have taken the
average of five checkpoints with the patch
> > Have you measured the performance effects of this? On fast storage with
> > large
> > shared_buffers I've seen these loops in profiles. It's probably fine, but
> > it'd
> > be good to verify that.
>
> I am wondering if we could make the function inlined at some point.
> We could also play it
On 2022-06-13 Mo 03:51, Michael Paquier wrote:
> On Sun, Jun 12, 2022 at 05:58:54PM -0400, Andrew Dunstan wrote:
>> On 2022-06-12 Su 10:14, Andrew Dunstan wrote:
>>> I tried in fb16d2c658 to avoid littering the mainline code with
>>> version-specific tests, and put that in the methods in the subc
Hi,
Please see the attached draft of the release announcement for the
2022-06-16 release.
Please review for technical accuracy and omissions. If you have
feedback. please provide it no later than Thu, June 16, 2022 0:00 AoE[1].
Thanks,
Jonathan
[1] https://en.wikipedia.org/wiki/Anywhere_o
On Sun, Apr 17, 2022 at 11:22 PM Noah Misch wrote:
> > Yes, but it could be false positives in some cases. For instance, the
> > column {oid, bool, XLogRecPtr} should be okay on ALIGNOF_DOUBLE == 4
> > and 8 platforms but the new test fails.
>
> I'm happy with that, because the affected author sho
On Mon, Jun 13, 2022 at 09:11:56AM +0200, Erik Rijkers wrote:
> Op 13-06-2022 om 07:51 schreef David Fetter:
> > Folks,
> >
> > Please find attached a patch to do $Subject. As dates in a fair number
> > of fields of endeavor are expressed this way, it seems reasonable to
> > ensure tha we can pars
Hello,
I've updated the patch in preparation for the upcoming commitfest.
Regards,
Sergey.
diff --git a/doc/src/sgml/monitoring.sgml b/doc/src/sgml/monitoring.sgml
index 4549c2560e..cf00685c96 100644
--- a/doc/src/sgml/monitoring.sgml
+++ b/doc/src/sgml/monitoring.sgml
@@ -979,6 +979,26 @@ postgr
=?UTF-8?Q?=C3=81lvaro_Herrera?= writes:
> Sadly, it looks like I won't be able to get this patched pushed for 14.4.
I think that's a good thing actually; this isn't urgent enough to
risk a last-minute commit. Please wait till the release freeze
lifts.
regards, tom lane
On Mon, Jun 13, 2022 at 9:23 AM Aleksander Alekseev
wrote:
> Should it necessarily be a fixed list? Why not support plugable algorithms?
>
> An extension implementing a checksum algorithm is going to need:
>
> - several hooks: check_page_after_reading, calc_checksum_before_writing
> - register_che
On Sat, Jun 4, 2022 at 6:23 PM Tomas Vondra
wrote:
> Hi,
>
> At on of the pgcon unconference sessions a couple days ago, I presented
> a bunch of benchmark results comparing performance with different
> data/WAL block size. Most of the OLTP results showed significant gains
> (up to 50%) with smal
Thomas Munro writes:
> On Mon, Jun 13, 2022 at 6:53 PM Peter Eisentraut
> wrote:
>> frame #1: 0x7ff803a28751 libsystem_c.dylib`hash_search + 215
>> frame #2: 0x000110357700
>> pltcl.so`compile_pltcl_function(fn_oid=16418, tgreloid=0,
> Hmm, I can’t reproduce that….
I can't either, altho
On 6/13/22 17:42, Merlin Moncure wrote:
> On Sat, Jun 4, 2022 at 6:23 PM Tomas Vondra
> mailto:tomas.von...@enterprisedb.com>>
> wrote:
>
> Hi,
>
> At on of the pgcon unconference sessions a couple days ago, I presented
> a bunch of benchmark results comparing performance with differe
Hi Robert,
> I don't think that a separate fork is a good option for reasons that I
> articulated previously: I think it will be significantly more complex
> to implement and add extra I/O.
>
> I am not completely opposed to the idea of making the algorithm
> pluggable but I'm not very excited abo
Kyotaro Horiguchi writes:
> The root cause of the errors is that the user-provided directory path
> of new cluster's root was too long. Anywhich one of the four buffers
> is overflowed, it doesn't makes any difference for users and doesn't
> offer any further detail to suppoerters/developers. I
"Jonathan S. Katz" writes:
> Please review for technical accuracy and omissions.
A few minor thoughts:
> The PostgreSQL Global Development Group has released PostgreSQL 14.4 to fix an
> issue that could cause silent data corruption when using the
> [`CREATE INDEX
> CONCURRENTLY`](https://www.po
On Fri, Jun 10, 2022 at 4:36 PM Peter Eisentraut
wrote:
> I think this would create a conflict with what role-based access control
> normally means (outside of PostgreSQL specifically). A role is a
> collection of privileges that you dynamically enable (e.g., with SET
> ROLE). That corresponds t
On Mon, Jun 13, 2022 at 12:59 PM Aleksander Alekseev
wrote:
> So, to clarify, what we are trying to achieve here is to reduce the
> probability of an event when a page gets corrupted but the checksum is
> accidentally the same as it was before the corruption, correct? And we
> also assume that nei
On Mon, Jun 13, 2022 at 11:01 AM Robert Haas wrote:
> Some
>
syntax would be a bit different on the new releases and that would
> unlock some new options we don't currently have, but there's no
> behavior that you can get today which you wouldn't be able to get any
> more under this proposal.
>
On Mon, Jun 13, 2022 at 2:42 PM David G. Johnston
wrote:
> Agreed. Moving the inherit flag to the many-to-many join relation provides
> flexibility, while representing the present behavior is trivial - every row
> for a given member role has the same value for said flag.
Precisely.
> One seem
On Sun, May 8, 2022 at 4:45 PM David Fetter wrote:
> Please find attached a patch to change the sub-second granularity of
> log timestamps from milliseconds to microseconds.
Why is this a good idea?
--
Robert Haas
EDB: http://www.enterprisedb.com
On Wed, Jun 8, 2022 at 8:46 AM Bruce Momjian wrote:
> We currently can check for missing heap/index files by comparing
> pg_class with the database directory files. However, I am not clear if
> this is safe during concurrent DDL. I assume we create the file before
> the update to pg_class is vis
On 13.06.22 13:27, Thomas Munro wrote:
On Mon, Jun 13, 2022 at 6:53 PM Peter Eisentraut
wrote:
frame #1: 0x7ff803a28751 libsystem_c.dylib`hash_search + 215
frame #2: 0x000110357700
pltcl.so`compile_pltcl_function(fn_oid=16418, tgreloid=0,
Hmm, I can’t reproduce that…. alt
Robert Haas writes:
> On Sun, May 8, 2022 at 4:45 PM David Fetter wrote:
>> Please find attached a patch to change the sub-second granularity of
>> log timestamps from milliseconds to microseconds.
> Why is this a good idea?
I can imagine that some people would have a use for microsecond
resol
Peter Eisentraut writes:
> The difference is that I use CC=gcc-11. I have change to CC=cc, then it
> works (nm output shows "from executable"). So it's gcc that gets thrown
> off by the -lc.
Hah, that makes sense. So does changing the option order help?
regards, tom
On Thu, 9 Jun 2022 at 16:12, Peter Geoghegan wrote:
>
> Presumably there is still significant value in detecting cases where
> some user-defined code provably does the wrong thing. Especially by
> targeting mistakes that experience has shown are relatively common.
> That's what the search_path cas
On 13.06.22 18:01, Tom Lane wrote:
Having said that, I wonder whether the position of the -bundle_loader
switch in the command line is relevant to which way the hash_search
reference is resolved. Seems like we could put it in front of the
various -l options if that'd help.
Switching the order
On Fri, 10 Jun 2022 at 15:58, Robert Haas wrote:
>
> On Thu, Jun 9, 2022 at 8:00 PM Matthias van de Meent
> wrote:
> > Why so? We already dole out per-page space in 4-byte increments
> > through pd_linp, and I see no reason why we can't reserve some line
> > pointers for per-page metadata if we d
On Tue, Jun 14, 2022 at 8:21 AM Peter Eisentraut
wrote:
> The difference is that I use CC=gcc-11. I have change to CC=cc, then it
> works (nm output shows "from executable"). So it's gcc that gets thrown
> off by the -lc.
Hrmph, I changed my CC to "ccache gcc-mp-11" (what MacPorts calls GCC
11)
On Fri, Jun 10, 2022 at 6:16 AM Robert Haas wrote:
> > My preference is for an approach that builds on that, or at least
> > doesn't significantly complicate it. So a cryptographic hash or nonce
> > can go in the special area proper (structs like BTPageOpaqueData don't
> > need any changes), but a
On Mon, Jun 13, 2022 at 02:44:41PM -0700, Peter Geoghegan wrote:
> On Fri, Jun 10, 2022 at 6:16 AM Robert Haas wrote:
> > > My preference is for an approach that builds on that, or at least
> > > doesn't significantly complicate it. So a cryptographic hash or nonce
> > > can go in the special area
On Mon, Jun 13, 2022 at 2:54 PM Bruce Momjian wrote:
> On Mon, Jun 13, 2022 at 02:44:41PM -0700, Peter Geoghegan wrote:
> > Is that the how block-level encryption feature from EDB Advanced Server
> > does it?
>
> Uh, EDB Advanced Server doesn't have a block-level encryption feature.
Apparently t
On Mon, Jun 13, 2022 at 03:03:17PM -0700, Peter Geoghegan wrote:
> On Mon, Jun 13, 2022 at 2:54 PM Bruce Momjian wrote:
> > On Mon, Jun 13, 2022 at 02:44:41PM -0700, Peter Geoghegan wrote:
> > > Is that the how block-level encryption feature from EDB Advanced Server
> > > does it?
> >
> > Uh, EDB
A little confused here, does this patch V3 intend to solve this problem "record
length 2145386550 at 0/360 too long"?
No, not once the record exists. But it does remove Postgres' ability
to create such records, thereby solving the problem for all systems
that generate WAL through Postgres
On Mon, Jun 13, 2022 at 3:06 PM Bruce Momjian wrote:
> That is encryption done in a virtual file system independent of
> Postgres. So, I guess the answer to your question is that this is not
> how EDB Advanced Server does it.
Okay, thanks for clearing that up. The term "block based" does appear
On Mon, Jun 13, 2022 at 04:06:12PM -0400, Robert Haas wrote:
> One idea might be for each heap table to have a metapage and store the
> length - or an upper bound on the length - in the metapage. That'd
> probably be cheaper than updating pg_class, but might still be
> expensive in some scenarios,
On Mon, Jun 13, 2022 at 4:15 PM Bruce Momjian wrote:
> I agree --- it would be nice, but might be hard to justify the
> engineering and overhead involved. I guess I was just checking that I
> wasn't missing something obvious.
I suspect that the cost of being sloppy about this kind of thing
outwe
On Mon, Jun 13, 2022 at 04:22:42PM -0400, Tom Lane wrote:
> Robert Haas writes:
> > On Sun, May 8, 2022 at 4:45 PM David Fetter wrote:
> >> Please find attached a patch to change the sub-second granularity of
> >> log timestamps from milliseconds to microseconds.
>
> > Why is this a good idea?
On Thu, Jun 9, 2022 at 11:33 AM Thomas Munro wrote:
> On Thu, Jun 9, 2022 at 5:42 AM Tom Lane wrote:
> > I'm sure that Apple are indeed updating the UTF8 data behind
> > their proprietary i18n APIs, but the libc APIs are mostly getting benign
> > neglect.
>
> As for how exactly they might be doin
At Mon, 13 Jun 2022 13:25:01 -0400, Tom Lane wrote in
> Kyotaro Horiguchi writes:
> > The root cause of the errors is that the user-provided directory path
> > of new cluster's root was too long. Anywhich one of the four buffers
> > is overflowed, it doesn't makes any difference for users and d
At Tue, 14 Jun 2022 09:48:26 +0900 (JST), Kyotaro Horiguchi
wrote in
> At Mon, 13 Jun 2022 13:25:01 -0400, Tom Lane wrote in
> > +1, but I'm inclined to make it read "... is too long".
>
> Yeah, I feel so and it is what I wondered about recently when I saw
> some complete error messages. Is
On Mon, Jun 13, 2022 at 5:41 PM Thomas Munro wrote:
> It'd clearly be a terrible idea for us to try to use any of that, and
> Mac users should be very happy with the new support for ICU as DB
> default.
This suggests something that I already suspected: nobody particularly
expects the system lib C
On 6/13/22 1:38 PM, Tom Lane wrote:
"Jonathan S. Katz" writes:
Please review for technical accuracy and omissions.
A few minor thoughts:
The PostgreSQL Global Development Group has released PostgreSQL 14.4 to fix an
issue that could cause silent data corruption when using the
[`CREATE INDEX
On Mon, Jun 13, 2022 at 6:15 PM Jonathan S. Katz wrote:
> > Perhaps it is also worth mentioning that you can use REINDEX without
> > CONCURRENTLY, even before upgrading.
>
> I'm hesitant on giving too many options. We did put out the "warning"
> announcement providing this as an option. I do think
On Mon, Jun 13, 2022 at 1:51 PM Greg Stark wrote:
> By "relatively common" I think we're talking "nigh universal". Afaics
> there are no warnings in the docs about worrying about search_path on
> IMMUTABLE functions. There is for SECURITY DEFINER but I have to admit
> I wasn't aware myself of all
On Tue, Jun 14, 2022 at 09:52:52AM +0900, Kyotaro Horiguchi wrote:
> At Tue, 14 Jun 2022 09:48:26 +0900 (JST), Kyotaro Horiguchi
> wrote in
>> Yeah, I feel so and it is what I wondered about recently when I saw
>> some complete error messages. Is that because of the length of the
>> subject?
>
Michael Paquier writes:
> I have noticed this thread and 4e54d23 as a result this morning. If
> you want to spread this style more, wouldn't it be better to do that
> in all the places of pg_upgrade where we store paths to files? I can
> see six code paths with log_opts.basedir that could do the
On Mon, Jun 13, 2022 at 06:41:17PM -0700, Peter Geoghegan wrote:
> On Mon, Jun 13, 2022 at 1:51 PM Greg Stark wrote:
>> By "relatively common" I think we're talking "nigh universal". Afaics
>> there are no warnings in the docs about worrying about search_path on
>> IMMUTABLE functions. There is fo
Kyotaro Horiguchi writes:
> At Mon, 13 Jun 2022 13:25:01 -0400, Tom Lane wrote in
>> I was about to question that, but now I remember that pg_upgrade has
>> its own logging facility with a different idea about who provides
>> the trailing newline than common/logging.[hc] has. Undoubtedly
>> tha
On Fri, Jun 10, 2022 at 05:45:11PM -0400, Andrew Dunstan wrote:
> The module is already a noop if there's a TAP test for pg_upgrade. So I
> don't understand the point of the PR at all.
Oh. I thought that the old path was still taken as long as
--enable-tap-tests was not used. I was wrong, then.
On Mon, Jun 13, 2022 at 10:41:41PM -0400, Tom Lane wrote:
> * logging.c believes it should prefix every line of output with the
> program's name and so on. This doesn't seem terribly appropriate
> for pg_upgrade's use --- at least, not unless we make pg_upgrade
> WAY less chatty. Perhaps that'd b
Peter Eisentraut writes:
> Switching the order of -bundle_loader and -lc did not help.
Meh. Well, it was worth a try.
I'd be okay with just dropping the -lc from pl/tcl/Makefile and seeing
what the buildfarm says. The fact that we needed it in 1998 doesn't
mean that we still need it on support
Hi.
FWIW, I stumbled on this obscure possible typo (?) in src/pl/plperl/po/ro.po:
~~~
#: plperl.c:788
msgid "while parsing Perl initialization"
msgstr "în timpul parsing inițializării Perl"
#: plperl.c:793
msgid "while running Perl initialization"
msgstr "în timpul rulării intializării Perl"
~~
On Wed, Jun 8, 2022 12:10 PM Amit Kapila wrote:
>
> On Tue, Jun 7, 2022 at 7:08 PM Euler Taveira wrote:
> >
> > On Tue, Jun 7, 2022, at 1:10 AM, Peter Smith wrote:
> >
> > The logical replication tablesync ignores the publication 'publish'
> > operations during the initial data copy.
> >
> > Thi
On Wednesday, June 8, 2022 7:04 PM Amit Kapila wrote:
>
> On Fri, Jun 3, 2022 at 3:37 PM vignesh C wrote:
> >
> > Thanks for the comments, the attached v8 patch has the changes for the
> same.
> >
>
> AFAICS, the summary of this proposal is that we want to support
> exclude of certain objects f
On Thu, Jun 09, 2022 at 04:29:38PM -0700, Jacob Champion wrote:
> On Wed, Jun 8, 2022 at 9:58 PM Michael Paquier wrote:
>> Er, this one could be a problem protocol-wise for SASL, because that
>> would mean that the authentication gets completed but that the
>> exchange has begun and is not finishe
On Mon, Jun 13, 2022 at 9:26 PM Amit Kapila wrote:
> On Mon, Jun 13, 2022 at 1:03 PM houzj.f...@fujitsu.com
> wrote:
> > On Monday, June 13, 2022 1:53 PM Amit Kapila
> > wrote:
> > I have separated out the bug-fix for the subscriber-side.
> > And fix the typo and function name.
> > Attach the n
On Mon, Jun 13, 2022 at 6:14 PM Amit Kapila wrote:
> On Mon, Jun 13, 2022 at 2:20 PM Amit Langote wrote:
> > On Sat, Jun 11, 2022 at 10:36 AM Amit Kapila
> > wrote:
> > > On Fri, Jun 10, 2022 at 2:26 PM Amit Langote
> > > wrote:
> > > >
> > > > +logicalrep_partmap_invalidate
> > > >
> > > > I
On Mon, Jun 13, 2022 at 8:29 AM Masahiko Sawada wrote:
>
> On Tue, Jun 7, 2022 at 9:32 PM Amit Kapila wrote:
> >
> > On Mon, May 30, 2022 at 11:13 AM Masahiko Sawada
> > wrote:
> > >
> > > On Wed, May 25, 2022 at 12:11 PM Masahiko Sawada
> > > wrote:
> > > >
> > >
> > > poc_add_regression_tes
74 matches
Mail list logo
