Re: Rewriting the test of pg_upgrade as a TAP test - take three - remastered set

2022-05-14 Thread Noah Misch
On Thu, May 12, 2022 at 02:27:30PM +0900, Michael Paquier wrote: > On Tue, May 10, 2022 at 10:32:55PM -0700, Noah Misch wrote: > > On Wed, May 11, 2022 at 10:29:44AM +0900, Michael Paquier wrote: > > > On Mon, May 09, 2022 at 12:18:39PM +0900, Michael Paquier wrote: > > > > All these fixes lead me

Re: Backends stunk in wait event IPC/MessageQueueInternal

2022-05-14 Thread Japin Li
On Sat, 14 May 2022 at 11:01, Thomas Munro wrote: > On Sat, May 14, 2022 at 10:25 AM Thomas Munro wrote: >> Japin, are you able to reproduce the problem reliably? Did I guess >> right, that you're on illumos? Does this help? I used >> defined(__sun__) to select the option, but I don't rememb

Re: Backends stunk in wait event IPC/MessageQueueInternal

2022-05-14 Thread Japin Li
On Fri, 13 May 2022 at 22:08, Robert Haas wrote: > On Fri, May 13, 2022 at 6:16 AM Japin Li wrote: >> The process cannot be terminated by pg_terminate_backend(), although >> it returns true. > > pg_terminate_backend() just sends SIGINT. What I'm wondering is what > happens when the stuck proces

Re: list of TransactionIds

2022-05-14 Thread Amit Kapila
On Sat, May 14, 2022 at 1:57 AM Alvaro Herrera wrote: > > We didn't have any use of TransactionId as members of List, until > RelationSyncEntry->streamed_txns was introduced (464824323e57, pg14). > It's currently implemented as a list of int. This is not wrong at > present, but it may soon be, an

Re: Skipping schema changes in publication

2022-05-14 Thread vignesh C
On Fri, May 13, 2022 at 9:37 AM Peter Smith wrote: > > On Thu, May 12, 2022 at 2:24 PM vignesh C wrote: > > > ... > > The attached patch has the implementation for "ALTER PUBLICATION > > pubname RESET". This command will reset the publication to default > > state which includes resetting the publ

Re: Intermittent buildfarm failures on wrasse

2022-05-14 Thread Alvaro Herrera
On 2022-Apr-20, Masahiko Sawada wrote: > > MyProc->statusFlags = (MyProc->statusFlags & ~PROC_XMIN_FLAGS) | > > (proc->statusFlags & PROC_XMIN_FLAGS); > > > > Perhaps the latter is more future-proof. > Copying only xmin-related flags in this way also makes sense to m

Re: First draft of the PG 15 release notes

2022-05-14 Thread Bruce Momjian
On Sat, May 14, 2022 at 10:22:10AM +0530, Amit Kapila wrote: > > I see the point now --- new item: > > > > > > > > > > > > Prevent logical replication of empty transactions (Ajin Cherian, > > Hou Zhijie, Euler Taveira) > > > > > > > >

PostgreSQL 15 Beta 1 release announcement draft

2022-05-14 Thread Jonathan S. Katz
Hi, Attached is a draft of the release announcement for the PostgreSQL 15 Beta 1 release. The goal of this announcement is to raise awareness around many of the new features appearing in PostgreSQL 15 and to encourage people to test. The success of the PostgreSQL 15 GA depends heavily on peop

Re: PostgreSQL 15 Beta 1 release announcement draft

2022-05-14 Thread Justin Pryzby
On Sat, May 14, 2022 at 02:52:35PM -0400, Jonathan S. Katz wrote: > PostgreSQL 15 is made generally available, thouh some details of the release > can though > a SQL standard command for conditionally perform write operations (`INSERT`, performing > he [`range_agg`](https://www.postgresql.org/

Avoid unecessary MemSet call (src/backend/utils/cache/relcache.c)

2022-05-14 Thread Ranier Vilela
Hi hackers, At function load_relcache_init_file, there is an unnecessary function call, to initialize pgstat_info pointer to NULL. MemSet(&rel->pgstat_info, 0, sizeof(rel->pgstat_info)); I think that intention with use of MemSet was: MemSet(&rel->pgstat_info, 0, sizeof(*rel->pgstat_info)); Init

Tracking notnull attributes inside Var

2022-05-14 Thread Andy Fan
notnulls discussion is forked from UniqueKey stuff, you can see the attachment for the UnqiueKey introduction. Tom raised his opinion to track the nullability inside Var[1][2][3], this thread would start from there based on my understanding. Generally tracking the null attributes inside Var would