New Object Access Type hooks

2022-03-17 Thread Mark Dilger
Hackers, Over in [1], Joshua proposed a new set of Object Access Type hooks based on strings rather than Oids. His patch was written to be applied atop my patch for granting privileges on gucs. On review of his patch, I became uncomfortable with the complete lack of regression test coverage.

Re: Proposal: Support custom authentication methods using hooks

2022-03-17 Thread Andres Freund
Hi, On 2022-03-17 22:13:27 -0400, Stephen Frost wrote: > This isn’t the first time I asked about this on this thread, yet the > question about why this is only being discussed as backend changes, and > with the only goal seeming to be to have a backend loadable module, without > anything on the cl

Re: Assert in pageinspect with NULL pages

2022-03-17 Thread Alexander Lakhin
Hello Michael, 18.03.2022 05:06, Michael Paquier wrote: Okay. I'll try to look more closely at that, then. It feels like we are just missing a MAXALIGN() in those code paths. Are you using any specific CFLAGS or something environment-sensitive (macos, 32b, etc.)? No, just x86_64, Ubuntu 20.04,

Re: Proposal: Support custom authentication methods using hooks

2022-03-17 Thread Stephen Frost
Greetings, On Thu, Mar 17, 2022 at 23:25 Andres Freund wrote: > On 2022-03-17 22:13:27 -0400, Stephen Frost wrote: > > This isn’t the first time I asked about this on this thread, yet the > > question about why this is only being discussed as backend changes, and > > with the only goal seeming t

Re: Proposal: Support custom authentication methods using hooks

2022-03-17 Thread Andres Freund
Hi, On 2022-03-18 00:03:37 -0400, Stephen Frost wrote: > On Thu, Mar 17, 2022 at 23:25 Andres Freund wrote: > > It's imo a separate project to make the client side extensible. There's > > plenty > > of authentication methods that don't need any further client side support > > than > > the existin

Re: [Proposal] Fully WAL logged CREATE DATABASE - No Checkpoints

2022-03-17 Thread Dilip Kumar
On Fri, Mar 18, 2022 at 1:44 AM Robert Haas wrote: > > On Wed, Mar 16, 2022 at 12:53 AM Dilip Kumar wrote: > > Thanks Ashutosh and Robert. Other pacthes cleanly applied on this > > patch still generated a new version so that we can find all patches > > together. There are no other changes. > >

Re: Proposal: Support custom authentication methods using hooks

2022-03-17 Thread Stephen Frost
Greetings, On Fri, Mar 18, 2022 at 00:24 Andres Freund wrote: > Hi, > > On 2022-03-18 00:03:37 -0400, Stephen Frost wrote: > > On Thu, Mar 17, 2022 at 23:25 Andres Freund wrote: > > > It's imo a separate project to make the client side extensible. There's > > > plenty > > > of authentication me

RE: Logical replication timeout problem

2022-03-17 Thread wangw.f...@fujitsu.com
On Thu, Mar 17, 2022 at 7:52 PM Masahiko Sawada wrote: > Thanks for your comments. > On Thu, Mar 17, 2022 at 7:14 PM Amit Kapila wrote: > > > > On Thu, Mar 17, 2022 at 12:27 PM Amit Kapila > wrote: > > > > > > On Wed, Mar 16, 2022 at 7:38 PM Masahiko Sawada > wrote: > > > > > > > > After more

RE: Logical replication timeout problem

2022-03-17 Thread wangw.f...@fujitsu.com
On Thu, Mar 9, 2022 at 11:52 AM Kuroda, Hayato/黒田 隼人 wrote: > Thank you for updating! Thanks for your comments. > 1. pgoutput_change > ``` > + bool is_send = true; > ``` > > My first impression is that is_send should be initialized to false, and it > will change > to true when OutputPlug

Re: add checkpoint stats of snapshot and mapping files of pg_logical dir

2022-03-17 Thread Bharath Rupireddy
On Fri, Mar 18, 2022 at 2:15 AM Nathan Bossart wrote: > > On Thu, Mar 17, 2022 at 06:48:43PM +0530, Bharath Rupireddy wrote: > > Personally, I tend to agree with v4-0001 (option (4)) or v4-0002 > > (option (3)) than v4-0003 (option (1)) as it adds more unreadability > > with most of the code dupli

Re: Column Filtering in Logical Replication

2022-03-17 Thread Amit Kapila
On Fri, Mar 18, 2022 at 12:47 AM Tomas Vondra wrote: > > I pushed the second fix. Interestingly enough, wrasse failed in the > 013_partition test. I don't see how that could be caused by this > particular commit, though - see the pgsql-committers thread [1]. > I have a theory about what's going o

Re: Proposal: Support custom authentication methods using hooks

2022-03-17 Thread Andres Freund
Hi, On 2022-03-18 00:45:49 -0400, Stephen Frost wrote: > > I also don’t think that I agree that it’s acceptable to only have the > > > ability to extend the authentication on the server side as that implies a > > > whole bunch of client-side work that goes above and beyond just > > > implementing

Re: Tab completion for ALTER MATERIALIZED VIEW ... SET ACCESS METHOD

2022-03-17 Thread Michael Paquier
On Fri, Mar 18, 2022 at 10:27:41AM +0900, Yugo NAGATA wrote: > I added some queries in the regression test. Attached is the updated patch. Thanks. This looks rather sane to me. I'll split things into 3 commits in total, as of the psql completion, SET TABLESPACE and SET ACCESS METHOD. The first

PROPOSAL: Support global and local disabling of indexes

2022-03-17 Thread Paul Martinez
Hey, hackers, Adding and removing indexes is a regular part of database maintenance, but in a large database, removing an index can be a very risky operation. Removing the wrong index could have disastrous consequences for performance, and it could take tens of minutes, or even hours, to rebuild t

Re: PROPOSAL: Support global and local disabling of indexes

2022-03-17 Thread Julien Rouhaud
Hi, On Thu, Mar 17, 2022 at 11:16:24PM -0700, Paul Martinez wrote: > > Adding and removing indexes is a regular part of database maintenance, > but in a large database, removing an index can be a very risky operation. > Removing the wrong index could have disastrous consequences for > performance,

Re: ICU for global collation

2022-03-17 Thread Julien Rouhaud
On Thu, Mar 17, 2022 at 02:14:52PM +0100, Peter Eisentraut wrote: > On 17.03.22 13:01, Shinoda, Noriyoshi (PN Japan FSIP) wrote: > > Thank you to all the developers. > > I found that the description of the pg_database.daticulocale column was not > > written in the documentation. > > The attached s

<    1   2