Re: pg_tablespace_location() failure with allow_in_place_tablespaces

2022-03-14 Thread Thomas Munro
On Tue, Mar 15, 2022 at 2:50 PM Michael Paquier wrote: > On Tue, Mar 15, 2022 at 02:33:17PM +1300, Thomas Munro wrote: > > As for the complaint about pg_tablespace_location() failing, would it > > be better to return an empty string? That's what was passed in as > > LOCATION. Something like the

Re: Issue with pg_stat_subscription_stats

2022-03-14 Thread Amit Kapila
On Sun, Mar 13, 2022 at 1:45 AM Andres Freund wrote: > > On 2022-03-12 08:28:35 +0530, Amit Kapila wrote: > > On Sat, Mar 12, 2022 at 2:14 AM Melanie Plageman > > wrote: > > > > > > So, I noticed that pg_stat_reset_subscription_stats() wasn't working > > > properly, and, upon further investigatio

RE: Handle infinite recursion in logical replication setup

2022-03-14 Thread kuroda.hay...@fujitsu.com
Dear Vignesh, > Thanks for kind explanation. > I read above and your doc in 0002, and I put some comments. I forgot a comment about 0002 doc. 5. create_subscription.sgml - about your example Three possibilities were listed in the doc, but I was not sure about b) case. In the situation Node1 and

Re: Issue with pg_stat_subscription_stats

2022-03-14 Thread Masahiko Sawada
On Tue, Mar 15, 2022 at 3:34 AM Melanie Plageman wrote: > > On Mon, Mar 14, 2022 at 4:02 AM Masahiko Sawada wrote: > > > > On Mon, Mar 14, 2022 at 2:05 AM Melanie Plageman > > wrote: > > > > > > On Sat, Mar 12, 2022 at 3:15 PM Andres Freund wrote: > > > > > > > > Hi, > > > > > > > > On 2022-03-

Re: Column Filtering in Logical Replication

2022-03-14 Thread Amit Kapila
On Mon, Mar 14, 2022 at 4:42 PM houzj.f...@fujitsu.com wrote: > > On Monday, March 14, 2022 5:08 AM Tomas Vondra > wrote: > > > > On 3/12/22 05:30, Amit Kapila wrote: > > >> ... > > > > > > Okay, please find attached. I have done basic testing of this, if we > > > agree with this approach then t

Re: Column Filtering in Logical Replication

2022-03-14 Thread Amit Kapila
On Mon, Mar 14, 2022 at 7:02 PM Tomas Vondra wrote: > > On 3/14/22 13:47, Amit Kapila wrote: > > On Mon, Mar 14, 2022 at 5:42 PM Tomas Vondra > > wrote: > >> > >> On 3/14/22 12:12, houzj.f...@fujitsu.com wrote: > >>> On Monday, March 14, 2022 5:08 AM Tomas Vondra > >>> wrote: > >> > >> Anyway,

Re: BufferAlloc: don't take two simultaneous locks

2022-03-14 Thread Yura Sokolov
В Пн, 14/03/2022 в 14:57 +0300, Yura Sokolov пишет: > В Пн, 14/03/2022 в 17:12 +0900, Kyotaro Horiguchi пишет: > > At Mon, 14 Mar 2022 09:15:11 +0300, Yura Sokolov > > wrote in > > > В Пн, 14/03/2022 в 14:31 +0900, Kyotaro Horiguchi пишет: > > > > I'd like to ask you to remove nalloced from part

Re: standby recovery fails (tablespace related) (tentative patch and discussion)

2022-03-14 Thread Kyotaro Horiguchi
At Mon, 14 Mar 2022 17:37:40 -0400, Robert Haas wrote in > On Mon, Mar 7, 2022 at 3:39 AM Kyotaro Horiguchi > wrote: > > So the new framework has been dropped in this version. > > The second test is removed as it is irrelevant to this bug. > > > > In this version the patch is a single file that

Re: Skipping logical replication transactions on subscriber side

2022-03-14 Thread Masahiko Sawada
Hi, On Fri, Mar 11, 2022 at 8:37 PM osumi.takami...@fujitsu.com wrote: > > On Friday, March 11, 2022 5:20 PM Masahiko Sawada > wrote: > > I've attached an updated version patch. This patch can be applied on top of > > the > > latest disable_on_error patch[1]. > Hi, thank you for the patch. I'l

Re: generic plans and "initial" pruning

2022-03-14 Thread Amit Langote
On Tue, Mar 15, 2022 at 5:06 AM Robert Haas wrote: > On Mon, Mar 14, 2022 at 3:38 PM Tom Lane wrote: > > What I am skeptical about is that this work actually accomplishes > > anything under real-world conditions. That's because if pruning would > > save enough to make skipping the lock-acquisiti

Re: Support logical replication of DDLs

2022-03-14 Thread rajesh singarapu
+ On Sun, Mar 13, 2022 at 5:05 PM Dilip Kumar wrote: > > On Mon, Feb 21, 2022 at 9:43 PM Zheng Li wrote: > > > > Hello, > > > > One of the most frequently requested improvements from our customers > > is to reduce downtime associated with software updates (both major and > > minor versions). To

Re: Add checkpoint and redo LSN to LogCheckpointEnd log message

2022-03-14 Thread Bharath Rupireddy
On Fri, Mar 4, 2022 at 10:40 AM Kyotaro Horiguchi wrote: > > At Mon, 14 Feb 2022 14:52:15 +0900 (JST), Kyotaro Horiguchi > wrote in > > In this version , 0001 gets one fix and two comment updates. > > While the disucssion on back-patching of 0001 proceeding on another > branch, the main patch is

<    1   2