Re: shared-memory based stats collector

At Wed, 2 Mar 2022 18:16:00 -0800, Andres Freund wrote in > Hi, > > On 2021-07-26 18:27:54 -0700, Andres Freund wrote: > > I had intended to post a rebase by now. But while I did mostly finish > > that (see [1]) I unfortunately encountered a new issue around > > partitioned tables, see [2]. Curr

Re: Skipping logical replication transactions on subscriber side

On Tue, Mar 1, 2022 at 8:31 PM Masahiko Sawada wrote: > > I’ve considered a plan for the skipping logical replication > transaction feature toward PG15. Several ideas and patches have been > proposed here and another related thread[1][2] for the skipping > logical replication transaction feature a

Re: libpq compression (part 2)

Ok, thanks > On 3 Mar 2022, at 02:33, Justin Pryzby wrote: > > If there's no objection, I'd like to move this to the next CF for > consideration > in PG16. > > On Mon, Jan 17, 2022 at 10:39:19PM -0600, Justin Pryzby wrote: >> On Tue, Jan 18, 2022 at 02:06:32AM +0500, Daniil Zakhlystov wrote:

Re: Support for grabbing multiple consecutive values with nextval()

On 02.03.22 20:12, Jille Timmermans wrote: On 2022-02-28 11:13, Peter Eisentraut wrote: On 27.02.22 10:42, Jille Timmermans wrote: I wanted to be able to allocate a bunch of numbers from a sequence at once. Multiple people seem to be struggling with this (https://stackoverflow.com/questions/89

Re: Commitfest 2022-03 Patch Triage Part 1a.i

On Tue, 1 Mar 2022 13:39:45 -0500 Greg Stark wrote: > As Justin suggested I CC the authors from these patches I'm adding > them here. Some of the patches have multiple "Authors" listed in the > commitfest which may just be people who posted updated patches so I > may have added more people than n

RE: Logical replication timeout problem

Dear Wang, > Attach the new patch. [suggestion by Kuroda-San] > 1. Fix the typo. > 2. Improve comment style. > 3. Fix missing consideration. > 4. Add comments to clarifies above functions and function calls. Thank you for updating the patch! I confirmed they were fixed. ```

Re: Support for grabbing multiple consecutive values with nextval()

On 2022-03-03 10:10, Peter Eisentraut wrote: On 02.03.22 20:12, Jille Timmermans wrote: On 2022-02-28 11:13, Peter Eisentraut wrote: On 27.02.22 10:42, Jille Timmermans wrote: I wanted to be able to allocate a bunch of numbers from a sequence at once. Multiple people seem to be struggling with

Re: Proposal: Support custom authentication methods using hooks

On 02.03.22 21:26, Stephen Frost wrote: Part of the point, for my part anyway, of dropping support for plaintext transmission would be to remove support for that from libpq, otherwise a compromised server could still potentially convince a client to provide a plaintext password be sent to it. I

Re: Proposal: Support custom authentication methods using hooks

On 02.03.22 16:45, Jonathan S. Katz wrote: By that argument, we should have kept "password" (plain) as an authentication method. For comparison, the time between adding md5 and removing password was 16 years. It has been 5 years since scram was added.

Re: Proposal: Support custom authentication methods using hooks

On 02.03.22 15:16, Jonathan S. Katz wrote: What are the reasons they are still purposely using it? The ones I have seen/heard are: - Using an older driver - On a pre-v10 PG - Unaware of SCRAM Another reason is that SCRAM presents subtle operational issues in distributed systems. As someone

Re: Make mesage at end-of-recovery less scary.

On Wed, Mar 2, 2022 at 7:47 AM Kyotaro Horiguchi wrote: > > At Sat, 19 Feb 2022 09:31:33 +0530, Ashutosh Sharma > wrote in > > The changes looks good. thanks.! > > Thanks! > > Some recent core change changed WAL insertion speed during the TAP > test and revealed one forgotton case of EndOfWAL.

Re: Proposal: Support custom authentication methods using hooks

On 02.03.22 21:49, samay sharma wrote: I think we are discussing two topics in this thread which in my opinion are orthogonal. (a) Should we make authentication methods pluggable by exposing these hooks? - These will allow users to add plugins of their own to support whatever auth method they

Re: Mingw task for Cirrus CI

Hi Andres, > This presumably is due to using mingw's python rather than python.org's > python. Seems like a reasonable thing to support for the mingw build. > > Melih, you could try to build against the python.org python (i installed > in > the CI container). > I tried to use the installed pytho

Re: row filtering for logical replication

On Thu, Mar 3, 2022 at 11:18 AM shiy.f...@fujitsu.com wrote: > > On Thu, Mar 3, 2022 10:40 AM Amit Kapila wrote: > > > > On Wed, Mar 2, 2022 at 5:42 PM Euler Taveira wrote: > > > > > > On Wed, Mar 2, 2022, at 8:45 AM, Tomas Vondra wrote: > > > > > > While working on the column filtering patch, w

Re: Add 64-bit XIDs into PostgreSQL 15

> > > The patch doesn't apply - I suppose the patch is relative a forked > postgres > > No, the authors just used a little outdated `master` branch. I > successfully applied it against 31d8d474 and then rebased to the > latest master (62ce0c75). The new version is attached. Not 100% sure if my reb

Re: Add 64-bit XIDs into PostgreSQL 15

BTW messages with patches in this thread are always invoke manual spam moderation and we need to wait for ~3 hours before the message with patch becomes visible in the hackers thread. Now when I've already answered Alexander's letter with v10 patch the very message (and a patch) I've answered is st

Problem with moderation of messages with patched attached.

Hi, hackers! Around 2 months ago I've noticed a problem that messages containing patches in the thread [1] were always processed with manual moderation. They appear in hackers' thread hours after posting None of them are from new CF members and personally, I don't see a reason for such inconvenien

Re: Problem with moderation of messages with patched attached.

On Thu, Mar 3, 2022 at 3:31 PM Pavel Borisov wrote: > Hi, hackers! > > Around 2 months ago I've noticed a problem that messages containing > patches in the thread [1] were always processed with manual moderation. > They appear in hackers' thread hours after posting None of them are from > new CF

Re: Commitfest 2022-03 Patch Triage Part 1a.i

> On 3 Mar 2022, at 10:11, Yugo NAGATA wrote: > I think this patch set needs more reviews to be commitable in 15, so I > returned the target version to blank. I'll change it to 16 later. I've added 16 as a target version in the CF app now. -- Daniel Gustafsson https://vmware.com/

Re: Mingw task for Cirrus CI

On 3/3/22 05:16, Melih Mutlu wrote: > Hi Andres,  >   > > This presumably is due to using mingw's python rather than > python.org 's > python. Seems like a reasonable thing to support for the mingw build. > > Melih, you could try to build against the python.org

Re: Problem with moderation of messages with patched attached.

Hi hackers, > Confirm Here are my two cents. My last email to pgsql-jobs@ was moderated in a similar fashion. To my knowledge that mailing list is not pre-moderated. So it may have the same problem, and not only with patches. (We use regular Google Workspace.) The pgsql-hackers@ thread under qu

Re: Add the replication origin name and commit-LSN to logical replication worker errcontext

On Thu, Mar 3, 2022 at 3:37 PM Amit Kapila wrote: > > On Wed, Mar 2, 2022 at 1:05 PM Masahiko Sawada wrote: > > > > On Wed, Mar 2, 2022 at 4:14 PM Amit Kapila wrote: > > > > I've attached updated patches. > > > > The first patch LGTM. Some comments on the second patch: > > 1. > @@ -3499,6 +3503,

Re: Rewriting the test of pg_upgrade as a TAP test - take three - remastered set

On 3/3/22 00:03, Michael Paquier wrote: >>> +if ( (defined($ENV{olddump}) && !defined($ENV{oldinstall})) >>> + || (!defined($ENV{olddump}) && defined($ENV{oldinstall}))) >> Odd indentation. Spaces between parens? > Well, perltidy tells me that this is right. > > Yeah, I haven't found a way t

Re: Problem with moderation of messages with patched attached.

Hi On Thu, 3 Mar 2022 at 12:31, Pavel Borisov wrote: > Hi, hackers! > > Around 2 months ago I've noticed a problem that messages containing > patches in the thread [1] were always processed with manual moderation. > They appear in hackers' thread hours after posting None of them are from > new C

Re: Problem with moderation of messages with patched attached.

> > Message to list pgsql-hackers held for moderation due to 'Size 1MB > (1061796 bytes) is larger than threshold 1000KB (1024000 bytes)', notice > queued for 2 moderators > Could you make this limit 2MB at least for authorized commitfest members? Thanks! -- Best regards, Pavel Borisov Postgres P

Re: Problem with moderation of messages with patched attached.

Hi Dave, > Message to list pgsql-hackers held for moderation due to 'Size 1MB (1061796 > bytes) is larger than threshold 1000KB (1024000 bytes)', notice queued for 2 > moderators Thanks! Does anyone know if cfbot understands .patch.gz and/or .tgz ? -- Best regards, Aleksander Alekseev

Re: Problem with moderation of messages with patched attached.

On Thu, 3 Mar 2022 at 13:22, Pavel Borisov wrote: > Message to list pgsql-hackers held for moderation due to 'Size 1MB >> (1061796 bytes) is larger than threshold 1000KB (1024000 bytes)', notice >> queued for 2 moderators >> > Could you make this limit 2MB at least for authorized commitfest membe

Re: Problem with moderation of messages with patched attached.

> > The mail system doesn't have the capability to apply different moderation > rules for people in that way I'm afraid. > Maybe then 2MB for everyone? Otherwise it's not so convenient. Lead to answers before the questions in the thread [1], seems weird. [1] https://www.postgresql.org/message-id/f

Re: Problem with moderation of messages with patched attached.

On Thu, Mar 03, 2022 at 04:24:03PM +0300, Aleksander Alekseev wrote: > > Thanks! Does anyone know if cfbot understands .patch.gz and/or .tgz ? There's a FAQ link on the cfbot main page that answers this kind of questions.

Re: Add 64-bit XIDs into PostgreSQL 15

Hi Pavel! On Thu, Mar 3, 2022 at 2:35 PM Pavel Borisov wrote: > BTW messages with patches in this thread are always invoke manual spam > moderation and we need to wait for ~3 hours before the message with patch > becomes visible in the hackers thread. Now when I've already answered > Alexander

Re: Problem with moderation of messages with patched attached.

> > There's a FAQ link on the cfbot main page that answers this kind of > questions. > Good to know! I'll try [.gz] next time then. Thanks!

Re: Problem with moderation of messages with patched attached.

On Thu, 3 Mar 2022 at 13:28, Pavel Borisov wrote: > The mail system doesn't have the capability to apply different moderation >> rules for people in that way I'm afraid. >> > Maybe then 2MB for everyone? Otherwise it's not so convenient. Lead to > answers before the questions in the thread [1], s

Re: Add 64-bit XIDs into PostgreSQL 15

> > > BTW messages with patches in this thread are always invoke manual spam > moderation and we need to wait for ~3 hours before the message with patch > becomes visible in the hackers thread. Now when I've already answered > Alexander's letter with v10 patch the very message (and a patch) I've >

Re: Problem with moderation of messages with patched attached.

Hi Dave, > Then someone will complain if their patch is 2.1MB! How often are messages > legitimately over 1MB anyway, even with a patch? I don't usually moderate > -hackers, so I don't know if this is a common thing or not. > > I'll ping a message across to the sysadmin team anyway; I can't just

Re: Problem with moderation of messages with patched attached.

On Thu, Mar 03, 2022 at 01:37:35PM +, Dave Page wrote: > > Then someone will complain if their patch is 2.1MB! How often are messages > legitimately over 1MB anyway, even with a patch? I don't usually moderate > -hackers, so I don't know if this is a common thing or not. It's not common, most

Re: Problem with moderation of messages with patched attached.

> > On Thu, 3 Mar 2022 at 13:28, Pavel Borisov wrote: > >> The mail system doesn't have the capability to apply different moderation >>> rules for people in that way I'm afraid. >>> >> Maybe then 2MB for everyone? Otherwise it's not so convenient. Lead to >> answers before the questions in the thr

Re: Problem with moderation of messages with patched attached.

Hi again, > Any chance we could include the reason in the message? I foresee that > otherwise such kinds of questions will be asked over and over again. A link to the list of common reasons should work too. -- Best regards, Aleksander Alekseev

Re: Allow parallel plan for referential integrity checks?

Hello, sorry for the late reply. On 2/14/22 15:33, Robert Haas wrote: On Mon, Feb 7, 2022 at 5:26 AM Frédéric Yhuel wrote: I noticed that referential integrity checks aren't currently parallelized. Is it on purpose? It's not 100% clear to me that it is safe. But on the other hand, it's also

Re: Add id's to various elements in protocol.sgml

On 02.03.2022 at 18:54, Chapman Flack wrote: Perhaps there are a bunch of variablelists where no one cares about linking to any of the entries. So maybe a useful non-terminating message to add eventually would be one that identifies any varlistentry lacking an id, with a variablelist where at le

Re: pg_walinspect - a new extension to get raw WAL data and WAL stats

Here are a few comments. 1) > > > == > > > > > > +-- > > > +-- pg_get_wal_records_info_till_end_of_wal() > > > +-- > > > +CREATE FUNCTION pg_get_wal_records_info_till_end_of_wal(IN start_lsn > > > pg_lsn, > > > +OUT lsn pg_lsn, > > > +OUT prev_lsn pg_lsn, > > > +OUT xid xid, > > > > >

Re: Report checkpoint progress with pg_stat_progress_checkpoint (was: Report checkpoint progress in server logs)

Here are some of my review comments on the latest patch: + + + type text + + + Type of checkpoint. See . + + + + + + kind text + + + Kind of checkpoint. See . + + This looks a bit confusing. Two columns, o

Re: pg_walinspect - a new extension to get raw WAL data and WAL stats

I think we should also see if we can allow end users to input timeline information with the pg_walinspect functions. This will help the end users to get information about WAL records from previous timeline which can be helpful in case of restored servers. -- With Regards, Ashutosh Sharma. On Thu,

Re: Problem with moderation of messages with patched attached.

Pavel Borisov writes: >> The mail system doesn't have the capability to apply different moderation >> rules for people in that way I'm afraid. > Maybe then 2MB for everyone? Maybe your patch needs to be split up? You're going to have a hard time finding people who want to review or commit such

casting operand to proper type in BlockIdGetBlockNumber

Hi, In test output, I saw: src/backend/utils/adt/tid.c:112:16: runtime error: left shift of 65535 by 16 places cannot be represented in type 'int' I think this was due to the left shift in BlockIdGetBlockNumber not properly casting its operand. Please see the proposed change in patch. Thanks

Re: Problem with moderation of messages with patched attached.

On Thu, Mar 03, 2022 at 10:17:06AM -0500, Tom Lane wrote: > Pavel Borisov writes: > >> The mail system doesn't have the capability to apply different moderation > >> rules for people in that way I'm afraid. > > > Maybe then 2MB for everyone? > > Maybe your patch needs to be split up? You're goi

Re: casting operand to proper type in BlockIdGetBlockNumber

Zhihong Yu writes: > In test output, I saw: > src/backend/utils/adt/tid.c:112:16: runtime error: left shift of 65535 by > 16 places cannot be represented in type 'int' What compiler is that? regards, tom lane

Re: casting operand to proper type in BlockIdGetBlockNumber

On Thu, Mar 3, 2022 at 7:44 AM Tom Lane wrote: > Zhihong Yu writes: > > In test output, I saw: > > src/backend/utils/adt/tid.c:112:16: runtime error: left shift of 65535 by > > 16 places cannot be represented in type 'int' > > What compiler is that? > > regards, tom lane

Re: Proposal: Support custom authentication methods using hooks

On Thu, Mar 3, 2022 at 4:45 AM Peter Eisentraut wrote: > > On 02.03.22 16:45, Jonathan S. Katz wrote: > > By that argument, we should have kept "password" (plain) as an > > authentication method. > > For comparison, the time between adding md5 and removing password was 16 > years. It has been 5 y

Re: [Proposal] Global temporary tables

On Wed, Mar 2, 2022 at 4:18 PM Andres Freund wrote: > I think there's just no way that it can be merged with anything close to the > current design - it's unmaintainable. The need for the feature doesn't change > that. I don't know whether the design is right or wrong, but I agree that a bad desi

Re: [Proposal] Fully WAL logged CREATE DATABASE - No Checkpoints

On Tue, Mar 1, 2022 at 5:15 PM Dilip Kumar wrote: > On Tue, Feb 22, 2022 at 8:27 PM Ashutosh Sharma > wrote: > >> I'm not sure about the current status, but found it while playing >> around with the latest changes a bit, so thought of sharing it here. >> >> + >> + strategy >> +

Re: casting operand to proper type in BlockIdGetBlockNumber

Zhihong Yu writes: > On Thu, Mar 3, 2022 at 7:44 AM Tom Lane wrote: >> Zhihong Yu writes: >>> In test output, I saw: >>> src/backend/utils/adt/tid.c:112:16: runtime error: left shift of 65535 by >>> 16 places cannot be represented in type 'int' > Jenkins build is alma8-clang12-asan Oh, I misre

Re: [PATCH v2] use has_privs_for_role for predefined roles

On Thu, Feb 10, 2022 at 2:37 PM Joe Conway wrote: > > On 2/10/22 14:28, Nathan Bossart wrote: > > On Wed, Feb 09, 2022 at 04:39:11PM -0500, Joe Conway wrote: > >> On 2/9/22 13:13, Nathan Bossart wrote: > >>> I do wonder if users find the differences between predefined roles and > >>> role > >>> a

Re: casting operand to proper type in BlockIdGetBlockNumber

On Thu, Mar 3, 2022 at 8:24 AM Tom Lane wrote: > Zhihong Yu writes: > > On Thu, Mar 3, 2022 at 7:44 AM Tom Lane wrote: > >> Zhihong Yu writes: > >>> In test output, I saw: > >>> src/backend/utils/adt/tid.c:112:16: runtime error: left shift of 65535 > by > >>> 16 places cannot be represented in

Re: pg_walinspect - a new extension to get raw WAL data and WAL stats

On Fri, Feb 25, 2022 at 6:03 AM Bharath Rupireddy wrote: > Added a new function that returns the first and last valid WAL record > LSN of a given WAL file. Sounds like fuzzy thinking to me. WAL records can cross file boundaries, and forgetting about that leads to all sorts of problems. Just give

Re: casting operand to proper type in BlockIdGetBlockNumber

Zhihong Yu writes: > On Thu, Mar 3, 2022 at 8:24 AM Tom Lane wrote: >> Oh, I misread this as a compile-time warning, but it must be from ASAN. >> Was the test case one of your own, or just our normal regression tests? > The Jenkins test is ported from contrib/postgres_fdw/sql/postgres_fdw.sql -

Re: Add 64-bit XIDs into PostgreSQL 15

Greetings, * Pavel Borisov (pashkin.e...@gmail.com) wrote: > > > BTW messages with patches in this thread are always invoke manual spam > > moderation and we need to wait for ~3 hours before the message with patch > > becomes visible in the hackers thread. Now when I've already answered > > Alexan

Re: Proposal: Support custom authentication methods using hooks,Re: Proposal: Support custom authentication methods using hooks

Greetings, * Tatsuo Ishii (is...@sraoss.co.jp) wrote: > > On 2/25/22 12:39 PM, Tom Lane wrote: > >> Jeff Davis writes: > >>> On Thu, 2022-02-24 at 20:47 -0500, Tom Lane wrote: > ... and, since we can't readily enforce that the client only sends > those cleartext passwords over suitably-

Re: Proposal: Support custom authentication methods using hooks

On Thu, Mar 3, 2022 at 10:45:42AM +0100, Peter Eisentraut wrote: > On 02.03.22 16:45, Jonathan S. Katz wrote: > > By that argument, we should have kept "password" (plain) as an > > authentication method. > > For comparison, the time between adding md5 and removing password was 16 > years. It has

Re: casting operand to proper type in BlockIdGetBlockNumber

On Thu, Mar 3, 2022 at 9:13 AM Tom Lane wrote: > Zhihong Yu writes: > > On Thu, Mar 3, 2022 at 8:24 AM Tom Lane wrote: > >> Oh, I misread this as a compile-time warning, but it must be from ASAN. > >> Was the test case one of your own, or just our normal regression tests? > > > The Jenkins test

Re: casting operand to proper type in BlockIdGetBlockNumber

Hi, On 2022-03-03 12:13:40 -0500, Tom Lane wrote: > Zhihong Yu writes: > > On Thu, Mar 3, 2022 at 8:24 AM Tom Lane wrote: > >> Oh, I misread this as a compile-time warning, but it must be from ASAN. > >> Was the test case one of your own, or just our normal regression tests? > > > The Jenkins t

Re: Proposal: Support custom authentication methods using hooks

Greetings, * Tatsuo Ishii (is...@sraoss.co.jp) wrote: > > Yes, really, it's a known-broken system which suffers from such an old > > and well known attack that it's been given a name: pass-the-hash. As > > was discussed on this thread even, just the fact that it's not trivial > > to break on the

Re: Proposal: Support custom authentication methods using hooks

On 3/3/22 12:23 PM, Bruce Momjian wrote: On Thu, Mar 3, 2022 at 10:45:42AM +0100, Peter Eisentraut wrote: On 02.03.22 16:45, Jonathan S. Katz wrote: By that argument, we should have kept "password" (plain) as an authentication method. For comparison, the time between adding md5 and removing

Re: Proposal: Support custom authentication methods using hooks

Greetings, * Peter Eisentraut (peter.eisentr...@enterprisedb.com) wrote: > On 02.03.22 21:49, samay sharma wrote: > >I think we are discussing two topics in this thread which in my opinion > >are orthogonal. > > > >(a) Should we make authentication methods pluggable by exposing these > >hooks? - T

Re: Problem with moderation of messages with patched attached.

Greetings, * Aleksander Alekseev (aleksan...@timescale.com) wrote: > My last email to pgsql-jobs@ was moderated in a similar fashion. To my > knowledge that mailing list is not pre-moderated. So it may have the same > problem, and not only with patches. (We use regular Google Workspace.) -jobs is

Re: Problem with moderation of messages with patched attached.

Greetings, * Pavel Borisov (pashkin.e...@gmail.com) wrote: > > On Thu, 3 Mar 2022 at 13:28, Pavel Borisov wrote: > >> The mail system doesn't have the capability to apply different moderation > >>> rules for people in that way I'm afraid. > >>> > >> Maybe then 2MB for everyone? Otherwise it's not

Re: casting operand to proper type in BlockIdGetBlockNumber

Andres Freund writes: > On 2022-03-03 12:13:40 -0500, Tom Lane wrote: >> Hmph. I tried enabling -fsanitize=undefined here, and I get some >> complaints about passing null pointers to memcmp and the like, but >> nothing about this shift (tested with clang 12.0.1 on RHEL8 as well >> as clang 13.0.0

Re: casting operand to proper type in BlockIdGetBlockNumber

Hi, On 2022-03-03 12:45:22 -0500, Tom Lane wrote: > Andres Freund writes: > > On 2022-03-03 12:13:40 -0500, Tom Lane wrote: > >> Hmph. I tried enabling -fsanitize=undefined here, and I get some > >> complaints about passing null pointers to memcmp and the like, but > >> nothing about this shift

Re: Proposal: Support custom authentication methods using hooks

On Thu, Mar 3, 2022 at 12:38:32PM -0500, Jonathan Katz wrote: > On 3/3/22 12:23 PM, Bruce Momjian wrote: > > On Thu, Mar 3, 2022 at 10:45:42AM +0100, Peter Eisentraut wrote: > > > On 02.03.22 16:45, Jonathan S. Katz wrote: > > > > By that argument, we should have kept "password" (plain) as an > >

Re: wrong fds used for refilenodes after pg_upgrade relfilenode changes Reply-To:

On Wed, Mar 2, 2022 at 3:00 PM Andres Freund wrote: > On 2022-03-02 14:52:01 -0500, Robert Haas wrote: > > - I am having some trouble understanding clearly what 0001 is doing. > > I'll try to study it further. > > It tests for the various scenarios I could think of that could lead to FD > reuse, t

Re: Report checkpoint progress with pg_stat_progress_checkpoint (was: Report checkpoint progress in server logs)

On Wed, Mar 2, 2022 at 7:15 PM Nitin Jadhav wrote: > > > > > As mentioned upthread, there can be multiple backends that request a > > > > checkpoint, so unless we want to store an array of pid we should store > > > > a number > > > > of backend that are waiting for a new checkpoint. > > It's a go

Re: wrong fds used for refilenodes after pg_upgrade relfilenode changes Reply-To:

Hi, On 2022-03-03 13:11:17 -0500, Robert Haas wrote: > On Wed, Mar 2, 2022 at 3:00 PM Andres Freund wrote: > > On 2022-03-02 14:52:01 -0500, Robert Haas wrote: > > > - I am having some trouble understanding clearly what 0001 is doing. > > > I'll try to study it further. > > > > It tests for the v

Re: wrong fds used for refilenodes after pg_upgrade relfilenode changes Reply-To:

On Thu, Mar 3, 2022 at 1:28 PM Andres Freund wrote: > > I can't remember that verify() is the one that accesses conflict.db large > > while cause_eviction() is the one that accesses postgres.replace_sb for more > > than like 15 seconds. > > For more than 15seconds? The whole test runs in a few sec

Re: casting operand to proper type in BlockIdGetBlockNumber

I wrote: > Andres Freund writes: >> We should fix these passing-null-pointer cases... > Yeah, working on that now. The attached is enough to get through check-world with "-fsanitize=undefined" using RHEL8's clang 12.0.1. Most of it is the same old null-pointer-with-zero-count business, but the c

Re: Commitfest 2022-03 Patch Triage Part 1b

Just FYI. Better to follow up to the thread for the patch that's already in the CF. Otherwise your patch will missed by someone who looks at the CF entry to see the latest patch.

Re: [PATCH] Expose port->authn_id to extensions and triggers

On Wed, 2022-03-02 at 09:18 +0100, Peter Eisentraut wrote: > On 01.03.22 23:05, Jacob Champion wrote: > > On Tue, 2022-03-01 at 19:56 +0100, Peter Eisentraut wrote: > > > This patch contains no documentation. I'm having a hard time > > > understanding what the name "session_authn_id" is supposed t

Re: [PATCH] Expose port->authn_id to extensions and triggers

On Thu, 2022-03-03 at 16:45 +0900, Michael Paquier wrote: > Anyway, FixedParallelState > includes some authentication data passed down by the leader when > spawning a worker. So, if we were to pass down the authn, we are > going to need a new PARALLEL_KEY_* to serialize and restore the data > pass

Re: casting operand to proper type in BlockIdGetBlockNumber

Hi, On 2022-03-03 14:00:14 -0500, Tom Lane wrote: > The attached is enough to get through check-world with > "-fsanitize=undefined" using RHEL8's clang 12.0.1. Cool. > I'm not sure whether to back-patch --- looking through the > git logs, it seems we've back-patched some fixes like these > and

Re: row filtering for logical replication

On Thu, Mar 3, 2022, at 7:47 AM, Amit Kapila wrote: > LGTM. I'll push this tomorrow unless Tomas or Euler feels otherwise. Sounds good to me. -- Euler Taveira EDB https://www.enterprisedb.com/

Re: [Proposal] Global temporary tables

It doesn't look like this is going to get committed this release cycle. I understand more feedback could be valuable, especially on the overall design, but as this is the last commitfest of the release we should focus on other patches for now and spend that time in the next release cycle. I'm goin

Re: casting operand to proper type in BlockIdGetBlockNumber

Andres Freund writes: > On 2022-03-03 14:00:14 -0500, Tom Lane wrote: >> I'm not sure whether to back-patch --- looking through the >> git logs, it seems we've back-patched some fixes like these >> and not others. Thoughts? > It'd be easier to run a BF animal if we fixed it everywhere. Fair eno

Re: [Proposal] Global temporary tables

On Thu, Mar 3, 2022 at 3:29 PM Greg Stark wrote: > I'm still hopeful we get to advance this early in 16 because I think > everyone agrees the feature would be great. I'm not saying this patch can't make progress, but I think the chances of this being ready to commit any time in the v16 release cy

Re: pg_stop_backup() v2 incorrectly marked as proretset

On Wed, Mar 2, 2022 at 9:35 AM Tom Lane wrote: > Yeah, there's plenty of precedent for that coding if you look around. > I've not read the whole patch, but this snippet seems fine to me > if there's also an #undef at the end of the function. >From later emails, it sounds like that's not the commo

Re: casting operand to proper type in BlockIdGetBlockNumber

Hi, On 2022-03-03 15:31:51 -0500, Tom Lane wrote: > Andres Freund writes: > > On 2022-03-03 14:00:14 -0500, Tom Lane wrote: > > For the buildfarm, I could enable it on flaviventris? That runs an > > experimental gcc, without optimization (whereas serinus runs with > > optimization). Which seems r

Re: casting operand to proper type in BlockIdGetBlockNumber

On Thu, Mar 3, 2022 at 1:11 PM Andres Freund wrote: > Hi, > > On 2022-03-03 15:31:51 -0500, Tom Lane wrote: > > Andres Freund writes: > > > On 2022-03-03 14:00:14 -0500, Tom Lane wrote: > > > For the buildfarm, I could enable it on flaviventris? That runs an > > > experimental gcc, without optim

Re: [Proposal] Global temporary tables

Hi, On 2022-03-03 16:07:37 -0500, Robert Haas wrote: > On Thu, Mar 3, 2022 at 3:29 PM Greg Stark wrote: > > I'm still hopeful we get to advance this early in 16 because I think > > everyone agrees the feature would be great. > > I'm not saying this patch can't make progress, but I think the chan

Re: pg_stop_backup() v2 incorrectly marked as proretset

Robert Haas writes: > On Wed, Mar 2, 2022 at 9:35 AM Tom Lane wrote: >> I've not read the whole patch, but this snippet seems fine to me >> if there's also an #undef at the end of the function. >> From later emails, it sounds like that's not the common practice in > similar cases, and I don't pe

Re: casting operand to proper type in BlockIdGetBlockNumber

Andres Freund writes: > The message says: > src/backend/utils/adt/tid.c:112:16: runtime error: left shift of 65535 by 16 > places cannot be represented in type 'int' > Afaics that means bi_hi is 65535. So either we're dealing with a very large > relation or BlockIdGetBlockNumber() is getting pas

Re: pg_stop_backup() v2 incorrectly marked as proretset

On 03/03/22 16:40, Tom Lane wrote: > The point is to make it clear that the macro isn't intended to affect > code outside the function. Since C lacks block-scoped macros, > there's no other way to do that. > > I concede that a lot of our code is pretty sloppy about this, but > that doesn't make i

Re: pg_stop_backup() v2 incorrectly marked as proretset

Chapman Flack writes: > On 03/03/22 16:40, Tom Lane wrote: >> The point is to make it clear that the macro isn't intended to affect >> code outside the function. Since C lacks block-scoped macros, >> there's no other way to do that. > Would the > Datum values[3]; > bool nulls[ lengthof(va

Re: Reducing power consumption on idle servers

Jim Nasby writes: > I'm wondering if it'd be worth linking autovac wakeup from a truly idle > state to the stats collector. If there's no stats messages coming in > clearly there's nothing new for autovac. That seems pretty scary in the current system design, where the stats collector is intent

Re: standby recovery fails (tablespace related) (tentative patch and discussion)

At Wed, 02 Mar 2022 19:31:24 +0900 (JST), Kyotaro Horiguchi wrote in > A function added to Util.pm used perl2host, which has been removed > recently. And same function contained a maybe-should-have-been-removed line which makes Windows build unhappy. This should make all platforms in the CI ha

Re: Make mesage at end-of-recovery less scary.

At Thu, 3 Mar 2022 15:39:44 +0530, Ashutosh Sharma wrote in > The new changes made in the patch look good. Thanks to the recent > changes to speed WAL insertion that have helped us catch this bug. Thanks for the quick checking. > One small comment: > > record = (XLogRecord *) (state->

Re: pg_stop_backup() v2 incorrectly marked as proretset

On Thu, Mar 03, 2022 at 04:40:42PM -0500, Tom Lane wrote: > The point is to make it clear that the macro isn't intended to affect > code outside the function. Since C lacks block-scoped macros, > there's no other way to do that. > > I concede that a lot of our code is pretty sloppy about this, bu

Re: Add the replication origin name and commit-LSN to logical replication worker errcontext

On Thu, Mar 3, 2022 at 10:02 PM Masahiko Sawada wrote: > > > I'm updating the patches and will submit them. Attached updated version patches. Regards, -- Masahiko Sawada EDB: https://www.enterprisedb.com/ v3-0002-Add-the-origin-name-and-remote-commit-LSN-to-logi.patch Description: Binary da

Re: pg_stop_backup() v2 incorrectly marked as proretset

At Fri, 4 Mar 2022 10:09:19 +0900, Michael Paquier wrote in > On Thu, Mar 03, 2022 at 04:40:42PM -0500, Tom Lane wrote: > > The point is to make it clear that the macro isn't intended to affect > > code outside the function. Since C lacks block-scoped macros, > > there's no other way to do that

Re: logical replication empty transactions

I have split the patch into two. I have kept the logic of skipping streaming changes in the second patch. I will work on the second patch once we can figure out a solution for the COMMIT PREPARED after restart problem. regards, Ajin Cherian v23-0001-Skip-empty-transactions-for-logical-replicatio

Re: XLogReadRecord() error in XlogReadTwoPhaseData()

On Sun, Jan 16, 2022 at 01:02:41PM -0800, Noah Misch wrote: > My next steps: > > - Report a Debian bug for the sparc64+ext4 zeros problem. Reported to Debian, then upstream: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1006157 https://marc.info/?t=16453926991 Last week, someone confirme

Re: [PATCH] Expose port->authn_id to extensions and triggers

On Thu, Mar 03, 2022 at 07:16:17PM +, Jacob Champion wrote: > I guess it depends on what we want MyProcPort to look like in a > parallel worker. Are we comfortable having most of it be blank/useless? > Does it need to be filled in? Good question. It depends on the definition of how much authe

RE: Add the replication origin name and commit-LSN to logical replication worker errcontext

On Friday, March 4, 2022 10:09 AM Masahiko Sawada wrote: > On Thu, Mar 3, 2022 at 10:02 PM Masahiko Sawada > wrote: > > > > > > I'm updating the patches and will submit them. > > Attached updated version patches. Thank you for sharing the patch v3. Few minor comments. (1) v03-0001, apply_erro

false failure of test_docoding regression test

Hello. The CF-CI complained on one of my patch for seemingly a reason unrelated to the patch. https://cirrus-ci.com/task/5544213843542016?logs=test_world#L1666 > diff -U3 > /tmp/cirrus-ci-build/contrib/test_decoding/expected/slot_creation_error.out > /tmp/cirrus-ci-build/contrib/test_decoding/

  1   2   >