Re: Correct handling of blank/commented lines in PSQL interactive-mode history

2021-11-29 Thread Tom Lane
Greg Nancarrow writes: > After a bit of investigation, it seems that patch attachments (like > yours) with a Context-Type of "text/x-diff" download through Gmail in > CRLF format for me (I'm running a browser on Windows, but my Postgres > development environment is in a Linux VM). So those must ge

Re: Unifying VACUUM VERBOSE and log_autovacuum_min_duration output

2021-11-29 Thread Justin Pryzby
I think the 2nd chunk here could say "if (instrument)" like the first: > @@ -482,8 +480,10 @@ heap_vacuum_rel(Relation rel, VacuumParams *params, > TransactionId FreezeLimit; > MultiXactId MultiXactCutoff; > > - /* measure elapsed time iff autovacuum logging requires it */

Re: Can I assume relation would not be invalid during from ExecutorRun to ExecutorEnd

2021-11-29 Thread Dilip Kumar
On Tue, Nov 30, 2021 at 6:44 AM Andy Fan wrote: >> >> >>> >>> Why do you think this ought to be in the relcache, and not in the >>> executor's rangetable-associated data structures? > > > I re-think about this, I guess I didn't mention something clear enough. > That's true that I bound my bala s

Re: Unifying VACUUM VERBOSE and log_autovacuum_min_duration output

2021-11-29 Thread Peter Geoghegan
On Mon, Nov 29, 2021 at 8:19 PM Justin Pryzby wrote: > I think the 2nd chunk here could say "if (instrument)" like the first: I agree that that would be clearer. > Autovacuum's format doesn't show the number of scanned pages ; it shows how > many pages were skipped due to frozen bit, but not how

Re: row filtering for logical replication

2021-11-29 Thread Amit Kapila
On Mon, Nov 29, 2021 at 8:40 PM Euler Taveira wrote: > > On Mon, Nov 29, 2021, at 7:11 AM, Amit Kapila wrote: > > I don't think it is a good idea to combine the row-filter from the > publication that publishes just 'insert' with the row-filter that > publishes 'updates'. We shouldn't apply the 'in

RE: parallel vacuum comments

2021-11-29 Thread houzj.f...@fujitsu.com
On Mon, Nov 29, 2021 11:38 AM Masahiko Sawada wrote: > > Maybe we can start with using parallel_vacuum_*. We can change them > later if there is an argument. > > I've attached an updated patch. I don't update the terminology in > vacuum that we're discussing on another thread[1]. Hi, I noticed

Re: [PATCH] buffile: ensure start offset is aligned with BLCKSZ

2021-11-29 Thread Sasasu
On 2021/11/29 18:05, Antonin Houska wrote: > Does this test really pass regression tests? In BufFileRead(), I would > understand if you did > > + file->pos = offsetInBlock; > + file->curOffset -= offsetInBlock; > > rather than > > + fil

Re: parallel vacuum comments

2021-11-29 Thread Amit Kapila
On Tue, Nov 30, 2021 at 11:03 AM houzj.f...@fujitsu.com wrote: > > On Mon, Nov 29, 2021 11:38 AM Masahiko Sawada wrote: > > > > 2) > + /* Reinitialize the parallel context to relaunch parallel > workers */ > + if (!pvs->first_time) > > It seems the ParallelVacuumState

Re: row filtering for logical replication

2021-11-29 Thread Dilip Kumar
On Tue, Nov 30, 2021 at 10:26 AM Amit Kapila wrote: > > On Mon, Nov 29, 2021 at 8:40 PM Euler Taveira wrote: > > > > On Mon, Nov 29, 2021, at 7:11 AM, Amit Kapila wrote: > > > > I don't think it is a good idea to combine the row-filter from the > > publication that publishes just 'insert' with th

Re: GUC flags

2021-11-29 Thread Michael Paquier
On Mon, Nov 29, 2021 at 05:04:01PM +0900, Michael Paquier wrote: > 0001, to adjust the units, and 0003, to make the GUC descriptions less > unit-dependent, are good ideas. Actually, after sleeping on it and doing some digging in codesearch.debian.org, changing the units of max_identifier_length, b

Re: Can I assume relation would not be invalid during from ExecutorRun to ExecutorEnd

2021-11-29 Thread Andy Fan
> > > You will see there are many pointers also in > RelationData but we ensure before we access them they are initialized, > The initialized values are not much helpful in the cases I provided here. What do you think about this question? 2. _If_ the relation can be reset after we open it durin

Re: Can I assume relation would not be invalid during from ExecutorRun to ExecutorEnd

2021-11-29 Thread Dilip Kumar
On Tue, Nov 30, 2021 at 12:12 PM Andy Fan wrote: >> >> >> You will see there are many pointers also in >> RelationData but we ensure before we access them they are initialized, > > > The initialized values are not much helpful in the cases I provided here. > > What do you think about this questio

Update stale code comment in CheckpointerMain()

2021-11-29 Thread Amul Sul
Hi, The attached patch updates the code comment which is no longer true after commit # 4a92a1c3d1c361ffb031ed05bf65b801241d7cdd -- Regards, Amul Sul EDB: http://www.enterprisedb.com diff --git a/src/backend/postmaster/checkpointer.c b/src/backend/postmaster/checkpointer.c index be7366379d0..25a18

Re: rand48 replacement

2021-11-29 Thread Fabien COELHO
Pushed with that change and some others, notably: Thanks for the improvements and the push! -- Fabien.

Re: parallel vacuum comments

2021-11-29 Thread Masahiko Sawada
On Tue, Nov 30, 2021 at 3:00 PM Amit Kapila wrote: > > On Tue, Nov 30, 2021 at 11:03 AM houzj.f...@fujitsu.com > wrote: > > > > On Mon, Nov 29, 2021 11:38 AM Masahiko Sawada wrote: > > > > > > > 2) > > + /* Reinitialize the parallel context to relaunch parallel > > workers */ > >

<    1   2