Re: BUG #17212: pg_amcheck fails on checking temporary relations

2021-10-05 Thread Alexander Lakhin
Hello Mark, Peter, Robert, 05.10.2021 20:22, Peter Geoghegan пишет: > On Tue, Oct 5, 2021 at 10:03 AM Mark Dilger > wrote: >> I took no offense. Actually, I owe you a thank-you for having put so much >> effort into debating the behavior with me. I think the patch to fix bug >> #17212 will be b

Re: Incorrect snapshots while promoting hot standby node when 2PC is used

2021-10-05 Thread Andres Freund
On 2021-10-04 17:27:44 +0900, Michael Paquier wrote: > On Fri, Oct 01, 2021 at 02:11:15PM +0900, Michael Paquier wrote: > > A couple of months later, I have looked back at this thread and this > > report. I have rechecked all the standby handling and snapshot builds > > involving KnownAssignedXids

Re: A test for replay of regression tests

2021-10-05 Thread Thomas Munro
On Thu, Jun 10, 2021 at 7:47 PM Thomas Munro wrote: > On Thu, Jun 10, 2021 at 7:37 PM Anastasia Lubennikova > wrote: > > For some reason, it failed on cfbot, so I'll switch it back to 'Waiting on Sorry for the delay. I got stuck in a CI loop trying to make a new improved version work on Windows

Re: Windows crash / abort handling

2021-10-05 Thread Craig Ringer
On Wed, 6 Oct 2021, 03:30 Andres Freund, wrote: > Hi, > > > My first attempt was to try to use the existing crashdump stuff in > pgwin32_install_crashdump_handler(). That's not really quite what I want, > because it only handles postmaster rather than any binary, but I thought > it'd > be a good

Re: BUG #17212: pg_amcheck fails on checking temporary relations

2021-10-05 Thread Peter Geoghegan
On Tue, Oct 5, 2021 at 11:00 PM Alexander Lakhin wrote: > I think that ideally pg_amcheck should not fail on a live database, that > does not contain corrupted data, and should not affect the database > usage by other users (as it's "only a check"). I agree that that's ideal. As you said, one or

More business with $Test::Builder::Level in the TAP tests

2021-10-05 Thread Michael Paquier
Hi all, Following up with Peter E's recent commit 73aa5e0 to add some forgotten level incrementations, I got to look again at what I did wrong and why this stuff is useful. I have gone through all the TAP tests and any code paths using subroutines, to note that we could improve the locations of t

Re: wrapping CF 2021-09

2021-10-05 Thread Peter Geoghegan
On Tue, Oct 5, 2021 at 10:21 PM Jaime Casanova wrote: > At this time I'm looking to close the CF. Thanks, Jaime. -- Peter Geoghegan

<    1   2