Re: using an end-of-recovery record in all cases

2021-09-04 Thread Amit Kapila
On Tue, Aug 10, 2021 at 12:31 AM Robert Haas wrote: > > On Thu, Jul 29, 2021 at 11:49 AM Robert Haas wrote: > > On Wed, Jul 28, 2021 at 3:28 PM Andres Freund wrote: > > > > Imagine if instead of > > > > all the hairy logic we have now we just replaced this whole if > > > > (IsInRecovery) stanza

Re: [PATCH] Hooks at XactCommand level

2021-09-04 Thread Gilles Darold
I have changed the status of this proposal as rejected. To resume the final state of this proposal there is no consensus on the interest to add a hook on start xact commands. Also the only useful case for this hook was to be able to have a server side automatic rollback at statement level. It

Re: [PATCH] support tab-completion for single quote input with equal sign

2021-09-04 Thread Tom Lane
"tanghy.f...@fujitsu.com" writes: > [ v2-0001-support-tab-completion-for-single-quote-input-wit.patch ] Surely this patch is completely wrong? It needs more thought about the interaction with the existing logic for double quotes, ie single quote inside double quotes is not special, nor the rever

Re: Column Filtering in Logical Replication

2021-09-04 Thread Alvaro Herrera
On 2021-Sep-04, Amit Kapila wrote: > On Thu, Sep 2, 2021 at 2:19 PM Alvaro Herrera wrote: > > > > On 2021-Sep-02, Rahila Syed wrote: > > > > > After thinking about this, I think it is best to remove the entire table > > > from publication, > > > if a column specified in the column filter is dropp

Re: [PATCH] support tab-completion for single quote input with equal sign

2021-09-04 Thread Tom Lane
I wrote: > Surely this patch is completely wrong? It needs more thought about > the interaction with the existing logic for double quotes, ie single > quote inside double quotes is not special, nor the reverse; nor should > parentheses inside quotes be counted. It also needs to be aware of > back

Re: [PATCH] support tab-completion for single quote input with equal sign

2021-09-04 Thread Tom Lane
Jacob Champion writes: > t/010_tab_completion.pl .. 17/? > # Failed test 'tab-completion after single quoted text input with equal > sign' > # at t/010_tab_completion.pl line 198. > # Actual output was "CREATE SUBSCRIPTION my_sub CONNECTION > 'host=localhost port=5432 dbname

Re: public schema default ACL

2021-09-04 Thread Noah Misch
On Thu, Sep 02, 2021 at 12:36:51PM +0200, Peter Eisentraut wrote: > I think this patch represents the consensus. > > The documentation looks okay. Some places still refer to PostgreSQL 13, > which should now be changed to 14. Thanks. I'll update s/13/14/ and/or s/14/15/ before the next step. >

Re: prevent immature WAL streaming

2021-09-04 Thread Alvaro Herrera
On 2021-Sep-03, Andres Freund wrote: > Hi, > > On 2021-09-03 20:01:50 -0400, Alvaro Herrera wrote: > > From 6abc5026f92b99d704bff527d1306eb8588635e9 Mon Sep 17 00:00:00 2001 > > From: Alvaro Herrera > > Date: Tue, 31 Aug 2021 20:55:10 -0400 > > Subject: [PATCH v3 1/5] Revert "Avoid creating arch

Re: [PATCH] Add tab-complete for backslash commands

2021-09-04 Thread Tom Lane
ilm...@ilmari.org (Dagfinn Ilmari =?utf-8?Q?Manns=C3=A5ker?=) writes: > I've updated the commitfest entry to Ready for Committer. I was about to push this but started to have second thoughts about it. I'm not convinced that offering multiple variant spellings of the same command is really such a g

Re: prevent immature WAL streaming

2021-09-04 Thread Alvaro Herrera
On 2021-Sep-03, Andres Freund wrote: > > +#ifdef WAL_DEBUG > > + ereport(LOG, > > + (errmsg_internal("recovery overwriting broken > > contrecord at %X/%X (EndRecPtr: %X/%X)", > > + > > LSN_FORMAT_ARGS(

Re: [PATCH] Add tab-complete for backslash commands

2021-09-04 Thread Tom Lane
... BTW, I went ahead and pushed the changes in help.c, since that part seemed uncontroversial. regards, tom lane

Re: PG Docs - CREATE SUBSCRIPTION option list order

2021-09-04 Thread Tom Lane
Amit Kapila writes: > On Mon, Apr 19, 2021 at 10:32 AM Peter Smith wrote: >> Yes, if there were dozens of list items then I would agree that they >> should be grouped somehow. But there aren't. > I think this list is going to grow in the future as we enhance this > subsystem. For example, the pe

Re: Reduce lock level for ALTER TABLE ... ADD CHECK .. NOT VALID

2021-09-04 Thread Tom Lane
Simon Riggs writes: > 897795240cfaaed724af2f53ed2c50c9862f951f forgot to reduce the lock > level for CHECK constraints when allowing them to be NOT VALID. > This is simple and safe, since check constraints are not used in > planning until validated. Unfortunately, just asserting that it's safe do

Re: SQL:2011 application time

2021-09-04 Thread Jaime Casanova
On Sat, Jul 03, 2021 at 10:46:55AM -0700, Paul A Jungwirth wrote: > On Fri, Jul 2, 2021 at 2:39 PM Paul A Jungwirth > wrote: > > > > On Wed, Jun 30, 2021 at 10:39 AM Paul A Jungwirth > > wrote: > > > Here is a set of patches to add SQL:2011 application-time support (aka > > > valid-time). > > > >