On Thu, Sep 2, 2021 at 1:43 PM Amit Kapila wrote:
>
...
> I think if get Dilip's patch then we can have a rule for filter
> columns such that it can contain only replica identity key columns.
> This rule is anyway required for Deletes and we can have it for
> Updates. At this stage, I haven't chec
Sorry, please let me add something.
At Thu, 02 Sep 2021 13:17:16 +0900 (JST), Kyotaro Horiguchi
wrote in
> At Thu, 2 Sep 2021 12:19:25 +0900, Fujii Masao
> wrote in
> > Also I'm tempted to move ereport() and reset of errmsg_buf to
> > under next_record_is_invalid as follows. That is, in stan
On Wed, Sep 1, 2021 at 5:31 PM Fujii Masao wrote:
>
>
>
> On 2021/08/24 13:07, Mahendra Singh Thalor wrote:
> > Thanks Sadhu for the updated patch.
> >
> > Patch looks good to me and I don't have any more comments.
> >
> > I marked this patch as 'ready for committer'.
> > https://commitfest.postgr
(.. sorry for the chained-mails)
At Thu, 02 Sep 2021 13:31:31 +0900 (JST), Kyotaro Horiguchi
wrote in
> Sorry, please let me add something.
>
> At Thu, 02 Sep 2021 13:17:16 +0900 (JST), Kyotaro Horiguchi
> wrote in
> > At Thu, 2 Sep 2021 12:19:25 +0900, Fujii Masao
> > wrote in
> > > Als
On 2021/09/02 13:36, Sadhuprasad Patro wrote:
Yes this update is fine.. Please commit this patch...
Yeah, pushed. Thanks!
Regards,
--
Fujii Masao
Advanced Computing Technology Center
Research and Development Headquarters
NTT DATA CORPORATION
On Wed, Sep 1, 2021 at 12:06 PM Peter Smith wrote:
>
> Similarly, when you say ALTER PUBLICATION pub1 DROP ALL TABLES IN
> SCHEMA sc1; I would expect it means to drop ALL tables in sc1 - not
> all of them sometimes but not all of them at other times or even none
> of them.
>
> ~~
>
> I thought a m
On Wed, Sep 1, 2021 at 5:33 PM Dilip Kumar wrote:
>
> On Wed, Sep 1, 2021 at 5:23 PM Amit Kapila wrote:
>>
>> On Wed, Sep 1, 2021 at 1:53 PM Dilip Kumar wrote:
>> >
>>
>> The latest patch looks good to me. I have made some changes in the
>> comments, see attached. I am planning to push this tomo
On 2021/09/02 13:17, Kyotaro Horiguchi wrote:
Did you read the comment just above?
Yes!
xlog.c:12523
* Check the page header immediately, so that we can retry immediately
if
* it's not valid. This may seem unnecessary, because XLogReadRecord()
* validates the
At Wed, 1 Sep 2021 10:30:05 +0530, Bharath Rupireddy
wrote in
> On Mon, Aug 30, 2021 at 3:26 PM Ronan Dunklau wrote:
> > > 7) How about we let pg_receivewal use READ_REPLICATION_SLOT as an option?
> >
> > From my point of view, I already expected it to use something like that when
> > using a r
On Mon, Aug 30, 2021 at 5:07 PM Masahiko Sawada wrote:
>
>
> I've attached rebased patches. 0004 patch is not the scope of this
> patch. It's borrowed from another thread[1] to fix the assertion
> failure for newly added tests. Please review them.
>
I have a few comments on the v12-0002 patch:
(
On Tue, Jul 6, 2021 at 3:00 PM Dilip Kumar wrote:
>
> On Fri, Jun 18, 2021 at 12:50 AM Robert Haas wrote:
> >
> > On Thu, Jun 17, 2021 at 2:48 PM Andres Freund wrote:
> > > Or do you mean that looking at the filesystem at all is bypassing shared
> > > buffers?
> >
> > This is what I mean. I thin
On Thu, 2 Sept 2021 at 00:39, Jaime Casanova
wrote:
>
> Hi Dean,
>
> It seems you already committed this. But it's still as "Ready for
> committer" in the commitfest app.
>
> Are we waiting for something else or we can mark it as committed?
>
It's mostly done, but there is one more corner case wh
On Sat, Aug 28, 2021 at 3:19 PM Amit Kapila wrote:
>
> Don't you think some users might want to know all the schema names for
> a publication? I am not completely sure on this point but I think it
> is good to have information for users. It might be also useful to have
> pg_publication_objects whe
On Wed, Sep 1, 2021 at 6:58 AM houzj.f...@fujitsu.com
wrote:
>
> Here are some other comments for v23-000x patches.
>
> 1)
>
> @@ -6225,6 +6342,9 @@ describePublications(const char *pattern)
> boolhas_pubtruncate;
> boolhas_pubviaroot;
>
> + PQExpBuffe
On Wed, Sep 1, 2021 at 11:14 AM tanghy.f...@fujitsu.com
wrote:
>
> > On Monday, August 30, 2021 11:28 PM vignesh C wrote:
> >
> > I have fixed these comments as part of v23 patch attached at [1].
> > [1] - https://www.postgresql.org/message-
> > id/CALDaNm0xmqJeQEfV5Wnj2BawM%3DsdFdfOXz5N%2BgGG3WB
On Thu, Sep 2, 2021 at 11:15 AM Kyotaro Horiguchi
wrote:
>
> At Wed, 1 Sep 2021 10:30:05 +0530, Bharath Rupireddy
> wrote in
> > On Mon, Aug 30, 2021 at 3:26 PM Ronan Dunklau
> > wrote:
> > > > 7) How about we let pg_receivewal use READ_REPLICATION_SLOT as an
> > > > option?
> > >
> > > From
101 - 116 of 116 matches
Mail list logo
