Re: [bug?] Missed parallel safety checks, and wrong parallel safety

2021-06-09 Thread Amit Kapila
On Wed, Jun 9, 2021 at 9:47 PM Robert Haas wrote: > > On Wed, Jun 9, 2021 at 2:43 AM Tom Lane wrote: > > There are specific cases where there's a good reason to worry. > > For example, if we assume blindly that domain_in() is parallel > > safe, we will have cause to regret that. But I don't find

Re: Parallel INSERT SELECT take 2

2021-06-09 Thread Greg Nancarrow
On Thu, Jun 10, 2021 at 11:26 AM houzj.f...@fujitsu.com wrote: > > Through further review and thanks for greg-san's suggestions, > I attached a new version patchset with some minor change in 0001,0003 and > 0004. > > 0001. > * fix a typo in variable name. > * add a TODO in patch comment about upd

Re: BF assertion failure on mandrill in walsender, v13

2021-06-09 Thread Noah Misch
On Thu, Jun 10, 2021 at 10:47:20AM +1200, Thomas Munro wrote: > Not sure if there is much chance of debugging this one-off failure in > without a backtrace (long shot: any chance there's still a core > file?) No; it was probably in a directory deleted for each run. One would need to add dbx suppo

Re: Logical replication keepalive flood

2021-06-09 Thread Kyotaro Horiguchi
At Wed, 9 Jun 2021 17:32:25 +0500, Abbas Butt wrote in > > On Wed, Jun 9, 2021 at 2:30 PM Amit Kapila wrote: > > Does these keepalive messages are sent at the same frequency even for > > subscribers? > > Yes, I have tested it with one publisher and one subscriber. > The moment I start pgbench

Re: Logical replication keepalive flood

2021-06-09 Thread Kyotaro Horiguchi
At Thu, 10 Jun 2021 15:00:16 +0900 (JST), Kyotaro Horiguchi wrote in > At Wed, 9 Jun 2021 17:32:25 +0500, Abbas Butt > wrote in > > > > On Wed, Jun 9, 2021 at 2:30 PM Amit Kapila wrote: > > > Is it possible that the write/flush location is not > > > updated at the pace at which we expect? >

Re: Logical replication keepalive flood

2021-06-09 Thread Amit Kapila
On Thu, Jun 10, 2021 at 11:42 AM Kyotaro Horiguchi wrote: > > At Thu, 10 Jun 2021 15:00:16 +0900 (JST), Kyotaro Horiguchi > wrote in > > At Wed, 9 Jun 2021 17:32:25 +0500, Abbas Butt > > wrote in > > > > > > On Wed, Jun 9, 2021 at 2:30 PM Amit Kapila > > > wrote: > > > > Is it possible that

<    1   2