Re: subscriptioncheck failure

2021-05-17 Thread vignesh C
On Tue, May 18, 2021 at 9:09 AM Amit Kapila wrote: > > On Mon, May 17, 2021 at 5:48 PM vignesh C wrote: > > > > On Mon, May 17, 2021 at 10:40 AM Amit Kapila > > wrote: > > > > > > One more point: > > > + $node_publisher->wait_for_catchup('tap_sub'); > > > + > > > + # Ensure a transactional logi

Re: Forget close an open relation in ReorderBufferProcessTXN()

2021-05-17 Thread Amit Langote
On Mon, May 17, 2021 at 9:45 PM osumi.takami...@fujitsu.com wrote: > On Monday, May 17, 2021 6:52 PM Amit Langote wrote: > > Both patches are attached. > The patch for PG13 can be applied to it cleanly and the RT succeeded. > > I have few really minor comments on your comments in the patch. > > (

Re: pg_get_wal_replay_pause_state() should not return 'paused' while a promotion is ongoing.

2021-05-17 Thread Michael Paquier
On Tue, May 18, 2021 at 12:48:38PM +0900, Fujii Masao wrote: > Currently a promotion causes all available WAL to be replayed before > a standby becomes a primary whether it was in paused state or not. > OTOH, something like immediate promotion (i.e., standby becomes > a primary without replaying ou

Re: Race condition in recovery?

2021-05-17 Thread Kyotaro Horiguchi
At Mon, 17 May 2021 10:46:24 +0530, Dilip Kumar wrote in > On Mon, May 17, 2021 at 10:09 AM Dilip Kumar wrote: > > > > On Mon, May 17, 2021 at 8:50 AM Kyotaro Horiguchi > > wrote: > > > > > > Before the commit expectedTLEs is always initialized with just one > > > entry for the TLI of the last

Re: Race condition in recovery?

2021-05-17 Thread Kyotaro Horiguchi
At Tue, 18 May 2021 15:52:07 +0900 (JST), Kyotaro Horiguchi wrote in > FWIW, you could be get a problematic base backup by the following steps. > > 0. (make sure /tmp/hoge is removed) > 1. apply the attached patch > 2. create a primary then start > 3. create a standby then start > 4. place stan

<    1   2