On Mon, Mar 15, 2021 at 11:04 AM Thomas Munro wrote:
>
> On Mon, Mar 15, 2021 at 6:14 PM Bharath Rupireddy
> wrote:
> > On Mon, Mar 15, 2021 at 9:54 AM Thomas Munro wrote:
> > > While reviewing the patch for parallel REFRESH MATERIALIZED VIEW, I
> > > noticed that select_parallel.sql and write_p
On Mon, Mar 15, 2021 at 10:38 AM Thomas Munro wrote:
> While reading some back history, I saw that commit e9baa5e9 introduced
> parallelism for CREATE M V, but REFRESH was ripped out of the original
> patch by Robert, who said:
>
> > The problem with a case like REFRESH MATERIALIZED VIEW is that t
On Mon, Mar 15, 2021 at 03:01:09PM +0900, Kyotaro Horiguchi wrote:
> Logical decoding stuff is (I think) designed to turn any backend into
> a walsender, which may need to maintain ThisTimeLineID. It seems to
> me that logical decoding stuff indents to maintain ThisTimeLineID of
> such backends at
Hi Julien,
-- Original --
From:
"Julien Rouhaud"
https://com
On Mon, Mar 15, 2021 at 01:05:11AM -0500, Jaime Casanova wrote:
> I found another problem when using CASE expressions:
>
> CREATE OR REPLACE FUNCTION foo_case()
> RETURNS boolean
> LANGUAGE SQL
> BEGIN ATOMIC
> select case when random() > 0.5 then true else false end;
> END;
>
> apparently th
On 15.03.21 03:47, Thomas Munro wrote:
On Thu, Mar 11, 2021 at 2:06 AM David Steele wrote:
On 12/1/20 3:38 AM, Jürgen Purtz wrote:
OK. Patch attached.
+Queries which access multiple tables (including repeats) at once are called
I'd write "Queries that" here (that's is a transatlantic dif
On Mon, Mar 15, 2021 at 04:03:44PM +0800, Julien Rouhaud wrote:
> On Mon, Mar 15, 2021 at 01:05:11AM -0500, Jaime Casanova wrote:
> > I found another problem when using CASE expressions:
> >
> > CREATE OR REPLACE FUNCTION foo_case()
> > RETURNS boolean
> > LANGUAGE SQL
> > BEGIN ATOMIC
> > sel
Le lun. 15 mars 2021 à 06:00, Michael Paquier a
écrit :
> On Sun, Feb 21, 2021 at 08:14:45AM +0900, Michael Paquier wrote:
> > Okay, that sounds fine to me. Thanks for confirming.
>
> Guillaume, it has been a couple of weeks since your last update. Are
> you planning to send a new version of th
At Sat, 13 Mar 2021 10:05:21 -0800, Andres Freund wrote in
> Hi,
>
> On 2021-03-13 12:53:30 +0100, Magnus Hagander wrote:
> > On Sat, Mar 13, 2021 at 7:20 AM Andres Freund wrote:
> > >I think before making things differently complicated with this patch,
> > >we need to clean this up, un
At Fri, 12 Mar 2021 23:33:05 +0900, Fujii Masao
wrote in
>
>
> On 2021/03/12 17:24, Kyotaro Horiguchi wrote:
> > At Fri, 12 Mar 2021 15:13:15 +0900, Fujii Masao
> > wrote in
> >> On 2021/03/12 13:49, Kyotaro Horiguchi wrote:
> >>> I noticed that I accidentally removed the launch-suppression f
At Fri, 12 Mar 2021 22:20:40 -0800, Andres Freund wrote in
> Horiguchi-san, is there a chance you could add a few tests (on master)
> that test/document the way stats are kept across "normal" restarts, and
> thrown away after crash restarts/immediate restarts and also thrown away
> graceful strea
On Sun, Mar 14, 2021 at 1:52 PM wangsh.f...@fujitsu.com
wrote:
>
> Hi,
>
> I noticed in patch
> v58-0001-Add-support-for-apply-at-prepare-time-to-built-i.patch
>
> > +static void
> > +prepare_spoolfile_name(char *path, int szpath, Oid subid, char *gid)
> > +{
> > + PsfHashEntry *hentry;
> > +
> > Attaching new version patch with this change.
> >
>
> Thanks, the patch looks good to me. I have made some minor cosmetic
> changes in the attached. I am planning to push this by tomorrow unless you or
> others have any more comments or suggestions for this patch.
Thanks for the review.
I hav
A cfbot failure showed I had missed ORDER BY in some test queries.
On Sun, Dec 27, 2020 at 08:31:48PM -0800, Noah Misch wrote:
> I ended up blocking DDL that creates role memberships involving the new role;
> see reasons in user.c comments. Lifting those restrictions looked feasible,
> but it was
On Mon, Mar 15, 2021 at 09:19:19AM +0100, Guillaume Lelarge wrote:
> Le lun. 15 mars 2021 à 06:00, Michael Paquier a
> écrit :
>
> > On Sun, Feb 21, 2021 at 08:14:45AM +0900, Michael Paquier wrote:
> > > Okay, that sounds fine to me. Thanks for confirming.
> >
> > Guillaume, it has been a couple
On Mon, Mar 15, 2021 at 06:21:55PM +0800, Julien Rouhaud wrote:
> Is that a feature you really want to see in pg14? If yes and if you're sure
> you won't have time to work on the patch within 2 weeks I can take care of
> addressing all comments.
A lot of things will depend on the feature freeze d
Le lun. 15 mars 2021 à 18:25, Michael Paquier a
écrit :
> On Mon, Mar 15, 2021 at 06:21:55PM +0800, Julien Rouhaud wrote:
> > Is that a feature you really want to see in pg14? If yes and if you're
> sure
> > you won't have time to work on the patch within 2 weeks I can take care
> of
> > address
On Mon, Mar 15, 2021 at 8:00 PM Bharath Rupireddy
wrote:
> Thanks. v2 LGTM, both make check and make check-world passes on my dev system.
Pushed. Thanks!
Le lun. 15 mars 2021 à 11:32, Julien Rouhaud a écrit :
> Le lun. 15 mars 2021 à 18:25, Michael Paquier a
> écrit :
>
>> On Mon, Mar 15, 2021 at 06:21:55PM +0800, Julien Rouhaud wrote:
>> > Is that a feature you really want to see in pg14? If yes and if you're
>> sure
>> > you won't have time to
On Mon, Mar 15, 2021 at 5:24 PM Thomas Munro wrote:
> However, since commit 862ef372d6b, there *is* one test that fails if
> you run make installcheck against a cluster running with -c
> default_transaction_isolation=serializable: transaction.sql. Is that
> a mistake? Is it a goal to be able to
Alvaro san, Tom san Horiguchi san, Tsunakawa san and Kirk san,
Thank you very much for review and advice.
> > Works for me.
>
> Pushed that. I think we're now waiting on Iwata-san to finish a new version
> of
> the tracing patch.
Thank you very much Alvaro san and Tom san. Your patch and code
On Mon, 15 Mar 2021 at 05:53, Michael Paquier wrote:
>
> On Wed, Mar 10, 2021 at 09:35:10AM +0100, Matthias van de Meent wrote:
> > There are examples in which pg_stat_progress_* -views report
> > inaccurate data. I think it is fairly reasonable to at least validate
> > some part of the progress r
Hello,
Forgive me for probably naive questions, being so talkative like the
following. But the less one knows the more one must explain. And I don't
know much regarding RLS.
1. Some time ago I've implemented in my schema a poore mans' RLS using
the rule system.
2. like half a year ago I've disco
‐‐‐ Original Message ‐‐‐
On Monday, March 15, 2021 7:10 AM, Michael Paquier wrote:
> On Wed, Feb 24, 2021 at 02:35:51PM +, gkokola...@pm.me wrote:
>
> > Now with attachment. Apologies for the chatter.
>
> The patch has no documentation for the two new functions, so it is a
> bit
On 12/15/20 9:03 AM, Peter Eisentraut wrote:
Here is a new patch for this. This now follows the implementation that
Tom has suggested: Leave date_part() alone, add a new set of extract()
functions, and map the SQL EXTRACT construct to those. I have basically
just copied over the implementati
On 3/3/21 9:44 AM, David Steele wrote:
On 3/4/20 3:18 PM, Nikita Glukhov wrote:
On 04.03.2020 19:13, David Steele wrote:
On 2/27/20 10:57 AM, Nikita Glukhov wrote:
Attached patches implement several useful jsonpath syntax extensions.
I already published them two years ago in the original SQL/
Hi,
This seems to be a new low frequency failure, I didn't see it mentioned already:
# Failed test 'DROP SUBSCRIPTION during error can clean up the slots
on the publisher'
# at t/004_sync.pl line 171.
# got: '1'
# expected: '0'
https://buildfarm.postgresql.org/cgi-bin/show_log
On 12/21/20 3:30 AM, Kyotaro Horiguchi wrote:
At Tue, 01 Dec 2020 10:03:42 -0500, Tom Lane wrote in
I think it should be "needs review" now.
Conflicted with some commit(s) uncertain to me. Rebased.
Tom, Georgios, thoughts on the new patch?
Regards,
--
-David
da...@pgmasters.net
On 12/23/20 2:27 PM, Stephen Frost wrote:
* Justin Pryzby (pry...@telsasoft.com) wrote:
On Mon, Nov 23, 2020 at 04:14:18PM -0500, Tom Lane wrote:
* I don't think it's okay to change the existing signatures of
pg_ls_logdir() et al. Even if you can make an argument that it's
not too harmful to a
On 11/18/20 5:23 AM, Simon Riggs wrote:
On Wed, 18 Nov 2020 at 06:42, Craig Ringer
wrote:
On Fri, Nov 13, 2020 at 7:24 PM Simon Riggs wrote:
What I'm proposing is an option to add 16 bytes onto each COMMIT
record
Would it make sense to write this at the time we write a topxid assignment
Hi Luc,
On 12/30/20 8:54 AM, Luc Vlaming wrote:
Created a commitfest entry assuming this is the right thing to do so
that someone can potentially pick it up during the commitfest.
Providing an updated patch based on latest master.
Looks like you need another rebase:
http://cfbot.cputube.o
On Mon, Mar 15, 2021 at 1:29 PM Avinash Kumar
wrote:
> Is this expected when replication is happening between PostgreSQL databases
> hosted on different OS versions like Ubuntu 16 and Ubuntu 20 ? Or, do we
> think this is some sort of corruption ?
Is this index on a text datatype, and using a c
Hi Thomas,
On Sun, Mar 14, 2021 at 9:40 PM Thomas Munro wrote:
> On Mon, Mar 15, 2021 at 1:29 PM Avinash Kumar
> wrote:
> > Is this expected when replication is happening between PostgreSQL
> databases hosted on different OS versions like Ubuntu 16 and Ubuntu 20 ?
> Or, do we think this is some
Hi Thomas,
On Sun, Mar 14, 2021 at 10:01 PM Avinash Kumar
wrote:
> Hi Thomas,
>
> On Sun, Mar 14, 2021 at 9:40 PM Thomas Munro
> wrote:
>
>> On Mon, Mar 15, 2021 at 1:29 PM Avinash Kumar
>> wrote:
>> > Is this expected when replication is happening between PostgreSQL
>> databases hosted on dif
On Friday, March 12, 2021 5:04 PM Peter Eisentraut
wrote:
> On 08.03.21 03:45, osumi.takami...@fujitsu.com wrote:
> > OK. The basic idea is to enable backup management tools to recognize
> > wal_level drop between*snapshots*.
> > When you have a snapshot of the cluster at one time and another one
Hi,
On Sun, Mar 14, 2021 at 11:24 PM Peter Geoghegan wrote:
> On Sun, Mar 14, 2021 at 6:54 PM Avinash Kumar
> wrote:
> > Following may be helpful to understand what I meant.
> >
> > I have renamed the table and index names before adding it here.
>
> It should be possible to run amcheck on your
Hi Peter,
On 12/30/20 9:33 AM, Peter Eisentraut wrote:
On 2020-10-09 20:46, Andres Freund wrote:
Is there really a good reason for forcing the client to issue
NextResult, Describe, Execute for each of the dynamic result sets? It's
not like there's really a case for allowing the clients to skip
On Fri, 2021-03-12 at 21:41 +, Bossart, Nathan wrote:
> On 3/12/21, 11:14 AM, "Joe Conway" wrote:
> > Looking back at the commit history it seems to me that this only works
> > accidentally. Perhaps it would be best to fix RESET ROLE and be done with
> > it.
>
> That seems reasonable to me.
On 3/1/21 10:30 AM, David Steele wrote:
Hackers,
The 2019-03 commitfest is now in progress. It's a big one as usual.
Needs review: 213.
Waiting on Author: 21.
Ready for Committer: 28.
Committed: 29.
Withdrawn: 3.
Total: 294.
We are now halfway through the 2021-03 commitfest, though historical
Thomas Munro writes:
> On Mon, Mar 15, 2021 at 5:24 PM Thomas Munro wrote:
>> However, since commit 862ef372d6b, there *is* one test that fails if
>> you run make installcheck against a cluster running with -c
>> default_transaction_isolation=serializable: transaction.sql. Is that
>> a mistake?
> On 2021/3/15, 7:34 AM, "Thomas Munro" wrote:
>> On Mon, Mar 15, 2021 at 11:52 AM Thomas Munro
wrote:
>> Time being of the essence, here is the patch I posted last year, this
>> time with a GUC and some docs. You can set sync_after_crash to
>> "fsync" (default) or "syncfs"
> to set visibility map bits on materialized views. I'll start a new
>thread to discuss that.
Thanks. Also I withdrew the patch.
On Tue, Feb 23, 2021 at 3:59 AM Andres Freund wrote:
>
> Hi,
>
> The 2pc decoding added in
>
> commit a271a1b50e9bec07e2ef3a05e38e7285113e4ce6
> Author: Amit Kapila
> Date: 2021-01-04 08:34:50 +0530
>
> Allow decoding at prepare time in ReorderBuffer.
>
> has a deadlock danger when used in
Hi all,
My country(Ethiopia) is one of the nations that uses different kind of
calendar than what PostgreSQL have so we are deprived from the benefit of
data datatype. We just uses String to store date that limits our
application quality greatly. The lag became even worst once application and
syste
> On Mar 2, 2021, at 6:08 AM, Pavel Borisov wrote:
>
> I completely agree that checking uniqueness requires looking at the heap, but
> I don't agree that every caller of bt_index_check on an index wants that
> particular check to be performed. There are multiple ways in which an index
> mi
Le 12/03/2021 à 13:44, Andrey Borodin a écrit :
>
>> 11 марта 2021 г., в 20:50, Gilles Darold написал(а):
>>
>>
>> The patch doesn't apply anymore in master cause of error: patch failed:
>> src/backend/utils/init/globals.c:150
>>
>>
>>
>> An other remark about this patch is that it should be ment
On 11.03.2021 03:47, Tomas Vondra wrote:
Hi Konstantin,
Thanks for working on this! Using extended statistics to improve join
cardinality estimates was definitely on my radar, and this patch seems
like a good start.
I had two basic ideas about how we might improve join estimates:
(a) use pe
On Mon, Feb 22, 2021 at 3:52 PM Andres Freund wrote:
> Hi,
>
> On 2021-02-22 11:20:54 -0500, Jim Mlodgenski wrote:
> > As Jan mentioned in his thread about a pluggable wire protocol [0], AWS
> is
> > working on a set of extensions for Babelfish. The intention is to not
> > necessarily have it as
On Tue, 2021-03-09 at 19:10 +, Jacob Champion wrote:
> And v5 is rebased over this morning's SSL test changes.
Rebased again after the SSL test revert (this is the same as v4).
--Jacob
From 470bf11f4b8feb6c22dc72626f6f3fcb7971ac26 Mon Sep 17 00:00:00 2001
From: Jacob Champion
Date: Wed, 3 Feb
On Mon, Mar 15, 2021 at 6:56 AM Avinash Kumar
wrote:
> psql:amchecksql.sql:17: DEBUG: leaf block 1043751 of index "idx_id_mtime"
> has no first data item
That one is harmless.
> And one error as follows.
>
> psql:amchecksql.sql:17: ERROR: down-link lower bound invariant violated for
> index
On Fri, 2021-03-12 at 13:12 -0500, Tom Lane wrote:
> I pushed the race-condition-fixing part of this, since that's an
> unarguable bug fix and hence seems OK to back-patch. (I added a
> check on change of file size, because why not.)
Thank you!
> Attached is the rest, just to keep the cfbot happ
> On Mar 14, 2021, at 8:33 PM, Julien Rouhaud wrote:
>
>
In the docs, 0001, "Fow now, the only dependency handled currently",
"Fow now" is misspelled, and "For now" seems redundant when used with
"currently".
In the docs, 0002, "For now only dependency on collations are supported."
"de
On Mon, Mar 15, 2021 at 11:48:58AM -0400, Jim Mlodgenski wrote:
>
> Going deeper on this, I created another POC as an example. Yes, having a
> hook at the top of the parser does mean an extension needs to copy the
> existing grammar and modify it. Without a total redesign of how the grammar
> is h
On Mon, Mar 15, 2021 at 09:30:43AM -0700, Mark Dilger wrote:
>
> In the docs, 0001, "Fow now, the only dependency handled currently",
>
> "Fow now" is misspelled, and "For now" seems redundant when used with
> "currently".
>
>
> In the docs, 0002, "For now only dependency on collations are sup
On Mon, Mar 15, 2021, at 16:48, Jim Mlodgenski wrote:
> The example I have is adding a CREATE JOB command that a scheduler may use.
This CREATE JOB thing sounds interesting.
Are you working on adding the ability to schedule SQL-commands to run in the
background,
similar to cronjob and/or adding
On Mon, Mar 15, 2021 at 12:43 PM Julien Rouhaud wrote:
> On Mon, Mar 15, 2021 at 11:48:58AM -0400, Jim Mlodgenski wrote:
> >
> > Going deeper on this, I created another POC as an example. Yes, having a
> > hook at the top of the parser does mean an extension needs to copy the
> > existing grammar
Looks like we're not quite out of the woods, as hornet and tern are
still unhappy:
# Failed test 'pg_amcheck excluding all corrupt schemas status (got 2 vs
expected 0)'
# at t/003_check.pl line 498.
# Failed test 'pg_amcheck excluding all corrupt schemas stdout /(?^:^$)/'
# at t/003_chec
On Mon, Mar 15, 2021 at 12:58 PM Joel Jacobson wrote:
> On Mon, Mar 15, 2021, at 16:48, Jim Mlodgenski wrote:
>
> The example I have is adding a CREATE JOB command that a scheduler may
> use.
>
>
> This CREATE JOB thing sounds interesting.
>
> Are you working on adding the ability to schedule SQL
> Also, I'm not sure that many extensions would really benefit from custom
> utility command, as you can already do pretty much anything you want using
> SQL
> functions. For instance it would be nice for hypopg to be able to support
>
> CREATE HYPOTHETICAL INDEX ...
>
> rather than
>
> SELECT hyp
On 3/15/21, 7:06 AM, "Laurenz Albe" wrote:
> On Fri, 2021-03-12 at 21:41 +, Bossart, Nathan wrote:
>> On 3/12/21, 11:14 AM, "Joe Conway" wrote:
>> > Looking back at the commit history it seems to me that this only works
>> > accidentally. Perhaps it would be best to fix RESET ROLE and be done
> On Mar 15, 2021, at 9:52 AM, Julien Rouhaud wrote:
>
> But there are also the tests in collate.icu.utf8.out which will fake outdated
> collations (that's the original tests for the collation tracking patches) and
> then check that outdated indexes are reindexed with both REINDEX and REINDEX
On Mon, Mar 15, 2021 at 06:05:52PM +0100, Pavel Stehule wrote:
>
> Possibility to work with a parser is one main reason for forking postgres.
> Lot of interestings projects fail on the cost of maintaining their own fork.
>
> Maybe a good enough possibility is the possibility to inject an own pars
On Mon, Mar 15, 2021 at 10:13:55AM -0700, Mark Dilger wrote:
>
>
> > On Mar 15, 2021, at 9:52 AM, Julien Rouhaud wrote:
> >
> > But there are also the tests in collate.icu.utf8.out which will fake
> > outdated
> > collations (that's the original tests for the collation tracking patches)
> > a
David Steele writes:
> On 12/15/20 9:03 AM, Peter Eisentraut wrote:
>> Here is a new patch for this. This now follows the implementation that
>> Tom has suggested: Leave date_part() alone, add a new set of extract()
>> functions, and map the SQL EXTRACT construct to those. I have basically
>
> On Mar 15, 2021, at 10:34 AM, Julien Rouhaud wrote:
>
> On Mon, Mar 15, 2021 at 10:13:55AM -0700, Mark Dilger wrote:
>>
>>
>>> On Mar 15, 2021, at 9:52 AM, Julien Rouhaud wrote:
>>>
>>> But there are also the tests in collate.icu.utf8.out which will fake
>>> outdated
>>> collations (tha
po 15. 3. 2021 v 18:18 odesílatel Julien Rouhaud
napsal:
> On Mon, Mar 15, 2021 at 06:05:52PM +0100, Pavel Stehule wrote:
> >
> > Possibility to work with a parser is one main reason for forking
> postgres.
> > Lot of interestings projects fail on the cost of maintaining their own
> fork.
> >
> >
On Mon, Mar 15, 2021 at 10:40:25AM -0700, Mark Dilger wrote:
> I'm saying that your patch seems to call down to
> get_collation_actual_version() via get_collation_version_for_oid() from your
> new function do_check_index_has_outdated_collation(), but I'm not seeing how
> that gets exercised.
It
On Mon, Mar 15, 2021 at 06:41:36PM +0100, Pavel Stehule wrote:
> po 15. 3. 2021 v 18:18 odesílatel Julien Rouhaud
> napsal:
>
> > On Mon, Mar 15, 2021 at 06:05:52PM +0100, Pavel Stehule wrote:
> > >
> > > Possibility to work with a parser is one main reason for forking
> > postgres.
> > > Lot of
> On Mar 15, 2021, at 10:50 AM, Julien Rouhaud wrote:
>
> On Mon, Mar 15, 2021 at 10:40:25AM -0700, Mark Dilger wrote:
>> I'm saying that your patch seems to call down to
>> get_collation_actual_version() via get_collation_version_for_oid() from your
>> new function do_check_index_has_outdat
po 15. 3. 2021 v 18:54 odesílatel Julien Rouhaud
napsal:
> On Mon, Mar 15, 2021 at 06:41:36PM +0100, Pavel Stehule wrote:
> > po 15. 3. 2021 v 18:18 odesílatel Julien Rouhaud
> > napsal:
> >
> > > On Mon, Mar 15, 2021 at 06:05:52PM +0100, Pavel Stehule wrote:
> > > >
> > > > Possibility to work
On Sun, Mar 14, 2021 at 07:31:35PM -0500, Justin Pryzby wrote:
> On Sat, Mar 13, 2021 at 08:48:33PM +0500, Andrey Borodin wrote:
> > > 13 марта 2021 г., в 06:28, Justin Pryzby
> > > написал(а):
> > > Updated patch with a minor fix to configure.ac to avoid warnings on OSX.
> > > And 2ndary patches
On Mon, Mar 15, 2021 at 10:56:50AM -0700, Mark Dilger wrote:
>
>
> > On Mar 15, 2021, at 10:50 AM, Julien Rouhaud wrote:
> >
> > On Mon, Mar 15, 2021 at 10:40:25AM -0700, Mark Dilger wrote:
> >> I'm saying that your patch seems to call down to
> >> get_collation_actual_version() via get_collat
> On Mar 15, 2021, at 10:04 AM, Tom Lane wrote:
>
> Looks like we're not quite out of the woods, as hornet and tern are
> still unhappy:
>
> # Failed test 'pg_amcheck excluding all corrupt schemas status (got 2 vs
> expected 0)'
> # at t/003_check.pl line 498.
>
> # Failed test 'pg_am
The wait event WalReceiverWaitStart has been categorized in the type Client.
But why? Walreceiver is waiting for startup process to set the lsn and
timeline while it is reporting WalReceiverWaitStart. So its type should be IPC,
instead?
The wait event WalSenderWaitForWAL has also been categorized
Hi,
On Mon, Mar 15, 2021 at 1:18 PM Peter Geoghegan wrote:
> On Mon, Mar 15, 2021 at 6:56 AM Avinash Kumar
> wrote:
> > psql:amchecksql.sql:17: DEBUG: leaf block 1043751 of index
> "idx_id_mtime" has no first data item
>
> That one is harmless.
>
> > And one error as follows.
> >
> > psql:amch
> On Mar 15, 2021, at 11:10 AM, Julien Rouhaud wrote:
>
> On Mon, Mar 15, 2021 at 10:56:50AM -0700, Mark Dilger wrote:
>>
>>
>>> On Mar 15, 2021, at 10:50 AM, Julien Rouhaud wrote:
>>>
>>> On Mon, Mar 15, 2021 at 10:40:25AM -0700, Mark Dilger wrote:
I'm saying that your patch seems to
> On Mar 15, 2021, at 11:11 AM, Mark Dilger
> wrote:
>
> I will submit a patch that turns off autovacuum for the test node shortly.
v5-0001-Turning-off-autovacuum-during-corruption-tests.patch
Description: Binary data
—
Mark Dilger
EnterpriseDB: http://www.enterprisedb.com
The Enterprise P
>
>
>
> Also, I'm not sure that many extensions would really benefit from custom
> utility command, as you can already do pretty much anything you want using
> SQL
> functions. For instance it would be nice for hypopg to be able to support
>
> CREATE HYPOTHETICAL INDEX ...
>
> rather than
>
> SELE
[ getting back to this, after a bit of procrastination ]
Andrew Dunstan writes:
> On 2/11/21 1:32 PM, Tom Lane wrote:
>> Noah Misch writes:
>>> On Tue, Feb 09, 2021 at 05:34:37PM -0500, Tom Lane wrote:
* A case could be made for tightening things up a lot more, and not
allowing anythin
Here's what seems a final version of the patch. I renamed one more
function: PQsendPipeline is now PQpipelineSync. I also reworded the
docs in a couple of places, added a few tests to the pgbench patch, and
made it work.
Note the pgbench results in pipeline mode:
./pgbench -r -Mextended -n -f
Mark Dilger writes:
> On Mar 15, 2021, at 10:04 AM, Tom Lane wrote:
>> These animals have somewhat weird alignment properties: MAXALIGN is 8
>> but ALIGNOF_DOUBLE is only 4. I speculate that that is affecting their
>> choices about whether an out-of-line TOAST value is needed, breaking
>> this t
> On Mar 15, 2021, at 11:32 AM, Mark Dilger
> wrote:
>
> If you had a real, not fake, collation provider which actually provided a
> collation with an actual version number, stopped the server, changed the
> behavior of the collation as well as its version number, started the server,
> and
Are you going to update the assertion ?
+#if 0
Assert((meta == META
> On Mar 15, 2021, at 11:57 AM, Tom Lane wrote:
>
> Do we have a strong enough lock on
> the table under examination to be sure that autovacuum couldn't remove
> a dead toast entry before we reach it?
The main table and the toast table are only locked with AccessShareLock. Each
page in the
Hi,
On 2021-03-14 19:04:34 -0700, Peter Geoghegan wrote:
> Attached is a POC-quality revision of Masahiko's
> skip_index_vacuum.patch [1]. There is an improved design for skipping
> index vacuuming (improved over the INDEX_CLEANUP stuff from Postgres
> 12). I'm particularly interested in your pers
On Mon, Mar 15, 2021 at 8:14 AM Dilip Kumar wrote:
> In the attached patches I have changed this, ...
OK, so just looking over this patch series, here's what I think:
- 0001 and 0002 are now somewhat independent of the rest of this work,
and could be dropped, but I think they're a good idea, so
> On Mar 15, 2021, at 11:57 AM, Tom Lane wrote:
>
> Yeah, that could be phrased better.
Attaching the 0001 patch submitted earlier, plus 0002 which fixes the confusing
corruption message.
v6-0001-Turning-off-autovacuum-during-corruption-tests.patch
Description: Binary data
v6-0002-Fixin
On Tue, Mar 16, 2021 at 2:32 AM Mark Dilger
wrote:
>
> We do test corrupt relations. We intentionally corrupt the pages within
> corrupted heap tables to check that they get reported as corrupt. (See
> src/bin/pg_amcheck/t/004_verify_heapam.pl)
I disagree. You're testing a modified version o
[ Sorry for not looking at this thread sooner ]
Bharath Rupireddy writes:
> Currently, $subject is not allowed. We do plan the mat view query
> before every refresh. I propose to show the explain/explain analyze of
> the select part of the mat view in case of Refresh Mat View(RMV).
TBH, I think
On 2021-Mar-15, Justin Pryzby wrote:
> Are you going to update the assertion ?
>
> +#if 0
>
>
On Mon, Mar 15, 2021 at 12:21 PM Andres Freund wrote:
> It's evil sorcery. Fragile sorcery. I think Robert, Tom and me all run
> afoul of edge cases around it in the last few years.
Right, which is why I thought that I might be missing something; why
put up with that at all for so long?
> > But
On 09.02.21 15:48, Tang, Haiying wrote:
I'm still confused about the APPROPRIATE behavior of tab completion.
It seems ALTER table/tablespace SET/RESET is already case-insensitive.
For example
# alter tablespace dbspace set(e[tab]
# alter tablespace dbspace set(effective_io_concurrency
# alter
Bharath Rupireddy writes:
> Thanks for pointing to the changes in the commit message. I corrected
> them. Attaching v4 patch set, consider it for further review.
I took a quick look at this. I'm quite worried about the potential
performance cost of the v4-0001 patch (the one for fixing
slot_stor
On Mon, Mar 15, 2021 at 12:58 PM Peter Geoghegan wrote:
> > I'm not comfortable with this change without adding more safety
> > checks. If there's ever a case in which the HEAPTUPLE_DEAD case is hit
> > and the xid needs to be frozen, we'll either cause errors or
> > corruption. Yes, that's alread
Greetings,
* tsunakawa.ta...@fujitsu.com (tsunakawa.ta...@fujitsu.com) wrote:
> From: David Steele
> > As a backup software author, I don't see this feature as very useful.
> >
> > The problem is that there are lots of ways for WAL to go missing so
> > monitoring the WAL archive for gaps is esse
Jim Finnerty writes:
> PostgreSQL 12 and onward supports nondeterministic collations. For "GROUP
> BY x", which value of 'x' will PostgreSQL return in this case? The first
> value of x?
> The SQL standard (section 8.2) states that the specific value returned is
> implementation-defined, but re
Hi Surafel,
On Tue, Mar 16, 2021 at 3:48 AM Surafel Temesgen wrote:
> My country(Ethiopia) is one of the nations that uses different kind of
> calendar than what PostgreSQL have so we are deprived from the benefit of
> data datatype. We just uses String to store date that limits our application
I noticed that the PG docs [1] for the catalog pg_subscription doesn't
have any mention of the substream column.
Accidental omission by commit 4648243 [2] from last year?
[1] https://www.postgresql.org/docs/devel/catalog-pg-subscription.html
[2]
https://github.com/postgres/postgres/commit/4
Justin Pryzby writes:
> For example:
> $ python3.5 -c "import pg; db=pg.DB(); q = db.query(\"SET
> log_parameter_max_length_on_error=-1;\"); db.prepare('p', 'SELECT
> \$1::smallint'); db.query_prepared('p',6);"
> 2021-01-03 02:21:04.547 CST [20157] ERROR: value "6" is out of range for
On Mon, Mar 15, 2021 at 06:45:49PM -0400, Tom Lane wrote:
> Justin Pryzby writes:
> > For example:
> > $ python3.5 -c "import pg; db=pg.DB(); q = db.query(\"SET
> > log_parameter_max_length_on_error=-1;\"); db.prepare('p', 'SELECT
> > \$1::smallint'); db.query_prepared('p',6);"
> > 2021-01-0
1 - 100 of 126 matches
Mail list logo
