Re: row filtering for logical replication

On Mon, Feb 01, 2021 at 04:11:50PM -0300, Euler Taveira wrote: > After the commit 3696a600e2, the last patch does not apply cleanly. I'm > attaching another version to address the documentation issues. I have bumped into this thread, and applied 0001. My guess is that one of the patches developpe

Re: Single transaction in the tablesync worker?

On Tue, Feb 2, 2021 at 8:29 AM Peter Smith wrote: > > On Mon, Feb 1, 2021 at 11:26 PM Amit Kapila wrote: > > > I have updated the patch to display WARNING for each of the tablesync > > slots during DropSubscription. As discussed, I have moved the drop > > slot related code towards the end in Alte

Re: Single transaction in the tablesync worker?

On Mon, Feb 1, 2021 at 11:26 PM Amit Kapila wrote: > I have updated the patch to display WARNING for each of the tablesync > slots during DropSubscription. As discussed, I have moved the drop > slot related code towards the end in AlterSubscription_refresh. Apart > from this, I have fixed one more

Re: Typo in tablesync comment

On Tue, Feb 02, 2021 at 10:38:31AM +1100, Peter Smith wrote: > PSA a trivial patch to correct what seems like a typo in the tablesync > comment. - * subscribed tables and their state. Some transient state during data - * synchronization is kept in shared memory. The states SYNCWAIT

Re: fix typo in reorderbuffer.c

On Wed, Jan 27, 2021 at 07:15:41AM +, Hou, Zhijie wrote: > I agree that it’s better to have a common way, but some different > style of combocid follow the variable or functionname[1]. > We may need to change the var name or function name too. > > [1]: > void > SerializeComboCIDState(Size maxs

Re: row filtering for logical replication

On Tue, 02 Feb 2021 at 03:11, Euler Taveira wrote: > On Mon, Feb 1, 2021, at 6:11 AM, japin wrote: >> Thanks for updating the patch. Here are some comments: > Thanks for your review. I updated the documentation accordingly. > >> The documentation says: >> >> > Columns used in the WHERE clause

Re: Single transaction in the tablesync worker?

Another failure I see in my testing On publisher create a big enough table: publisher: postgres=# CREATE TABLE tab_rep (a int primary key);CREATE TABLE postgres=# INSERT INTO tab_rep SELECT generate_series(1,100); INSERT 0 100 postgres=# CREATE PUBLICATION tap_pub FOR ALL TABLES; CREATE PU

Re: Single transaction in the tablesync worker?

On Mon, Feb 1, 2021 at 11:26 PM Amit Kapila wrote: > > I have updated the patch to display WARNING for each of the tablesync > slots during DropSubscription. As discussed, I have moved the drop > slot related code towards the end in AlterSubscription_refresh. Apart > from this, I have fixed one mo

Re: Commitfest 2021-01 is now closed.

On Mon, Feb 1, 2021 at 7:16 AM Julien Rouhaud wrote: > > Le lun. 1 févr. 2021 à 22:53, Laurenz Albe a écrit > : >> >> On Mon, 2021-02-01 at 23:33 +0900, Masahiko Sawada wrote: >> > I've closed this commitfest. If you have feedback or comment on my CFM >> > work, please tell me here or by directl

RE: [POC] Fast COPY FROM command for the table with foreign partitions

Hello, Andrey-san, From: Tang, Haiying > > Sometimes before i suggested additional optimization [1] which can > > additionally speed up COPY by 2-4 times. Maybe you can perform the > > benchmark for this solution too? ... > But the patch no longer applies, I tried to apply on e42b3c3bd6(2021/1/2

Re: Recording foreign key relationships for the system catalogs

On Tue, Feb 2, 2021, at 04:27, Tom Lane wrote: >Attachments: >add-catalog-foreign-key-info-2.patch Very nice. I could only find one minor error, found by running the regression-tests, and then using the query below to compare "is_opt" with my own "zero_values" in my tool that derives its value fr

<    1   2