Hello,
18.12.2020 19:02, Tom Lane wrote:
> "osumi.takami...@fujitsu.com" writes:
>> I have a question about how to execute valgrind with TAP tests
>> in order to check some patches in the community.
>> My main interest is testing src/test/subscription now but
>> is there any general way to do it
On Thu, Nov 26, 2020 at 10:28 AM movead...@highgo.ca
wrote:
> I test the patch and occur several issues as blow:
Thank you for the review!
> Issue one:
> Get a Assert error at 'Assert(bms_is_member(i, node->as_needrequest));' in
> ExecAppendAsyncRequest() function when I use more than two foreig
On Thu, Dec 10, 2020 at 3:38 PM Andrey V. Lepikhov
wrote:
> On 11/17/20 2:56 PM, Etsuro Fujita wrote:
> > On Mon, Oct 5, 2020 at 3:35 PM Etsuro Fujita
> > wrote:
> > Comments welcome! The attached is still WIP and maybe I'm missing
> > something, though.
> I reviewed your patch and used it in m
On Sun, Dec 20, 2020 at 8:07 PM Tom Lane wrote:
> One minor thought is that in
>
> + struct iovec iov[Min(IOV_MAX, 1024)]; /* cap stack space */
>
> it seems like pretty much every use of IOV_MAX would want some
> similar cap. Should we centralize that idea with, say,
>
> #define
Hello David,
We have \gset to set some parameters, but not ones in the environment,
so I fixed this with a new analogous command, \gsetenv. I considered
refactoring SetVariable to include environment variables, but for a
first cut, I just made a separate function and an extra if.
My 0.02€: IS
On Sat, Dec 19, 2020 at 6:00 AM Michael Paquier wrote:
>
> On Sat, Dec 19, 2020 at 10:03:47AM +0530, Amit Kapila wrote:
> > Glad to hear. I am confident that you can do justice to this role.
>
> I also think you will do just fine. Thanks for taking care of this.
+1 on both accounts.
If you have
Hello,
pgbench use -f filename[@weight] to receive a sql script file with a weight,
ISTM that I thought of this: "pgbench -f filen@me@1" does work.
sh> touch foo@bla
sh> pgbench -f foo@bla@1
pgbench: fatal: empty command list for script "foo@bla"
The documentation could point this ou
Hello Tom,
I think we should just leave this as it is. The user can simply rename
the file.
Yeah. The assumption when we defined the script-weight syntax was that
there's no particular reason to use "@" in a script file name, and
I don't see why that's a bad assumption.
The "parser" looks
Hi all
suppose I started the server with the following command
pg_ctl -D . . . start -l
is there a way to get later by sending some query to the server or
reading some configuration file
(for example I can get data directory with the query “show data_directory”)
thanks in advance
Dimitry M
Dmitry Markman writes:
> suppose I started the server with the following command
> pg_ctl -D . . . start -l
> is there a way to get later by sending some query to the server
> or
No, the server has no way to know where its stdout/stderr were
pointed to. You might want to enable the syslogger
On 12/20/20 11:31 AM, Tom Lane wrote:
> Dmitry Markman writes:
>> suppose I started the server with the following command
>> pg_ctl -D . . . start -l
>> is there a way to get later by sending some query to the
>> server or
> No, the server has no way to know where its stdout/stderr were
> poi
On 12/19/20 11:19 AM, Andrew Dunstan wrote:
>
>
> This turns out to be remarkably short, with the use of a little eval magic.
>
> Give the attached, this test program works just fine:
>
> #!/bin/perl
> use PostgresNodePath;
> $ENV{PG_REGRESS} =
> '/home/andrew/pgl/vpath.12/src/test
On Sun, Dec 20, 2020 at 02:26:14PM +0100, Fabien COELHO wrote:
> Hello David,
>
> > We have \gset to set some parameters, but not ones in the environment,
> > so I fixed this with a new analogous command, \gsetenv. I considered
> > refactoring SetVariable to include environment variables, but for
David Fetter writes:
> On Sun, Dec 20, 2020 at 02:26:14PM +0100, Fabien COELHO wrote:
>> SELECT 'Calvin' AS foo \gset
>> \setenv FOO :foo
>> \! echo $FOO
>> Calvin
> You're the second person who's mentioned this workaround, which goes
> to a couple of points I tried to make earlier:
> - This is
Fabien COELHO writes:
> The "parser" looks for the last @ in the argument, so the simple
> workaround is to append "@1".
> I suggest the attached doc update, or anything in better English.
Agreed, done.
regards, tom lane
On Sun, Dec 20, 2020 at 01:07:12PM -0500, Tom Lane wrote:
> David Fetter writes:
> > On Sun, Dec 20, 2020 at 02:26:14PM +0100, Fabien COELHO wrote:
> >> SELECT 'Calvin' AS foo \gset
> >> \setenv FOO :foo
> >> \! echo $FOO
> >> Calvin
>
> > You're the second person who's mentioned this workaround,
Hi,
I took a look at the rebased patch.
+ varisnotnull
+ boolean
+
+
+ True if the schema variable doesn't allow null value. The default
value is false.
I wonder whether the field can be named in positive tense: e.g.
varallowsnull with default of true.
+ vareoxac
On 20/12/2020 21:05, David Fetter wrote:
We have plenty of ways to spawn shells and cause havoc, and we
wouldn't be able to block them all even if we decided to put a bunch
of pretty onerous restrictions on psql at this very late date. We have
\set, backticks, \!, and bunches of things less obvio
Hi,
This is continuation of the previous review.
+* We should to use schema variable buffer, when
+* it is available.
'should use' (no to)
+ /* When buffer of used schema variables loaded from shared memory */
A verb seems missing in
Hi,
The current wait events are already pretty useful. But I think we could
make them more informative without adding real runtime overhead.
1) For lwlocks I think it'd be quite useful to show the mode of acquisition in
pg_stat_activity.wait_event_type, instead of just saying 'LWLock'.
I think
Hi,
On 2020-11-23 19:44:37 -0300, Alvaro Herrera wrote:
> I was contemplating commands/trigger.c this morning (after Heikki split
> copy.c) thinking about the three pieces embedded in there -- one
> catalog/pg_trigger.c, one in executor (execTrigger.c?) and what seems a
> very small piece to remai
Hi,
w.r.t. the patch,
+select '[3]'::jsonb || '{}'::jsonb;
+ ?column?
+--
+ [3, {}]
+(1 row)
+
+select '3'::jsonb || '[]'::jsonb;
Should cases where the empty array precedes non-empty jsonb be added ?
select '[]'::jsonb || '3'::jsonb;
select '{}'::jsonb || '[3]'::jsonb;
Cheers
On Sun, Dec 20, 2020 at 10:27 PM Magnus Hagander wrote:
>
> On Sat, Dec 19, 2020 at 6:00 AM Michael Paquier wrote:
> >
> > On Sat, Dec 19, 2020 at 10:03:47AM +0530, Amit Kapila wrote:
> > > Glad to hear. I am confident that you can do justice to this role.
> >
> > I also think you will do just fi
Hi,
On 2020-12-20 16:26:42 +1300, Thomas Munro wrote:
> > 1. port.h cannot assume that has already been included;
> > nor do I want to fix that by including there. Do we
> > really need to define a fallback value of IOV_MAX? If so,
> > maybe the answer is to put the replacement struct iovec an
Thanks, Bruce
On Sat, 19 Dec 2020 at 16:58, Bruce Momjian wrote:
>
...
>
> To enable the direct injection of keys into the server, we would need a
> new command for this, since trying to make the passphrase command do
> this will lead to unnecessary complexity. The passphrase command should
> do
Greetings Alastair,
* Alastair Turner (min...@decodable.me) wrote:
> On Sat, 19 Dec 2020 at 16:58, Bruce Momjian wrote:
> > To enable the direct injection of keys into the server, we would need a
> > new command for this, since trying to make the passphrase command do
> > this will lead to unnece
Hi,
On 2020-12-20 04:13:19 +, Noah Misch wrote:
> postgres: subscriber: logical replication worker for subscription 16411
> (GetTransactionSnapshot+0x168) [0x951ce8]
> postgres: subscriber: logical replication worker for subscription 16411
> (InitializeParallelDSM+0x16) [0x52cf86
On Sun, Dec 20, 2020 at 10:42:40PM +0200, Heikki Linnakangas wrote:
> On 20/12/2020 21:05, David Fetter wrote:
> > We have plenty of ways to spawn shells and cause havoc, and we
> > wouldn't be able to block them all even if we decided to put a bunch
> > of pretty onerous restrictions on psql at th
On Sun, Dec 20, 2020 at 3:13 PM Andres Freund wrote:
> Hm. Do I understand correctly that this problem is hit solely because
> the parallel mode code relies on there already have been a transaction
> snapshot set, thus avoiding the error? And that the code normally only
> works because GetTransact
On Sun, Dec 20, 2020 at 11:07 AM Tom Lane wrote:
> If we could draw a line between "safe" and "unsafe" environment
> variables, I'd be willing to consider a patch that allows directly
> setting only the former. But I don't see how to draw that line.
>
>
IIUC the threat here is for users that wri
Hi Stephen
On Sun, 20 Dec 2020 at 22:59, Stephen Frost wrote:
>
...
> However, after chatting with Bruce about it for a bit this weekend, I'm
> not sure that we need to tackle the second case today. I don't think
> there's any doubt that there will be users who will want PG to manage
> the keyri
Greetings,
* Alastair Turner (min...@decodable.me) wrote:
> On Sun, 20 Dec 2020 at 22:59, Stephen Frost wrote:
> > Yes, it's true that after things are implemented it can be more
> > difficult to change them- but if you're concerned about the specific
> > on-disk format of the keyring then please
On Fri, Dec 18, 2020 at 11:30:16AM -0500, Stephen Frost wrote:
> * Heikki Linnakangas (hlinn...@iki.fi) wrote:
>> +1
>
> Yeah, in a quick look, this looks like a good improvement.
Thanks. This has been applied as of 93e8ff8.
--
Michael
signature.asc
Description: PGP signature
Thanks Stephen,
On Mon, 21 Dec 2020 at 00:33, Stephen Frost wrote:
>
> Greetings,
>
> * Alastair Turner (min...@decodable.me) wrote:
...
> >
> > What I'd like specifically is to have the option of an external
> > keyring as a first class key store, where the keys stored in the
> > external keyrin
Greetings,
* Alastair Turner (min...@decodable.me) wrote:
> On Mon, 21 Dec 2020 at 00:33, Stephen Frost wrote:
> > * Alastair Turner (min...@decodable.me) wrote:
> > > What I'd like specifically is to have the option of an external
> > > keyring as a first class key store, where the keys stored i
Hi
The cfbost seems complains about the testcase:
Command exited with code 1
perl dumpregr.pl
=== $path ===\ndiff -w -U3
C:/projects/postgresql/src/test/regress/expected/write_parallel.out
C:/projects/postgresql/src/test/regress/results/write_parallel.out
--- C:/projects/postgresql/src/test/reg
Hi
> Posting an updated set of patches to address recent feedback:
>
> - Removed conditional-locking code used in parallel-safety checking code
> (Tsunakawa-san feedback). It turns out that for the problem test case, no
> parallel-safety checking should be occurring that locks relations because
>
"David G. Johnston" writes:
> On Sun, Dec 20, 2020 at 11:07 AM Tom Lane wrote:
>> If we could draw a line between "safe" and "unsafe" environment
>> variables, I'd be willing to consider a patch that allows directly
>> setting only the former. But I don't see how to draw that line.
> Because if
On Sat, Dec 19, 2020 at 12:10 PM Amit Kapila wrote:
>
> On Fri, Dec 18, 2020 at 6:41 PM Peter Smith wrote:
> >
>
> I understand why you are trying to create this patch atop logical
> decoding of 2PC patch but I think it is better to create this as an
> independent patch and then use it to test 2P
On Fri, Dec 18, 2020 at 8:15 AM Bharath Rupireddy
wrote:
> On Fri, Dec 18, 2020 at 7:18 AM Michael Paquier wrote:
> > On Thu, Dec 17, 2020 at 03:06:59PM +0530, Bharath Rupireddy wrote:
> > > The behavior of the ctas/cmv, in case the relation already exists is as
> > > shown in [1]. The things tha
On Sun, Dec 20, 2020 at 9:43 AM Noah Misch wrote:
>
> Since commit 039eb6e added logical replication support for TRUNCATE, logical
> apply of the TRUNCATE fails if it chooses a parallel index build:
>
I think the TRUNCATE operation should not use parallelism either via
apply worker or without it
Hi all,
While analyzing the issue James reported to us, I realized that if the
schema option in the control file is specified and the schema doesn’t
exist we create the schema on CREATE EXTENSION but the created schema
doesn’t refer to the extension. Due to this behavior, the schema
remains even o
> > I'm drawing a blank on trivial candidate uses for preadv(), without
> > infrastructure from later patches.
>
> Can't immediately think of something either.
This might be not that trivial , but maybe acquire_sample_rows() from analyze.c
?
Please note however there's patch
https://www.post
On Fri, Dec 18, 2020 at 11:24 PM Justin Pryzby wrote:
> On Fri, Dec 18, 2020 at 07:39:14AM +0530, Bharath Rupireddy wrote:
> > On Fri, Dec 18, 2020 at 2:14 AM Justin Pryzby wrote:
> > > Are you thinking that TableInsertState would eventually have additional
> > > attributes which would apply to o
On Fri, Dec 18, 2020 at 11:54:39AM -0600, Justin Pryzby wrote:
> On Fri, Dec 18, 2020 at 07:39:14AM +0530, Bharath Rupireddy wrote:
> > On Fri, Dec 18, 2020 at 2:14 AM Justin Pryzby wrote:
> > > Are you thinking that TableInsertState would eventually have additional
> > > attributes which would ap
On Mon, Dec 21, 2020 at 04:02:29PM +0900, Masahiko Sawada wrote:
> Is it a bug? Since the created schema obviously depends on the
> extension when we created the schema specified in the schema option, I
> think we might want to create the dependency so that DROP EXTENSION
> drops the schema as well
46 matches
Mail list logo
