Hi all,
The remnant work that I have on my agenda to replace the remaining
low-level cryptohash calls of OpenSSL (SHAXXInit and such) by EVP is
the stuff related to SHA1, that gets used in two places: pgcrypto and
uuid-ossp.
First, I got to wonder if it would be better to support SHA1 directly
in
On Thursday, December 10, 2020 12:27 PM, Amit Kapila wrote:
> On Thu, Dec 10, 2020 at 7:11 AM Kyotaro Horiguchi
> wrote:
> >
> > At Wed, 9 Dec 2020 16:27:30 +0530, Amit Kapila
> > wrote in
> > > On Wed, Dec 9, 2020 at 6:32 AM Kyotaro Horiguchi
> > > > Mmm. At least btree doesn't need to call smg
On Thu, Dec 10, 2020 at 5:25 PM Dilip Kumar wrote:
>
>
> /*
> + * PrepareParallelMode
> + *
> + * Prepare for entering parallel mode, based on command-type.
> + */
> +void
> +PrepareParallelMode(CmdType commandType)
> +{
> + Assert(!IsInParallelMode() || force_parallel_mode != FORCE_PARALLEL_OFF)
From: Jamison, Kirk/ジャミソン カーク
> I added comment in 0004 the limitation of optimization when there are TOAST
> relations that use NON-PLAIN strategy. i.e. The optimization works if the data
> types used are integers, OID, bytea, etc. But for TOAST-able data types like
> text,
> the optimization wi
On Tue, 8 Dec 2020 at 14:33, Krunal Bauskar wrote:
>
>
> On Thu, 3 Dec 2020 at 21:32, Tom Lane wrote:
>
>> Krunal Bauskar writes:
>> > Any updates or further inputs on this.
>>
>> As far as LSE goes: my take is that tampering with the
>> compiler/platform's default optimization options requires
On Tue, Dec 8, 2020 at 9:14 PM Amit Kapila wrote:
>
> On Tue, Dec 8, 2020 at 11:53 AM Peter Smith wrote:
> >
> > Yes, I observed this same behavior.
> >
> > IIUC the only way for the tablesync worker to go from CATCHUP mode to
> > SYNCDONE is via the call to process_sync_tables.
> >
> > But a sid
On Thu, Dec 10, 2020 at 1:50 PM Greg Nancarrow wrote:
>
> On Thu, Dec 10, 2020 at 5:25 PM Dilip Kumar wrote:
> >
> >
> > /*
> > + * PrepareParallelMode
> > + *
> > + * Prepare for entering parallel mode, based on command-type.
> > + */
> > +void
> > +PrepareParallelMode(CmdType commandType)
> >
Hi,
While reading the documentation of pg_shmem_allocations, I noticed that the
off column is described as such :
"The offset at which the allocation starts. NULL for anonymous allocations
and unused memory."
Whereas, the view returns a value for unused memory:
[local]:5433 postgres@postgres=#
On Thu, Dec 10, 2020 at 3:19 PM Peter Smith wrote:
>
> On Tue, Dec 8, 2020 at 9:14 PM Amit Kapila wrote:
> >
> > On Tue, Dec 8, 2020 at 11:53 AM Peter Smith wrote:
> > >
> > > Yes, I observed this same behavior.
> > >
> > > IIUC the only way for the tablesync worker to go from CATCHUP mode to
>
> 9 дек. 2020 г., в 14:47, Andrey Borodin написал(а):
>
>
>
>> 7 дек. 2020 г., в 23:56, Peter Geoghegan написал(а):
>>
>> On Mon, Dec 7, 2020 at 2:05 AM Andrey Borodin wrote:
>>> Here's version with tests and docs. I still have no idea how to print some
>>> useful information about tuples
Hi
+ allow = ps && IsA(ps, GatherState) && !ps->ps_ProjInfo &&
+ plannedstmt->parallelModeNeeded &&
+ plannedstmt->planTree &&
+ IsA(plannedstmt->planTree, Gather) &&
+
On Thu, Dec 10, 2020 at 1:40 PM k.jami...@fujitsu.com
wrote:
>
> Yes, I have tested that optimization works for index relations.
>
> I have attached the V34, following the conditions that we use "cached" flag
> for both DropRelFileNodesBuffers() and DropRelFileNodesBuffers() for
> consistency.
> I
On Thu, Dec 10, 2020 at 3:59 PM Hou, Zhijie wrote:
>
> Hi
>
> + allow = ps && IsA(ps, GatherState) && !ps->ps_ProjInfo &&
> + plannedstmt->parallelModeNeeded &&
> + plannedstmt->planTree &&
> +
On Thu, Dec 10, 2020 at 4:49 PM Dilip Kumar wrote:
> > + allow = ps && IsA(ps, GatherState) && !ps->ps_ProjInfo
&&
> > + plannedstmt->parallelModeNeeded &&
> > + plannedstmt->planTree &&
> > + I
On Mon, Dec 7, 2020 at 8:26 PM Andy Fan wrote:
> Hi:
> I see initscan calls RelationGetwNumberOfBlocks every time and rescan
> calls
> initscan as well. In my system, RelationGetNumberOfBlocks is expensive
> (the reason
> doesn't deserve a talk.. ), so in a nest loop + Bitmap heap scan case,
Hi,
Currently, for CTAS or CREATE MATERIALIZED VIEW(CMV) without
if-not-exists clause, the existence of the relation gets checked
during the execution of the select part and an error is thrown there.
All the unnecessary rewrite and planning for the select part would
have happened just to fail late
On Thu, Dec 10, 2020 at 5:00 PM Bharath Rupireddy
wrote:
>
> On Thu, Dec 10, 2020 at 4:49 PM Dilip Kumar wrote:
> > > + allow = ps && IsA(ps, GatherState) && !ps->ps_ProjInfo &&
> > > + plannedstmt->parallelModeNeeded &&
> > > +
On Thu, Dec 10, 2020 at 7:31 PM Andy Fan wrote:
>
>
> On Mon, Dec 7, 2020 at 8:26 PM Andy Fan wrote:
>
>> Hi:
>> I see initscan calls RelationGetwNumberOfBlocks every time and rescan
>> calls
>> initscan as well. In my system, RelationGetNumberOfBlocks is expensive
>> (the reason
>> doesn't d
On 10.12.2020 10:45, Pavel Stehule wrote:
st 9. 12. 2020 v 14:28 odesílatel Konstantin Knizhnik
mailto:k.knizh...@postgrespro.ru>> napsal:
On 09.12.2020 15:34, Pavel Stehule wrote:
Hi
st 9. 12. 2020 v 13:17 odesílatel Greg Nancarrow
mailto:gregn4...@gmail.com>> napsal:
On Wed, Dec 9, 2020 at 9:10 PM David G. Johnston
wrote:
>
> Hey,
>
> Would it be accurate to add the following sentence to the INSERT
> documentation under "Outputs"?
>
> "...inserted or updated by the command." For a multiple-values insertion,
> the order of output rows will match the order th
Hi, everyone
>
> I have read the patch and did some simple tests. I'm not entirely sure
> about some code segments; e.g.:
>
> In the BootStrapKmgr() we generate a data encryption key by:
> key = generate_crypto_key(file_encryption_keylen);
>
> However, I found that the file_encryption_keylen is alw
I went looking at the SSL connection state change information callback we
install when setting up connections with OpenSSL, and I wasn't getting the
state changes I expected. Turns out we install it at the tail end of setting
up the connection so we miss most of the calls. Moving it to the beginn
On Thu, Dec 10, 2020 at 5:19 PM Dilip Kumar wrote:
> > > > + allow = ps && IsA(ps, GatherState) && !ps->ps_ProjInfo
> > > > &&
> > > > + plannedstmt->parallelModeNeeded &&
> > > > + plannedstmt->planTree &&
> > > > +
On Thursday, December 10, 2020, Ashutosh Bapat
wrote:
> On Wed, Dec 9, 2020 at 9:10 PM David G. Johnston
> wrote:
> >
> > Hey,
> >
> > Would it be accurate to add the following sentence to the INSERT
> documentation under "Outputs"?
> >
> > "...inserted or updated by the command." For a multipl
Le 08/12/2020 à 18:52, Andrey Borodin a écrit :
Hi Gilles!
Many thanks for your message!
8 дек. 2020 г., в 21:05, Gilles Darold написал(а):
I know that this report is not really helpful
Quite contrary - this benchmarks prove that controllable reproduction exists.
I've rebased patches for P
čt 10. 12. 2020 v 14:03 odesílatel Konstantin Knizhnik <
k.knizh...@postgrespro.ru> napsal:
>
>
> On 10.12.2020 10:45, Pavel Stehule wrote:
>
>
>
> st 9. 12. 2020 v 14:28 odesílatel Konstantin Knizhnik <
> k.knizh...@postgrespro.ru> napsal:
>
>>
>>
>> On 09.12.2020 15:34, Pavel Stehule wrote:
>>
>
Hi, Amit!
It's really cool to hear about another GiST improvement proposal. I'd like
to connect recently committed GiST ordered build discussion here [1] and
further improvement proposed [2]
I've tested feature [1] and got 2.5-3 times speed improvement which is much
better I believe. There is an o
On 10.12.2020 18:12, Pavel Stehule wrote:
My idea was a little bit different. Inside postinit initialize some
global variables with info if there are event triggers or not. And
later you can use this variable to start transactions and other things.
There will be two access to pg_event_tri
On Wed, Dec 09, 2020 at 12:49:48PM -0500, Tom Lane wrote:
> I've pushed the core patch now. The jsonb parts now have to be
> rebased onto this design, which I'm assuming Dmitry will tackle
> (I do not intend to). It's not quite clear to me whether we have
> a meeting of the minds on what the json
Greetings,
* Laurenz Albe (laurenz.a...@cybertec.at) wrote:
> On Tue, 2020-12-08 at 17:29 +, Bossart, Nathan wrote:
> > +1 to setting checkpoint_completion_target to 0.9 by default.
>
> +1 for changing the default or getting rid of it, as Tom suggested.
Attached is a patch to change it from
Howdy,
On 2020-Dec-10, Stephen Frost wrote:
> * Laurenz Albe (laurenz.a...@cybertec.at) wrote:
> > On Tue, 2020-12-08 at 17:29 +, Bossart, Nathan wrote:
> > > +1 to setting checkpoint_completion_target to 0.9 by default.
> >
> > +1 for changing the default or getting rid of it, as Tom sugges
Greetings,
* Alvaro Herrera (alvhe...@alvh.no-ip.org) wrote:
> On 2020-Dec-10, Stephen Frost wrote:
> > * Laurenz Albe (laurenz.a...@cybertec.at) wrote:
> > > On Tue, 2020-12-08 at 17:29 +, Bossart, Nathan wrote:
> > > > +1 to setting checkpoint_completion_target to 0.9 by default.
> > >
> >
$SUBJECT is not great. The options to pg_basebackup that are not
tested by any part of the regression test suite include the
single-letter options rlzZdUwWvP as well as --no-estimate-size.
It would probably be good to fix as much of this as we can, but there
are a couple of cases I think would be
čt 10. 12. 2020 v 16:48 odesílatel Konstantin Knizhnik <
k.knizh...@postgrespro.ru> napsal:
>
>
> On 10.12.2020 18:12, Pavel Stehule wrote:
>
>
> My idea was a little bit different. Inside postinit initialize some global
> variables with info if there are event triggers or not. And later you can
>
On 2020-06-24 20:21, Peter Eisentraut wrote:
On 2020-06-24 10:12, Vik Fearing wrote:
On 6/24/20 8:35 AM, Peter Eisentraut wrote:
I was checking some loose ends in SQL conformance, when I noticed: We
support GRANT role ... GRANTED BY CURRENT_USER, but we don't support
CURRENT_ROLE in that place,
On Wed, Dec 9, 2020 at 10:34:59PM +0100, Daniel Gustafsson wrote:
> > On 2 Dec 2020, at 22:38, Bruce Momjian wrote:
> >
> > Attached is a patch for key management, which will eventually be part of
> > cluster file encryption (CFE), called TDE (Transparent Data Encryption)
> > by Oracle.
>
> The
Hi,
I noticed that when pg_waldump finds an invalid record, the
corresponding error message seems to point to the last valid record
read.
rmgr: ... lsn: 0/090E5AF8, prev 0/090E59D0, ...
pg_waldump: fatal: error in WAL record at 0/90E5AF8: invalid record length
at 0/90E5B30: wanted 24, go
On Wed, Dec 9, 2020 at 05:18:37PM -0500, Stephen Frost wrote:
> Greetings,
>
> * Daniel Gustafsson (dan...@yesql.se) wrote:
> > > On 2 Dec 2020, at 22:38, Bruce Momjian wrote:
> > > Attached is a patch for key management, which will eventually be part of
> > > cluster file encryption (CFE), call
Greetings,
* Tom Lane (t...@sss.pgh.pa.us) wrote:
> Alvaro Herrera writes:
> > On 2020-Oct-29, Stephen Frost wrote:
> >> I do think it'd be good to find a way to check every once in a while
> >> even when we aren't going to delay though. Not sure what the best
> >> answer there is.
>
> > Maybe
Hi,
Continuing with TODO list maintenance, first a couple things to clean up:
- Allow ALTER INDEX ... RENAME concurrently
This was in the wrong section, but it's irrelevant: The lock level was
lowered in commit 1b5d797cd4f, so I went ahead and removed this already.
- Add CORRESPONDING BY to UNI
On Thu, Oct 29, 2020 at 5:36 PM Alvaro Herrera wrote:
> Maybe instead of thinking specifically in terms of vacuum, we could
> count buffer accesses (read from kernel) and check the latch once every
> 1000th such, or something like that. Then a very long query doesn't
> have to wait until it's run
Hi,
over in the pgsql-general channel, Michael Lewis reported [1] a bit
strange behavior switching between good/bad estimates with extended
statistics.
The crux of the issue is that with statistics containing both MCV and
functional dependencies, we prefer applying the MCV. And functional
depende
Hi,
I try to host multiple postgresql-servers on the same ip and the same
port through SNI-based load-balancing.
Currently this is not possible because of two issues:
1. The psql client won't set the tls-sni-extension correctly
(https://www.postgresql.org/message-id/20181211145240.GL20222%40redha
Thanks a lot for testing this patch. It's good to see it run through a
benchmark that exercises quite a few join problems.
On Fri, 11 Dec 2020 at 05:44, Konstantin Knizhnik
wrote:
> For most queries performance is the same, some queries are executed
> faster but
> one query is 150 times slower:
>
On Thursday, December 10, 2020 8:12 PM, Amit Kapila wrote:
> On Thu, Dec 10, 2020 at 1:40 PM k.jami...@fujitsu.com
> wrote:
> >
> > Yes, I have tested that optimization works for index relations.
> >
> > I have attached the V34, following the conditions that we use "cached"
> > flag for both DropR
> Currently, for CTAS or CREATE MATERIALIZED VIEW(CMV) without if-not-exists
> clause, the existence of the relation gets checked during the execution
> of the select part and an error is thrown there.
> All the unnecessary rewrite and planning for the select part would have
> happened just to fail
From: Jamison, Kirk/ジャミソン カーク
> On Thursday, December 10, 2020 8:12 PM, Amit Kapila wrote:
> > AFAIU, it won't take optimization path only when we have TOAST relation but
> > there is no insertion corresponding to it. If so, then we don't need to
> > mention
> > it specifically because there are
On Fri, Dec 11, 2020 at 5:54 AM k.jami...@fujitsu.com
wrote:
>
> On Thursday, December 10, 2020 8:12 PM, Amit Kapila wrote:
> > On Thu, Dec 10, 2020 at 1:40 PM k.jami...@fujitsu.com
> > wrote:
> > >
> > > Yes, I have tested that optimization works for index relations.
> > >
> > > I have attached
From: tsunakawa.ta...@fujitsu.com
> What's valuable as a code comment to describe the remaining issue is that the
You can attach XXX or FIXME in front of the issue description for easier
search. (XXX appears to be used much more often in Postgres.)
Regards
Takayuki Tsunakawa
On Thu, Dec 10, 2020 at 07:26:48PM +0800, Neil Chen wrote:
>
>
> Hi, everyone
>
> I have read the patch and did some simple tests. I'm not entirely sure
> about some code segments; e.g.:
>
> In the BootStrapKmgr() we generate a data encryption key by:
> key = generate_crypto
Thanks for taking a look at this.
On Fri, Dec 11, 2020 at 6:33 AM Hou, Zhijie wrote:
>
> > Currently, for CTAS or CREATE MATERIALIZED VIEW(CMV) without if-not-exists
> > clause, the existence of the relation gets checked during the execution
> > of the select part and an error is thrown there.
>
At Thu, 10 Dec 2020 11:07:47 +0100, Benoit Lobréau
wrote in
> Hi,
>
> While reading the documentation of pg_shmem_allocations, I noticed that the
> off column is described as such :
>
> "The offset at which the allocation starts. NULL for anonymous allocations
> and unused memory."
>
> Wherea
On Fri, Dec 11, 2020 at 8:34 AM Robert Haas wrote:
> On Thu, Oct 29, 2020 at 5:36 PM Alvaro Herrera
> wrote:
> > Maybe instead of thinking specifically in terms of vacuum, we could
> > count buffer accesses (read from kernel) and check the latch once every
> > 1000th such, or something like that
On Wed, Dec 09, 2020 at 06:37:22PM +, Bossart, Nathan wrote:
> On 12/8/20, 10:16 PM, "Michael Paquier" wrote:
>> Yeah, I'd rather leave out the part of the patch where we have the
>> checkpointer say "idle". So I still think that what v3 did upthread,
>> by just resetting the ps display in al
Isn't the sense of "reset" inverted ?
I think maybe you mean to do set_ps_display(""); in the "if reset".
On Fri, Dec 11, 2020 at 12:54:22PM +0900, Michael Paquier wrote:
> +update_checkpoint_display(int flags, bool restartpoint, bool reset)
> +{
> + if (reset)
> + {
> + char
On Thu, Dec 10, 2020 at 10:02:10PM -0600, Justin Pryzby wrote:
> Isn't the sense of "reset" inverted ?
It is ;p
--
Michael
signature.asc
Description: PGP signature
At Thu, 10 Dec 2020 18:47:58 +, "Bossart, Nathan"
wrote in
> Hi,
>
> I noticed that when pg_waldump finds an invalid record, the
> corresponding error message seems to point to the last valid record
> read.
Good catch!
> rmgr: ... lsn: 0/090E5AF8, prev 0/090E59D0, ...
> pg_waldump
On Fri, Dec 11, 2020 at 01:30:16PM +0900, Kyotaro Horiguchi wrote:
> currRecPtr is a private member of the struct (see the definition of
> the struct XLogReaderState). We should instead use EndRecPtr outside
> xlog reader.
Please note that this is documented in xlogreader.h. Hmm. I can see
your
On Fri, Dec 11, 2020 at 11:00:58AM +0900, Kyotaro Horiguchi wrote:
> Although we could just rip some words off, I'd like to propose instead
> to add an explanation why it is not exposed for anonymous allocations,
> like the column allocated_size.
Indeed, there is a hiccup between what the code doe
> IMO, let's not change the 1) behaviour to 3) with the patch. If agreed,
> I can do the following way in ExplainOneUtility and will add a comment on
> why we are doing this.
>
> if (es->analyze)
> (void) CheckRelExistenceInCTAS(ctas, true);
>
> Thoughts?
Agreed.
Just in case, I took
On Thu, Dec 10, 2020 at 12:32:52PM -0500, Robert Haas wrote:
> It would probably be good to fix as much of this as we can, but there
> are a couple of cases I think would be particularly good to cover. One
> is 'pg_basebackup -Ft -Xnone -D -', which tries to write the output as
> a single tar file
čt 10. 12. 2020 v 19:09 odesílatel Pavel Stehule
napsal:
>
>
> čt 10. 12. 2020 v 16:48 odesílatel Konstantin Knizhnik <
> k.knizh...@postgrespro.ru> napsal:
>
>>
>>
>> On 10.12.2020 18:12, Pavel Stehule wrote:
>>
>>
>> My idea was a little bit different. Inside postinit initialize some
>> global
On Fri, Dec 11, 2020 at 12:13 PM Hou, Zhijie wrote:
> > IMO, let's not change the 1) behaviour to 3) with the patch. If agreed,
>
> > I can do the following way in ExplainOneUtility and will add a comment on
>
> > why we are doing this.
>
> > if (es->analyze)
>
> > (void) CheckRelExistenceInCTAS(
63 matches
Mail list logo
