Re: Online verification of checksums

2020-11-09 Thread Michael Paquier
On Thu, Nov 05, 2020 at 10:57:16AM +0900, Michael Paquier wrote: > I was referring to the patch I sent on this thread that fixes the > detection of a corruption for the zero-only case and where pd_lsn > and/or pg_upper are trashed by a corruption of the page header. Both > cases allow a base backu

Re: Allow some recovery parameters to be changed with reload

2020-11-09 Thread Kyotaro Horiguchi
At Sat, 07 Nov 2020 00:36:33 +0300, Sergei Kornilov wrote in > Hello > > > I'm wondering if it's safe to allow restore_command to be emptied during > > archive recovery. Even when it's emptied, archive recovery can proceed > > by reading WAL files from pg_wal directory. This is the same behavior

Re: logical streaming of xacts via test_decoding is broken

2020-11-09 Thread Dilip Kumar
On Tue, Nov 10, 2020 at 8:14 AM Amit Kapila wrote: > > On Mon, Nov 9, 2020 at 6:00 PM Dilip Kumar wrote: > > > > On Mon, Nov 9, 2020 at 5:37 PM Dilip Kumar wrote: > > > > > > On Mon, Nov 9, 2020 at 4:21 PM Amit Kapila > > > wrote: > > > > > > The bigger question is do we want to give users an

Re: [BUG]: segfault during update

2020-11-09 Thread Andres Freund
Hi, On 2020-11-08 12:46:44 -0500, Tom Lane wrote: > This logic is entirely gone in v12, which confirms my instinct that > there was something about Andres' slot-manipulation changes that > broke this scenario. Entirely possible :(. In my defense, it wasn't exactly obvious or documented that the f

RE: [Patch] Optimize dropping of relation buffers using dlist

2020-11-09 Thread k.jami...@fujitsu.com
On Tuesday, November 10, 2020 12:27 PM, Horiguchi-san wrote: > To: amit.kapil...@gmail.com > Cc: Jamison, Kirk/ジャミソン カーク ; Tsunakawa, > Takayuki/綱川 貴之 ; t...@sss.pgh.pa.us; > and...@anarazel.de; robertmh...@gmail.com; > tomas.von...@2ndquadrant.com; pgsql-hack...@postgresql.org > Subject: Re: [Patc

Re: [Patch] Optimize dropping of relation buffers using dlist

2020-11-09 Thread Amit Kapila
On Tue, Nov 10, 2020 at 10:00 AM Thomas Munro wrote: > > On Sat, Nov 7, 2020 at 12:40 AM Amit Kapila wrote: > > I think one of the problems is returning fewer rows and that too > > without any warning or error, so maybe that is a bigger problem but we > > seem to be okay with it as that is alread

Re: logical streaming of xacts via test_decoding is broken

2020-11-09 Thread Amit Kapila
On Tue, Nov 10, 2020 at 10:26 AM Dilip Kumar wrote: > > On Tue, Nov 10, 2020 at 8:14 AM Amit Kapila wrote: > > > > On Mon, Nov 9, 2020 at 6:00 PM Dilip Kumar wrote: > > > > > > On Mon, Nov 9, 2020 at 5:37 PM Dilip Kumar wrote: > > > > > > > > On Mon, Nov 9, 2020 at 4:21 PM Amit Kapila > > > >

Re: [BUG]: segfault during update

2020-11-09 Thread Tom Lane
Andres Freund writes: > On 2020-11-08 12:46:44 -0500, Tom Lane wrote: >> In v12 we end up using the junkfilter's output >> slot, which does not have a sufficiently accurate tupdesc to deal with >> an on-disk tuple rather than one constructed by the executor. > I really wonder if we ought to redes

[PATCH] TAP test showing that pg_replication_slot_advance() works on standby

2020-11-09 Thread Craig Ringer
Hi all The attached patch adds a test to the TAP logical decoding suite to show that pg_replication_slot_advance() works on a server in standby mode. I didn't add a full demonstration of how to do failover with logical slots because we're still missing a way to "sync" a logical slot from a primar

Re: [Patch] Optimize dropping of relation buffers using dlist

2020-11-09 Thread Thomas Munro
On Tue, Nov 10, 2020 at 6:18 PM Amit Kapila wrote: > Do we always truncate all the blocks? What if the vacuum has cleaned > last N (say 100) blocks then how do we handle it? Oh, hmm. Yeah, that idea only works for DROP, not for truncate last N.

Add docs stub for recovery.conf

2020-11-09 Thread Craig Ringer
Hi all I noticed that when recovery.conf was removed in 2dedf4d9a8 (yay!) the docs for it were removed completely as well. That's largely sensible, but is confusing when users have upgraded and are trying to find out what happened, or how to configure equivalent functionality. https://www.postgre

Re: [HACKERS] logical decoding of two-phase transactions

2020-11-09 Thread Peter Smith
FYI - I have cross-checked all the v18 patch code against the v18 code coverage [1] resulting from running the tests. The purpose of this study was to identify where there may be any gaps in the testing of this patch - e.g is there some v18 code not currently getting executed by the tests? I foun

Re: logical streaming of xacts via test_decoding is broken

2020-11-09 Thread Dilip Kumar
On Tue, Nov 10, 2020 at 10:52 AM Amit Kapila wrote: > > On Tue, Nov 10, 2020 at 10:26 AM Dilip Kumar wrote: > > > > On Tue, Nov 10, 2020 at 8:14 AM Amit Kapila wrote: > > > > > > On Mon, Nov 9, 2020 at 6:00 PM Dilip Kumar wrote: > > > > > > > > On Mon, Nov 9, 2020 at 5:37 PM Dilip Kumar > > >

RE: [Patch] Optimize dropping of relation buffers using dlist

2020-11-09 Thread tsunakawa.ta...@fujitsu.com
From: Jamison, Kirk/ジャミソン カーク > So I proceeded to update the patches using the "cached" parameter and > updated the corresponding comments to it in 0002. OK, I'm in favor of the name "cached" now, although I first agreed with Horiguchi-san in that it's better to use a name that represents the na

Re: MultiXact\SLRU buffers configuration

2020-11-09 Thread Andrey Borodin
> 10 нояб. 2020 г., в 05:13, Tomas Vondra > написал(а): > After the issue reported in [1] got fixed, I've restarted the multi-xact > stress test, hoping to reproduce the issue. But so far no luck :-( Tomas, many thanks for looking into this. I figured out that to make multixact sets bigger

Re: PATCH: Report libpq version and configuration

2020-11-09 Thread Craig Ringer
On Tue, Nov 10, 2020 at 12:33 AM Tom Lane wrote: > Alvaro Herrera writes: > > Well, if we can make it run in more systems than just Linux, then it > > seems worth having. The submitted patch seems a little bit on the > > naughty side. > > I agree that the facility seems possibly useful, as long

Re: abstract Unix-domain sockets

2020-11-09 Thread Michael Paquier
On Mon, Nov 09, 2020 at 09:04:24AM +0100, Peter Eisentraut wrote: > On 2020-11-09 07:08, Michael Paquier wrote: > The @ is the standard way of representing this in the user interface and the > configuration, so it seems sensible to me that way. Ok. > Can you sketch how you would structure this?

Re: Temporary tables versus wraparound... again

2020-11-09 Thread Masahiko Sawada
On Mon, Nov 9, 2020 at 3:23 PM Greg Stark wrote: > > On Mon, 9 Nov 2020 at 00:17, Noah Misch wrote: > > > > > 2) adding the dependency on heapam.h to heap.c makes sense because of > > > heap_inplace_update bt it may be a bit annoying because I suspect > > > that's a useful sanity check that the t

Re: Use standard SIGHUP and SIGTERM handlers in autoprewarm module

2020-11-09 Thread Kyotaro Horiguchi
At Sat, 7 Nov 2020 19:31:21 +0530, Bharath Rupireddy wrote in > The main reason for having SetLatch() in > SignalHandlerForConfigReload() is to wake up the calling process if > waiting in WaitLatchOrSocket() or WaitLatch() and reload the new > config file and use the reloaded config variables. M

<    1   2