Re: tab completion of IMPORT FOREIGN SCHEMA

2020-09-14 Thread Michael Paquier
On Mon, Aug 17, 2020 at 02:15:34PM +0900, Michael Paquier wrote: > Sounds fine to me as well. The LIMIT TO and EXCEPT clauses are > optional, so using TailMatches() looks fine. > > + else if (TailMatches("FROM", "SERVER", MatchAny, "INTO", MatchAny)) > + COMPLETE_WITH("OPTIONS") > Shouldn

Re: logtape.c stats don't account for unused "prefetched" block numbers

2020-09-14 Thread Jeff Davis
On Mon, 2020-09-14 at 20:48 -0700, Peter Geoghegan wrote: > On Mon, Sep 14, 2020 at 8:07 PM Jeff Davis wrote: > > Sure. Will backporting either patch into REL_13_STABLE now > > interfere > > with RC1 release in any way? > > The RMT will discuss this. > > It would help if there was a patch ready

Re: New statistics for tuning WAL buffer size

2020-09-14 Thread Masahiro Ikeda
On 2020-09-11 01:40, Fujii Masao wrote: On 2020/09/09 13:57, Masahiro Ikeda wrote: On 2020-09-07 16:19, Fujii Masao wrote: On 2020/09/07 9:58, Masahiro Ikeda wrote: Thanks for the review and advice! On 2020-09-03 16:05, Fujii Masao wrote: On 2020/09/02 18:56, Masahiro Ikeda wrote: +/* -

Re: logtape.c stats don't account for unused "prefetched" block numbers

2020-09-14 Thread Jeff Davis
On Thu, 2020-09-10 at 18:42 -0700, Peter Geoghegan wrote: > We still need to put the reliance on ltsWriteBlock() allocating many > blocks before they've been logically written on some kind of formal > footing for Postgres 13 -- it is now possible that an all-zero block > will be left behind even af

<    1   2