Hi Andrey,
On Fri, Aug 21, 2020 at 9:19 PM Andrey Lepikhov
wrote:
> On 8/7/20 2:14 PM, Amit Langote wrote:
> > I was playing around with v5 and I noticed an assertion failure which
> > I concluded is due to improper setting of ri_usesBulkModify. You can
> > reproduce it with these steps.
> >
> >
On Tue, May 19, 2020 at 5:03 AM Tom Lane wrote:
>
> Peter Eisentraut writes:
> > What are the thoughts about then marking the postfix operator deprecated
> > and eventually removing it?
>
> If we do this it'd require a plan. We'd have to also warn about the
> feature deprecation in (at least) th
Hi!
+1 good idea
+1 that's a good idea. Please add it to the next commitfest!
Thanks!
You have a typo:
+if (pset.sversion < 1)
+{
+charsverbuf[32];
+
+pg_log_error("The server (version %s) does not support
extended statistics.",
+
On Fri, Aug 21, 2020 at 06:03:32PM -0400, Bruce Momjian wrote:
> On Tue, Aug 18, 2020 at 02:41:09PM +0200, Bernd Helmle wrote:
>> protocol.sgml describes the protocol messages received by a BASE_BACKUP
>> streaming command, but doesn't tell anything about the additional
>> CopyResponse data message
On Mon, Aug 24, 2020 at 02:48:50PM +0900, Fujii Masao wrote:
> As far as I know, utils/adt is the directory to basically include the files
> for a particular type or operator. So ISTM that mcxtfuncs.c doesn't
> fit to this directory. Isn't it better to put that in utils/mmgr ?
We have also stuff l
On Mon, Aug 24, 2020 at 4:18 PM Amit Langote wrote:
> I would
Oops, thought I'd continue writing, but hit send before actually doing
that. Please ignore.
I have some comments on v6, which I will share later this week.
--
Amit Langote
EnterpriseDB: http://www.enterprisedb.com
Hi Hackers,
I may be wrong, but an issue seems to have been introduced by the
following commit (March 11, 2019):
Allow fractional input values for integer GUCs, and improve rounding logic
https://github.com/postgres/postgres/commit/1a83a80a2fe5b559f85ed4830acb92d5124b7a9a
The changes ma
Few comments for v14 version:
v14-0001:
verify_heapam.c: In function ‘verify_heapam’:
verify_heapam.c:339:14: warning: variable ‘ph’ set but not used
[-Wunused-but-set-variable]
PageHeader ph;
^
verify_heapam.c: In function ‘check_toast_tuple’:
verify_heapam.c:877:8: warning: var
Hi,
As specified in $subject, if the bitmap constructed by bitmap index
scan is non-lossy i.e. row-level bitmap, then showing "Recheck Cond"
in EXPLAIN ANALYZE output is pointless. However in EXPLAIN without
ANALYZE we can't say the bitmap is actually a non-lossy one, as we
don't actually construc
On Sat, 22 Aug 2020 at 08:16, Konstantin Knizhnik
wrote:
> It is possible to do something like this:
>
>with ins as (insert into jsonb_schemas (schema) values (obj_schema)
> on conflict(schema) do nothing returning id) select coalesce((select id
> from ins),(select id from jsonb_schemas where
Re: Magnus Hagander
> > The confusion in my case is I wasn't sure why my distro was named,
> > tried the instructions and it...half worked.
> >
> > Maybe something like this?
> >
> > The PostgreSQL apt repository supports the currently supported stable
> > versions of Debian with the latest version
Hi,
Thanks, Peter.
> FYI - The latest patch (v06) has conflicts when applied.
I've fixed my v06 and created v07.
Also, I added one test to throw an error
to avoid a situation that trigger which has pending events are replaced by
any other trigger in the same session.
Best,
Takamichi Osum
Re: Magnus Hagander
> Well, they are not supported. The packages may be there, but they are not
> supported. I think that's an important distinction. Maybe add something
> like "some packages may be available for older versions of Debian, but are
> not supported" or such?
I'm talking about https:/
Hi, thanks for useful comments.
I agree to expose the number of WAL write caused by full of WAL
buffers.
It's helpful when tuning wal_buffers size. Haribabu separated that
number
into two fields in his patch; one is the number of WAL write by
backend,
and another is by background processes an
On 2020-08-24 20:45, Masahiro Ikeda wrote:
Hi, thanks for useful comments.
I agree to expose the number of WAL write caused by full of WAL
buffers.
It's helpful when tuning wal_buffers size. Haribabu separated that
number
into two fields in his patch; one is the number of WAL write by
backend
On Mon, Aug 24, 2020 at 1:34 PM Christoph Berg wrote:
> Re: Magnus Hagander
> > Well, they are not supported. The packages may be there, but they are not
> > supported. I think that's an important distinction. Maybe add something
> > like "some packages may be available for older versions of Debi
On Mon, Aug 24, 2020 at 1:33 PM Christoph Berg wrote:
> > Or get rid of the wheezy side altogether?
> > >
> >
> > Or move it to the archive. I'm not entirely sure why it's still there.
> > Christoph?
>
> Last time I checked there were still some docker containers using
> wheezy to pull older PG s
On 2020-08-24 13:13, Fujii Masao wrote:
On 2020/08/24 13:01, torikoshia wrote:
On 2020-08-22 21:18, Michael Paquier wrote:
Thanks for reviewing!
On Fri, Aug 21, 2020 at 11:27:06PM +0900, torikoshia wrote:
OK. Added a regression test on sysviews.sql.
(0001-Added-a-regression-test-for-pg_backe
Hi all,
Admittedly quite ahead of time, I would like to volunteer as Commitfest manager
for 2020-11.
If the role is not filled and there are no objections, I can reach out again in
October for confirmation.
//Georgios
On Tue, 18 Aug 2020 at 17:36, Ashutosh Bapat
wrote:
> On Mon, Aug 17, 2020 at 7:32 PM Bharath Rupireddy
> wrote:
> >
> > On Fri, Aug 14, 2020 at 12:46 PM Konstantin Knizhnik <
> k.knizh...@postgrespro.ru> wrote:
> > >
> > > Right now postgres_fdw treat as shippable only builtin functions or
> >
>
> I'm looking into the patch. I have few notes:
>
> 1. I see that in src/backend/access/spgist/README you describe SP-GiST
> tuple as sequence of {Value, ItemPtr to heap, Included attributes}. Is it
> different from regular IndexTuple where tid is within TupleHeader?
>
Yes, the header of SpGist
Hi Tom,
I'm starting tests using ASAN (address sanitizer) at Windows side, using
msvc 2019 (built in asan support):
First test report this:
2020-08-24 10:02:33.220 -03 postmaster[6656] LOG: starting PostgreSQL
14devel, compiled by Visual C++ build 1927, 64-bit
2020-08-24 10:02:33.228 -03 postmast
On Fri, Aug 21, 2020 at 8:53 PM Peter Geoghegan wrote:
> Note that there is a ~20% reduction in blks_hit here, even though the
> patch does ~1% more transactions (the rate limiting doesn't work
> perfectly). There is also a ~5.5% reduction in aggregate
> blk_read_time, and a ~9% reduction in blk_
I wrote:
> For our archives' sake: today I got seemingly-automated mail informing me
> that this patch has been merged into the 4.19-stable, 5.4-stable,
> 5.7-stable, and 5.8-stable kernel branches; but not 4.4-stable,
> 4.9-stable, or 4.14-stable, because it failed to apply.
And this morning's ma
On Tue, Aug 18, 2020 at 12:14 PM Alvaro Herrera
wrote:
> It makes sense to recommend VACUUM after fixing the page, but I agree
> with Sawada-san that it would be sensible to reset the VM bit while
> doing surgery, since that's the state that the page would be in. We
> should certainly *strongly r
Bharath Rupireddy writes:
> As specified in $subject, if the bitmap constructed by bitmap index
> scan is non-lossy i.e. row-level bitmap, then showing "Recheck Cond"
> in EXPLAIN ANALYZE output is pointless. However in EXPLAIN without
> ANALYZE we can't say the bitmap is actually a non-lossy one,
Greg Nancarrow writes:
> The changes made allow fractional input for some cases where I believe
> it shouldn't be allowed (i.e. when the setting does not accept a
> unit).
> ...
> (Is it intentional - or indeed useful - to allow such settings, for
> integer options?)
Given that the commit include
> On Aug 24, 2020, at 12:28 AM, John Naylor wrote:
>
> On Tue, May 19, 2020 at 5:03 AM Tom Lane wrote:
>>
>> Peter Eisentraut writes:
>>> What are the thoughts about then marking the postfix operator deprecated
>>> and eventually removing it?
>>
>> If we do this it'd require a plan. We'd
Hi
I wrote a proof concept for the support window function from plpgsql.
Window function API - functions named WinFuncArg* are polymorphic and it is
not easy to wrap these functions for usage from SQL level. I wrote an
enhancement of the GET statement - for this case GET WINDOW_CONTEXT, that
allo
On Sat, Aug 22, 2020 at 8:38 AM Amit Kapila wrote:
>
> On Fri, Aug 21, 2020 at 5:10 PM Dilip Kumar wrote:
> >
> > I have reviewed and tested the patch and the changes look fine to me.
> >
>
> Thanks, I will push the next patch early next week (by Tuesday) unless
> you or someone else has any more
po 24. 8. 2020 v 4:19 odesílatel Peter Smith napsal:
> I have re-checked the string_to_table_20200821.patch.
>
> Below is one remaining problem.
>
>
>
> COMMENT (help text)
>
> +Splits the string at occurrences
> +of delimiter and forms the remaining data
> +into a ta
Hi!
> 21 авг. 2020 г., в 18:24, Ashutosh Sharma написал(а):
>
> Please find the updated patch with the following new changes:
Do you have plans to support pg_surgery as external extension? For example for
earlier versions of Postgres and for new features, like amcheck_next is
maintained.
ISTM
ne 23. 8. 2020 v 23:08 odesílatel Tom Lane napsal:
> Pavel Stehule writes:
> > I am sending a patch that is years used in GoodData.
>
> I'm quite unexcited about that. I'd be the first to agree that the
> ten-pages estimate is a hack, but it's not an improvement to ask users
> to think of a bet
Hi,
On 2020-08-19 18:58:11 -0400, Alvaro Herrera wrote:
> On 2020-Aug-19, David Rowley wrote:
>
> > Andres' suggestion:
> >
> > regression=# explain (analyze, costs off, timing off, summary off)
> > select count(*) from tenk1 t1 inner join tenk1 t2 on
> > t1.twenty=t2.unique1;
> >
Hi,
On 2020-08-23 22:53:18 -0400, Tom Lane wrote:
> We've seen repeated failures in the tests added by commit 43e084197:
> ...
> I dug into this a bit today, and found that I can reproduce the failure
> reliably by adding a short delay in the right place, as attached.
>
> However, after studying
On 2020-08-24 13:42:35 -0700, Andres Freund wrote:
> Hi,
>
> On 2020-08-23 22:53:18 -0400, Tom Lane wrote:
> > We've seen repeated failures in the tests added by commit 43e084197:
> > ...
> > I dug into this a bit today, and found that I can reproduce the failure
> > reliably by adding a short del
Hi,
Currently lwlock acquisition, whether direct, or via the LockBuffer()
wrapper, have a mode argument. I don't like that much, for three
reasons:
1) I've tried to add annotations for static analyzers to help with
locking correctness. The ones I looked at don't support annotating
shared/ex
Hi.
I have re-checked the string_to_table_20200824.patch.
On Tue, Aug 25, 2020 at 2:34 AM Pavel Stehule wrote:
>> COMMENT (help text)
>>
>> +Splits the string at occurrences
>> +of delimiter and forms the remaining data
>> +into a table with one text type column.
>
On Thu, Jul 16, 2020 at 09:30:12AM +0900, Kyotaro Horiguchi wrote:
> Hello.
>
> The "Certificate Authentication" section in the doc for PG12 and later
> describes the relation ship with clientcert as follows.
>
> > In a pg_hba.conf record specifying certificate authentication, the
> > authenticat
On Wed, Jul 15, 2020 at 01:22:21PM +0200, Magnus Hagander wrote:
> According to the documentation, the filename given in file_fdw must be an
> absolute path. Hwever, it works perfectly fine with a relative path.
>
> So either the documentation is wrong, or the code is wrong. It behaves the
> same
Andres Freund writes:
> ISTM the issue at hand isn't so much that X expects something to be
> printed by Y before it terminates, but that it expects the next step to
> not be executed before Y unlocks. If I understand the wrong output
> correctly, what happens is that "controller_print_speculative
At Mon, 24 Aug 2020 20:01:26 -0400, Bruce Momjian wrote in
> On Thu, Jul 16, 2020 at 09:30:12AM +0900, Kyotaro Horiguchi wrote:
> > Hello.
> >
> > The "Certificate Authentication" section in the doc for PG12 and later
> > describes the relation ship with clientcert as follows.
> >
> > > In a pg
On Tue, Aug 25, 2020 at 10:41:26AM +0900, Kyotaro Horiguchi wrote:
> At Mon, 24 Aug 2020 20:01:26 -0400, Bruce Momjian wrote in
> > I have slightly adjusted the doc part of the patch, attached.
>
> Thanks.
>
> In a pg_hba.conf record specifying certificate
> -authentication, the authen
At Mon, 24 Aug 2020 21:49:40 -0400, Bruce Momjian wrote in
> > > Are you saying we should _require_ clientcert=verify-full when 'cert'
> > > authentication is used? I don't see the point of that --- I just
> > > updated the docs to say doing so was duplicate behavior.
> >
> > I don't suggest ch
On Tue, Aug 25, 2020 at 11:00:49AM +0900, Kyotaro Horiguchi wrote:
> At Mon, 24 Aug 2020 21:49:40 -0400, Bruce Momjian wrote in
> > > > Are you saying we should _require_ clientcert=verify-full when 'cert'
> > > > authentication is used? I don't see the point of that --- I just
> > > > updated t
On 2020/08/24 17:09, Michael Paquier wrote:
On Mon, Aug 24, 2020 at 02:48:50PM +0900, Fujii Masao wrote:
As far as I know, utils/adt is the directory to basically include the files
for a particular type or operator. So ISTM that mcxtfuncs.c doesn't
fit to this directory. Isn't it better to pu
On Mon, Aug 24, 2020 at 6:38 AM John Naylor wrote:
> On Fri, Aug 21, 2020 at 8:53 PM Peter Geoghegan wrote:
> > Note that there is a ~20% reduction in blks_hit here, even though the
> > patch does ~1% more transactions (the rate limiting doesn't work
> > perfectly). There is also a ~5.5% reductio
Hi all,
While testing with DTrace, I realized we acquire
ReplicationSlotControl lwlock at some places even when
max_replication_slots is set to 0. For instance, we call
ReplicationSlotCleanup() within PostgresMian() when an error happens
and acquire ReplicationSlotControl lwlock.
The attached pat
On 2020/08/24 21:56, torikoshia wrote:
On 2020-08-24 13:13, Fujii Masao wrote:
On 2020/08/24 13:01, torikoshia wrote:
On 2020-08-22 21:18, Michael Paquier wrote:
Thanks for reviewing!
On Fri, Aug 21, 2020 at 11:27:06PM +0900, torikoshia wrote:
OK. Added a regression test on sysviews.sql.
Hi,
On August 24, 2020 7:38:39 PM PDT, Masahiko Sawada
wrote:
>Hi all,
>
>While testing with DTrace, I realized we acquire
>ReplicationSlotControl lwlock at some places even when
>max_replication_slots is set to 0. For instance, we call
>ReplicationSlotCleanup() within PostgresMian() when an er
Thank you for the patience.
At Mon, 24 Aug 2020 22:06:45 -0400, Bruce Momjian wrote in
> On Tue, Aug 25, 2020 at 11:00:49AM +0900, Kyotaro Horiguchi wrote:
> > At Mon, 24 Aug 2020 21:49:40 -0400, Bruce Momjian wrote
> > in
> > > > > Are you saying we should _require_ clientcert=verify-full wh
> Given that the commit included a test case exercising exactly that,
> I'm not sure why you might think it was unintentional.
Well, maybe not exercising exactly that. No positive test case was
added. The commit replaced a CREATE TABLE fillfactor test case testing
that "30.5" is invalid, with a te
On Tue, 25 Aug 2020 at 11:42, Andres Freund wrote:
>
> Hi,
>
> On August 24, 2020 7:38:39 PM PDT, Masahiko Sawada
> wrote:
> >Hi all,
> >
> >While testing with DTrace, I realized we acquire
> >ReplicationSlotControl lwlock at some places even when
> >max_replication_slots is set to 0. For instan
On Tue, Aug 25, 2020 at 11:41:55AM +0900, Kyotaro Horiguchi wrote:
> Thank you for the patience.
>
> At Mon, 24 Aug 2020 22:06:45 -0400, Bruce Momjian wrote in
> > On Tue, Aug 25, 2020 at 11:00:49AM +0900, Kyotaro Horiguchi wrote:
> > > At Mon, 24 Aug 2020 21:49:40 -0400, Bruce Momjian
> > > w
On Mon, Aug 24, 2020 at 9:41 PM Dilip Kumar wrote:
>
> On Sat, Aug 22, 2020 at 8:38 AM Amit Kapila wrote:
> >
> > On Fri, Aug 21, 2020 at 5:10 PM Dilip Kumar wrote:
> > >
> > > I have reviewed and tested the patch and the changes look fine to me.
> > >
> >
> > Thanks, I will push the next patch
Hi,
On 2020-08-25 12:00:47 +0900, Masahiko Sawada wrote:
> On Tue, 25 Aug 2020 at 11:42, Andres Freund wrote:
> >
> > Hi,
> >
> > On August 24, 2020 7:38:39 PM PDT, Masahiko Sawada
> > wrote:
> > >Hi all,
> > >
> > >While testing with DTrace, I realized we acquire
> > >ReplicationSlotControl lw
On Tue, 25 Aug 2020 at 13:13, Andres Freund wrote:
>
> Hi,
>
> On 2020-08-25 12:00:47 +0900, Masahiko Sawada wrote:
> > On Tue, 25 Aug 2020 at 11:42, Andres Freund wrote:
> > >
> > > Hi,
> > >
> > > On August 24, 2020 7:38:39 PM PDT, Masahiko Sawada
> > > wrote:
> > > >Hi all,
> > > >
> > > >Wh
On Mon, Aug 24, 2020 at 7:15 PM Robert Haas wrote:
>
> On Tue, Aug 18, 2020 at 12:14 PM Alvaro Herrera
> wrote:
> > It makes sense to recommend VACUUM after fixing the page, but I agree
> > with Sawada-san that it would be sensible to reset the VM bit while
> > doing surgery, since that's the sta
On Mon, Aug 24, 2020 at 11:00 PM Andrey M. Borodin wrote:
>
> Hi!
>
> > 21 авг. 2020 г., в 18:24, Ashutosh Sharma
> > написал(а):
> >
> > Please find the updated patch with the following new changes:
>
> Do you have plans to support pg_surgery as external extension? For example
> for earlier ve
On Tue, Aug 25, 2020 at 9:31 AM Amit Kapila wrote:
>
> On Mon, Aug 24, 2020 at 9:41 PM Dilip Kumar wrote:
> >
> > On Sat, Aug 22, 2020 at 8:38 AM Amit Kapila wrote:
> > >
> > > On Fri, Aug 21, 2020 at 5:10 PM Dilip Kumar wrote:
> > > >
> > > > I have reviewed and tested the patch and the change
Here is a series of patches to remove some unused function parameters.
In each case, the need for them was removed by some other code changes
over time but the unusedness was not noticed. I have included a
reference to when they became unused in each case.
--
Peter Eisentraut htt
At Mon, 24 Aug 2020 23:04:51 -0400, Bruce Momjian wrote in
> > > I don't see "no-verify" mentioned anywhere in our docs.
> >
> > no-verify itself is mentioned here.
> >
> > https://www.postgresql.org/docs/13/ssl-tcp.html#SSL-CLIENT-CERTIFICATES
>
> Oh, I see it now, thanks. Do you have any id
út 25. 8. 2020 v 1:19 odesílatel Peter Smith napsal:
> Hi.
>
> I have re-checked the string_to_table_20200824.patch.
>
>
>
> On Tue, Aug 25, 2020 at 2:34 AM Pavel Stehule
> wrote:
>
> >> COMMENT (help text)
> >>
> >> +Splits the string at occurrences
> >> +of delimiter and f
63 matches
Mail list logo
