Re: PATCH: logical_work_mem and logical streaming of large in-progress transactions

2020-07-09 Thread Ajin Cherian
On Thu, Jul 9, 2020 at 1:30 PM Amit Kapila wrote: > > > I think if the GUC is set then maybe we can bypass this check so that > > it can try to stream every single change? > > > > Yeah and probably we need to do something for the check "while > (rb->size >= logical_decoding_work_mem * 1024L)" as

distribute_restrictinfo_to_rels if restrictinfo contains volatile functions

2020-07-09 Thread Zhenghua Lyu
Hi all, consider the following SQL: gpadmin=# explain (verbose, costs off) select * from t, (select a from generate_series(1, 1)a)x,

Re: Added tab completion for the missing options in copy statement

2020-07-09 Thread vignesh C
On Sat, Jun 27, 2020 at 6:52 AM vignesh C wrote: > > Hi, > > I found that tab completion for some parts of the copy statement was > missing. The Tab completion was missing for the following cases: > 1) COPY [BINARY] FROM filename -> "BINARY", "DELIMITER", "NULL", > "CSV", "ENCODING", "WITH (", "W

Re: POC: postgres_fdw insert batching

2020-07-09 Thread Andrey V. Lepikhov
On 6/28/20 8:10 PM, Tomas Vondra wrote: Now, the primary reason why the performance degrades like this is that while FDW has batching for SELECT queries (i.e. we read larger chunks of data from the cursors), we don't have that for INSERTs (or other DML). Every time you insert a row, it has to go

Re: PATCH: logical_work_mem and logical streaming of large in-progress transactions

2020-07-09 Thread Dilip Kumar
On Fri, Jul 10, 2020 at 9:21 AM Ajin Cherian wrote: > > > > On Thu, Jul 9, 2020 at 1:30 PM Amit Kapila wrote: >> >> >> > I think if the GUC is set then maybe we can bypass this check so that >> > it can try to stream every single change? >> > >> >> Yeah and probably we need to do something for th

Re: Support for NSS as a libpq TLS backend

2020-07-09 Thread Thomas Munro
On Fri, Jul 3, 2020 at 11:51 PM Daniel Gustafsson wrote: > > On 25 Jun 2020, at 17:39, Daniel Gustafsson wrote: > >> On 15 May 2020, at 22:46, Daniel Gustafsson wrote: > >> The 0001 patch contains the full NSS support, and 0002 is a fix for the > >> pgstat > >> abstraction which IMO leaks backe

Re: PATCH: logical_work_mem and logical streaming of large in-progress transactions

2020-07-09 Thread Ajin Cherian
On Fri, Jul 10, 2020 at 3:11 PM Dilip Kumar wrote: > With your changes sometimes due to incomplete toast > changes, if it can not pick the largest top txn for streaming it will > hang forever in the while loop, in that case, it should go for > spilling. > > while (rb->size >= logical_decoding_wor

Re: Yet another fast GiST build (typo)

2020-07-09 Thread Thomas Munro
On Tue, Jul 7, 2020 at 7:03 PM Andrey M. Borodin wrote: > Oops. I've mismerged docs and did not notice this with check world. PFA v8 > with fixed docs. It looks like point_zorder_internal() has the check for NaN in the wrong place.

Re: PATCH: logical_work_mem and logical streaming of large in-progress transactions

2020-07-09 Thread Dilip Kumar
On Fri, Jul 10, 2020 at 11:01 AM Ajin Cherian wrote: > > > > On Fri, Jul 10, 2020 at 3:11 PM Dilip Kumar wrote: >> >> With your changes sometimes due to incomplete toast >> changes, if it can not pick the largest top txn for streaming it will >> hang forever in the while loop, in that case, it sh

Re: posgres 12 bug (partitioned table)

2020-07-09 Thread Amit Langote
Hi Soumyadeep, On Fri, Jul 10, 2020 at 2:56 AM Soumyadeep Chakraborty wrote: > > Hey Amit, > > On Thu, Jul 9, 2020 at 12:16 AM Amit Langote wrote: > > > By the way, what happens today if you do INSERT INTO a_zedstore_table > > ... RETURNING xmin? Do you get an error "xmin is unrecognized" or >

Re: Log the location field before any backtrace

2020-07-09 Thread Peter Eisentraut
On 2020-07-10 04:04, Michael Paquier wrote: On Thu, Jul 09, 2020 at 12:31:38PM -0400, Alvaro Herrera wrote: On 2020-Jul-09, Daniel Gustafsson wrote: On 9 Jul 2020, at 11:17, Peter Eisentraut wrote: In PG13, we added the ability to add backtraces to the log output. After some practical exper

Re: SQL-standard function body

2020-07-09 Thread Thomas Munro
On Wed, Jul 1, 2020 at 5:49 AM Peter Eisentraut wrote: > - More test coverage is needed. Surprisingly, there wasn't actually any > test AFAICT that just creates and SQL function and runs it. Most of > that code is tested incidentally, but there is very little or no > targeted testing of this fun

Re: Yet another fast GiST build (typo)

2020-07-09 Thread Andrey M. Borodin
> 10 июля 2020 г., в 10:53, Thomas Munro написал(а): > > On Tue, Jul 7, 2020 at 7:03 PM Andrey M. Borodin wrote: >> Oops. I've mismerged docs and did not notice this with check world. PFA v8 >> with fixed docs. > > It looks like point_zorder_internal() has the check for NaN in the wrong > p

<    1   2